GNU bug report logs - #48375
coding-system-for-read in net-utils-run-simple is not properly set

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#48375: closed (coding-system-for-read in net-utils-run-simple
 is not properly set)
Date: Sat, 15 May 2021 09:40:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 15 May 2021 12:39:25 +0300
with message-id <835yzkxrn6.fsf <at> gnu.org>
and subject line Re: bug#48375: coding-system-for-read in net-utils-run-simple is not properly set
has caused the debbugs.gnu.org bug report #48375,
regarding coding-system-for-read in net-utils-run-simple is not properly set
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
48375: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48375
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: iquiw <iku.iwasa <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: coding-system-for-read in net-utils-run-simple is not properly set
Date: Wed, 12 May 2021 18:39:25 +0900

In the following code, `let' binding of `coding-system-for-read'
covers only `erase-buffer' call.

https://emba.gnu.org/emacs/emacs/-/blob/47070ed39eda524d334e5f82dc7f4a50b8d3252c/lisp/net/net-utils.el#L366-375

So it does not affect to executed process and output characters are garbled.
e.g. "M-x ifconfig" on Windows.

`net-utils-run-program' (e.g. "M-x ping") has no problem.

Thanks in advance,
Iku

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: iquiw <iku.iwasa <at> gmail.com>
Cc: 48375-done <at> debbugs.gnu.org
Subject: Re: bug#48375: coding-system-for-read in net-utils-run-simple is not
 properly set
Date: Sat, 15 May 2021 12:39:25 +0300

> From: iquiw <iku.iwasa <at> gmail.com>
> Date: Sat, 15 May 2021 18:32:05 +0900
> Cc: 48375 <at> debbugs.gnu.org
> 
> > > In the following code, `let' binding of `coding-system-for-read'
> > > covers only `erase-buffer' call.
> > >
> > > https://emba.gnu.org/emacs/emacs/-/blob/47070ed39eda524d334e5f82dc7f4a50b8d3252c/lisp/net/net-utils.el#L366-375
> > >
> > > So it does not affect to executed process and output characters are garbled.
> > > e.g. "M-x ifconfig" on Windows.
> >
> > Thanks.  Does the patch below fix the problem?
> 
> Yes, it works fine with the patch.
> Thank you!

Thanks for testing, I installed the fix on the master branch, and I'm
closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.