GNU bug report logs - #48367
28.0.50; quit-restore-buffer may jam

Previous Next

Full log

View this message in rfc822 format

From: pillule <pillule <at> riseup.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: pillule <pillule <at> riseup.net>, 48367 <at> debbugs.gnu.org
Subject: bug#48367: 28.0.50; quit-restore-window may jam
Date: Wed, 12 May 2021 11:25:51 +0000

[Message part 1 (text/plain, inline)]

martin rudalics <rudalics <at> gmx.at> writes:

>> The first patch adress this, and a similar one : when there is 
>> a previous-buffer available, but it referes to the same buffer. 
>> (eg: try the recipe again but exchange the role of *Messages* 
>> and *Backtrace*, you will finish with a blank buffer for 
>> backtrace, that you can quit again to end up to the same point)
>>
>> The second patch is a proposition to clarify a little the code.
>
> LGTM.  Can you please provide a ChangeLog entry and add a short 
> comment
> in the code that mentions the bug number of your report.

Looking at the CONTRIBUTE file, I have done this new version with 
`git format-patch -l1',
Is that overall better ?

[quit-restore-window.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Is that OK to call a cl-lib function in the second patch even if 
this library is not required in window.el ?


> Also, have you signed the copyright agreement for Emacs?  How 
> should I
> call you in the commit?  "pillule"?

No, I have not yet signed the agreement, I contact assign <at> gnu.org 
today to do so. I was hoping sloppily that you consider these 
contributions as trivial.

If it is fine for you to use my pseudonym, it is fine for me.


-- 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.