From unknown Sat Sep 06 02:03:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48367: 28.0.50; quit-restore-buffer may jam Resent-From: pillule Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 May 2021 20:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 48367@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162076478511908 (code B ref -1); Tue, 11 May 2021 20:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 May 2021 20:26:25 +0000 Received: from localhost ([127.0.0.1]:37600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgYxV-000360-14 for submit@debbugs.gnu.org; Tue, 11 May 2021 16:26:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:58210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgYxT-00035s-Hk for submit@debbugs.gnu.org; Tue, 11 May 2021 16:26:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgYxT-0002tS-AZ for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 16:26:23 -0400 Received: from mx1.riseup.net ([198.252.153.129]:49406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgYxR-0003cb-0T for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 16:26:22 -0400 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4FfqFQ53zWzDxXW for ; Tue, 11 May 2021 13:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1620764778; bh=ua5r690v+PiTfXk678b4+rhuCxGMjW58GV5diF33i80=; h=From:To:Subject:Date:From; b=n+NCKo0IumoJ7dmeJgTMAbVJNbRueY1CCd0NY5ljZCU58hi3Bul99cmJ9NIox/LKa 9eG21K7vUU5smrGsZzRQu8PgpWl7SEWN3W83/TwLsEdE/vKJ3REwJF225CekEMi+YZ R3QOzyStl6Wimerm6CFZGTBwCiEPjWEcB5vZOA0Y= X-Riseup-User-ID: A844B4E9461AFF5AD33DE3608D22CD2D8C9B3B4D455BD35F4562D48AF6E60366 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4FfqFP2mNHz5vbR for ; Tue, 11 May 2021 13:26:16 -0700 (PDT) From: pillule Date: Tue, 11 May 2021 20:26:08 +0000 Message-ID: <87h7j9xbj3.fsf@host.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=198.252.153.129; envelope-from=pillule@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; format=flowed Hello there, I think there is a small bug with quit-window / quit-restore-window : with emacs -Q ;; set some rules (setq display-buffer-alist '(("\\*\\(Backtrace\\|Messages\\)\\*" (display-buffer-in-side-window) (window-height . 0.2) (side . bottom)))) ;; trigger a logical error to display the *Backtrace* buffer (> vim emacs) ;; display the *Messages* buffer (view-echo-area-messages) ;; mess the `quit-restore' window parameter (kill-buffer (get-buffer "*Backtrace*")) ;; which looks now like that in the *Messages* window : ;; ((quit-restore) (window-slot . 0) (window-side . bottom)) ;; try to quit the *Messages* window (progn (select-window (view-echo-area-messages)) (quit-window)) ;; nothing happens : The first `cond' of quit-restore-window end up to 't, it calls (switch-to-prev-buffer window bury-or-kill) but there is no previous-window available. The first patch adress this, and a similar one : when there is a previous-buffer available, but it referes to the same buffer. (eg: try the recipe again but exchange the role of *Messages* and *Backtrace*, you will finish with a blank buffer for backtrace, that you can quit again to end up to the same point) The second patch is a proposition to clarify a little the code. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=quit-restore-window.patch Content-Description: quit-restore-window-patch1 diff -u --label /usr/share/emacs/28.0.50/lisp/window.el.gz --label /home/user/src/patches/window.el /tmp/jka-comHlW7wF /home/user/src/patches/window.el --- /usr/share/emacs/28.0.50/lisp/window.el.gz +++ /home/user/src/patches/window.el @@ -5151,7 +5151,9 @@ (set-window-parameter window 'quit-restore nil) ;; Make sure that WINDOW is no more dedicated. (set-window-dedicated-p window nil) - (switch-to-prev-buffer window bury-or-kill))) + (if prev-buffer + (switch-to-prev-buffer window bury-or-kill) + (window--delete window nil (eq bury-or-kill 'kill))))) ;; Deal with the buffer. (cond Diff finished. Tue May 11 21:26:38 2021 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=quit-restore-window2.patch Content-Description: quit-restore-window-patch2 diff -u --label /usr/share/emacs/28.0.50/lisp/window.el.gz --label /home/user/src/patches/window.el /tmp/jka-comAXCNZa /home/user/src/patches/window.el --- /usr/share/emacs/28.0.50/lisp/window.el.gz +++ /home/user/src/patches/window.el @@ -5073,14 +5073,9 @@ (setq window (window-normalize-window window t)) (let* ((buffer (window-buffer window)) (quit-restore (window-parameter window 'quit-restore)) - (prev-buffer - (let* ((prev-buffers (window-prev-buffers window)) - (prev-buffer (caar prev-buffers))) - (and (or (not (eq prev-buffer buffer)) - (and (cdr prev-buffers) - (not (eq (setq prev-buffer (cadr prev-buffers)) - buffer)))) - prev-buffer))) + (prev-buffer (car (cl-find-if-not + (lambda (buf) (eq (car buf) buffer)) + (window-prev-buffers window)))) quad entry) (cond ((and (not prev-buffer) Diff finished. Tue May 11 22:00:30 2021 --=-=-= Content-Type: text/plain; format=flowed -- --=-=-=-- From unknown Sat Sep 06 02:03:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48367: 28.0.50; quit-restore-buffer may jam Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 May 2021 08:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: pillule , 48367@debbugs.gnu.org Received: via spool by 48367-submit@debbugs.gnu.org id=B48367.16208092876279 (code B ref 48367); Wed, 12 May 2021 08:49:02 +0000 Received: (at 48367) by debbugs.gnu.org; 12 May 2021 08:48:07 +0000 Received: from localhost ([127.0.0.1]:38145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgkXH-0001dD-BJ for submit@debbugs.gnu.org; Wed, 12 May 2021 04:48:07 -0400 Received: from mout.gmx.net ([212.227.15.19]:35817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgkXF-0001cU-DB for 48367@debbugs.gnu.org; Wed, 12 May 2021 04:48:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620809276; bh=kWIeFslQk4MQwvHofcoH97IVlfWBf7A/tC3JN7ilrk8=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=HJ9q8kzs4kRTCtXrEEjwIDtvoqwwpd2/Vc0CH7H30nP3iERq7g51LW7kaMPkt4+Vy pFYNGgxy4H0HE1LmMCVaguWFHqMobHn/HNHVNlXVyuauo7aE/AZnVDW95vgiLLseoh 9Re8ZuJ7pwfeilUQ86O4wgHr+i2i/hbE9JDYLdUE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([46.125.249.51]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mg6Zw-1l1Lla23m2-00haPg; Wed, 12 May 2021 10:47:56 +0200 References: <87h7j9xbj3.fsf@host.localdomain> From: martin rudalics Message-ID: <13f5a988-f78b-11ed-fcde-fc03ad841390@gmx.at> Date: Wed, 12 May 2021 10:47:55 +0200 MIME-Version: 1.0 In-Reply-To: <87h7j9xbj3.fsf@host.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:DKeBM/CCCodAs24017563KQPpJfChz3fj6YQtI0Ovc+JIaZ6F+B mi15tU8Chyk08Y9li5kLQGcSd1cE/X2twIXRVYMKVOY6uLa/iyQPxUYTqyaloraJJuUZ/gD QnUpHtPgEGcfae6Bxx1z3dHr/FB9YwOuiVhyvyDMm5iVWZutBpOcDg0eOSgdVFmWz41XjXF svieBr+4mJ4HCn2f4hS1Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ln2JRtm8bAw=:HQrHufTNI+BFYJ50rIVieo kDMDo5IY0rXC/uBiD2OZB2s9XAu8m+ifBLwd7u48fJ1hZQ/QIbwc9W2Xe/pwdENUtDllBFmNs CUxIDYY49o9/jZYfhOXAZ0V8ntmAbHJ85i5NMZH4MTZcqOBBHnmLrZynryi3ZC72kbvKdk255 Gh0bgIdfqnkdTQ1FfY60fLxO3eROtYCn5w2KVeg+N4VKCT/9In+CTR+z/GSf2iFC/uvGp6dP7 Kl3qLvzHlyDz8s7VKPIPlRmfy9TBht3Bycv1oN3KHCUFL7ClpLr2cGEJXgKL/6kLUyIzbCpek eTpZjGKoXb9vEl/tPjaBLquriE9HTQjV3ZXbv35Fo1xFjVXCVvSuobEnmCCnFv9U9M5bkijho IdvxH2zLhYK+D5mb8N/5sUgwOb6zuiIJLZLB7xL6QfdIrVaRRFM/N6M340xnLC13jh6weFNAu 6IVxFXAj0DrXTgn0k7lvjyZTdMT1Q2LxVExYqYZeAJ3XJ+vWuXImOmcmeCEaSm9hkR/ReyaDu qaXajgv0ntx45+bV0qTPyTGm5GRWybkXC2nyIv8bTg9CCFKkDJ+mgLGNANnM8e6RlecKTr2pi 5U7SttlmbN6kR47yuHfd6JVGuScBq21+kVH2iqa9IjEkdDR3+mYL1di7HzryYFdmQrysNA240 lvGZab4ggmc2FUJ+PC6pUQJLiXFTa61xXr+QYtovG/6qCrC6TrMGfK1y402ebUvielojOLMEe 6vylsdG4LjYoO3RUvM0xjZQU32eAnzYQsQyTb2QsZGakmR8e16bCmSf09o9W+PDJ6yYt1xy0A 59jxgTurU7J471BeveuHpgvpUqMxopHCYFPdJH9oZVd7iprXxMg+dKwOgbU0FgGDWDaEFdBT7 P+phyiFZ6f/GLhjiS9OMpbU2NYFRLrz/DPxwEOjatg5AtlQaD8OmSmUQLlV+CvML09D0TCsdo Tfv7i5rzfb/tguhfBTir1+y1gnUsmct6ia/LIX4RJFLhXc8bvEMJmIq8wl/OVVIo2ZLROM4Ke jr7LCPOGNaNm5sdqCP/Y6uLXkwczAyg+fSjLUxOGaspoc8kfWjF16A84i+XW2K1cUosj+a8a/ qF76lrsdXOaNXoZkRXAAprEDjYIMeXMsxsfx7kX44P2wcas30sZv2O8C7XAmrQOjtJQluW4I8 fqwM9N7NeKgd7ktCDNYiwgEvIDLzoXVEiOdINnjRob8WsBTDzLI74LZ3WeKqIkWfFqgsY= X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) > The first patch adress this, and a similar one : when there is a previous-buffer available, but it referes to the same buffer. (eg: try the recipe again but exchange the role of *Messages* and *Backtrace*, you will finish with a blank buffer for backtrace, that you can quit again to end up to the same point) > > The second patch is a proposition to clarify a little the code. LGTM. Can you please provide a ChangeLog entry and add a short comment in the code that mentions the bug number of your report. Also, have you signed the copyright agreement for Emacs? How should I call you in the commit? "pillule"? And please try to avoid putting your local settings in diffs as with --- /usr/share/emacs/28.0.50/lisp/window.el.gz +++ /home/user/src/patches/window.el Many thanks, martin From unknown Sat Sep 06 02:03:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48367: 28.0.50; quit-restore-window may jam Resent-From: pillule Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 May 2021 11:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: pillule , 48367@debbugs.gnu.org Received: via spool by 48367-submit@debbugs.gnu.org id=B48367.162081876824320 (code B ref 48367); Wed, 12 May 2021 11:27:02 +0000 Received: (at 48367) by debbugs.gnu.org; 12 May 2021 11:26:08 +0000 Received: from localhost ([127.0.0.1]:38287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgn0C-0006K9-9S for submit@debbugs.gnu.org; Wed, 12 May 2021 07:26:08 -0400 Received: from mx1.riseup.net ([198.252.153.129]:56552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgn09-0006Ja-As for 48367@debbugs.gnu.org; Wed, 12 May 2021 07:26:07 -0400 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4FgCCW4nSczDxX9; Wed, 12 May 2021 04:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1620818759; bh=VcBLy0c5fhA28fVkgSChmM23Y8XSf1ycLcdyANR+9Eo=; h=References:From:To:Cc:Subject:In-reply-to:Date:From; b=Nz/xzRlpQK4iPWuO9m71BmWLH2vTaqyZxKVsliD8Ff4o3hMopO845MDcam/HQAwKb uLceRMMAJ76jRc5XxP0j0e+DMXkgzrLGTMS4Z5/Cf6d4hhgKnLWsgIolWr4QS07RVd 9ysRN9Ld4HHg/wGJY635pOhR2NUSe3iQ0qS8P4bs= X-Riseup-User-ID: 88C5EC57608A4D2E93D09B6D6C2F6A1767CB5E2C2D61C7F7379E45E0CC4F569D Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4FgCCV0y7Wz5vqb; Wed, 12 May 2021 04:25:57 -0700 (PDT) References: <87h7j9xbj3.fsf@host.localdomain> <13f5a988-f78b-11ed-fcde-fc03ad841390@gmx.at> From: pillule In-reply-to: <13f5a988-f78b-11ed-fcde-fc03ad841390@gmx.at> Date: Wed, 12 May 2021 11:25:51 +0000 Message-ID: <87v97o42io.fsf@host.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; format=flowed martin rudalics writes: >> The first patch adress this, and a similar one : when there is >> a previous-buffer available, but it referes to the same buffer. >> (eg: try the recipe again but exchange the role of *Messages* >> and *Backtrace*, you will finish with a blank buffer for >> backtrace, that you can quit again to end up to the same point) >> >> The second patch is a proposition to clarify a little the code. > > LGTM. Can you please provide a ChangeLog entry and add a short > comment > in the code that mentions the bug number of your report. Looking at the CONTRIBUTE file, I have done this new version with `git format-patch -l1', Is that overall better ? --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=quit-restore-window.patch Content-Description: reformated-patchs >From b0e58a68a2f67b3ef2b2467f6473929fc6a720e9 Mon Sep 17 00:00:00 2001 From: Trust me I am a doctor Date: Wed, 12 May 2021 10:23:39 +0000 Subject: [PATCH 1/2] Unjam quit-restore-window (bug #48367) Deleting previous buffers of a window may result in a state where quit-window have no more effect, using the variable `prev-buffer', we can avoid it by asking to simply close the window in this case. --- lisp/window.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/window.el b/lisp/window.el index db62d3308f..24b5df3396 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -5114,7 +5114,10 @@ nil means to not handle the buffer in a particular way. This (set-window-parameter window 'quit-restore nil) ;; Make sure that WINDOW is no more dedicated. (set-window-dedicated-p window nil) - (switch-to-prev-buffer window bury-or-kill))) + (if prev-buffer + (switch-to-prev-buffer window bury-or-kill) + ;; delete the window if there is no previous-buffer (bug #48367) + (window--delete window nil (eq bury-or-kill 'kill))))) ;; Deal with the buffer. (cond -- 2.20.1 >From 55ec1b7a2ba50be0b55cc32601a88ec554c19034 Mon Sep 17 00:00:00 2001 From: Trust me I am a doctor Date: Wed, 12 May 2021 10:34:40 +0000 Subject: [PATCH 2/2] Clarifying code of quit-restore-window Still (bug #48367) This portion may be expressed more succinctly with an higher function. --- lisp/window.el | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/lisp/window.el b/lisp/window.el index 24b5df3396..a530761028 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -5036,14 +5036,9 @@ nil means to not handle the buffer in a particular way. This (setq window (window-normalize-window window t)) (let* ((buffer (window-buffer window)) (quit-restore (window-parameter window 'quit-restore)) - (prev-buffer - (let* ((prev-buffers (window-prev-buffers window)) - (prev-buffer (caar prev-buffers))) - (and (or (not (eq prev-buffer buffer)) - (and (cdr prev-buffers) - (not (eq (setq prev-buffer (cadr prev-buffers)) - buffer)))) - prev-buffer))) + (prev-buffer (car (cl-find-if-not + (lambda (buf) (eq (car buf) buffer)) + (window-prev-buffers window)))) quad entry) (cond ((and (not prev-buffer) -- 2.20.1 --=-=-= Content-Type: text/plain; format=flowed Is that OK to call a cl-lib function in the second patch even if this library is not required in window.el ? > Also, have you signed the copyright agreement for Emacs? How > should I > call you in the commit? "pillule"? No, I have not yet signed the agreement, I contact assign@gnu.org today to do so. I was hoping sloppily that you consider these contributions as trivial. If it is fine for you to use my pseudonym, it is fine for me. -- --=-=-=-- From unknown Sat Sep 06 02:03:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48367: 28.0.50; quit-restore-window may jam Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 May 2021 12:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: pillule Cc: 48367@debbugs.gnu.org Received: via spool by 48367-submit@debbugs.gnu.org id=B48367.16208227827413 (code B ref 48367); Wed, 12 May 2021 12:34:01 +0000 Received: (at 48367) by debbugs.gnu.org; 12 May 2021 12:33:02 +0000 Received: from localhost ([127.0.0.1]:38339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgo2v-0001vU-Sl for submit@debbugs.gnu.org; Wed, 12 May 2021 08:33:02 -0400 Received: from mout.gmx.net ([212.227.17.22]:46355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgo2u-0001uz-Ct for 48367@debbugs.gnu.org; Wed, 12 May 2021 08:33:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620822771; bh=9xEKUT0IcqwlAlESTAtPdHaNcURoZc9vllzttNY78CY=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=KBzFt0LDFBKh8+fTC5ADTe1OBjK1JRRY/KX/VwKwSyo7eg0RK0oyYJknsfCNrIlBQ ci3aSrcnaAJoWJOHVRyx0Nl2AXRVPML17k1eBhxYgluUS4NSOONq4PEHxIs3wsMzXx neLMPiZRQrlBjtGMiXZ7Uohr4Mf06miFJsV5uGU4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([46.125.249.124]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MWzfl-1m0IxO1q6z-00XMEV; Wed, 12 May 2021 14:32:51 +0200 References: <87h7j9xbj3.fsf@host.localdomain> <13f5a988-f78b-11ed-fcde-fc03ad841390@gmx.at> <87v97o42io.fsf@host.localdomain> From: martin rudalics Message-ID: <6a45ac55-4727-adca-009c-f4634619c21b@gmx.at> Date: Wed, 12 May 2021 14:32:49 +0200 MIME-Version: 1.0 In-Reply-To: <87v97o42io.fsf@host.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:rE0F+eQ7W6fWjEus4RlGWCwspI/h3l2X4qqKN4d5RLx30CL88/p C5G4Y8cM/eMk3kgenJOJ0q8RsFiLeZf9laKkWFcziZyGZQ2CN03umav6B+/aoX8CYwYay9t yQsRCYxgPixLcXfg5tj2z69F8l9zSTMAkBkCO+4X2bOck22nAIqCDLU/bMV3XsPLxBsKyjO s52nIexPdEkPp/4+RntdA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Ttpuel+Xtns=:LM59oXirPqpuqKkmoxdQcI 5bx/p3eKXgbHaoXLV3ZpeavFMSy5eHSp36m/Mkg5pMXyjSxSDKSL/+Mm7DYP14/KANdaTzY4Z 13gSxsZF8XqMciRz3z9yGCf7geEuI/wfOT8T/+i+rkVENdxlkrtpYFTTOVj5v8pMQflxAfrib TnF/smv8hBDgZSfVUlNIR4TzE0oib68i7epUVoqojHAiuH/9t3d6U2ccms0KQsPHUg9vkqJLw ikifO687GI5NIuLs+RmJKphFEmVflEwPJoIYIng+ZplmrD6tCGRfk2t9cl3L64B/eAvWZPNcz 1RX1Y3b7FqLQif4ThaTtwKa32nRMRvKMBp6UKgdsDi1bF0ViUtG0PXw69BD86CkGgb5Xsjx/H tC7zvGdplc7td4Z28F0Afgvzm+xWo/gdV1YkAYNM9KdJ1p3dRqlm07/aX2w6WbaOZZYaHeMJo 9LXVOgDOrLADXqi/5tIQMCqpU7LbLmCif9AhPqHvAGzQNzIzAmhOq0CdR2cYnwaFCF0GtOmjq FaMD/sTOQcYwHr9jlJOGV13bLWTktDN1iFJDeoP3JF+FXqujt1FPZ0ExEEj19JSZW98MQ3TK4 jztNmH1hkuxKDqsjesAiQvUt/QCc/eiDTGuXX5PRVEAioYLaoWgoBfk6DRBjfzWQxaZYHc4nF khzwWkzH5BMOh14jVRU9mY/z/Fd5nFcDojOK2kHQ0dxBvL+XhedRSNI+zmStZ6Q98QGnSmtoK mtbHXV5MpytHtjB7JyHmJn0Ic6Qk2oQ3VgVSe7CjlHurTT2nYwAkTzyfqocYe5ovmDVoC3Qeo BaTygd0aF2uueaOEr9tiCXAYsbIYMEDUr8sjGbbhKWTNscwgXz4vpKjCgW+EWO3tE8UQV3FZi Ov9Bh52eurdLyN/SL2vsqb0ZP3NuCR9cDEONMtkwK38JykfIGb2dPHKXCI+vHKxeIBOdLU5Sn UcVjSIRtT0EXfa49VTSo+kf19BorPuiLkw1BfnJeJoMCJ3PhJQIHtlIaekw9SYUn779tmuYZH 118LFDisbylhxLLZwqJuVbrYQXsRhAtafUUBKcd4pBGGpQiAT3ANTVDlaDAHhU+1yh7woB0Ng IDp0ESt7x727fhxcrX3unMt6No8M1pMaC80mF74is/wlOWapwPQ0d0G7uMQTrWv1dmUE6zFJJ udUc5pOdtl35f4JBbEBRNQ8Quyydu9VgzAY7yJHcmlY26ArmHjIEsAPftxe9gPRInuc7g= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Looking at the CONTRIBUTE file, I have done this new version with `git= format-patch -l1', > Is that overall better ? Yes. > Is that OK to call a cl-lib function in the second patch even if this = library is not required in window.el ? No. I only re-compiled and did not build. Please try to avoid it since otherwise we get a In end of data: =2E./../lisp/window.el:5039:29: Warning: the function =E2=80=98cl-find-if= -not=E2=80=99 is not known to be defined. warning. >> Also, have you signed the copyright agreement for Emacs? How should = I >> call you in the commit? "pillule"? > > No, I have not yet signed the agreement, I contact assign@gnu.org toda= y to do so. I was hoping sloppily that you consider these contributions a= s trivial. They are trivial and we don't need an assignment for them. But signing the agreement is always a good idea. > If it is fine for you to use my pseudonym, it is fine for me. Then "pillule" be it. Thanks again, martin From unknown Sat Sep 06 02:03:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48367: 28.0.50; quit-restore-window may jam Resent-From: pillule Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 May 2021 14:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: pillule , 48367@debbugs.gnu.org Received: via spool by 48367-submit@debbugs.gnu.org id=B48367.16208286504420 (code B ref 48367); Wed, 12 May 2021 14:11:01 +0000 Received: (at 48367) by debbugs.gnu.org; 12 May 2021 14:10:50 +0000 Received: from localhost ([127.0.0.1]:39971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgpZa-00019E-HJ for submit@debbugs.gnu.org; Wed, 12 May 2021 10:10:50 -0400 Received: from mx1.riseup.net ([198.252.153.129]:37912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgpZY-00018y-MB for 48367@debbugs.gnu.org; Wed, 12 May 2021 10:10:49 -0400 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4FgGsb1VZTzF24G; Wed, 12 May 2021 07:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1620828643; bh=qolm6JiMvVY75fod4H2zQ/dF/qXn+A8vsyoiMlUMDmk=; h=References:From:To:Cc:Subject:In-reply-to:Date:From; b=dqsHpuID7QvhyuzJcDBMjZ/i9NLyK0t+9L+94B4Kcl7//O0oNn31ffq3jM3V3B4vg MXl5+lQgXnQT1z1OrRJRi0ApYCqGLoXxhRFvcVKas15a14buDy1PzELGz+99kdQMSg RBr6Bh3pJIJvFDIK95UI1EgGO4NhuswR6hUQtwvs= X-Riseup-User-ID: B41A1AD654815B3F4CC8A1C85C5D5132720635AB9BB8E664B3F31B0B3FEA8E55 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4FgGsY1bHNz1xph; Wed, 12 May 2021 07:10:40 -0700 (PDT) References: <87h7j9xbj3.fsf@host.localdomain> <13f5a988-f78b-11ed-fcde-fc03ad841390@gmx.at> <87v97o42io.fsf@host.localdomain> <6a45ac55-4727-adca-009c-f4634619c21b@gmx.at> From: pillule In-reply-to: <6a45ac55-4727-adca-009c-f4634619c21b@gmx.at> Date: Wed, 12 May 2021 14:10:27 +0000 Message-ID: <87sg2s3uwc.fsf@host.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable martin rudalics writes: >> Is that OK to call a cl-lib function in the second patch even=20 >> if this library is not required in window.el ? > > No. I only re-compiled and did not build. Please try to avoid=20 > it since > otherwise we get a > > In end of data: > ../../lisp/window.el:5039:29: Warning: the function=20 > =E2=80=98cl-find-if-not=E2=80=99 is not > known to be defined. > > warning. Here an alternative version using subr.el instead : --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=quit-restore-window.patch Content-Description: quit-restore-patch-with-subr.el.patch >From 5c18c2b416b8fb6ef50dee6acc863130847eec03 Mon Sep 17 00:00:00 2001 From: Trust me I am a doctor Date: Wed, 12 May 2021 10:34:40 +0000 Subject: [PATCH] Clarifying code of quit-restore-window Still (bug #48367) This portion may be expressed more succinctly with an higher function. --- lisp/window.el | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/lisp/window.el b/lisp/window.el index 24b5df3396..914467aba0 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -5036,14 +5036,10 @@ nil means to not handle the buffer in a particular way. This (setq window (window-normalize-window window t)) (let* ((buffer (window-buffer window)) (quit-restore (window-parameter window 'quit-restore)) - (prev-buffer - (let* ((prev-buffers (window-prev-buffers window)) - (prev-buffer (caar prev-buffers))) - (and (or (not (eq prev-buffer buffer)) - (and (cdr prev-buffers) - (not (eq (setq prev-buffer (cadr prev-buffers)) - buffer)))) - prev-buffer))) + (prev-buffer (catch 'prev-buffer + (dolist (buf (window-prev-buffers window)) + (unless (eq (car buf) buffer) + (throw 'prev-buffer (car buf)))))) quad entry) (cond ((and (not prev-buffer) -- 2.20.1 --=-=-= Content-Type: text/plain; format=flowed > They are trivial and we don't need an assignment for them. But > signing > the agreement is always a good idea. Ok, it's on its way. Thank you for the guidance. -- --=-=-=-- From unknown Sat Sep 06 02:03:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48367: 28.0.50; quit-restore-window may jam Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 May 2021 16:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: pillule Cc: 48367@debbugs.gnu.org Received: via spool by 48367-submit@debbugs.gnu.org id=B48367.16208376484654 (code B ref 48367); Wed, 12 May 2021 16:41:02 +0000 Received: (at 48367) by debbugs.gnu.org; 12 May 2021 16:40:48 +0000 Received: from localhost ([127.0.0.1]:40287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgrui-0001D0-J2 for submit@debbugs.gnu.org; Wed, 12 May 2021 12:40:48 -0400 Received: from mout.gmx.net ([212.227.17.20]:59863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgrug-0001Cm-6F for 48367@debbugs.gnu.org; Wed, 12 May 2021 12:40:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620837637; bh=dKiqU9nGUKXuZF3gpneIlAkUKU09v+zJHnpdYU3qN7Y=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=alcEHLUPTV/HuTrPha02D6B9FbTDpcB4KxfMuvRKNnPIVpZ6JafEOmQoi9Npiqcg6 vSxul0434Ml55thL7nenttHHMOQwZWOUMDVYrrbHZI++/vWdh+VpifTnrUE8fYEspK xw/stKr/B2AdBx7VICFi0dNoW/8GpIZYwEMz6NxQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([46.125.249.124]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M8QS8-1lcUCL1UAq-004Vdh; Wed, 12 May 2021 18:40:37 +0200 References: <87h7j9xbj3.fsf@host.localdomain> <13f5a988-f78b-11ed-fcde-fc03ad841390@gmx.at> <87v97o42io.fsf@host.localdomain> <6a45ac55-4727-adca-009c-f4634619c21b@gmx.at> <87sg2s3uwc.fsf@host.localdomain> From: martin rudalics Message-ID: Date: Wed, 12 May 2021 18:40:35 +0200 MIME-Version: 1.0 In-Reply-To: <87sg2s3uwc.fsf@host.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:kdSPteJBqFN3YrDzXOyac0bNeIzTEbG3dpVk5VIGSl9grF7dAAB gj90s0xYJX0Jec/UECl9VZdmhL7bs/pFHQQ9V7YBrzO29slN9tdMBHq03l8IDVcW3lHE6mi IoW5TIFU2GkkOpnC9FZ1EpK2Yh/nAQG8Ld/EO/+xApFiCh78HnI3CXJzJOghr4Oarc1rP04 U40q4UxBZ67omJ9A1oWbw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:X1jXQZ2RD5U=:zJphD2JFt8LqBJy0TL6jK7 LXUNHj1aKk4ckj+I2zrPaqdt/iiyli4VX97CRVq+ewEMRDAEjeDCakDpt2isQwotCvUI9FpuP xQbyHD/AfcAB+vNavGwjBk7szmkGdYXajh3dl4eB88xe7zXkPDyCr0NDKYXjVwFgVFZJvgi7G z7NHewSro1iO69w45KC6ybmfRSsxaLICp5NRavrO5Bjz0p4jBQGKSG7g2j1OqjIHEkvWEXOq+ WkVHj6X9K467I1X3CGnHXedtw+TOhXvdjbIYHhASGyLIuM3EGRbAHIN/VufgHA27pWLCasW6d /W9qiuAnBLTiwD4m1MoDeXXBGrQpJ2peAOCpRP5PwSZkwTerfSpPrtu81bpyf+/Gsmy54tfd3 aK2hCjT3zcMd9lkfdnzCsIPHqJ0NSlgiABbTqPEQ/junVe+P1y8kiXo0MLC8a8M/DfT0g0gb5 I0D4DWMr0s5Ow3XIeRCRyZtafJdy+tyknSwf3NhskkcuI21u1+9JuAfVtIUfXkzpk+81MtcPE zTEbHKXLp5Y5kkK3DvksQyIzp+9WLCpEr2GWeF/PjLeZqD0MlHaVJWUGe9lC4QUcBW4uayyc4 MUlK6y1XXiDeREBVlemsVN0bpOyxOKKep4ufapLWzw0ka8ebZSTVMGk0FkTTLumyWIvDKI8Nj CzWLNWHirWqJ2ftHegSI6AOG9Xhy7IpJw9VgK+ycttWXD8YKhL2Ir2vw0wDJZ4206CRoymzUt H1RpmmuK6/W6SYMHr/FgTpWsmd/Yww6DGGnsDYQcL/asJF9xDrHhGTMfGTZRAe1myGmfvHP5b 74ZLaMyI2aQ+93AnQxFkQUOwoY1xFbMEyigT/T6GUTneZiYX02nAxoEAbncAZpF7xQaSsLMFm DLn1Es9Fk58qYqqxMWuJ2w0bpnnfjuUasfPoqPAKzqiraIV3KH+WcozKM0eps1TvMmR0abBF6 CIYNZG9IuXFvyEkXvAcjk9Bqrl8YXpf8nOllm2zulcYn751bNYKoWcHa+2Bwh9SRsY03ydnV0 w63W45nbODoobEJTVuTc/PaodT4KxOjfZc7JFPycpXpJ/+wROEHZTkcPIu47zVBwUFco2bP3X ymBsL2Fkx92tqT719GJYlzM5yzLFzF7Eb0IrAZZie/P2hVzWYo93TtRqy8LKu6ECyYGzSKcud 32ZOitwbVd0VUuw4s+R4ZHMbkmyl6vOOmoaS/FGov4OU3eqbGzYXPCwfhL9LmwnQYk9Qg= X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Here an alternative version using subr.el instead : OK. I trust you that it works as intended. martin Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.17.20 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 2.0 PDS_TONAME_EQ_TOLOCAL_SHORT Short body with To: name matches everything in local email 1.0 PDS_TONAME_EQ_TOLOCAL_VSHORT Very short body and From looks like 2 different emails X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Here an alternative version using subr.el instead : OK. I trust you that it works as intended. martin Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.17.20 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_TONAME_EQ_TOLOCAL_SHORT Short body with To: name matches everything in local email 1.0 PDS_TONAME_EQ_TOLOCAL_VSHORT Very short body and From looks like 2 different emails -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager > Here an alternative version using subr.el instead : OK. I trust you that it works as intended. martin From unknown Sat Sep 06 02:03:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48367: 28.0.50; quit-restore-window may jam Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 May 2021 08:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: pillule Cc: 48367@debbugs.gnu.org Received: via spool by 48367-submit@debbugs.gnu.org id=B48367.162106897612993 (code B ref 48367); Sat, 15 May 2021 08:57:01 +0000 Received: (at 48367) by debbugs.gnu.org; 15 May 2021 08:56:16 +0000 Received: from localhost ([127.0.0.1]:47520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhq5n-0003NV-Us for submit@debbugs.gnu.org; Sat, 15 May 2021 04:56:16 -0400 Received: from mout.gmx.net ([212.227.17.21]:50027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhq5l-0003NF-D8 for 48367@debbugs.gnu.org; Sat, 15 May 2021 04:56:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1621068964; bh=F4U3sUWvNg2OtbVFxXcfAOzIGXa5+UgCsRqxIPi0r3k=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Cr9ODYxFWhyvo9JJnh2/1cAB1J/kD9lmnYcWaVbi5d4gafKTCXBkkTWuEBglonDeW 9/qNFdr6zQ/MeEkCOn0T06LkYVcn2aG3XXVfpUlZDbEdgeZBrh2wSx8mxG8V6cLyTR 5EESDiCP1c0efTMX64Eds6A1Kq1yauYvohs0FMo4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([46.125.249.41]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MJE27-1lwTd2419v-00KkNI; Sat, 15 May 2021 10:56:04 +0200 References: <87h7j9xbj3.fsf@host.localdomain> <13f5a988-f78b-11ed-fcde-fc03ad841390@gmx.at> <87v97o42io.fsf@host.localdomain> <6a45ac55-4727-adca-009c-f4634619c21b@gmx.at> <87sg2s3uwc.fsf@host.localdomain> From: martin rudalics Message-ID: <6b41e4d0-0283-0cc2-15f3-563f8d843116@gmx.at> Date: Sat, 15 May 2021 10:56:02 +0200 MIME-Version: 1.0 In-Reply-To: <87sg2s3uwc.fsf@host.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:krgaK8Sr5AyZIROeOhWjVTCLMmA6YiohBBxHECa5Ih+PPwrnjsr M5Dwvc35MW3vngIS21oYx0GnDaMHoig6P1/V4FAdack1haPPIPIlDo4g7YInTUEgTZxseJE E3MQcAaF0UvcxVUju1dPms91aydEZ9CGID4+izzsrYnc7lsfS/SWN1GYUlVvPaT+rTX41QY LhxMJ7PkP6/CgaUEVEJ5g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:dEyhc3+6vKo=:CxYDTofs9psprBKI0E4G+/ zGy9A8oV7bhqcOTASpDUfF1CZDo8EXe+gAPnvUdBjuD4WdEfjWJMs1WdqvQsClndXr78nDTr9 pFiciQLNH0ZBgpE72PPCo4lVKPcfdC2iG5CB33J70Pu06cZu3Es982TjFwUUW03HSxxKvtgAP ERMJVqpJSlrSr3il+hJT6YoGgvP/20igGAWyU/7iQ+5g7o2GH3wd3lGOPJ6euQMKReqLe2o3i UzxpOpICKSyFNTwF7nzThNWJ9ew7/Sak2oXj8ERwbfadRX9SjTy4czD5Rwiy42i82UAkr57Yl eSPtrmHNxXDAEtP+byZUigVo2ym5O2FBKvUIPgKfMfFvwiwkvo9gJroBb+XKuzREUGoTYpATd Dee5J/XHerFPFvuK2GsrNP4mSfDozeuuTBLFlehzVU8NE6PNtoCeWS+CrHSrpnzbhxZaS+FAk tTkCRh5+bOqkIescp9Pcp4PZ7b1pm7KxQSLTTbF2JPnc0KuUgD03CaTxKGa7fRqM6sA5wDuKE E9vbj1hxK5en/wVr4un/CZuCpuoNM7gw8nopFi5igqgePEU6nmCr53y+yOCXudZVBRQMpj9Zd 9XHbc8NEZS7G+MfEJ+1nTO0wxstTTgWjJRcZrKzqGX6EYLIHxdko1nt0HGhA0RPWuicghzMCB Amls76GK3bjIjAGF3XChbnb3bwiq8WepPiDyWP9mBbo0BQH5J6yttnQ1M8dKvMfpttb41WCKi Po+omJz5ZO8S6Vt+xYtTnZEZBbH6b9sK7AadIFRxKo8ed4AEALpbF6iBnn990oaNuwyL229TG AaBnHiqxZ6q2StNqjC0Sll7RzQdwblODrPaIDfBEqNJMaJtgeRgYqvtGo2KwDSB74ahvG1pjl l08z82O7vDcQEMljcalrtfDz22JDfDlOvPcOaCqH1fo21t9j4lkCEoPGhKk6VN+MdiLGexNuh IxzI7PrUbdyQ+z5+aKLXEPFgxvfJj0l2okavi+rRKypppJiK8x3f8dw40Cq7BXJT0OkgoyepX CD7jnesRVwQ97sSrHvg6GnTzjgtFQeYThimDzondrctcYyoLXDs9a/siQDT140ftHx1OGN3rx edvriqwpCNrwYPoSEC5ln9d/LSnQI7dmZL6U8J7ZUMEE0+O1bWjzFIPQ3LGnLaij6SlPKvL+T Z+mh1EOjLayYrETUvPNzSVgDy6N4uW1w4NMy0itO2+5eLTDJgQ8SnABdyBrK2L0LppoBU= X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Here an alternative version using subr.el instead : I've pushed this and the other change now to master in commit 0a681590268a4039f95a5a919b6b6d4f4e880d4c, converting your ChangeLog exercises to our style. Please have a look and close this bug if every [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.17.21 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.21 listed in list.dnswl.org] 2.0 PDS_TONAME_EQ_TOLOCAL_SHORT Short body with To: name matches everything in local email X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Here an alternative version using subr.el instead : I've pushed this and the other change now to master in commit 0a681590268a4039f95a5a919b6b6d4f4e880d4c, converting your ChangeLog exercises to our style. Please have a look and close this bug if everything is alright. Thanks, martin From unknown Sat Sep 06 02:03:43 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: pillule Subject: bug#48367: closed (Re: bug#48367: 28.0.50; quit-restore-window may jam) Message-ID: References: <87mtswjngb.fsf@host.localdomain> <87h7j9xbj3.fsf@host.localdomain> X-Gnu-PR-Message: they-closed 48367 X-Gnu-PR-Package: emacs Reply-To: 48367@debbugs.gnu.org Date: Sat, 15 May 2021 10:35:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1621074901-8353-1" This is a multi-part message in MIME format... ------------=_1621074901-8353-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #48367: 28.0.50; quit-restore-buffer may jam which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 48367@debbugs.gnu.org. --=20 48367: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D48367 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1621074901-8353-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 48367-close) by debbugs.gnu.org; 15 May 2021 10:34:31 +0000 Received: from localhost ([127.0.0.1]:47687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhrct-00029r-Mc for submit@debbugs.gnu.org; Sat, 15 May 2021 06:34:31 -0400 Received: from mx1.riseup.net ([198.252.153.129]:38454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhrcr-00029c-5z for 48367-close@debbugs.gnu.org; Sat, 15 May 2021 06:34:30 -0400 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4Fj1wb1qgwzDq7K; Sat, 15 May 2021 03:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1621074863; bh=SOiVN/mBW2g8TvfXyW4XiT2PolRtPNVy2Ycjq7/moyI=; h=References:From:To:Cc:Subject:In-reply-to:Date:From; b=HztabfahT8a9nxDxguCQUW/3z919AVjTZXdSqhMqjhz1JfjPQpYZms2V3AF+xpUCQ 9ofOslJrTqpylNlZ0aLdi/GMoVpFztIoNF5+k8x20MgOICM+hKUL3GZTHdk/jYGv0L ZvGOc+RGzua4aUg5dvvuzIT/HgTCry/ee5zZ+x1o= X-Riseup-User-ID: E1490C41C9E6B21AD05A8BA177A731A6E7B5108B235A619499A0C3F6CB6EB482 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4Fj1wY4rNlz5vNG; Sat, 15 May 2021 03:34:21 -0700 (PDT) References: <87h7j9xbj3.fsf@host.localdomain> <13f5a988-f78b-11ed-fcde-fc03ad841390@gmx.at> <87v97o42io.fsf@host.localdomain> <6a45ac55-4727-adca-009c-f4634619c21b@gmx.at> <87sg2s3uwc.fsf@host.localdomain> <6b41e4d0-0283-0cc2-15f3-563f8d843116@gmx.at> From: pillule To: 48367-close@debbugs.gnu.org Subject: Re: bug#48367: 28.0.50; quit-restore-window may jam Message-ID: <87mtswjngb.fsf@host.localdomain> In-reply-to: <6b41e4d0-0283-0cc2-15f3-563f8d843116@gmx.at> Date: Sat, 15 May 2021 10:34:16 +0000 MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48367-close Cc: pillule , rudalics@gmx.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) martin rudalics writes: >> Here an alternative version using subr.el instead : > > I've pushed this and the other change now to master in commit > 0a681590268a4039f95a5a919b6b6d4f4e880d4c, converting your > ChangeLog > exercises to our style. Please have a look and close this bug > if > everything is alright. Looks fine to me, thanks. Looking at https://debbugs.gnu.org/Developer.html how to close this bug, I hope it worked. -- ------------=_1621074901-8353-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 May 2021 20:26:25 +0000 Received: from localhost ([127.0.0.1]:37600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgYxV-000360-14 for submit@debbugs.gnu.org; Tue, 11 May 2021 16:26:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:58210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgYxT-00035s-Hk for submit@debbugs.gnu.org; Tue, 11 May 2021 16:26:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgYxT-0002tS-AZ for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 16:26:23 -0400 Received: from mx1.riseup.net ([198.252.153.129]:49406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgYxR-0003cb-0T for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 16:26:22 -0400 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4FfqFQ53zWzDxXW for ; Tue, 11 May 2021 13:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1620764778; bh=ua5r690v+PiTfXk678b4+rhuCxGMjW58GV5diF33i80=; h=From:To:Subject:Date:From; b=n+NCKo0IumoJ7dmeJgTMAbVJNbRueY1CCd0NY5ljZCU58hi3Bul99cmJ9NIox/LKa 9eG21K7vUU5smrGsZzRQu8PgpWl7SEWN3W83/TwLsEdE/vKJ3REwJF225CekEMi+YZ R3QOzyStl6Wimerm6CFZGTBwCiEPjWEcB5vZOA0Y= X-Riseup-User-ID: A844B4E9461AFF5AD33DE3608D22CD2D8C9B3B4D455BD35F4562D48AF6E60366 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4FfqFP2mNHz5vbR for ; Tue, 11 May 2021 13:26:16 -0700 (PDT) From: pillule To: bug-gnu-emacs@gnu.org Subject: 28.0.50; quit-restore-buffer may jam Date: Tue, 11 May 2021 20:26:08 +0000 Message-ID: <87h7j9xbj3.fsf@host.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=198.252.153.129; envelope-from=pillule@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; format=flowed Hello there, I think there is a small bug with quit-window / quit-restore-window : with emacs -Q ;; set some rules (setq display-buffer-alist '(("\\*\\(Backtrace\\|Messages\\)\\*" (display-buffer-in-side-window) (window-height . 0.2) (side . bottom)))) ;; trigger a logical error to display the *Backtrace* buffer (> vim emacs) ;; display the *Messages* buffer (view-echo-area-messages) ;; mess the `quit-restore' window parameter (kill-buffer (get-buffer "*Backtrace*")) ;; which looks now like that in the *Messages* window : ;; ((quit-restore) (window-slot . 0) (window-side . bottom)) ;; try to quit the *Messages* window (progn (select-window (view-echo-area-messages)) (quit-window)) ;; nothing happens : The first `cond' of quit-restore-window end up to 't, it calls (switch-to-prev-buffer window bury-or-kill) but there is no previous-window available. The first patch adress this, and a similar one : when there is a previous-buffer available, but it referes to the same buffer. (eg: try the recipe again but exchange the role of *Messages* and *Backtrace*, you will finish with a blank buffer for backtrace, that you can quit again to end up to the same point) The second patch is a proposition to clarify a little the code. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=quit-restore-window.patch Content-Description: quit-restore-window-patch1 diff -u --label /usr/share/emacs/28.0.50/lisp/window.el.gz --label /home/user/src/patches/window.el /tmp/jka-comHlW7wF /home/user/src/patches/window.el --- /usr/share/emacs/28.0.50/lisp/window.el.gz +++ /home/user/src/patches/window.el @@ -5151,7 +5151,9 @@ (set-window-parameter window 'quit-restore nil) ;; Make sure that WINDOW is no more dedicated. (set-window-dedicated-p window nil) - (switch-to-prev-buffer window bury-or-kill))) + (if prev-buffer + (switch-to-prev-buffer window bury-or-kill) + (window--delete window nil (eq bury-or-kill 'kill))))) ;; Deal with the buffer. (cond Diff finished. Tue May 11 21:26:38 2021 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=quit-restore-window2.patch Content-Description: quit-restore-window-patch2 diff -u --label /usr/share/emacs/28.0.50/lisp/window.el.gz --label /home/user/src/patches/window.el /tmp/jka-comAXCNZa /home/user/src/patches/window.el --- /usr/share/emacs/28.0.50/lisp/window.el.gz +++ /home/user/src/patches/window.el @@ -5073,14 +5073,9 @@ (setq window (window-normalize-window window t)) (let* ((buffer (window-buffer window)) (quit-restore (window-parameter window 'quit-restore)) - (prev-buffer - (let* ((prev-buffers (window-prev-buffers window)) - (prev-buffer (caar prev-buffers))) - (and (or (not (eq prev-buffer buffer)) - (and (cdr prev-buffers) - (not (eq (setq prev-buffer (cadr prev-buffers)) - buffer)))) - prev-buffer))) + (prev-buffer (car (cl-find-if-not + (lambda (buf) (eq (car buf) buffer)) + (window-prev-buffers window)))) quad entry) (cond ((and (not prev-buffer) Diff finished. Tue May 11 22:00:30 2021 --=-=-= Content-Type: text/plain; format=flowed -- --=-=-=-- ------------=_1621074901-8353-1--