From unknown Tue Jun 17 01:48:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48359: 28.0.50; vc-annotate revert doesn't work Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 May 2021 18:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48359 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 48359@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16207593242922 (code B ref -1); Tue, 11 May 2021 18:56:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 May 2021 18:55:24 +0000 Received: from localhost ([127.0.0.1]:37380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgXXQ-0000l4-Hv for submit@debbugs.gnu.org; Tue, 11 May 2021 14:55:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:46052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgXXO-0000kw-MZ for submit@debbugs.gnu.org; Tue, 11 May 2021 14:55:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgXXO-00078q-D3 for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 14:55:22 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35425) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgXXM-0004xx-Hz for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 14:55:22 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A88A75C017F for ; Tue, 11 May 2021 14:55:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 11 May 2021 14:55:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secretsauce.net; h=from:to:subject:date:message-id:mime-version:content-type; s= fm3; bh=xe3+dl5riPC3VxWFyu/MLEFIfU5bx6/W817CkZQrmpQ=; b=TLizz5u0 RUFN9YSSEaVStfFMVl97DzQRyqJUch9yyHqreDD+nEO7CPtb8y1V1NNN1TKqTseI SMVpBbde5rqqTXrCtvtF/2j98QgkeuK2NzPO70nwpkViU+//j9mJ6GDhrXafTUon 2N90d0kru0rs8kTL0M74DvZdZi3ofYz+s/ei8XGA+Ph+HVtE+Lapg/IG39YLLsgg KCAjm3lhGrzF9QioWEsn8evaQDTB5YO3n0+jQrEiX1LoRPSFNRJD5F7yz55iybHh l74OgXL2yW4hf30vwuFCUutH6N/8io3wYxA8vJsFVGqZyoUjyNuipeCXD54mXe1B n3U7dVXh9nvMaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=xe3+dl5riPC3VxWFyu/MLEFIfU5bx 6/W817CkZQrmpQ=; b=aAOAhmJbOKrqnJQasIKXsbVCkHamFz//M89LD7TApNzyY 89lXEQ9NXsxQiOt37XEZGhwMLO2aWtzPaFfFSNAO63CXhNYfrwwxhTVKiAXpNhzX +8MoThNR+hHU1+j3ysAgeA+4127GpMKX9gT24WUUf06Be2DRrtpSGLtYXDqFkC5A nsZVSOkCkX3nHQGtEMLkWgotPb38xwC4/RgbuY6w2DN0PV9vwBE2/XZXzEMDhVsk nCCEFuYtFrOwxohsk63p++xcvRWRltzQSrATSwVQdbt/h8DmLQ0M2EWglTjfa8Qr 7Fkvyl98KXeVc0kplwA6QGW8NsA0lNPoILbeut8Bg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehtddgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecufghrlhcuvffnffculddquddtmdenucfjughrpe fhvffufffkgggtsehttdertddttddtnecuhfhrohhmpeffihhmrgcumfhoghgrnhcuoegu ihhmrgesshgvtghrvghtshgruhgtvgdrnhgvtheqnecuggftrfgrthhtvghrnhepffdvff duhfekfffhieefhfffvddtgfefjeevuedvfedujeejudevfedtgeeguedvnecukfhppedu tdejrddvuddtrddvudefrddvgeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepughimhgrsehsvggtrhgvthhsrghutggvrdhnvght X-ME-Proxy: Received: from localhost (107-210-213-243.lightspeed.irvnca.sbcglobal.net [107.210.213.243]) by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 11 May 2021 14:55:19 -0400 (EDT) From: Dima Kogan Date: Tue, 11 May 2021 11:55:33 -0700 Message-ID: <87o8dhyuai.fsf@jpl.nasa.gov> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.29; envelope-from=dima@secretsauce.net; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hi. This should be simple, but I can't figure it out quickly. Can I get another set of eyes? Using a very recent emacs built from git. Recipe: 1. emacs -Q -nw file_in_a_git_repo Any file in any repo works probably. I'm using ~/.emacs.d/init.el 2. C-x v g vc-annotate 3. g Should "revert" the annotation buffer This last step doesn't work: I get apply: Symbol's function definition is void: nil Looking into that, I see that 'g' maps to (revert-buffer), which makes sense. For some reason, revert-buffer-function is set to #'help-mode-revert-buffer. This feels very strange. And is the cause of the error: help-mode-revert-buffer assumes we're looking at a Help buffer, and tries to call nil as a function. Is this speaking to anybody? Thanks From unknown Tue Jun 17 01:48:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48359: 28.0.50; vc-annotate revert doesn't work Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 May 2021 19:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48359 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dima Kogan Cc: 48359@debbugs.gnu.org Received: via spool by 48359-submit@debbugs.gnu.org id=B48359.16207602394506 (code B ref 48359); Tue, 11 May 2021 19:11:01 +0000 Received: (at 48359) by debbugs.gnu.org; 11 May 2021 19:10:39 +0000 Received: from localhost ([127.0.0.1]:37425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgXmB-0001Ac-8g for submit@debbugs.gnu.org; Tue, 11 May 2021 15:10:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgXm9-0001AP-Lk for 48359@debbugs.gnu.org; Tue, 11 May 2021 15:10:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33124) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgXm3-00067c-N0; Tue, 11 May 2021 15:10:32 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1050 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgXm1-0006c7-Ot; Tue, 11 May 2021 15:10:31 -0400 Date: Tue, 11 May 2021 22:10:34 +0300 Message-Id: <83lf8l3x3p.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87o8dhyuai.fsf@jpl.nasa.gov> (message from Dima Kogan on Tue, 11 May 2021 11:55:33 -0700) References: <87o8dhyuai.fsf@jpl.nasa.gov> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Dima Kogan > Date: Tue, 11 May 2021 11:55:33 -0700 > > 1. emacs -Q -nw file_in_a_git_repo > Any file in any repo works probably. I'm using ~/.emacs.d/init.el > > 2. C-x v g > vc-annotate > > 3. g > Should "revert" the annotation buffer > > This last step doesn't work: I get > > apply: Symbol's function definition is void: nil > > Looking into that, I see that 'g' maps to (revert-buffer), which makes > sense. For some reason, revert-buffer-function is set to > #'help-mode-revert-buffer. This feels very strange. And is the cause of > the error: help-mode-revert-buffer assumes we're looking at a Help > buffer, and tries to call nil as a function. Is this speaking to anybody? Here's the backtrace of the code which sets revert-buffer-function to help-mode-revert-buffer: help-mode() help-mode-setup() run-hooks(temp-buffer-setup-hook) vc-annotate("d:/gnu/git/emacs/trunk/src/bidi.c" ... funcall-interactively(vc-annotate "d:/gnu/git/emacs/trunk/src/bidi.c" ... call-interactively(vc-annotate nil nil) command-execute(vc-annotate) From unknown Tue Jun 17 01:48:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48359: 28.0.50; vc-annotate revert doesn't work Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2022 14:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48359 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dima Kogan Cc: 48359@debbugs.gnu.org Received: via spool by 48359-submit@debbugs.gnu.org id=B48359.16575497007552 (code B ref 48359); Mon, 11 Jul 2022 14:29:01 +0000 Received: (at 48359) by debbugs.gnu.org; 11 Jul 2022 14:28:20 +0000 Received: from localhost ([127.0.0.1]:40552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAuOa-0001xk-8A for submit@debbugs.gnu.org; Mon, 11 Jul 2022 10:28:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAuOX-0001xR-SC for 48359@debbugs.gnu.org; Mon, 11 Jul 2022 10:28:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qqiSEKEbEzZEoSDI42yxf/O2LhGZ1uMu3I30svsYIQU=; b=gbOJY2QzDmPGLQ9S5r+20Zeftk FvJEcaCjQWF/R5zqWRcnwM9Tujv96N5sKLAQXSbteAMVcxIe8FoPOWxxwFQJetHZGZL+Bjrcck557 Wg3qKsggbZQmso0ftgQciYv1cFk7MNrxepCsKWwpx3uFPUw1iaJMkKFwIJ7sNC0/q1Ow=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAuOO-0003vP-2R; Mon, 11 Jul 2022 16:28:10 +0200 From: Lars Ingebrigtsen In-Reply-To: <87o8dhyuai.fsf@jpl.nasa.gov> (Dima Kogan's message of "Tue, 11 May 2021 11:55:33 -0700") References: <87o8dhyuai.fsf@jpl.nasa.gov> X-Now-Playing: Cult Of Wedge's _Scarred For Life 2_: "The Day Before Doomsday " Date: Mon, 11 Jul 2022 16:28:05 +0200 Message-ID: <87fsj7u3ka.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dima Kogan writes: > 3. g > Should "revert" the annotation buffer > > This last step doesn't work: I get > > apply: Symbol's function definition is void: nil I've now fixed this in Emacs 29. (By just resetting `revert-buffer-function'.) It might make sense to make a real reversion function, but that doesn't really seem that useful in one of these buffers. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dima Kogan writes: > 3. g > Should "revert" the annotation buffer > > This last step doesn't work: I get > > apply: Symbol's function definition is void: nil I've now fixed this in Emacs 29. (By just resetting `revert-buffer-function'.) It might make sense to make a real reversion function, but that doesn't really seem that useful in one of these buffers. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 10:28:23 2022 Received: (at control) by debbugs.gnu.org; 11 Jul 2022 14:28:23 +0000 Received: from localhost ([127.0.0.1]:40555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAuOd-0001xz-Ew for submit@debbugs.gnu.org; Mon, 11 Jul 2022 10:28:23 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAuOc-0001xb-2l for control@debbugs.gnu.org; Mon, 11 Jul 2022 10:28:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rTx8ENFiQ4qXHE9lucynbrMPrD5OdG1nfePYyVsYf2Q=; b=TO4NXhL2TC2rVdRuTtZJyBsRYD hQZA2i3LJyArbXnHzxwIIZFWZXToyySwQKu7EqJeDbrOOKqABBV+XAhsazmJoxmxYp4fTEQUDGu8g Q1Nk/aD9RiCqfKpRkWpebRUYqScApOIio48VVnEa7bk5boDppa2Txqd+02BzsqGYWpQo=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAuOU-0003vW-43 for control@debbugs.gnu.org; Mon, 11 Jul 2022 16:28:16 +0200 Date: Mon, 11 Jul 2022 16:28:13 +0200 Message-Id: <87edyru3k2.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #48359 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 48359 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 48359 29.1 quit