Subject: bug#48354: closed (Re: bug#48354: [PATCH] Fix compat with latest mingw64-headers)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 11 May 2021 15:47:02 +0000

Your bug report

#48354: [PATCH] Fix compat with latest mingw64-headers

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
48354: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48354
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#48354: [PATCH] Fix compat with latest mingw64-headers
From: Eli Zaretskii <[email-masked]>
To: Konstantin Shabanov <[email-masked]>
Cc: [email-masked]
Date: Tue, 11 May 2021 18:46:50 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> Date: Tue, 11 May 2021 12:59:47 +0000
> From: Konstantin Shabanov <[email-masked]>
> 
> 
> [1:text/plain Hide]
> 
> This commit to mingw-w64 broke compatibility with emacs-head because of the OS_NT conflict:
> 
>     In file included from w32image.c:32:
>     w32common.h:45:3: error: expected identifier before numeric constant
>        45 |   OS_NT
>           |   ^~~~~
> 
> https://sourceforge.net/p/mingw-w64/mingw-w64/ci/dc7ef298837d4581200a3bed660aed36818c1b00/
> 
> The series of patches in attachments should fix the issue:
> - the first one should cause the build to fail in the future instead of silent overriding definition;
> - the second patch renames OS_9X to conform mingw-w64 naming;
> - the third actually fixes build failure (preserving backward compatibility);

Thanks, this is already fixed since 2 days ago on the emacs-27 branch,
soon to be merged to master.

Subject: [PATCH] Fix compat with latest mingw64-headers
From: Konstantin Shabanov <[email-masked]>
To: "[email-masked]" <[email-masked]>
Date: Tue, 11 May 2021 12:59:47 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

This commit to mingw-w64 broke compatibility with emacs-head because of the OS_NT conflict:

    In file included from w32image.c:32:
    w32common.h:45:3: error: expected identifier before numeric constant
       45 |   OS_NT
          |   ^~~~~

https://sourceforge.net/p/mingw-w64/mingw-w64/ci/dc7ef298837d4581200a3bed660aed36818c1b00/

The series of patches in attachments should fix the issue:
- the first one should cause the build to fail in the future instead of silent overriding definition;
- the second patch renames OS_9X to conform mingw-w64 naming;
- the third actually fixes build failure (preserving backward compatibility);

Best regards,
Konstantin Shabanov