From unknown Wed Jun 18 23:05:54 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#48351 <48351@debbugs.gnu.org> To: bug#48351 <48351@debbugs.gnu.org> Subject: Status: 28.0.50; custom-theme-summary doesn't find theme summary line reliably Reply-To: bug#48351 <48351@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:05:54 +0000 retitle 48351 28.0.50; custom-theme-summary doesn't find theme summary line= reliably reassign 48351 emacs submitter 48351 Mauro Aranda severity 48351 normal tag 48351 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue May 11 10:22:14 2021 Received: (at submit) by debbugs.gnu.org; 11 May 2021 14:22:14 +0000 Received: from localhost ([127.0.0.1]:37026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgTH3-0006Tv-Lo for submit@debbugs.gnu.org; Tue, 11 May 2021 10:22:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:44422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgTH2-0006To-BV for submit@debbugs.gnu.org; Tue, 11 May 2021 10:22:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgTH2-0000UD-2k for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 10:22:12 -0400 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]:33752) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgTH0-0008OD-6o for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 10:22:11 -0400 Received: by mail-qk1-x734.google.com with SMTP id f29so6602099qka.0 for ; Tue, 11 May 2021 07:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=fUVqBBlJLGYOMFriGX6bvGjxCosLHis30DhHht8KyiA=; b=WbOCNLigsmcC0IDnb0xy2w4uQMabPokpvvMs3RGMJt2LPBRcP78cnQmkGJuZUtKEcV oLqep1tlxPVrAnh17mdEZJkSP+E2gStlUEtBcXKYXRaAeJMScD9m5K9ij5T+ir4xzWYG 3/nq8VRFMSD73RSzk+M2kyFPxrUvo/0hLjCAh1K5bblNgSrcxbXjvd0jp8LngNLEevk1 qSAqWVVkf35WhUYcEz26NnhQCXyhd1bNORmuiYa8J4y51QfInaHjEPffHNQG0q6NlPob B7Jr3fi5SAGCbr9enEMNTjEIFcJSxHZN1/fhueTOaXUvRCGWTrBLDbRla8eDb3JJzelU RfBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=fUVqBBlJLGYOMFriGX6bvGjxCosLHis30DhHht8KyiA=; b=P6Gd90n6XOeF/hJMVpHckPfeY3Js9WEkiyYG4bCQKH8Bzj6m5L8k6Gds7FIYX3jT/F Cni1++hSKhWXZfURxCYTJ9q/fbavQ2TPieUikM5K2xeCv9Y15pWOqV0Kbz3bxFe2acMQ r+SM2TWsizCqITc82qreYMuKMJQSgSiVQq0zoS7AFwqoka3+4Hl/x/xeOGgDwf+Pmh2w CbJ2VJ3gEvSJ8Z+AmS6I5qxumrWVoNE7ufBHY9EpH+EJDQUb7q1ANOZ/EiVx70AdxLqR VNXpr/rDsqGC3ARI4xDssOW5knFxcRniNpBhnsJRiWSoY4vFTCh5W3CAyyK4r+SnY03n hkGQ== X-Gm-Message-State: AOAM530HLDDkaMPdvYo1AJ2AD/kofc5yQMaTCI7kXtbU5kuozjuOA31J xYtVT5d6xc7guB0JRSdAlXTUOv9RzYWgVg== X-Google-Smtp-Source: ABdhPJyRBDHrt6lVlmQWmcTi/w29EHrOm41D/SgmQzg3I/odXl0r6DtnJBBzMjxh+ZwcHktaPlQ9Vg== X-Received: by 2002:a37:f503:: with SMTP id l3mr27878620qkk.307.1620742924739; Tue, 11 May 2021 07:22:04 -0700 (PDT) Received: from tbb.theblackbeard.org ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id f12sm14281916qtj.26.2021.05.11.07.22.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 07:22:04 -0700 (PDT) From: Mauro Aranda To: bug-gnu-emacs@gnu.org Subject: 28.0.50; custom-theme-summary doesn't find theme summary line reliably Date: Tue, 11 May 2021 11:22:22 -0300 Message-ID: <87o8dhuz8h.fsf@tbb.theblackbeard.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::734; envelope-from=maurooaranda@gmail.com; helo=mail-qk1-x734.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Starting from emacs -Q: M-x customize-themes Look for themes such as the leuven theme or the modus-* themes. The summary after the checkbox reads: "(no documentation available)" However looking at the theme files, the deftheme form has a docstring, so I think the *Custom Themes* buffer should be showing the summary correctly. IMO, the restriction imposed by `custom-theme-summary' is too strict: the function currently requires that the deftheme form is the very first one in the file. In GNU Emacs 28.0.50 (build 2, i686-pc-linux-gnu, GTK+ Version 2.24.33, cairo version 1.16.0) of 2021-05-11 built on tbb Repository revision: cd46972ee82d392cef8fa6e51c370d3d8f48777a Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12010000 System Description: Slackware 14.2 i586 (post 14.2 -current) Configured using: 'configure --with-mailutils PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK2 ZLIB Important settings: value of $LC_COLLATE: C value of $LANG: en_US.utf8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 8 50866 5885) (symbols 24 6591 1) (strings 16 18158 1687) (string-bytes 1 599925) (vectors 8 13197) (vector-slots 4 179810 14964) (floats 8 21 47) (intervals 28 197 4) (buffers 564 10)) From debbugs-submit-bounces@debbugs.gnu.org Tue May 11 10:26:44 2021 Received: (at 48351) by debbugs.gnu.org; 11 May 2021 14:26:44 +0000 Received: from localhost ([127.0.0.1]:37049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgTLQ-0006cG-9l for submit@debbugs.gnu.org; Tue, 11 May 2021 10:26:44 -0400 Received: from mail-qk1-f170.google.com ([209.85.222.170]:41704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgTLO-0006bw-K6; Tue, 11 May 2021 10:26:42 -0400 Received: by mail-qk1-f170.google.com with SMTP id l129so18859104qke.8; Tue, 11 May 2021 07:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=3tm7FiUhGmi86nCjnKcacLmbfaIq6Xq6ef++nSTRxvw=; b=OvqRob2Q3BexNvkq7dIobKU1jADa4MIk3VuEFtCNlG347Iu4RPgsEylLNAvtGVmScV SXd25RyHI4X91OsYhymKELQyYmMCuZkkQmVOwWn+rYgrfcM02yf4MCNWWSVZ5XeG90Ws 1CyKeG7koekjA1uK4hRd00zxZVrOeA/wjLxKMuiWn4lCccpORWTfDUjiLlAVjytWHsK5 hLAcPWq6XUt1H3JaQ4qGNZNcGpDoSVuPVJEXgJf0iTFLJKRTHewzLnHENDRyxWCdBw+6 5LYZcjpqudgnX++LKF2o90aGl+r1SUtTID38VzQzPSdtGFRZtC0BffUhOGx6SN/NYtlA MsBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=3tm7FiUhGmi86nCjnKcacLmbfaIq6Xq6ef++nSTRxvw=; b=oCZowAHHqpjOjmxTPsTBeSc/jrzE2lWb78QJmrsy+o3+gnPwVcMItadOrdUTpPFEaU 1ukIJ5KruP+308TeQ5n05xA1BrBPZUkojd+n4hYXWHaojuHMytCpjJkDT7q8tJqUCkYF xfBb80H9uRuVCbfn/4QS5HJLNWSbTl350Ghxl21qCT6e35ZQfw8JewF1NoAcJCoZH2hC M8Poi7i4v/lbZdEbhxqVHmtfTp43L3SaaW+Pd2fXzGWF9Szx1tiZdEd5aEPVljMn4Ffr OEt7l7ItE0lMyHnWK+0n4et5KnTlWv2gDzM19UvtsR8O+XSFrm/7pdPdTGeV57k8MU2r gXBQ== X-Gm-Message-State: AOAM532y7qcIJ7utLWwUTiru/JfeMQIbW/JvrQdD60ZrVAF0TztHYSvj 3TwfZLF4Y1Pm76XFv/cn8pbTK8ugvBNS5g== X-Google-Smtp-Source: ABdhPJxvOeryouGBQwnklYnjQt3LWwSL4QSO9NbJ9tk1jen5XCNQn9B9tb2Mz8GsCTqTVMA2qX5ZvA== X-Received: by 2002:ae9:f504:: with SMTP id o4mr12958177qkg.246.1620743196622; Tue, 11 May 2021 07:26:36 -0700 (PDT) Received: from tbb.theblackbeard.org ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id p1sm13522749qtq.12.2021.05.11.07.26.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 07:26:35 -0700 (PDT) From: Mauro Aranda To: 48351@debbugs.gnu.org Subject: Re: bug#48351: 28.0.50; custom-theme-summary doesn't find theme summary line reliably References: <87o8dhuz8h.fsf@tbb.theblackbeard.org> Date: Tue, 11 May 2021 11:26:54 -0300 In-Reply-To: <87o8dhuz8h.fsf@tbb.theblackbeard.org> (Mauro Aranda's message of "Tue, 11 May 2021 11:22:22 -0300") Message-ID: <87lf8luz0x.fsf@tbb.theblackbeard.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 48351 patch quit Mauro Aranda writes: > IMO, the restriction imposed by `custom-theme-summary' is too strict: > the function currently requires that the deftheme form is the very first > one in the file. Here's a patch. Any comments? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Lift-restriction-for-finding-theme-summary-line.patch Content-Description: patch >From dd65d7bf57e1cffc64af0f86282b0634b9216b20 Mon Sep 17 00:00:00 2001 From: Mauro Aranda Date: Tue, 11 May 2021 09:14:57 -0300 Subject: [PATCH] Lift restriction for finding theme summary line * lisp/cus-theme.el (custom-theme-summary): Don't limit the file to having the deftheme form as the very first form, rather look for the deftheme form explicitly. --- lisp/cus-theme.el | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lisp/cus-theme.el b/lisp/cus-theme.el index 13fb9f34fa..dfa2226403 100644 --- a/lisp/cus-theme.el +++ b/lisp/cus-theme.el @@ -657,10 +657,12 @@ custom-theme-summary (insert-file-contents fn) (let ((sexp (let ((read-circle nil)) (condition-case nil - (read (current-buffer)) - (end-of-file nil))))) - (and (eq (car-safe sexp) 'deftheme) - (setq doc (nth 2 sexp)))))))) + (progn + (re-search-forward "^(deftheme") + (beginning-of-line) + (read (current-buffer))) + (error nil))))) + (setq doc (nth 2 sexp))))))) (cond ((null doc) "(no documentation available)") ((string-match ".*" doc) -- 2.31.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 18 11:16:42 2021 Received: (at 48351) by debbugs.gnu.org; 18 May 2021 15:16:43 +0000 Received: from localhost ([127.0.0.1]:56950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj1Sc-00041u-Fu for submit@debbugs.gnu.org; Tue, 18 May 2021 11:16:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj1Sa-0003vs-C6 for 48351@debbugs.gnu.org; Tue, 18 May 2021 11:16:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Iq/t1sBcqwMilUt+14DKIZhy0yHDHNwSZXEWi7PRPd8=; b=cpAQPDDe9HcsuGZa5Lq9gzGTdL Z9foI7pIYELPPq27X0K2uaHgZ8PVwAy0bmsxiq9FN32FS2dUkLJqo/cZMt5sB/C/dPPYUDr46rPUx VfWGuSTZ2ovf0sVeLPdFuT+7Fa2uPjKGE1tZysWRGHioUlR3pAsoTWLArUo1+g81pek8=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lj1SS-0006gA-43; Tue, 18 May 2021 17:16:34 +0200 From: Lars Ingebrigtsen To: Mauro Aranda Subject: Re: bug#48351: 28.0.50; custom-theme-summary doesn't find theme summary line reliably References: <87o8dhuz8h.fsf@tbb.theblackbeard.org> <87lf8luz0x.fsf@tbb.theblackbeard.org> X-Now-Playing: The Specials's _The Specials_: "Stupid Marriage" Date: Tue, 18 May 2021 17:16:31 +0200 In-Reply-To: <87lf8luz0x.fsf@tbb.theblackbeard.org> (Mauro Aranda's message of "Tue, 11 May 2021 11:26:54 -0300") Message-ID: <875yzgdqcw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: >> IMO, the restriction imposed by `custom-theme-summary' is too strict: >> the function currently requires that the deftheme form is the very first >> one in the file. > > Here's a patch. Any comment [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48351 Cc: 48351@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: >> IMO, the restriction imposed by `custom-theme-summary' is too strict: >> the function currently requires that the deftheme form is the very first >> one in the file. > > Here's a patch. Any comments? Looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed May 19 09:03:25 2021 Received: (at 48351) by debbugs.gnu.org; 19 May 2021 13:03:25 +0000 Received: from localhost ([127.0.0.1]:58366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljLrA-0000Il-SI for submit@debbugs.gnu.org; Wed, 19 May 2021 09:03:25 -0400 Received: from mail-qk1-f181.google.com ([209.85.222.181]:46864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljLr9-0000IQ-09; Wed, 19 May 2021 09:03:23 -0400 Received: by mail-qk1-f181.google.com with SMTP id 76so12516536qkn.13; Wed, 19 May 2021 06:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:date:message-id:mime-version; bh=b+fvREQkRyP3q1famLP8zAkpA2QdemWHVKuZynvbIJI=; b=JVwWXZfJ708qzhy3x2TU8+h/rLOiBlxle/3NqYueWtGEyXwmZaxxyidT4s89FUDDwx OwjBxCqpGnv/bLXBp2iAQ8rik2CoU3bvSDZHVSEsUPqdC5NQKGYDCevapA8eKYMCF7Ek hezhX0XaBYs8Hjs90TUICBuLO6DXdF/5mnUACqTeZDmUZszx2hSIHEWPz97E2w39Z3yZ pEZncGuqKcnY6wGQGl1NJ7aJ4Fw6qtftpBpsniqZEZ+vHNmZ5JPsbTJNeWB4kwUOoTYq aZ6ukd0Gb8CtOpfW+7645tv5/OLzGHr/18bLrvJKvFSTyixeiVY8et67q/Icwjtk6MM1 0hIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :mime-version; bh=b+fvREQkRyP3q1famLP8zAkpA2QdemWHVKuZynvbIJI=; b=Hy1HUzBJzPXK32N+5PPdp0zdY1M72FeufQtRfJb+gQ4lZPUiI6NlUfX9cdc00/ZaVM InMVU9m4eltqzKO2DlPZ4mXz2q2Adhnbj/zCaGbrleuoBIu+VHok5B9yYreSlgPUBi/4 Kc9+9rDawjm/+PFgrWW/MP2WcaE5Gtz+bw3puWmOSb4seHJQCL3ZPB6vcpO9/U0nyuA7 TfTzJ3Q3tce+Xvvykce89x6GSp93F3WBCxXqeFZd5xprpEXstXoU0dwJp+ZKK3yh69TE fNifWx3nLxev0c5tbQ12HUreIkVaeH5oQeCcl6AjZxA7WW4YobjlgV59CJKO76Vj8aSE jfUw== X-Gm-Message-State: AOAM531eSL7Cvdx1ok3R52xqCKK5JwcQ7spO2HZNLL+a/s8oKSop3ugF xqziEnXtU5jeFq+QfGhzU7QqxIG0FU4= X-Google-Smtp-Source: ABdhPJx1FHX/stWSgDWrPIzRCw56Ljt0EA9jyihQfmICYdzJNQELNaOqHIIQ3Tz0E+XJqSAIBfxE2Q== X-Received: by 2002:a37:4697:: with SMTP id t145mr12024989qka.188.1621429397111; Wed, 19 May 2021 06:03:17 -0700 (PDT) Received: from tbb.theblackbeard.org ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id 25sm5195583qtd.51.2021.05.19.06.03.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 06:03:16 -0700 (PDT) From: Mauro Aranda To: Lars Ingebrigtsen Subject: Re: bug#48351: 28.0.50; custom-theme-summary doesn't find theme summary line reliably In-Reply-To: <875yzgdqcw.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 18 May 2021 17:16:31 +0200) Date: Wed, 19 May 2021 10:03:44 -0300 Message-ID: <87fsyiri33.fsf@tbb.theblackbeard.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48351 Cc: 48351@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 48351 28.1 quit Lars Ingebrigtsen writes: > Mauro Aranda writes: > >>> IMO, the restriction imposed by `custom-theme-summary' is too strict: >>> the function currently requires that the deftheme form is the very first >>> one in the file. >> >> Here's a patch. Any comments? > > Looks good to me. Thanks for taking a look. I pushed the patch, but forgot to add the bug number to the commit message (I should've double checked, sorry!). Anyway, closing the bug report. From unknown Wed Jun 18 23:05:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 Jun 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator