GNU bug report logs - #4835
something about message-log-max? - see msg#95

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Fri, 30 Oct 2009 22:55:05 UTC

Severity: wishlist

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #30 received at 4835 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: "Stefan Monnier" <monnier <at> iro.umontreal.ca>,
        4835 <at> debbugs.gnu.org
Subject: RE: bug#4835: 23.1; Improper `Invalid face reference' messages. Performance degraded.
Date: Sat, 31 Oct 2009 14:59:38 -0400
> 2. The code I had seems nevertheless to "work", in the sense that it
> does what I expect (highlights the column). Except that it logs those
> messages and the performance is terrible.

I suspect this is because parts of font-lock do this:

  (if (stringp matcher)
      (re-search-forward matcher end t)
   (funcall matcher end)))

while other parts do this:

  (font-lock-eval-keywords (if (fboundp keywords)
                               (funcall keywords)
                             (eval keywords)))))

If `matcher' is a lambda expression, the first will work as expected,
because you can pass a lambda to funcall.  But the second will do the
wrong thing.

We should probably fix the code to check for and disallow lambda
expressions (and the docs), assuming not too much external code is
relying on the unintended behavior.



This bug report was last modified 9 years and 23 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.