From unknown Tue Jun 17 01:43:28 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4834: 23.1; Invalid face reference: tags-tag-face Reply-To: "Drew Adams" , 4834@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 30 Oct 2009 21:40:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4834 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125693840621330 (code B ref -1); Fri, 30 Oct 2009 21:40:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 30 Oct 2009 21:33:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.3 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9ULXO3O021326 for ; Fri, 30 Oct 2009 14:33:25 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3z63-0004Rp-Oy for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2009 17:33:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3z5y-0004RK-97 for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2009 17:33:22 -0400 Received: from [199.232.76.173] (port=50171 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3z5y-0004RC-5L for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2009 17:33:18 -0400 Received: from acsinet11.oracle.com ([141.146.126.233]:55754) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N3z5x-0002uX-Or for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2009 17:33:18 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n9ULXn9B008005 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Oct 2009 21:33:51 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n9UIESJY000607 for ; Fri, 30 Oct 2009 21:34:35 GMT Received: from abhmt020.oracle.com by acsmt354.oracle.com with ESMTP id 20738152321256938371; Fri, 30 Oct 2009 14:32:51 -0700 Received: from dradamslap1 (/24.5.185.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 30 Oct 2009 14:32:51 -0700 From: "Drew Adams" To: Date: Fri, 30 Oct 2009 14:32:50 -0700 Message-ID: <039B652994C447B2AD2449524AFDE078@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcpZqIgqY/eK6r7/S2mV3U6nUfy5+w== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt357.oracle.com [141.146.40.157] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.4AEB5B98.016F:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) I sent this bug, same Subject line, to emacs-pretest-bug on 2008-02-12, before there was a bug tracker. Never got any response. The bug is still there, in release 23.1. Here's the recipe (from the first bug report). Where it says `list-tags', you must provide the name of a function in the tags table, obviously. > emacs -Q > visit a tags table, and then do M-x list-tags. > Check buffer *Messages* for error message: > "Invalid face reference: tags-tag-face" > > It is soon updated, so you see, for instance, > "Invalid face reference: tags-tag-face [161 times]" > > The problem seems to be the (multiple) occurrences of things like > this: > > (make-text-button > pt (point) > 'tag-info tag-info > 'file-path path > 'goto-func goto-func > 'action (lambda (button) > (let ((tag-info (button-get button 'tag-info)) > (goto-func (button-get button 'goto-func))) > (tag-find-file-of-tag (button-get button 'file-path)) > (widen) > (funcall goto-func tag-info))) > 'face 'tags-tag-face ; <====== SHOULD NOT BE QUOTED > 'type 'button) > > The problem is that `tags-tag-face' is not a face; it is a variable > whose value is a face - face `default', by default. Presumably, the > quote should be removed. There are several such occurrences in > etags.el - in fact all occurrences of `tags-tag-face' seem to be > incorrectly quoted. In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600) of 2009-07-29 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4)' From unknown Tue Jun 17 01:43:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: "Drew Adams" Subject: bug#4834 closed by Chong Yidong (Re: 23.1; Invalid face reference: tags-tag-face) Message-ID: References: <87zl77floi.fsf@stupidchicken.com> <039B652994C447B2AD2449524AFDE078@us.oracle.com> X-Emacs-PR-Message: they-closed 4834 X-Emacs-PR-Package: emacs Reply-To: 4834@debbugs.gnu.org Date: Sat, 31 Oct 2009 18:50:05 +0000 Content-Type: multipart/mixed; boundary="----------=_1257015005-15197-1" This is a multi-part message in MIME format... ------------=_1257015005-15197-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #4834: 23.1; Invalid face reference: tags-tag-face It has been closed by Chong Yidong . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Chong Yidong by replying to this email. --=20 4834: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D4834 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1257015005-15197-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4834-done) by emacsbugs.donarmstrong.com; 31 Oct 2009 18:44:20 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.3 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pantheon-po44.its.yale.edu (pantheon-po44.its.yale.edu [130.132.50.78]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9VIiI05014628 for <4834-done@emacsbugs.donarmstrong.com>; Sat, 31 Oct 2009 11:44:19 -0700 Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po44.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n9VIiDkr024780 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 31 Oct 2009 14:44:13 -0400 Received: by furry (Postfix, from userid 1000) id 15BDBC070; Sat, 31 Oct 2009 14:44:13 -0400 (EDT) From: Chong Yidong To: "Drew Adams" Cc: 4834-done@debbugs.gnu.org Subject: Re: 23.1; Invalid face reference: tags-tag-face Date: Sat, 31 Oct 2009 14:44:13 -0400 Message-ID: <87zl77floi.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) > emacs -Q > visit a tags table, and then do M-x list-tags. > Check buffer *Messages* for error message: > "Invalid face reference: tags-tag-face" > > It is soon updated, so you see, for instance, > "Invalid face reference: tags-tag-face [161 times]" Fixed, thanks. ------------=_1257015005-15197-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 30 Oct 2009 21:33:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.3 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9ULXO3O021326 for ; Fri, 30 Oct 2009 14:33:25 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3z63-0004Rp-Oy for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2009 17:33:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3z5y-0004RK-97 for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2009 17:33:22 -0400 Received: from [199.232.76.173] (port=50171 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3z5y-0004RC-5L for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2009 17:33:18 -0400 Received: from acsinet11.oracle.com ([141.146.126.233]:55754) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N3z5x-0002uX-Or for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2009 17:33:18 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n9ULXn9B008005 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Oct 2009 21:33:51 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n9UIESJY000607 for ; Fri, 30 Oct 2009 21:34:35 GMT Received: from abhmt020.oracle.com by acsmt354.oracle.com with ESMTP id 20738152321256938371; Fri, 30 Oct 2009 14:32:51 -0700 Received: from dradamslap1 (/24.5.185.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 30 Oct 2009 14:32:51 -0700 From: "Drew Adams" To: Subject: 23.1; Invalid face reference: tags-tag-face Date: Fri, 30 Oct 2009 14:32:50 -0700 Message-ID: <039B652994C447B2AD2449524AFDE078@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcpZqIgqY/eK6r7/S2mV3U6nUfy5+w== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt357.oracle.com [141.146.40.157] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.4AEB5B98.016F:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) I sent this bug, same Subject line, to emacs-pretest-bug on 2008-02-12, before there was a bug tracker. Never got any response. The bug is still there, in release 23.1. Here's the recipe (from the first bug report). Where it says `list-tags', you must provide the name of a function in the tags table, obviously. > emacs -Q > visit a tags table, and then do M-x list-tags. > Check buffer *Messages* for error message: > "Invalid face reference: tags-tag-face" > > It is soon updated, so you see, for instance, > "Invalid face reference: tags-tag-face [161 times]" > > The problem seems to be the (multiple) occurrences of things like > this: > > (make-text-button > pt (point) > 'tag-info tag-info > 'file-path path > 'goto-func goto-func > 'action (lambda (button) > (let ((tag-info (button-get button 'tag-info)) > (goto-func (button-get button 'goto-func))) > (tag-find-file-of-tag (button-get button 'file-path)) > (widen) > (funcall goto-func tag-info))) > 'face 'tags-tag-face ; <====== SHOULD NOT BE QUOTED > 'type 'button) > > The problem is that `tags-tag-face' is not a face; it is a variable > whose value is a face - face `default', by default. Presumably, the > quote should be removed. There are several such occurrences in > etags.el - in fact all occurrences of `tags-tag-face' seem to be > incorrectly quoted. In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600) of 2009-07-29 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4)' ------------=_1257015005-15197-1--