GNU bug report logs - #48320
[PATCH] lint: Verify if #:tests? is respected in the 'check' phase.

Previous Next

Package: guix-patches;

Reported by: Maxime Devos <maximedevos <at> telenet.be>

Date: Sun, 9 May 2021 18:03:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#48320: closed ([PATCH] lint: Verify if #:tests? is respected
 in the 'check' phase.)
Date: Wed, 30 Jun 2021 11:56:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 30 Jun 2021 13:55:32 +0200
with message-id <87pmw3lg7f.fsf <at> gnu.org>
and subject line Re: [PATCH v3] lint: Verify if #:tests? is respected in the 'check' phase.
has caused the debbugs.gnu.org bug report #48320,
regarding [PATCH] lint: Verify if #:tests? is respected in the 'check' phase.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
48320: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48320
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: [PATCH] lint: Verify if #:tests? is respected in the 'check' phase.
Date: Sun, 09 May 2021 20:02:12 +0200
[Message part 3 (text/plain, inline)]
Hi guix,

There have been a few patches to the mailing list lately not
respecting this, and this linter detects 325 package definitions
that could be modified to support the --without-tests package
transformation.

Copyright lines were added in the previous patch I sent to guix-patches
today.

Greetings,
Maxime
[0001-lint-Verify-if-tests-is-respected-in-the-check-phase.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]
[Message part 6 (message/rfc822, inline)]
From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 48320-done <at> debbugs.gnu.org
Subject: Re: [PATCH v3] lint: Verify if #:tests? is respected in the 'check'
 phase.
Date: Wed, 30 Jun 2021 13:55:32 +0200
Hey,

> Indeed. I added a test case and replaced "or" with "append". The linter
> now detects about 300 additional cases.

Great, pushed on master. We now have some work to fix those ~600
packages!

Thanks,

Mathieu


This bug report was last modified 4 years and 18 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.