From unknown Fri Aug 15 12:49:37 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#48320 <48320@debbugs.gnu.org> To: bug#48320 <48320@debbugs.gnu.org> Subject: Status: [PATCH] lint: Verify if #:tests? is respected in the 'check' phase. Reply-To: bug#48320 <48320@debbugs.gnu.org> Date: Fri, 15 Aug 2025 19:49:37 +0000 retitle 48320 [PATCH] lint: Verify if #:tests? is respected in the 'check' = phase. reassign 48320 guix-patches submitter 48320 Maxime Devos severity 48320 normal tag 48320 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 14:02:32 2021 Received: (at submit) by debbugs.gnu.org; 9 May 2021 18:02:32 +0000 Received: from localhost ([127.0.0.1]:56555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfnl9-00075R-N8 for submit@debbugs.gnu.org; Sun, 09 May 2021 14:02:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:48680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfnl6-00075I-JT for submit@debbugs.gnu.org; Sun, 09 May 2021 14:02:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfnl5-0000HF-9a for guix-patches@gnu.org; Sun, 09 May 2021 14:02:28 -0400 Received: from laurent.telenet-ops.be ([2a02:1800:110:4::f00:19]:34846) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lfnl2-0006cC-B2 for guix-patches@gnu.org; Sun, 09 May 2021 14:02:27 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by laurent.telenet-ops.be with bizsmtp id 2i2K250020mfAB401i2KQX; Sun, 09 May 2021 20:02:19 +0200 Message-ID: <2b0fee1845a66e1fb126b4bbf1c9892b7c648a3a.camel@telenet.be> Subject: [PATCH] lint: Verify if #:tests? is respected in the 'check' phase. From: Maxime Devos To: guix-patches@gnu.org Date: Sun, 09 May 2021 20:02:12 +0200 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-V/VY7clTfbiglQh9/MF4" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1620583339; bh=DvpLwUPDDyHeUnlOZ//u2OOFTKBEWan69D2MYwxGWhg=; h=Subject:From:To:Date; b=RumX3z0KAieEc9JR/gzsqAfwvrIu89obDIk5d8gfA2F+oMYa8j0jvLtobgOdahiY1 rBM1chBcgXJbQtY0MCv6AHUwQjfZop/W7HmFqGJIgrJSslmxuQMKPbPlWUVGHoPjZ6 AxF4p+2WDA47qelUPKhhHrepgJYJVvyi+ReTOAqTA0be34WarTxUDDPgUKEOgYtAKz cpi1NlM2ZYO9D4wI90qSoEAxMPndDRTSg4BbtTV1wmu9Je67mffzdVlNi0xcJgMLAu +fWpEMk/7o6ufvjrYB1V9jQ00yKdFeYWRBXStGhkIGba7TuUHeZ4BQ/JM3D6Z91nTb +Bb0Csead+ZbQ== Received-SPF: pass client-ip=2a02:1800:110:4::f00:19; envelope-from=maximedevos@telenet.be; helo=laurent.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-V/VY7clTfbiglQh9/MF4 Content-Type: multipart/mixed; boundary="=-YnYl4aLurAcNrO1m9sO7" --=-YnYl4aLurAcNrO1m9sO7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi guix, There have been a few patches to the mailing list lately not respecting this, and this linter detects 325 package definitions that could be modified to support the --without-tests package transformation. Copyright lines were added in the previous patch I sent to guix-patches today. Greetings, Maxime --=-YnYl4aLurAcNrO1m9sO7 Content-Disposition: attachment; filename*0=0001-lint-Verify-if-tests-is-respected-in-the-check-phase.pat; filename*1=ch Content-Type: text/x-patch; name="0001-lint-Verify-if-tests-is-respected-in-the-check-phase.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA3N2Y2ZmRiMDE1OGQ3NmFmOWE2Nzg5YmQwZGE0NWFjODUyZWUyODY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXhpbWUgRGV2b3MgPG1heGltZWRldm9zQHRlbGVuZXQuYmU+ CkRhdGU6IFN1biwgOSBNYXkgMjAyMSAxOTo1MzozMSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGxp bnQ6IFZlcmlmeSBpZiAjOnRlc3RzPyBpcyByZXNwZWN0ZWQgaW4gdGhlICdjaGVjaycgcGhhc2Uu CgpUaGVyZSBoYXZlIGJlZW4gYSBmZXcgcGF0Y2hlcyB0byB0aGUgbWFpbGluZyBsaXN0IGxhdGVs eSBub3QKcmVzcGVjdGluZyB0aGlzLCBhbmQgdGhpcyBsaW50ZXIgZGV0ZWN0cyAzMjUgcGFja2Fn ZSBkZWZpbml0aW9ucwp0aGF0IGNvdWxkIGJlIG1vZGlmaWVkIHRvIHN1cHBvcnQgdGhlIC0td2l0 aG91dC10ZXN0cyBwYWNrYWdlCnRyYW5zZm9ybWF0aW9uLgoKKiBndWl4L2xpbnQuc2NtCiAgKGNo ZWNrLW9wdGlvbmFsLXRlc3RzKTogTmV3IGxpbnRlci4KICAoJWxvY2FsLWNoZWNrZXJzKVtvcHRp b25hbC10ZXN0c106IEFkZCBpdC4KKiB0ZXN0cy9saW50LnNjbQogIChwYWNrYWdlLXdpdGgtcGhh c2UtY2hhbmdlcyk6IE5ldyBwcm9jZWR1cmUuCiAgKCJvcHRpb25hbC10ZXN0czogbm8gY2hlY2sg cGhhc2UiKQogICgib3B0aW9uYWwtdGVzdHM6IGNoZWNrIHBoYXNlIHJlc3BlY3RzICM6dGVzdHM/ IikKICAoIm9wdGlvbmFsLXRlc3RzOiBjaGVjayBwaGFzZSBpZ25vcmVzICM6dGVzdHM/IikKICAo Im9wdGlvbmFsLXRlc3RzOiBkbyBub3QgY3Jhc2ggd2hlbiAjOnBoYXNlcyBpcyBpbnZhbGlkIik6 IE5ldyB0ZXN0cy4KLS0tCiBndWl4L2xpbnQuc2NtICB8IDQwICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKIHRlc3RzL2xpbnQuc2NtIHwgMzEgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA3MSBpbnNlcnRpb25zKCspCgpkaWZm IC0tZ2l0IGEvZ3VpeC9saW50LnNjbSBiL2d1aXgvbGludC5zY20KaW5kZXggZDFjYmM5ZDMwMC4u ZjVkYjQ2NjRkYyAxMDA2NDQKLS0tIGEvZ3VpeC9saW50LnNjbQorKysgYi9ndWl4L2xpbnQuc2Nt CkBAIC04Nyw2ICs4Nyw3IEBACiAgICAgICAgICAgICBjaGVjay1zb3VyY2UKICAgICAgICAgICAg IGNoZWNrLXNvdXJjZS1maWxlLW5hbWUKICAgICAgICAgICAgIGNoZWNrLXNvdXJjZS11bnN0YWJs ZS10YXJiYWxsCisgICAgICAgICAgICBjaGVjay1vcHRpb25hbC10ZXN0cwogICAgICAgICAgICAg Y2hlY2stbWlycm9yLXVybAogICAgICAgICAgICAgY2hlY2stZ2l0aHViLXVybAogICAgICAgICAg ICAgY2hlY2stbGljZW5zZQpAQCAtOTYzLDYgKzk2NCw0MSBAQCBkZXNjcmlwdGlvbnMgbWFpbnRh aW5lZCB1cHN0cmVhbS4iCiAgICAgICAgICAgICAgICAgICAgIChvcmlnaW4tdXJpcyBvcmlnaW4p KQogICAgICAgICAnKCkpKSkKIAorKGRlZmluZSAoY2hlY2stb3B0aW9uYWwtdGVzdHMgcGFja2Fn ZSkKKyAgIkVtaXQgYSB3YXJuaW5nIGlmIHRoZSB0ZXN0IHN1aXRlIGlzIHJ1biB1bmNvbmRpdGlv bmFsbHkuIgorICAoZGVmaW5lIChjaGVjay1jaGVjay1wcm9jZWR1cmUgZXhwcmVzc2lvbikKKyAg ICAobWF0Y2ggZXhwcmVzc2lvbgorICAgICAgKGAoLChvciAnbGFtYmRhICdsYW1iZGEqKSAsXyAo aW52b2tlIC4gLF8pIC4gLF8pCisgICAgICAgKGxpc3QgKG1ha2Utd2FybmluZyBwYWNrYWdlCisg ICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBUUkFOU0xBVE9SUzogY2hlY2sgYW5kICM6dGVz dHM/IGFyZSBhIFNjaGVtZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgc3ltYm9sIGFu ZCBrZXl3b3JkIHJlc3BlY3RpdmVseSBhbmQgc2hvdWxkIG5vdAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgOzsgYmUgdHJhbnNsYXRlZC4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChH XyAidGhlICdjaGVjaycgcGhhc2Ugc2hvdWxkIHJlc3BlY3QgIzp0ZXN0cz8iKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgIzpmaWVsZCAnYXJndW1lbnRzKSkpCisgICAgICA7OyBUaGUgJ2No ZWNrJyBwaGFzZSBzZWVtcyBvaywgc3RvcCBzZWFyY2hpbmcgZm9yIGEgYnVnIGluIHRoaXMgcGFj a2FnZQorICAgICAgOzsgZGVmaW5pdGlvbi4KKyAgICAgIChfICcoKSkpKQorICAoZGVmaW5lIChj aGVjay1waGFzZXMtZGVsdGEgZGVsdGEpCisgICAgKG1hdGNoIGRlbHRhCisgICAgICAoYChyZXBs YWNlICdjaGVjayAsZXhwcmVzc2lvbikKKyAgICAgICAoY2hlY2stY2hlY2stcHJvY2VkdXJlIGV4 cHJlc3Npb24pKQorICAgICAgKF8gI2YpKSkKKyAgKGRlZmluZSAoY2hlY2stcGhhc2VzLWRlbHRh cyBkZWx0YXMpCisgICAgKG1hdGNoIGRlbHRhcworICAgICAgKCgpICcoKSkKKyAgICAgICgoaGVh ZCAuIHRhaWwpCisgICAgICAgKG9yIChjaGVjay1waGFzZXMtZGVsdGEgaGVhZCkKKyAgICAgICAg ICAgKGNoZWNrLXBoYXNlcy1kZWx0YXMgdGFpbCkpKQorICAgICAgKF8gKGxpc3QgKG1ha2Utd2Fy bmluZyBwYWNrYWdlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChHXyAiaW5jb3JyZWN0 IGNhbGwgdG8gbW9kaWZ5LXBoYXNlcyIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICM6 ZmllbGQgJ2FyZ3VtZW50cykpKSkpCisgIChhcHBseSAobGFtYmRhKiAoIzprZXkgcGhhc2VzICM6 YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAgICAgKG1hdGNoIHBoYXNlcworICAgICAgICAgICAg IChgKG1vZGlmeS1waGFzZXMgLF8gLiAsY2hhbmdlcykKKyAgICAgICAgICAgICAgKGNoZWNrLXBo YXNlcy1kZWx0YXMgY2hhbmdlcykpCisgICAgICAgICAgICAgKF8gJygpKSkpCisgICAgICAgICAo cGFja2FnZS1hcmd1bWVudHMgcGFja2FnZSkpKQorCiAoZGVmaW5lIChjaGVjay1taXJyb3ItdXJs IHBhY2thZ2UpCiAgICJDaGVjayB3aGV0aGVyIFBBQ0tBR0UgdXNlcyBzb3VyY2UgVVJMcyB0aGF0 IHNob3VsZCBiZSAnbWlycm9yOi8vJy4iCiAgIChkZWZpbmUgKGNoZWNrLW1pcnJvci11cmkgdXJp KSAgICAgICAgICAgICAgICAgIDtYWFg6IGNvdWxkIGJlIG9wdGltaXplZApAQCAtMTUyOSw2ICsx NTY1LDEwIEBAIHRoZW0gZm9yIFBBQ0tBR0UuIgogICAgICAoZGVzY3JpcHRpb24gIk1ha2Ugc3Vy ZSB0aGUgJ2xpY2Vuc2UnIGZpZWxkIGlzIGEgPGxpY2Vuc2U+IFwKIG9yIGEgbGlzdCB0aGVyZW9m IikKICAgICAgKGNoZWNrICAgICAgIGNoZWNrLWxpY2Vuc2UpKQorICAgKGxpbnQtY2hlY2tlcgor ICAgICAobmFtZSAgICAgICAgJ29wdGlvbmFsLXRlc3RzKQorICAgICAoZGVzY3JpcHRpb24gIk1h a2Ugc3VyZSB0ZXN0cyBhcmUgb25seSBydW4gd2hlbiByZXF1ZXN0ZWQiKQorICAgICAoY2hlY2sg ICAgICAgY2hlY2stb3B0aW9uYWwtdGVzdHMpKQogICAgKGxpbnQtY2hlY2tlcgogICAgICAobmFt ZSAgICAgICAgJ21pcnJvci11cmwpCiAgICAgIChkZXNjcmlwdGlvbiAiU3VnZ2VzdCAnbWlycm9y Oi8vJyBVUkxzIikKZGlmZiAtLWdpdCBhL3Rlc3RzL2xpbnQuc2NtIGIvdGVzdHMvbGludC5zY20K aW5kZXggZDZlODc3ZDBkNy4uYzljZDYzNjZlYyAxMDA2NDQKLS0tIGEvdGVzdHMvbGludC5zY20K KysrIGIvdGVzdHMvbGludC5zY20KQEAgLTczMSw2ICs3MzEsMzcgQEAKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoc2hhMjU2ICVudWxsLXNoYTI1NikpKSkpKQogICAgIChjaGVjay1z b3VyY2UtdW5zdGFibGUtdGFyYmFsbCBwa2cpKSkKIAorKGRlZmluZSAocGFja2FnZS13aXRoLXBo YXNlLWNoYW5nZXMgY2hhbmdlcykKKyAgKGR1bW15LXBhY2thZ2UgIngiCisgICAgICAgICAgICAg ICAgIChhcmd1bWVudHMgYCgjOnBoYXNlcworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcyAsQGNoYW5nZXMpKSkpKQorCisodGVzdC1l cXVhbCAib3B0aW9uYWwtdGVzdHM6IG5vIGNoZWNrIHBoYXNlIgorICAnKCkKKyAgKGxldCAoKHBr ZyAocGFja2FnZS13aXRoLXBoYXNlLWNoYW5nZXMgJygpKSkpCisgICAgKGNoZWNrLW9wdGlvbmFs LXRlc3RzIHBrZykpKQorKHRlc3QtZXF1YWwgIm9wdGlvbmFsLXRlc3RzOiBjaGVjayBwaGFzZSBy ZXNwZWN0cyAjOnRlc3RzPyIKKyAgJygpCisgIChsZXQgKChwa2cgKHBhY2thZ2Utd2l0aC1waGFz ZS1jaGFuZ2VzCisgICAgICAgICAgICAgICcoKHJlcGxhY2UgJ2NoZWNrCisgICAgICAgICAgICAg ICAgICAobGFtYmRhICgjOmtleSB0ZXN0cz8gIzphbGxvdy1vdGhlci1rZXlzPykKKyAgICAgICAg ICAgICAgICAgICAgKHdoZW4gdGVzdHM/CisgICAgICAgICAgICAgICAgICAgICAgKGludm9rZSAi Li90aGUtdGVzdC1zdWl0ZSIpKSkpKSkpKQorICAgIChjaGVjay1vcHRpb25hbC10ZXN0cyBwa2cp KSkKKyh0ZXN0LWVxdWFsICJvcHRpb25hbC10ZXN0czogY2hlY2sgcGhhc2UgaWdub3JlcyAjOnRl c3RzPyIKKyAgInRoZSAnY2hlY2snIHBoYXNlIHNob3VsZCByZXNwZWN0ICM6dGVzdHM/IgorICAo bGV0ICgocGtnIChwYWNrYWdlLXdpdGgtcGhhc2UtY2hhbmdlcworICAgICAgICAgICAgICAnKChy ZXBsYWNlICdjaGVjaworICAgICAgICAgICAgICAgICAgKGxhbWJkYSBfCisgICAgICAgICAgICAg ICAgICAgIChpbnZva2UgIi4vdGhlLXRlc3Qtc3VpdGUiKSkpKSkpKQorICAgIChzaW5nbGUtbGlu dC13YXJuaW5nLW1lc3NhZ2UKKyAgICAgKGNoZWNrLW9wdGlvbmFsLXRlc3RzIHBrZykpKSkKKyh0 ZXN0LWVxdWFsICJvcHRpb25hbC10ZXN0czogZG8gbm90IGNyYXNoIHdoZW4gIzpwaGFzZXMgaXMg aW52YWxpZCIKKyAgImluY29ycmVjdCBjYWxsIHRvIG1vZGlmeS1waGFzZXMiCisgIChsZXQgKChw a2cgKHBhY2thZ2Utd2l0aC1waGFzZS1jaGFuZ2VzICd0aGlzLWlzLW5vdC1hLWxpc3QpKSkKKyAg ICAoc2luZ2xlLWxpbnQtd2FybmluZy1tZXNzYWdlCisgICAgIChjaGVjay1vcHRpb25hbC10ZXN0 cyBwa2cpKSkpCisKICh0ZXN0LWVxdWFsICJzb3VyY2U6IDIwMCIKICAgJygpCiAgICh3aXRoLWh0 dHAtc2VydmVyIGAoKDIwMCAsJWxvbmctc3RyaW5nKSkKLS0gCjIuMzEuMQoK --=-YnYl4aLurAcNrO1m9sO7-- --=-V/VY7clTfbiglQh9/MF4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYJgjpRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7mS2AQDE6GmX2rgPP04WQhiWSFAe7vuJ l058vc5A5t814RtvLQD/R89rFFBIwrYcoPdn7HacGBy5xnb711tZMLirBAsvWQw= =V/0D -----END PGP SIGNATURE----- --=-V/VY7clTfbiglQh9/MF4-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 18 08:16:03 2021 Received: (at 48320) by debbugs.gnu.org; 18 Jun 2021 12:16:03 +0000 Received: from localhost ([127.0.0.1]:55975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luDPm-0002bv-Vt for submit@debbugs.gnu.org; Fri, 18 Jun 2021 08:16:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luDPl-0002bH-E2 for 48320@debbugs.gnu.org; Fri, 18 Jun 2021 08:16:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43600) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luDPf-0007o6-A0; Fri, 18 Jun 2021 08:15:55 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=37586 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luDPc-0003XJ-IJ; Fri, 18 Jun 2021 08:15:55 -0400 From: Mathieu Othacehe To: Maxime Devos Subject: Re: bug#48320: [PATCH] lint: Verify if #:tests? is respected in the 'check' phase. References: <2b0fee1845a66e1fb126b4bbf1c9892b7c648a3a.camel@telenet.be> Date: Fri, 18 Jun 2021 14:15:50 +0200 In-Reply-To: <2b0fee1845a66e1fb126b4bbf1c9892b7c648a3a.camel@telenet.be> (Maxime Devos's message of "Sun, 09 May 2021 20:02:12 +0200") Message-ID: <87wnqrbc7d.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48320 Cc: 48320@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Maxime, > + (`(,(or 'lambda 'lambda*) ,_ (invoke . ,_) . ,_) > + (list (make-warning package > + ;; TRANSLATORS: check and #:tests? are a Scheme > + ;; symbol and keyword respectively and should not > + ;; be translated. > + (G_ "the 'check' phase should respect #:tests?") > + #:field 'arguments))) I like the idea behind this patch. However I think the detection pattern could be improved for instance, here are a few unreported packages: - dejagnu - python-dateutil - eigen Maybe we should check directly if the tests? variable is used within the 'check replace phase? Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 18 11:34:27 2021 Received: (at 48320) by debbugs.gnu.org; 18 Jun 2021 15:34:27 +0000 Received: from localhost ([127.0.0.1]:57641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luGVn-0001uT-AI for submit@debbugs.gnu.org; Fri, 18 Jun 2021 11:34:27 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:35576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luGVl-0001uK-JF for 48320@debbugs.gnu.org; Fri, 18 Jun 2021 11:34:26 -0400 Received: from butterfly.local ([188.188.242.184]) by michel.telenet-ops.be with bizsmtp id JfaP250043zRM2s06faPUa; Fri, 18 Jun 2021 17:34:24 +0200 Message-ID: <2ecfe7d292264ff24a80fa02c47dd566c831776a.camel@telenet.be> Subject: Re: bug#48320: [PATCH] lint: Verify if #:tests? is respected in the 'check' phase. From: Maxime Devos To: Mathieu Othacehe Date: Fri, 18 Jun 2021 17:34:17 +0200 In-Reply-To: <87wnqrbc7d.fsf@gnu.org> References: <2b0fee1845a66e1fb126b4bbf1c9892b7c648a3a.camel@telenet.be> <87wnqrbc7d.fsf@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-6Dmlpj6VsICBAQJSSrbc" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1624030464; bh=q8F1LZXmqxeaaoWQpkP/4ix8KCjbrkeP2EId+PAeRyY=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=f2cNo8jn2203Wy9+tgV06an8FbY5eudlyRDq0/YsClCnW8UpN9G9SgvheU0m5pfx2 mWUeuxfWJhBQaXvRAXFN7q9p2Tycajrtm8ysVJIyyTC2fGeLkMjC+Q21VqTn6Sx7jb I09t8zQfetCoQgBbygwFZwU8KsThYaKsX4stWvBmfu8Bknb2dQ7JGM6TTdH7yyJdJX AsPm3HbjfsQIY0vnQB0oPj/EZjXxDo2T+StI2B2STCFG30ln96iTbH89ujy2yBZJIT RP6SWJdmR+9qaqSRUsoOfrjDszhJzKsQlHwRek5paYuvaGFdIJzajem4SCIP1uNxh/ nbRLEiBVoZldQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48320 Cc: 48320@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-6Dmlpj6VsICBAQJSSrbc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mathieu Othacehe schreef op vr 18-06-2021 om 14:15 [+0200]: > Hello Maxime, >=20 > > + (`(,(or 'lambda 'lambda*) ,_ (invoke . ,_) . ,_) > > + (list (make-warning package > > + ;; TRANSLATORS: check and #:tests? are a Sc= heme > > + ;; symbol and keyword respectively and shou= ld not > > + ;; be translated. > > + (G_ "the 'check' phase should respect #:tes= ts?") > > + #:field 'arguments))) I just noticed the following test case in (tests lint) is somewhat bogus: > + '((replace 'check+ > + (lambda (#:key tests? #:allow-other-keys?) Instead of 'lambda', this should be 'lambda*'. Also, the value for #:phases can now be a G-expression, so the usage of 'package-arguments' in the patch would need to be adjusted as well. > I like the idea behind this patch. However I think the detection pattern > could be improved for instance, here are a few unreported packages: >=20 > - dejagnu > - python-dateutil > - eigen >=20 > Maybe we should check directly if the tests? variable is used within the > 'check replace phase? So, basically, test if applying the following procedure to the body succeeds? (define (sexp-uses-tests?? sexp) (sexp-contains-atom? sexp 'tests?)) (define (sexp-contains-atom? sexp atom) ; atoms are compared with eq? and vectors are currently not supported (if (pair? sexp) (or (sexp-contains? sexp atom) (sexp-contains? sexp atom)) (eq? sexp atom))) That seems a good improvement for a v2. Thanks, Maxime. --=-6Dmlpj6VsICBAQJSSrbc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYMy8+RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7ssVAQDJwL8ffq8IaVa/aF0TbF/5h8u4 tDvV4B2gtF1orxOsqAEAjItEOgvCVnDrcR0Dr/Cij64KNUoo4PEygxjsBRmvWgM= =SCrC -----END PGP SIGNATURE----- --=-6Dmlpj6VsICBAQJSSrbc-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 28 17:16:45 2021 Received: (at 48320) by debbugs.gnu.org; 28 Jun 2021 21:16:45 +0000 Received: from localhost ([127.0.0.1]:53170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxycR-000737-TV for submit@debbugs.gnu.org; Mon, 28 Jun 2021 17:16:45 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:60170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxycP-00072v-EI for 48320@debbugs.gnu.org; Mon, 28 Jun 2021 17:16:38 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by baptiste.telenet-ops.be with bizsmtp id NlGa2500R0mfAB401lGbsF; Mon, 28 Jun 2021 23:16:35 +0200 Message-ID: <44f0c8b823b0f6f8e5388ff6c1d90e76fa09bf2c.camel@telenet.be> Subject: [PATCH v2] lint: Verify if #:tests? is respected in the 'check' phase. From: Maxime Devos To: 48320@debbugs.gnu.org Date: Mon, 28 Jun 2021 23:15:42 +0200 In-Reply-To: <2b0fee1845a66e1fb126b4bbf1c9892b7c648a3a.camel@telenet.be> References: <2b0fee1845a66e1fb126b4bbf1c9892b7c648a3a.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-a66tmHWbPZXIlU1QAaYg" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1624914995; bh=iCsRZOeOCnZ1tmtzL3I8gXlEPb5FPfAl3F+Yn1sFO50=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=FnB5t9s1vSN1Vso5aGjZxs/foE+pk2xUkNFtsYJ+1msuLi7EXSi62bZKmWLrtHhuO oQJjtzaMYk4zGelAvENzNzmn98bIz08pep/G3D6hqtk2XLfKI0hYLafSTGQnJY3jq9 pRng5GrnHUbHN280v4wCKOAO5L5pDzPWQQH25YxYhM7uL6sfewSGF62bZtNd9XmzN8 TUmIR4FDsiIkvHDxca3Z1TwQZCyDMRL5Yso0q2zjDc1ZukDdvPlAiECpgobXC2Whh7 Hj9AFrm8hYv2eYgEgn97z03GSs/Pe0oUXEpd4vUwFllBxOgRZsjMxoyQy2/MMTIxKI MHkmvhZFiUxtA== X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Guix, This is a v2. It detects some more cases (e.g. python-dateutil dejagnu and eigen). It also allows letting '#:phases' be a G-exp. With thanks to Mathieu Othacehe. Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [195.130.132.51 listed in list.dnswl.org] 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (maximedevos[at]telenet.be) X-Debbugs-Envelope-To: 48320 Cc: Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --=-a66tmHWbPZXIlU1QAaYg Content-Type: multipart/mixed; boundary="=-gtucq2/GeTqxaD5VJcDg" --=-gtucq2/GeTqxaD5VJcDg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Guix, This is a v2. It detects some more cases (e.g. python-dateutil dejagnu and eigen). It also allows letting '#:phases' be a G-exp. With thanks to Mathieu Othacehe. Greetings, Maxime. --=-gtucq2/GeTqxaD5VJcDg Content-Disposition: inline; filename="v2-0001-guix-gexp-Define-gexp-approximate-sexp.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="v2-0001-guix-gexp-Define-gexp-approximate-sexp.patch"; charset="UTF-8" RnJvbSA4ZTg5OGE2YzBmM2RmYTA4NmYxNDE0MTE1ZmIyZjU4ZmUzNjIyNGIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXhpbWUgRGV2b3MgPG1heGltZWRldm9zQHRlbGVuZXQuYmU+ CkRhdGU6IE1vbiwgMjggSnVuIDIwMjEgMTk6MjQ6NDQgKzAyMDAKU3ViamVjdDogW1BBVENIIHYy IDEvMl0gZ3VpeDogZ2V4cDogRGVmaW5lIGdleHAtPmFwcHJveGltYXRlLXNleHAuClRvOiA0ODMy MEBkZWJidWdzLmdudS5vcmcKQ2M6IE1hdGhpZXUgT3RoYWNlaGUgPG90aGFjZWhlQGdudS5vcmc+ CgpJdCB3aWxsIGJlIHVzZWQgaW4gdGhlICdvcHRpb25hbC10ZXN0cycgbGludGVyLgoKKiBndWl4 L2dleHAuc2NtIChnZXhwLT5hcHByb3hpbWF0ZS1zZXhwKTogTmV3IHByb2NlZHVyZS4KKiB0ZXN0 cy9nZXhwLnNjbQogICgibm8gcmVmZXJlbmNlcyIsICJ1bnF1b3RlZCBnZXhwIiwgInVucXVvdGVk IGdleHAgKG5hdGl2ZSkiKQogICgic3BsaWNlZCBnZXhwIiwgInVuc3BsaWNlZCBnZXhwLCBhcHBy b3hpbWF0ZWQiKQogICgidW5xdW90ZWQgZ2V4cCwgYXBwcm94aW1hdGVkIik6IFRlc3QgaXQuCiog ZG9jL2dleHAuc2NtICgiRy1FeHByZXNzaW9ucyIpOiBEb2N1bWVudCBpdC4KLS0tCiBkb2MvZ3Vp eC50ZXhpICB8IDExICsrKysrKysrKysrCiBndWl4L2dleHAuc2NtICB8IDE5ICsrKysrKysrKysr KysrKysrKysKIHRlc3RzL2dleHAuc2NtIHwgMzEgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKwogMyBmaWxlcyBjaGFuZ2VkLCA2MSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZG9j L2d1aXgudGV4aSBiL2RvYy9ndWl4LnRleGkKaW5kZXggMTVlODk5OTQ0Ny4uY2M4MWM0MTdhMCAx MDA2NDQKLS0tIGEvZG9jL2d1aXgudGV4aQorKysgYi9kb2MvZ3VpeC50ZXhpCkBAIC0xMDAzOCw2 ICsxMDAzOCwxNyBAQCBjb3JyZXNwb25kaW5nIHRvIEB2YXJ7b2JqfSBmb3IgQHZhcntzeXN0ZW19 LCBjcm9zcy1jb21waWxpbmcgZm9yCiBoYXMgYW4gYXNzb2NpYXRlZCBnZXhwIGNvbXBpbGVyLCBz dWNoIGFzIGEgQGNvZGV7PHBhY2thZ2U+fS4KIEBlbmQgZGVmZm4KIAorQGRlZmZuIHtQcm9jZWR1 cmV9IGdleHAtPmFwcHJveGltYXRlLXNleHAgQHZhcntnZXhwfQorU29tZXRpbWVzLCBpdCBtYXkg YmUgdXNlZnVsIHRvIGNvbnZlcnQgYSBHLWV4cCBpbnRvIGEgUy1leHAuCitGb3IgZXhhbXBsZSwg c29tZSBsaW50ZXJzIChAcHhyZWZ7SW52b2tpbmcgZ3VpeCBsaW50fSkKK3BlZWsgaW50byB0aGUg YnVpbGQgcGhhc2VzIG9mIGEgcGFja2FnZSB0byBkZXRlY3QgcG90ZW50aWFsCitwcm9ibGVtcy4g IFRoaXMgY29udmVyc2lvbiBjYW4gYmUgYWNoaWV2ZWQgd2l0aCB0aGlzCitwcm9jZWR1cmUuICBI b3dldmVyLCBzb21lIGluZm9ybWF0aW9uIGNhbiBiZSBsb3N0IGluIHRoZQorcHJvY2Vzcy4gIE1v cmUgc3BlY2lmaWNhbGx5LCBsb3dlcmFibGUgb2JqZWN0cyB3aWxsIGJlIHNpbGVudGx5CityZXBs YWNlZCB3aXRoIHNvbWUgYXJiaXRyYXJ5IG9iamVjdCAtLSBjdXJyZW50bHkgdGhlIGxpc3QKK0Bj b2RleygqYXBwcm94aW1hdGUqKX0sIGJ1dCB0aGlzIG1heSBjaGFuZ2UuCitAZW5kIGRlZmZuCisK IEBub2RlIEludm9raW5nIGd1aXggcmVwbAogQHNlY3Rpb24gSW52b2tpbmcgQGNvbW1hbmR7Z3Vp eCByZXBsfQogCmRpZmYgLS1naXQgYS9ndWl4L2dleHAuc2NtIGIvZ3VpeC9nZXhwLnNjbQppbmRl eCAxODdmNWM1ZTg1Li5mM2QyNzhiM2U2IDEwMDY0NAotLS0gYS9ndWl4L2dleHAuc2NtCisrKyBi L2d1aXgvZ2V4cC5zY20KQEAgLTQsNiArNCw3IEBACiA7OzsgQ29weXJpZ2h0IMKpIDIwMTggSmFu IE5pZXV3ZW5odWl6ZW4gPGphbm5la2VAZ251Lm9yZz4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxOSwg MjAyMCBNYXRoaWV1IE90aGFjZWhlIDxtLm90aGFjZWhlQGdtYWlsLmNvbT4KIDs7OyBDb3B5cmln aHQgwqkgMjAyMCBNYXhpbSBDb3Vybm95ZXIgPG1heGltLmNvdXJub3llckBnbWFpbC5jb20+Cis7 OzsgQ29weXJpZ2h0IMKpIDIwMjEgTWF4aW1lIERldm9zIDxtYXhpbWVkZXZvc0B0ZWxlbmV0LmJl PgogOzs7CiA7OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTQyLDYg KzQzLDcgQEAKICAgICAgICAgICAgIHdpdGgtaW1wb3J0ZWQtbW9kdWxlcwogICAgICAgICAgICAg d2l0aC1leHRlbnNpb25zCiAgICAgICAgICAgICBsZXQtc3lzdGVtCisgICAgICAgICAgICBnZXhw LT5hcHByb3hpbWF0ZS1zZXhwCiAKICAgICAgICAgICAgIGdleHAtaW5wdXQKICAgICAgICAgICAg IGdleHAtaW5wdXQ/CkBAIC0xNTcsNiArMTU5LDIzIEBACiAgICJSZXR1cm4gdGhlIHNvdXJjZSBj b2RlIGxvY2F0aW9uIG9mIEdFWFAuIgogICAoYW5kPT4gKCVnZXhwLWxvY2F0aW9uIGdleHApIHNv dXJjZS1wcm9wZXJ0aWVzLT5sb2NhdGlvbikpCiAKKyhkZWZpbmUqIChnZXhwLT5hcHByb3hpbWF0 ZS1zZXhwIGdleHApCisgICJSZXR1cm4gdGhlIFMtZXhwcmVzc2lvbiBjb3JyZXNwb25kaW5nIHRv IEdFWFAsIGJ1dCBkbyBub3QgbG93ZXIgYW55dGhpbmcuCitBcyBhIHJlc3VsdCwgdGhlIFMtZXhw cmVzc2lvbiB3aWxsIGJlIGFwcHJveGltYXRlIGlmIEdFWFAgaGFzIHJlZmVyZW5jZXMuIgorICAo ZGVmaW5lIChnZXhwLWxpa2U/IHRoaW5nKQorICAgIChvciAoZ2V4cD8gdGhpbmcpIChnZXhwLWlu cHV0PyB0aGluZykpKQorICAoYXBwbHkgKGdleHAtcHJvYyBnZXhwKQorICAgICAgICAgKG1hcCAo bGFtYmRhIChyZWZlcmVuY2UpCisgICAgICAgICAgICAgICAgKG1hdGNoIHJlZmVyZW5jZQorICAg ICAgICAgICAgICAgICAgKCgkIDxnZXhwLWlucHV0PiB0aGluZyBvdXRwdXQgbmF0aXZlKQorICAg ICAgICAgICAgICAgICAgIChpZiAoZ2V4cC1saWtlPyB0aGluZykKKyAgICAgICAgICAgICAgICAg ICAgICAgKGdleHAtPmFwcHJveGltYXRlLXNleHAgdGhpbmcpCisgICAgICAgICAgICAgICAgICAg ICAgIDs7IFNpbXBseSByZXR1cm5pbmcgJ3RoaW5nJyB3b24ndCB3b3JrIGluIHNvbWUKKyAgICAg ICAgICAgICAgICAgICAgICAgOzsgc2l0dWF0aW9uczsgc2VlICd3cml0ZS1nZXhwJyBiZWxvdy4K KyAgICAgICAgICAgICAgICAgICAgICAgJygqYXBwcm94aW1hdGUqKSkpCisgICAgICAgICAgICAg ICAgICAoXyAnKCphcHByb3hpbWF0ZSopKSkpCisgICAgICAgICAgICAgIChnZXhwLXJlZmVyZW5j ZXMgZ2V4cCkpKSkKKwogKGRlZmluZSAod3JpdGUtZ2V4cCBnZXhwIHBvcnQpCiAgICJXcml0ZSBH RVhQIG9uIFBPUlQuIgogICAoZGlzcGxheSAiIzxnZXhwICIgcG9ydCkKZGlmZiAtLWdpdCBhL3Rl c3RzL2dleHAuc2NtIGIvdGVzdHMvZ2V4cC5zY20KaW5kZXggODM0ZTc4YjlhMC4uMzlhNDdkNGU4 YyAxMDA2NDQKLS0tIGEvdGVzdHMvZ2V4cC5zY20KKysrIGIvdGVzdHMvZ2V4cC5zY20KQEAgLTEs NSArMSw2IEBACiA7OzsgR05VIEd1aXggLS0tIEZ1bmN0aW9uYWwgcGFja2FnZSBtYW5hZ2VtZW50 IGZvciBHTlUKIDs7OyBDb3B5cmlnaHQgwqkgMjAxNCwgMjAxNSwgMjAxNiwgMjAxNywgMjAxOCwg MjAxOSwgMjAyMCwgMjAyMSBMdWRvdmljIENvdXJ0w6hzIDxsdWRvQGdudS5vcmc+Cis7OzsgQ29w eXJpZ2h0IMKpIDIwMjEgTWF4aW1lIERldm9zIDxtYXhpbWVkZXZvc0B0ZWxlbmV0LmJlPgogOzs7 CiA7OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTg5LDYgKzkwLDM2 IEBACiAMCiAodGVzdC1iZWdpbiAiZ2V4cCIpCiAKKyh0ZXN0LWVxdWFsICJubyByZWZlcmVuY2Vz IgorICAnKGRpc3BsYXkgImhlbGxvIGdleHAtPmFwcHJveGltYXRlLXNleHAhIikKKyAgKGdleHAt PmFwcHJveGltYXRlLXNleHAgI34oZGlzcGxheSAiaGVsbG8gZ2V4cC0+YXBwcm94aW1hdGUtc2V4 cCEiKSkpCisKKyh0ZXN0LWVxdWFsICJ1bnF1b3RlZCBnZXhwIgorICAnKGRpc3BsYXkgImhlbGxv IikKKyAgKGxldCAoKGluc2lkZSAjfiJoZWxsbyIpKQorICAgIChnZXhwLT5hcHByb3hpbWF0ZS1z ZXhwICN+KGRpc3BsYXkgIyRpbnNpZGUpKSkpCisKKyh0ZXN0LWVxdWFsICJ1bnF1b3RlZCBnZXhw IChuYXRpdmUpIgorICAnKGRpc3BsYXkgImhlbGxvIikKKyAgKGxldCAoKGluc2lkZSAjfiJoZWxs byIpKQorICAgIChnZXhwLT5hcHByb3hpbWF0ZS1zZXhwICN+KGRpc3BsYXkgIytpbnNpZGUpKSkp CisKKyh0ZXN0LWVxdWFsICJzcGxpY2VkIGdleHAiCisgICcoZGlzcGxheSAnKGZyZXNoIHZlZ2V0 YWJsZXMpKQorICAobGV0ICgoaW5zaWRlICN+KGZyZXNoIHZlZ2V0YWJsZXMpKSkKKyAgICAoZ2V4 cC0+YXBwcm94aW1hdGUtc2V4cCAjfihkaXNwbGF5ICcoIyRAaW5zaWRlKSkpKSkKKworKHRlc3Qt ZXF1YWwgInVuc3BsaWNlZCBnZXhwLCBhcHByb3hpbWF0ZWQiCisgIDs7ICgqYXBwcm94aW1hdGUq KSBpcyByZWFsbHkgYW4gaW1wbGVtZW50YXRpb24gZGV0YWlsCisgICcoZGlzcGxheSAnKCphcHBy b3hpbWF0ZSopKQorICAobGV0ICgoaW5zaWRlIChmaWxlLWFwcGVuZCBjb3JldXRpbHMgIi9iaW4v aGVsbG8iKSkpCisgICAgKGdleHAtPmFwcHJveGltYXRlLXNleHAgI34oZGlzcGxheSAnKCMkQGlu c2lkZSkpKSkpCisKKyh0ZXN0LWVxdWFsICJ1bnF1b3RlZCBnZXhwLCBhcHByb3hpbWF0ZWQiCisg ICcoZGlzcGxheSAnKCphcHByb3hpbWF0ZSopKQorICAobGV0ICgoaW5zaWRlIChmaWxlLWFwcGVu ZCBjb3JldXRpbHMgIi9iaW4vaGVsbG8iKSkpCisgICAgKGdleHAtPmFwcHJveGltYXRlLXNleHAg I34oZGlzcGxheSAnIyRpbnNpZGUpKSkpCisKICh0ZXN0LWVxdWFsICJubyByZWZzIgogICAnKGRp c3BsYXkgImhlbGxvISIpCiAgIChsZXQgKChleHAgKGdleHAgKGRpc3BsYXkgImhlbGxvISIpKSkp Ci0tIAoyLjMyLjAKCg== --=-gtucq2/GeTqxaD5VJcDg Content-Disposition: inline; filename*0=v2-0002-lint-Verify-if-tests-is-respected-in-the-check-ph.pat; filename*1=ch Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="v2-0002-lint-Verify-if-tests-is-respected-in-the-check-ph.patch"; charset="UTF-8" RnJvbSA2MDRjZDAwYzNmY2NlNDM2ZDIzZjA1ZmY3NDk2YTZlYTEyMDA1OTRlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXhpbWUgRGV2b3MgPG1heGltZWRldm9zQHRlbGVuZXQuYmU+ CkRhdGU6IE1vbiwgMjggSnVuIDIwMjEgMjA6NDQ6MTYgKzAyMDAKU3ViamVjdDogW1BBVENIIHYy IDIvMl0gbGludDogVmVyaWZ5IGlmICM6dGVzdHM/IGlzIHJlc3BlY3RlZCBpbiB0aGUgJ2NoZWNr JwogcGhhc2UuClRvOiA0ODMyMEBkZWJidWdzLmdudS5vcmcKQ2M6IE1hdGhpZXUgT3RoYWNlaGUg PG90aGFjZWhlQGdudS5vcmc+CgpUaGVyZSBoYXZlIGJlZW4gYSBmZXcgcGF0Y2hlcyB0byB0aGUg bWFpbGluZyBsaXN0IGxhdGVseQpub3QgcmVzcGVjdGluZyB0aGlzLCBhbmQgdGhpcyBsaW50ZXIg ZGV0ZWN0cyAzNjggcGFja2FnZQpkZWZpbml0aW9ucyB0aGF0IGNvdWxkIGJlIG1vZGlmaWVkIHRv IHN1cHBvcnQgdGhlIC0td2l0aG91dC10ZXN0cwpwYWNrYWdlIHRyYW5zZm9ybWF0aW9uLgoKKiBn dWl4L2xpbnQuc2NtCiAgKGNoZWNrLW9wdGlvbmFsLXRlc3RzKTogTmV3IGxpbnRlci4KICAoJWxv Y2FsLWNoZWNrZXJzKVtvcHRpb25hbC10ZXN0c106IEFkZCBpdC4KKiB0ZXN0cy9saW50LnNjbQog IChwYWNrYWdlLXdpdGgtcGhhc2UtY2hhbmdlcyk6IE5ldyBwcm9jZWR1cmUuCiAgKCJvcHRpb25h bC10ZXN0czogbm8gY2hlY2sgcGhhc2UiKQogICgib3B0aW9uYWwtdGVzdHM6IGNoZWNrIGhhc2Ug cmVzcGVjdHMgIzp0ZXN0cz8iKQogICgib3B0aW9uYWwtdGVzdHM6IGNoZWNrIHBoYXNlIGlnbm9y ZXMgIzp0ZXN0cz8iKQogICgib3B0aW9uYWwtdGVzdHM6IGRvIG5vdCBjcmFzaCB3aGVuICM6cGhh c2VzIGlzIGludmFsaWQiKQogICgib3B0aW9uYWwtdGVzdHM6IGFsbG93IEctZXhwcyAobm8gd2Fy bmluZykiKQogICgib3B0aW9uYWwtdGVzdHM6IGFsbG93IEctZXhwcyAod2FybmluZykiKQogICgi b3B0aW9uYWwtdGVzdHM6IGNvbXBsaWNhdGVkICdjaGVjaycgcGhhc2UiKTogTmV3IHRlc3RzLgot LS0KIGd1aXgvbGludC5zY20gIHwgNjAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKystCiB0ZXN0cy9saW50LnNjbSB8IDY2ICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDEyNCBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2d1aXgvbGludC5zY20gYi9ndWl4 L2xpbnQuc2NtCmluZGV4IGQ2NWQ1Y2U4ZjkuLjdmZGMzMzAzMDYgMTAwNjQ0Ci0tLSBhL2d1aXgv bGludC5zY20KKysrIGIvZ3VpeC9saW50LnNjbQpAQCAtNDAsNyArNDAsOCBAQAogICAjOnVzZS1t b2R1bGUgKGd1aXggcGFja2FnZXMpCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCBpMThuKQogICAjOnVz ZS1tb2R1bGUgKChndWl4IGdleHApCi0gICAgICAgICAgICAgICAgIzpzZWxlY3QgKGxvY2FsLWZp bGU/IGxvY2FsLWZpbGUtYWJzb2x1dGUtZmlsZS1uYW1lKSkKKyAgICAgICAgICAgICAgICAjOnNl bGVjdCAoZ2V4cD8gbG9jYWwtZmlsZT8gbG9jYWwtZmlsZS1hYnNvbHV0ZS1maWxlLW5hbWUKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2V4cC0+YXBwcm94aW1hdGUtc2V4cCkpCiAg ICM6dXNlLW1vZHVsZSAoZ3VpeCBsaWNlbnNlcykKICAgIzp1c2UtbW9kdWxlIChndWl4IHJlY29y ZHMpCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCBncmFmdHMpCkBAIC04OCw2ICs4OSw3IEBACiAgICAg ICAgICAgICBjaGVjay1zb3VyY2UKICAgICAgICAgICAgIGNoZWNrLXNvdXJjZS1maWxlLW5hbWUK ICAgICAgICAgICAgIGNoZWNrLXNvdXJjZS11bnN0YWJsZS10YXJiYWxsCisgICAgICAgICAgICBj aGVjay1vcHRpb25hbC10ZXN0cwogICAgICAgICAgICAgY2hlY2stbWlycm9yLXVybAogICAgICAg ICAgICAgY2hlY2stZ2l0aHViLXVybAogICAgICAgICAgICAgY2hlY2stbGljZW5zZQpAQCAtMTA1 MCw2ICsxMDUyLDU4IEBAIGRlc2NyaXB0aW9ucyBtYWludGFpbmVkIHVwc3RyZWFtLiIKIChkZWZp bmUgZXhjZXB0aW9uLXdpdGgta2luZC1hbmQtYXJncz8KICAgKGV4Y2VwdGlvbi1wcmVkaWNhdGUg JmV4Y2VwdGlvbi13aXRoLWtpbmQtYW5kLWFyZ3MpKQogCisoZGVmaW5lIChjaGVjay1vcHRpb25h bC10ZXN0cyBwYWNrYWdlKQorICAiRW1pdCBhIHdhcm5pbmcgaWYgdGhlIHRlc3Qgc3VpdGUgaXMg cnVuIHVuY29uZGl0aW9uYWxseS4iCisgIChkZWZpbmUgKHNleHAtdXNlcy10ZXN0cz8/IHNleHAp CisgICAgIlRlc3QgaWYgU0VYUCBjb250YWlucyB0aGUgc3ltYm9sICd0ZXN0cz8nLiIKKyAgICAo c2V4cC1jb250YWlucy1hdG9tPyBzZXhwICd0ZXN0cz8pKQorICAoZGVmaW5lIChzZXhwLWNvbnRh aW5zLWF0b20/IHNleHAgYXRvbSkKKyAgICAiVGVzdCBpZiBTRVhQIGNvbnRhaW5zIEFUT00uIgor ICAgIChpZiAocGFpcj8gc2V4cCkKKyAgICAgICAgKG9yIChzZXhwLWNvbnRhaW5zLWF0b20/IChj YXIgc2V4cCkgYXRvbSkKKyAgICAgICAgICAgIChzZXhwLWNvbnRhaW5zLWF0b20/IChjZHIgc2V4 cCkgYXRvbSkpCisgICAgICAgIChlcT8gc2V4cCBhdG9tKSkpCisgIChkZWZpbmUgKGNoZWNrLWNo ZWNrLXByb2NlZHVyZSBleHByZXNzaW9uKQorICAgIChtYXRjaCBleHByZXNzaW9uCisgICAgICAo YCgsKG9yICdsZXQgJ2xldCopIC4gLF8pCisgICAgICAgKGNoZWNrLWNoZWNrLXByb2NlZHVyZSAo Y2FyIChsYXN0LXBhaXIgZXhwcmVzc2lvbikpKSkKKyAgICAgIChgKCwob3IgJ2xhbWJkYSAnbGFt YmRhKikgLF8gLiAsY29kZSkKKyAgICAgICAoaWYgKHNleHAtdXNlcy10ZXN0cz8/IGNvZGUpCisg ICAgICAgICAgICcoKQorICAgICAgICAgICAobGlzdCAobWFrZS13YXJuaW5nIHBhY2thZ2UKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBUUkFOU0xBVE9SUzogY2hlY2sgYW5kICM6 dGVzdHM/IGFyZSBhCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgU2NoZW1lIHN5 bWJvbCBhbmQga2V5d29yZCByZXNwZWN0aXZlbHkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICA7OyBhbmQgc2hvdWxkIG5vdCBiZSB0cmFuc2xhdGVkLgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIChHXyAidGhlICdjaGVjaycgcGhhc2Ugc2hvdWxkIHJlc3BlY3QgIzp0ZXN0 cz8iKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICM6ZmllbGQgJ2FyZ3VtZW50cykp KSkKKyAgICAgIChfICcoKSkpKQorICAoZGVmaW5lIChjaGVjay1waGFzZXMtZGVsdGEgZGVsdGEp CisgICAgKG1hdGNoIGRlbHRhCisgICAgICAoYChyZXBsYWNlICdjaGVjayAsZXhwcmVzc2lvbikK KyAgICAgICAoY2hlY2stY2hlY2stcHJvY2VkdXJlIGV4cHJlc3Npb24pKQorICAgICAgKF8gJygp KSkpCisgIChkZWZpbmUgKGNoZWNrLXBoYXNlcy1kZWx0YXMgZGVsdGFzKQorICAgIChtYXRjaCBk ZWx0YXMKKyAgICAgICgoKSAnKCkpCisgICAgICAoKGhlYWQgLiB0YWlsKQorICAgICAgIChvciAo Y2hlY2stcGhhc2VzLWRlbHRhIGhlYWQpCisgICAgICAgICAgIChjaGVjay1waGFzZXMtZGVsdGFz IHRhaWwpKSkKKyAgICAgIChfIChsaXN0IChtYWtlLXdhcm5pbmcgcGFja2FnZQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICA7OyBUUkFOU0xBVE9SUzogbW9kaWZ5LXBoYXNlcyBpcyBhIFNj aGVtZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBzeW50YXggYW5kIG11c3Qgbm90 IGJlIHRyYW5zbGF0ZWQuCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChHXyAiaW5jb3Jy ZWN0IGNhbGwgdG8g4oCYbW9kaWZ5LXBoYXNlc+KAmSIpCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICM6ZmllbGQgJ2FyZ3VtZW50cykpKSkpCisgIChhcHBseSAobGFtYmRhKiAoIzprZXkg cGhhc2VzICM6YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAgICAgKGRlZmluZSBwaGFzZXMvc2V4 cAorICAgICAgICAgICAgIChpZiAoZ2V4cD8gcGhhc2VzKQorICAgICAgICAgICAgICAgICAoZ2V4 cC0+YXBwcm94aW1hdGUtc2V4cCBwaGFzZXMpCisgICAgICAgICAgICAgICAgIHBoYXNlcykpCisg ICAgICAgICAgIChtYXRjaCBwaGFzZXMvc2V4cAorICAgICAgICAgICAgIChgKG1vZGlmeS1waGFz ZXMgLF8gLiAsY2hhbmdlcykKKyAgICAgICAgICAgICAgKGNoZWNrLXBoYXNlcy1kZWx0YXMgY2hh bmdlcykpCisgICAgICAgICAgICAgKF8gJygpKSkpCisgICAgICAgICAocGFja2FnZS1hcmd1bWVu dHMgcGFja2FnZSkpKQorCiAoZGVmaW5lKiAoY2hlY2stZGVyaXZhdGlvbiBwYWNrYWdlICM6a2V5 IHN0b3JlKQogICAiRW1pdCBhIHdhcm5pbmcgaWYgd2UgZmFpbCB0byBjb21waWxlIFBBQ0tBR0Ug dG8gYSBkZXJpdmF0aW9uLiIKICAgKGRlZmluZSAodHJ5IHN0b3JlIHN5c3RlbSkKQEAgLTE1OTAs NiArMTY0NCwxMCBAQCB0aGVtIGZvciBQQUNLQUdFLiIKICAgICAgKGRlc2NyaXB0aW9uICJNYWtl IHN1cmUgdGhlICdsaWNlbnNlJyBmaWVsZCBpcyBhIDxsaWNlbnNlPiBcCiBvciBhIGxpc3QgdGhl cmVvZiIpCiAgICAgIChjaGVjayAgICAgICBjaGVjay1saWNlbnNlKSkKKyAgIChsaW50LWNoZWNr ZXIKKyAgICAgKG5hbWUgICAgICAgICdvcHRpb25hbC10ZXN0cykKKyAgICAgKGRlc2NyaXB0aW9u ICJNYWtlIHN1cmUgdGVzdHMgYXJlIG9ubHkgcnVuIHdoZW4gcmVxdWVzdGVkIikKKyAgICAgKGNo ZWNrICAgICAgIGNoZWNrLW9wdGlvbmFsLXRlc3RzKSkKICAgIChsaW50LWNoZWNrZXIKICAgICAg KG5hbWUgICAgICAgICdtaXJyb3ItdXJsKQogICAgICAoZGVzY3JpcHRpb24gIlN1Z2dlc3QgJ21p cnJvcjovLycgVVJMcyIpCmRpZmYgLS1naXQgYS90ZXN0cy9saW50LnNjbSBiL3Rlc3RzL2xpbnQu c2NtCmluZGV4IGZhZTM0NmU3MjQuLjMzNzA1ZjdjZDMgMTAwNjQ0Ci0tLSBhL3Rlc3RzL2xpbnQu c2NtCisrKyBiL3Rlc3RzL2xpbnQuc2NtCkBAIC05LDYgKzksNyBAQAogOzs7IENvcHlyaWdodCDC qSAyMDE4LCAyMDE5IEFydW4gSXNhYWMgPGFydW5pc2FhY0BzeXN0ZW1yZWJvb3QubmV0PgogOzs7 IENvcHlyaWdodCDCqSAyMDIwIFRpbW90aHkgU2FtcGxlIDxzYW1wbGV0QG5neXJvLmNvbT4KIDs7 OyBDb3B5cmlnaHQgwqkgMjAyMSBYaW5nbHUgQ2hlbiA8cHVibGljQHlvY3RvY2VsbC54eXo+Cis7 OzsgQ29weXJpZ2h0IMKpIDIwMjEgTWF4aW1lIERldm9zIDxtYXhpbWVkZXZvc0B0ZWxlbmV0LmJl PgogOzs7CiA7OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTM4LDcg KzM5LDcgQEAKICAgIzp1c2UtbW9kdWxlIChndWl4IGxpbnQpCiAgICM6dXNlLW1vZHVsZSAoZ3Vp eCB1aSkKICAgIzp1c2UtbW9kdWxlIChndWl4IHN3aCkKLSAgIzp1c2UtbW9kdWxlICgoZ3VpeCBn ZXhwKSAjOnNlbGVjdCAobG9jYWwtZmlsZSkpCisgICM6dXNlLW1vZHVsZSAoKGd1aXggZ2V4cCkg IzpzZWxlY3QgKGdleHAgbG9jYWwtZmlsZSBnZXhwPykpCiAgICM6dXNlLW1vZHVsZSAoKGd1aXgg dXRpbHMpICM6c2VsZWN0IChjYWxsLXdpdGgtdGVtcG9yYXJ5LWRpcmVjdG9yeSkpCiAgICM6dXNl LW1vZHVsZSAoKGd1aXggaW1wb3J0IGhhY2thZ2UpICM6c2VsZWN0ICglaGFja2FnZS11cmwpKQog ICAjOnVzZS1tb2R1bGUgKChndWl4IGltcG9ydCBzdGFja2FnZSkgIzpzZWxlY3QgKCVzdGFja2Fn ZS11cmwpKQpAQCAtNzQ0LDYgKzc0NSw2OSBAQAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChzaGEyNTYgJW51bGwtc2hhMjU2KSkpKSkpCiAgICAgKGNoZWNrLXNvdXJjZS11bnN0YWJs ZS10YXJiYWxsIHBrZykpKQogCisoZGVmaW5lIChwYWNrYWdlLXdpdGgtcGhhc2UtY2hhbmdlcyBj aGFuZ2VzKQorICAoZHVtbXktcGFja2FnZSAieCIKKyAgICAgICAgICAgICAgICAgKGFyZ3VtZW50 cyBgKCM6cGhhc2VzCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAsKGlmIChnZXhwPyBj aGFuZ2VzKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjfihtb2RpZnktcGhh c2VzICVzdGFuZGFyZC1waGFzZXMKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICMkQGNoYW5nZXMpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGAobW9k aWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICxAY2hhbmdlcykpKSkpKQorCisodGVzdC1lcXVhbCAib3B0aW9uYWwtdGVzdHM6 IG5vIGNoZWNrIHBoYXNlIgorICAnKCkKKyAgKGxldCAoKHBrZyAocGFja2FnZS13aXRoLXBoYXNl LWNoYW5nZXMgJygpKSkpCisgICAgKGNoZWNrLW9wdGlvbmFsLXRlc3RzIHBrZykpKQorCisodGVz dC1lcXVhbCAib3B0aW9uYWwtdGVzdHM6IGNoZWNrIHBoYXNlIHJlc3BlY3RzICM6dGVzdHM/Igor ICAnKCkKKyAgKGxldCAoKHBrZyAocGFja2FnZS13aXRoLXBoYXNlLWNoYW5nZXMKKyAgICAgICAg ICAgICAgJygocmVwbGFjZSAnY2hlY2sKKyAgICAgICAgICAgICAgICAgIChsYW1iZGEqICgjOmtl eSB0ZXN0cz8gIzphbGxvdy1vdGhlci1rZXlzPykKKyAgICAgICAgICAgICAgICAgICAgKHdoZW4g dGVzdHM/CisgICAgICAgICAgICAgICAgICAgICAgKGludm9rZSAiLi90aGUtdGVzdC1zdWl0ZSIp KSkpKSkpKQorICAgIChjaGVjay1vcHRpb25hbC10ZXN0cyBwa2cpKSkKKworKHRlc3QtZXF1YWwg Im9wdGlvbmFsLXRlc3RzOiBjaGVjayBwaGFzZSBpZ25vcmVzICM6dGVzdHM/IgorICAidGhlICdj aGVjaycgcGhhc2Ugc2hvdWxkIHJlc3BlY3QgIzp0ZXN0cz8iCisgIChsZXQgKChwa2cgKHBhY2th Z2Utd2l0aC1waGFzZS1jaGFuZ2VzCisgICAgICAgICAgICAgICcoKHJlcGxhY2UgJ2NoZWNrCisg ICAgICAgICAgICAgICAgICAobGFtYmRhIF8KKyAgICAgICAgICAgICAgICAgICAgKGludm9rZSAi Li90aGUtdGVzdC1zdWl0ZSIpKSkpKSkpCisgICAgKHNpbmdsZS1saW50LXdhcm5pbmctbWVzc2Fn ZQorICAgICAoY2hlY2stb3B0aW9uYWwtdGVzdHMgcGtnKSkpKQorCisodGVzdC1lcXVhbCAib3B0 aW9uYWwtdGVzdHM6IGRvIG5vdCBjcmFzaCB3aGVuICM6cGhhc2VzIGlzIGludmFsaWQiCisgICJp bmNvcnJlY3QgY2FsbCB0byDigJhtb2RpZnktcGhhc2Vz4oCZIgorICAobGV0ICgocGtnIChwYWNr YWdlLXdpdGgtcGhhc2UtY2hhbmdlcyAndGhpcy1pcy1ub3QtYS1saXN0KSkpCisgICAgKHNpbmds ZS1saW50LXdhcm5pbmctbWVzc2FnZQorICAgICAoY2hlY2stb3B0aW9uYWwtdGVzdHMgcGtnKSkp KQorCisodGVzdC1lcXVhbCAib3B0aW9uYWwtdGVzdHM6IGFsbG93IEctZXhwcyAobm8gd2Fybmlu ZykiCisgICcoKQorICAobGV0ICgocGtnIChwYWNrYWdlLXdpdGgtcGhhc2UtY2hhbmdlcyAjfigp KSkpCisgICAgKGNoZWNrLW9wdGlvbmFsLXRlc3RzIHBrZykpKQorCisodGVzdC1lcXVhbCAib3B0 aW9uYWwtdGVzdHM6IGFsbG93IEctZXhwcyAod2FybmluZykiCisgICJ0aGUgJ2NoZWNrJyBwaGFz ZSBzaG91bGQgcmVzcGVjdCAjOnRlc3RzPyIKKyAgKGxldCAoKHBrZyAocGFja2FnZS13aXRoLXBo YXNlLWNoYW5nZXMKKyAgICAgICAgICAgICAgI34oKHJlcGxhY2UgJ2NoZWNrCisgICAgICAgICAg ICAgICAgICAgKGxhbWJkYSBfCisgICAgICAgICAgICAgICAgICAgICAoaW52b2tlICIvdGhlLXRl c3Qtc3VpdGUiKSkpKSkpKQorICAgIChzaW5nbGUtbGludC13YXJuaW5nLW1lc3NhZ2UKKyAgICAg KGNoZWNrLW9wdGlvbmFsLXRlc3RzIHBrZykpKSkKKworKHRlc3QtZXF1YWwgIm9wdGlvbmFsLXRl c3RzOiBjb21wbGljYXRlZCAnY2hlY2snIHBoYXNlIgorICAidGhlICdjaGVjaycgcGhhc2Ugc2hv dWxkIHJlc3BlY3QgIzp0ZXN0cz8iCisgIChsZXQgKChwa2cgKHBhY2thZ2Utd2l0aC1waGFzZS1j aGFuZ2VzCisgICAgICAgICAgICAgICcoKHJlcGxhY2UgJ2NoZWNrCisgICAgICAgICAgICAgICAg ICAobGFtYmRhKiAoIzprZXkgaW5wdXRzIHRlc3RzPyAjOmFsbG93LW90aGVyLWtleXMpCisgICAg ICAgICAgICAgICAgICAgIChsZXQgKChzb21ldGhpbmcgKHN0dWZmIGZyb20gaW5wdXRzIG9yIG5h dGl2ZS1pbnB1dHMpKSkKKyAgICAgICAgICAgICAgICAgICAgICAoZGVsZXRlLWZpbGUgImRhdGV1 dGlsL3Rlc3QvdGVzdF91dGlscy5weSIpCisgICAgICAgICAgICAgICAgICAgICAgKGludm9rZSAi cHl0ZXN0IiAiLXZ2IikpKSkpKSkpCisgICAgKHNpbmdsZS1saW50LXdhcm5pbmctbWVzc2FnZQor ICAgICAoY2hlY2stb3B0aW9uYWwtdGVzdHMgcGtnKSkpKQorCiAodGVzdC1lcXVhbCAic291cmNl OiAyMDAiCiAgICcoKQogICAod2l0aC1odHRwLXNlcnZlciBgKCgyMDAgLCVsb25nLXN0cmluZykp Ci0tIAoyLjMyLjAKCg== --=-gtucq2/GeTqxaD5VJcDg-- --=-a66tmHWbPZXIlU1QAaYg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYNo7/hccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7p0vAP9OpY+Vuo5yymS1BQeAodl01J/3 Xr/764zjJkqajwaWYgEA6nlIgBrcpfZSZidFaElQDQKuVEUCyp+hwpxGNtt7GAs= =GuJE -----END PGP SIGNATURE----- --=-a66tmHWbPZXIlU1QAaYg-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 29 06:34:59 2021 Received: (at 48320) by debbugs.gnu.org; 29 Jun 2021 10:34:59 +0000 Received: from localhost ([127.0.0.1]:53657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyB51-00059f-4O for submit@debbugs.gnu.org; Tue, 29 Jun 2021 06:34:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyB4y-00059S-QO for 48320@debbugs.gnu.org; Tue, 29 Jun 2021 06:34:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50200) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyB4s-0004jg-Vk; Tue, 29 Jun 2021 06:34:51 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=59006 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyB4r-0001XH-Ax; Tue, 29 Jun 2021 06:34:50 -0400 From: Mathieu Othacehe To: Maxime Devos Subject: Re: [PATCH v2] lint: Verify if #:tests? is respected in the 'check' phase. References: <2b0fee1845a66e1fb126b4bbf1c9892b7c648a3a.camel@telenet.be> <44f0c8b823b0f6f8e5388ff6c1d90e76fa09bf2c.camel@telenet.be> Date: Tue, 29 Jun 2021 12:34:48 +0200 In-Reply-To: <44f0c8b823b0f6f8e5388ff6c1d90e76fa09bf2c.camel@telenet.be> (Maxime Devos's message of "Mon, 28 Jun 2021 23:15:42 +0200") Message-ID: <87h7hhvu0n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48320 Cc: 48320@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Maxime, Thanks for the new revision. > +@deffn {Procedure} gexp->approximate-sexp @var{gexp} > +Sometimes, it may be useful to convert a G-exp into a S-exp. > +For example, some linters (@pxref{Invoking guix lint}) You can write longer sentences here, up to 78 columns. If you are using Emacs, fill-paragraph does the right thing. > + (define (sexp-uses-tests?? sexp) > + "Test if SEXP contains the symbol 'tests?'." > + (sexp-contains-atom? sexp 'tests?)) > + (define (sexp-contains-atom? sexp atom) > + "Test if SEXP contains ATOM." > + (if (pair? sexp) > + (or (sexp-contains-atom? (car sexp) atom) > + (sexp-contains-atom? (cdr sexp) atom)) > + (eq? sexp atom))) It would make more sense to define "sexp-uses-tests??" later as it uses "sexp-contains-atom" that is defined afterwards. > + (or (check-phases-delta head) > + (check-phases-deltas tail))) I think it should be "append" instead of "or". Otherwise, it fails to detect package which 'replace is not the first phase, see mkvtoolnix for instance. Otherwise looks fine :) Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 30 06:34:28 2021 Received: (at 48320) by debbugs.gnu.org; 30 Jun 2021 10:34:28 +0000 Received: from localhost ([127.0.0.1]:56526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyXXz-0001KB-9m for submit@debbugs.gnu.org; Wed, 30 Jun 2021 06:34:28 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:35146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyXXv-0001Jz-IF for 48320@debbugs.gnu.org; Wed, 30 Jun 2021 06:34:21 -0400 Received: from butterfly.local ([188.189.254.236]) by michel.telenet-ops.be with bizsmtp id PNaG2500C56nx8C06NaHzP; Wed, 30 Jun 2021 12:34:17 +0200 Message-ID: Subject: [PATCH v3] lint: Verify if #:tests? is respected in the 'check' phase. From: Maxime Devos To: Mathieu Othacehe Date: Wed, 30 Jun 2021 12:31:57 +0200 In-Reply-To: <87h7hhvu0n.fsf@gnu.org> References: <2b0fee1845a66e1fb126b4bbf1c9892b7c648a3a.camel@telenet.be> <44f0c8b823b0f6f8e5388ff6c1d90e76fa09bf2c.camel@telenet.be> <87h7hhvu0n.fsf@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ce0ZMArvV6NrAugx+U+G" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1625049257; bh=44sBkRXfqynIHLiiL/Fa7op0w5Fpg1VwKNV+V0hyv4M=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=gherYjtdMk396o7/qlupTQPkJch7FzxmLFNFD2smQNZ7XaGZYDIuzQF4D/LgN1S7j HjzppK2yrnWiIMs52jyXCJiaRvU6CpL+dL7g8eqcsWCLb/tTjKE0BOVfU0aXsRdc/x zaqRx1LjYUok9tq5UToRcTJ4a6U+pW3Fqt7/Swasj4xiSs+ZBxP2ifMBj312veIK+E I2ksS5fMktCNaGszX+W04CXqBkxey++Ig0RW3Sbf2Z0lMm/zBtfPkRsd72/N66srQX KE6GnN9LTmLaSj54Nw7Y8mtlbBE7b8+2rJPZcuscGqf6sSZq4+kTQtfiKPIZpYqCLu cPIqP7xP7sDng== X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Mathieu Othacehe schreef op di 29-06-2021 om 12:34 [+0200]: > Hello Maxime, > > Thanks for the new revision. > > > +@deffn {Procedure} gexp->approximate-sexp @var{gexp} > > +Sometimes, it may be usefu [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [195.130.137.88 listed in list.dnswl.org] 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (maximedevos[at]telenet.be) -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 48320 Cc: 48320@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --=-ce0ZMArvV6NrAugx+U+G Content-Type: multipart/mixed; boundary="=-yWm4rju4VxtiXUuUDipg" --=-yWm4rju4VxtiXUuUDipg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mathieu Othacehe schreef op di 29-06-2021 om 12:34 [+0200]: > Hello Maxime, >=20 > Thanks for the new revision. >=20 > > +@deffn {Procedure} gexp->approximate-sexp @var{gexp} > > +Sometimes, it may be useful to convert a G-exp into a S-exp. > > +For example, some linters (@pxref{Invoking guix lint}) >=20 > You can write longer sentences here, up to 78 columns. If you are using > Emacs, fill-paragraph does the right thing. I did a "fill-paragraph" in the v3. > > + (define (sexp-uses-tests?? sexp) > > + "Test if SEXP contains the symbol 'tests?'." > > + (sexp-contains-atom? sexp 'tests?)) > > + (define (sexp-contains-atom? sexp atom) > > + "Test if SEXP contains ATOM." > > + (if (pair? sexp) > > + (or (sexp-contains-atom? (car sexp) atom) > > + (sexp-contains-atom? (cdr sexp) atom)) > > + (eq? sexp atom))) >=20 > It would make more sense to define "sexp-uses-tests??" later as it uses > "sexp-contains-atom" that is defined afterwards. Indeed. I switched these two procedures around in the v3. > > + (or (check-phases-delta head) > > + (check-phases-deltas tail))) >=20 > I think it should be "append" instead of "or". Otherwise, it fails to > detect package which 'replace is not the first phase, see mkvtoolnix for > instance. Indeed. I added a test case and replaced "or" with "append". The linter now detects about 300 additional cases. Greetings, Maxime. --=-yWm4rju4VxtiXUuUDipg Content-Disposition: inline; filename="v3-0001-guix-gexp-Define-gexp-approximate-sexp.patch" Content-Type: text/x-patch; name="v3-0001-guix-gexp-Define-gexp-approximate-sexp.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA1ODM1YjMyZDkxNjY4MWRiNzNmYjJkOTFiMzY0NmQ5MTViZmJkMGE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXhpbWUgRGV2b3MgPG1heGltZWRldm9zQHRlbGVuZXQuYmU+ CkRhdGU6IE1vbiwgMjggSnVuIDIwMjEgMTk6MjQ6NDQgKzAyMDAKU3ViamVjdDogW1BBVENIIHYz IDEvMl0gZ3VpeDogZ2V4cDogRGVmaW5lIGdleHAtPmFwcHJveGltYXRlLXNleHAuCgpJdCB3aWxs IGJlIHVzZWQgaW4gdGhlICdvcHRpb25hbC10ZXN0cycgbGludGVyLgoKKiBndWl4L2dleHAuc2Nt IChnZXhwLT5hcHByb3hpbWF0ZS1zZXhwKTogTmV3IHByb2NlZHVyZS4KKiB0ZXN0cy9nZXhwLnNj bQogICgibm8gcmVmZXJlbmNlcyIsICJ1bnF1b3RlZCBnZXhwIiwgInVucXVvdGVkIGdleHAgKG5h dGl2ZSkiKQogICgic3BsaWNlZCBnZXhwIiwgInVuc3BsaWNlZCBnZXhwLCBhcHByb3hpbWF0ZWQi KQogICgidW5xdW90ZWQgZ2V4cCwgYXBwcm94aW1hdGVkIik6IFRlc3QgaXQuCiogZG9jL2dleHAu c2NtICgiRy1FeHByZXNzaW9ucyIpOiBEb2N1bWVudCBpdC4KLS0tCiBkb2MvZ3VpeC50ZXhpICB8 IDEwICsrKysrKysrKysKIGd1aXgvZ2V4cC5zY20gIHwgMTkgKysrKysrKysrKysrKysrKysrKwog dGVzdHMvZ2V4cC5zY20gfCAzMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAzIGZp bGVzIGNoYW5nZWQsIDYwIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9kb2MvZ3VpeC50ZXhp IGIvZG9jL2d1aXgudGV4aQppbmRleCAxNWU4OTk5NDQ3Li5mMDUxMzczNTcxIDEwMDY0NAotLS0g YS9kb2MvZ3VpeC50ZXhpCisrKyBiL2RvYy9ndWl4LnRleGkKQEAgLTEwMDM4LDYgKzEwMDM4LDE2 IEBAIGNvcnJlc3BvbmRpbmcgdG8gQHZhcntvYmp9IGZvciBAdmFye3N5c3RlbX0sIGNyb3NzLWNv bXBpbGluZyBmb3IKIGhhcyBhbiBhc3NvY2lhdGVkIGdleHAgY29tcGlsZXIsIHN1Y2ggYXMgYSBA Y29kZXs8cGFja2FnZT59LgogQGVuZCBkZWZmbgogCitAZGVmZm4ge1Byb2NlZHVyZX0gZ2V4cC0+ YXBwcm94aW1hdGUtc2V4cCBAdmFye2dleHB9CitTb21ldGltZXMsIGl0IG1heSBiZSB1c2VmdWwg dG8gY29udmVydCBhIEctZXhwIGludG8gYSBTLWV4cC4gIEZvcgorZXhhbXBsZSwgc29tZSBsaW50 ZXJzIChAcHhyZWZ7SW52b2tpbmcgZ3VpeCBsaW50fSkgcGVlayBpbnRvIHRoZSBidWlsZAorcGhh c2VzIG9mIGEgcGFja2FnZSB0byBkZXRlY3QgcG90ZW50aWFsIHByb2JsZW1zLiAgVGhpcyBjb252 ZXJzaW9uIGNhbgorYmUgYWNoaWV2ZWQgd2l0aCB0aGlzIHByb2NlZHVyZS4gIEhvd2V2ZXIsIHNv bWUgaW5mb3JtYXRpb24gY2FuIGJlIGxvc3QKK2luIHRoZSBwcm9jZXNzLiAgTW9yZSBzcGVjaWZp Y2FsbHksIGxvd2VyYWJsZSBvYmplY3RzIHdpbGwgYmUgc2lsZW50bHkKK3JlcGxhY2VkIHdpdGgg c29tZSBhcmJpdHJhcnkgb2JqZWN0IC0tIGN1cnJlbnRseSB0aGUgbGlzdAorQGNvZGV7KCphcHBy b3hpbWF0ZSopfSwgYnV0IHRoaXMgbWF5IGNoYW5nZS4KK0BlbmQgZGVmZm4KKwogQG5vZGUgSW52 b2tpbmcgZ3VpeCByZXBsCiBAc2VjdGlvbiBJbnZva2luZyBAY29tbWFuZHtndWl4IHJlcGx9CiAK ZGlmZiAtLWdpdCBhL2d1aXgvZ2V4cC5zY20gYi9ndWl4L2dleHAuc2NtCmluZGV4IDE4N2Y1YzVl ODUuLmYzZDI3OGIzZTYgMTAwNjQ0Ci0tLSBhL2d1aXgvZ2V4cC5zY20KKysrIGIvZ3VpeC9nZXhw LnNjbQpAQCAtNCw2ICs0LDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAxOCBKYW4gTmlldXdlbmh1 aXplbiA8amFubmVrZUBnbnUub3JnPgogOzs7IENvcHlyaWdodCDCqSAyMDE5LCAyMDIwIE1hdGhp ZXUgT3RoYWNlaGUgPG0ub3RoYWNlaGVAZ21haWwuY29tPgogOzs7IENvcHlyaWdodCDCqSAyMDIw IE1heGltIENvdXJub3llciA8bWF4aW0uY291cm5veWVyQGdtYWlsLmNvbT4KKzs7OyBDb3B5cmln aHQgwqkgMjAyMSBNYXhpbWUgRGV2b3MgPG1heGltZWRldm9zQHRlbGVuZXQuYmU+CiA7OzsKIDs7 OyBUaGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwpAQCAtNDIsNiArNDMsNyBAQAog ICAgICAgICAgICAgd2l0aC1pbXBvcnRlZC1tb2R1bGVzCiAgICAgICAgICAgICB3aXRoLWV4dGVu c2lvbnMKICAgICAgICAgICAgIGxldC1zeXN0ZW0KKyAgICAgICAgICAgIGdleHAtPmFwcHJveGlt YXRlLXNleHAKIAogICAgICAgICAgICAgZ2V4cC1pbnB1dAogICAgICAgICAgICAgZ2V4cC1pbnB1 dD8KQEAgLTE1Nyw2ICsxNTksMjMgQEAKICAgIlJldHVybiB0aGUgc291cmNlIGNvZGUgbG9jYXRp b24gb2YgR0VYUC4iCiAgIChhbmQ9PiAoJWdleHAtbG9jYXRpb24gZ2V4cCkgc291cmNlLXByb3Bl cnRpZXMtPmxvY2F0aW9uKSkKIAorKGRlZmluZSogKGdleHAtPmFwcHJveGltYXRlLXNleHAgZ2V4 cCkKKyAgIlJldHVybiB0aGUgUy1leHByZXNzaW9uIGNvcnJlc3BvbmRpbmcgdG8gR0VYUCwgYnV0 IGRvIG5vdCBsb3dlciBhbnl0aGluZy4KK0FzIGEgcmVzdWx0LCB0aGUgUy1leHByZXNzaW9uIHdp bGwgYmUgYXBwcm94aW1hdGUgaWYgR0VYUCBoYXMgcmVmZXJlbmNlcy4iCisgIChkZWZpbmUgKGdl eHAtbGlrZT8gdGhpbmcpCisgICAgKG9yIChnZXhwPyB0aGluZykgKGdleHAtaW5wdXQ/IHRoaW5n KSkpCisgIChhcHBseSAoZ2V4cC1wcm9jIGdleHApCisgICAgICAgICAobWFwIChsYW1iZGEgKHJl ZmVyZW5jZSkKKyAgICAgICAgICAgICAgICAobWF0Y2ggcmVmZXJlbmNlCisgICAgICAgICAgICAg ICAgICAoKCQgPGdleHAtaW5wdXQ+IHRoaW5nIG91dHB1dCBuYXRpdmUpCisgICAgICAgICAgICAg ICAgICAgKGlmIChnZXhwLWxpa2U/IHRoaW5nKQorICAgICAgICAgICAgICAgICAgICAgICAoZ2V4 cC0+YXBwcm94aW1hdGUtc2V4cCB0aGluZykKKyAgICAgICAgICAgICAgICAgICAgICAgOzsgU2lt cGx5IHJldHVybmluZyAndGhpbmcnIHdvbid0IHdvcmsgaW4gc29tZQorICAgICAgICAgICAgICAg ICAgICAgICA7OyBzaXR1YXRpb25zOyBzZWUgJ3dyaXRlLWdleHAnIGJlbG93LgorICAgICAgICAg ICAgICAgICAgICAgICAnKCphcHByb3hpbWF0ZSopKSkKKyAgICAgICAgICAgICAgICAgIChfICco KmFwcHJveGltYXRlKikpKSkKKyAgICAgICAgICAgICAgKGdleHAtcmVmZXJlbmNlcyBnZXhwKSkp KQorCiAoZGVmaW5lICh3cml0ZS1nZXhwIGdleHAgcG9ydCkKICAgIldyaXRlIEdFWFAgb24gUE9S VC4iCiAgIChkaXNwbGF5ICIjPGdleHAgIiBwb3J0KQpkaWZmIC0tZ2l0IGEvdGVzdHMvZ2V4cC5z Y20gYi90ZXN0cy9nZXhwLnNjbQppbmRleCA4MzRlNzhiOWEwLi4zOWE0N2Q0ZThjIDEwMDY0NAot LS0gYS90ZXN0cy9nZXhwLnNjbQorKysgYi90ZXN0cy9nZXhwLnNjbQpAQCAtMSw1ICsxLDYgQEAK IDs7OyBHTlUgR3VpeCAtLS0gRnVuY3Rpb25hbCBwYWNrYWdlIG1hbmFnZW1lbnQgZm9yIEdOVQog Ozs7IENvcHlyaWdodCDCqSAyMDE0LCAyMDE1LCAyMDE2LCAyMDE3LCAyMDE4LCAyMDE5LCAyMDIw LCAyMDIxIEx1ZG92aWMgQ291cnTDqHMgPGx1ZG9AZ251Lm9yZz4KKzs7OyBDb3B5cmlnaHQgwqkg MjAyMSBNYXhpbWUgRGV2b3MgPG1heGltZWRldm9zQHRlbGVuZXQuYmU+CiA7OzsKIDs7OyBUaGlz IGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwpAQCAtODksNiArOTAsMzYgQEAKIAwKICh0 ZXN0LWJlZ2luICJnZXhwIikKIAorKHRlc3QtZXF1YWwgIm5vIHJlZmVyZW5jZXMiCisgICcoZGlz cGxheSAiaGVsbG8gZ2V4cC0+YXBwcm94aW1hdGUtc2V4cCEiKQorICAoZ2V4cC0+YXBwcm94aW1h dGUtc2V4cCAjfihkaXNwbGF5ICJoZWxsbyBnZXhwLT5hcHByb3hpbWF0ZS1zZXhwISIpKSkKKwor KHRlc3QtZXF1YWwgInVucXVvdGVkIGdleHAiCisgICcoZGlzcGxheSAiaGVsbG8iKQorICAobGV0 ICgoaW5zaWRlICN+ImhlbGxvIikpCisgICAgKGdleHAtPmFwcHJveGltYXRlLXNleHAgI34oZGlz cGxheSAjJGluc2lkZSkpKSkKKworKHRlc3QtZXF1YWwgInVucXVvdGVkIGdleHAgKG5hdGl2ZSki CisgICcoZGlzcGxheSAiaGVsbG8iKQorICAobGV0ICgoaW5zaWRlICN+ImhlbGxvIikpCisgICAg KGdleHAtPmFwcHJveGltYXRlLXNleHAgI34oZGlzcGxheSAjK2luc2lkZSkpKSkKKworKHRlc3Qt ZXF1YWwgInNwbGljZWQgZ2V4cCIKKyAgJyhkaXNwbGF5ICcoZnJlc2ggdmVnZXRhYmxlcykpCisg IChsZXQgKChpbnNpZGUgI34oZnJlc2ggdmVnZXRhYmxlcykpKQorICAgIChnZXhwLT5hcHByb3hp bWF0ZS1zZXhwICN+KGRpc3BsYXkgJygjJEBpbnNpZGUpKSkpKQorCisodGVzdC1lcXVhbCAidW5z cGxpY2VkIGdleHAsIGFwcHJveGltYXRlZCIKKyAgOzsgKCphcHByb3hpbWF0ZSopIGlzIHJlYWxs eSBhbiBpbXBsZW1lbnRhdGlvbiBkZXRhaWwKKyAgJyhkaXNwbGF5ICcoKmFwcHJveGltYXRlKikp CisgIChsZXQgKChpbnNpZGUgKGZpbGUtYXBwZW5kIGNvcmV1dGlscyAiL2Jpbi9oZWxsbyIpKSkK KyAgICAoZ2V4cC0+YXBwcm94aW1hdGUtc2V4cCAjfihkaXNwbGF5ICcoIyRAaW5zaWRlKSkpKSkK KworKHRlc3QtZXF1YWwgInVucXVvdGVkIGdleHAsIGFwcHJveGltYXRlZCIKKyAgJyhkaXNwbGF5 ICcoKmFwcHJveGltYXRlKikpCisgIChsZXQgKChpbnNpZGUgKGZpbGUtYXBwZW5kIGNvcmV1dGls cyAiL2Jpbi9oZWxsbyIpKSkKKyAgICAoZ2V4cC0+YXBwcm94aW1hdGUtc2V4cCAjfihkaXNwbGF5 ICcjJGluc2lkZSkpKSkKKwogKHRlc3QtZXF1YWwgIm5vIHJlZnMiCiAgICcoZGlzcGxheSAiaGVs bG8hIikKICAgKGxldCAoKGV4cCAoZ2V4cCAoZGlzcGxheSAiaGVsbG8hIikpKSkKLS0gCjIuMzIu MAoK --=-yWm4rju4VxtiXUuUDipg Content-Disposition: inline; filename*0=v3-0002-lint-Verify-if-tests-is-respected-in-the-check-ph.pat; filename*1=ch Content-Type: text/x-patch; name="v3-0002-lint-Verify-if-tests-is-respected-in-the-check-ph.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBjMTYwMjJmMGMxOGQ1OTY2NzhiZGJhODJjZDEyM2JhNmRhZTk2YTYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXhpbWUgRGV2b3MgPG1heGltZWRldm9zQHRlbGVuZXQuYmU+ CkRhdGU6IE1vbiwgMjggSnVuIDIwMjEgMjA6NDQ6MTYgKzAyMDAKU3ViamVjdDogW1BBVENIIHYz IDIvMl0gbGludDogVmVyaWZ5IGlmICM6dGVzdHM/IGlzIHJlc3BlY3RlZCBpbiB0aGUgJ2NoZWNr JwogcGhhc2UuCgpUaGVyZSBoYXZlIGJlZW4gYSBmZXcgcGF0Y2hlcyB0byB0aGUgbWFpbGluZyBs aXN0IGxhdGVseQpub3QgcmVzcGVjdGluZyB0aGlzLCBhbmQgdGhpcyBsaW50ZXIgZGV0ZWN0cyA2 MzAgcGFja2FnZQpkZWZpbml0aW9ucyB0aGF0IGNvdWxkIGJlIG1vZGlmaWVkIHRvIHN1cHBvcnQg dGhlIC0td2l0aG91dC10ZXN0cwpwYWNrYWdlIHRyYW5zZm9ybWF0aW9uLgoKKiBndWl4L2xpbnQu c2NtCiAgKGNoZWNrLW9wdGlvbmFsLXRlc3RzKTogTmV3IGxpbnRlci4KICAoJWxvY2FsLWNoZWNr ZXJzKVtvcHRpb25hbC10ZXN0c106IEFkZCBpdC4KKiB0ZXN0cy9saW50LnNjbQogIChwYWNrYWdl LXdpdGgtcGhhc2UtY2hhbmdlcyk6IE5ldyBwcm9jZWR1cmUuCiAgKCJvcHRpb25hbC10ZXN0czog bm8gY2hlY2sgcGhhc2UiKQogICgib3B0aW9uYWwtdGVzdHM6IGNoZWNrIGhhc2UgcmVzcGVjdHMg Izp0ZXN0cz8iKQogICgib3B0aW9uYWwtdGVzdHM6IGNoZWNrIHBoYXNlIGlnbm9yZXMgIzp0ZXN0 cz8iKQogICgib3B0aW9uYWwtdGVzdHM6IGRvIG5vdCBjcmFzaCB3aGVuICM6cGhhc2VzIGlzIGlu dmFsaWQiKQogICgib3B0aW9uYWwtdGVzdHM6IGFsbG93IEctZXhwcyAobm8gd2FybmluZykiKQog ICgib3B0aW9uYWwtdGVzdHM6IGFsbG93IEctZXhwcyAod2FybmluZykiKQogICgib3B0aW9uYWwt dGVzdHM6IGNvbXBsaWNhdGVkICdjaGVjaycgcGhhc2UiKQogICgib3B0aW9uYWwtdGVzdHM6ICdj aGVjaycgcGhhc2UgaXMgbm90IGZpcnN0IHBoYXNlIik6IE5ldyB0ZXN0cy4KLS0tCiBndWl4L2xp bnQuc2NtICB8IDYwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQogdGVz dHMvbGludC5zY20gfCA3NyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrLQogMiBmaWxlcyBjaGFuZ2VkLCAxMzUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9ndWl4L2xpbnQuc2NtIGIvZ3VpeC9saW50LnNjbQppbmRleCBk NjVkNWNlOGY5Li5jNjM3OTI5YzM4IDEwMDY0NAotLS0gYS9ndWl4L2xpbnQuc2NtCisrKyBiL2d1 aXgvbGludC5zY20KQEAgLTQwLDcgKzQwLDggQEAKICAgIzp1c2UtbW9kdWxlIChndWl4IHBhY2th Z2VzKQogICAjOnVzZS1tb2R1bGUgKGd1aXggaTE4bikKICAgIzp1c2UtbW9kdWxlICgoZ3VpeCBn ZXhwKQotICAgICAgICAgICAgICAgICM6c2VsZWN0IChsb2NhbC1maWxlPyBsb2NhbC1maWxlLWFi c29sdXRlLWZpbGUtbmFtZSkpCisgICAgICAgICAgICAgICAgIzpzZWxlY3QgKGdleHA/IGxvY2Fs LWZpbGU/IGxvY2FsLWZpbGUtYWJzb2x1dGUtZmlsZS1uYW1lCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGdleHAtPmFwcHJveGltYXRlLXNleHApKQogICAjOnVzZS1tb2R1bGUgKGd1 aXggbGljZW5zZXMpCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCByZWNvcmRzKQogICAjOnVzZS1tb2R1 bGUgKGd1aXggZ3JhZnRzKQpAQCAtODgsNiArODksNyBAQAogICAgICAgICAgICAgY2hlY2stc291 cmNlCiAgICAgICAgICAgICBjaGVjay1zb3VyY2UtZmlsZS1uYW1lCiAgICAgICAgICAgICBjaGVj ay1zb3VyY2UtdW5zdGFibGUtdGFyYmFsbAorICAgICAgICAgICAgY2hlY2stb3B0aW9uYWwtdGVz dHMKICAgICAgICAgICAgIGNoZWNrLW1pcnJvci11cmwKICAgICAgICAgICAgIGNoZWNrLWdpdGh1 Yi11cmwKICAgICAgICAgICAgIGNoZWNrLWxpY2Vuc2UKQEAgLTEwNTAsNiArMTA1Miw1OCBAQCBk ZXNjcmlwdGlvbnMgbWFpbnRhaW5lZCB1cHN0cmVhbS4iCiAoZGVmaW5lIGV4Y2VwdGlvbi13aXRo LWtpbmQtYW5kLWFyZ3M/CiAgIChleGNlcHRpb24tcHJlZGljYXRlICZleGNlcHRpb24td2l0aC1r aW5kLWFuZC1hcmdzKSkKIAorKGRlZmluZSAoY2hlY2stb3B0aW9uYWwtdGVzdHMgcGFja2FnZSkK KyAgIkVtaXQgYSB3YXJuaW5nIGlmIHRoZSB0ZXN0IHN1aXRlIGlzIHJ1biB1bmNvbmRpdGlvbmFs bHkuIgorICAoZGVmaW5lIChzZXhwLWNvbnRhaW5zLWF0b20/IHNleHAgYXRvbSkKKyAgICAiVGVz dCBpZiBTRVhQIGNvbnRhaW5zIEFUT00uIgorICAgIChpZiAocGFpcj8gc2V4cCkKKyAgICAgICAg KG9yIChzZXhwLWNvbnRhaW5zLWF0b20/IChjYXIgc2V4cCkgYXRvbSkKKyAgICAgICAgICAgIChz ZXhwLWNvbnRhaW5zLWF0b20/IChjZHIgc2V4cCkgYXRvbSkpCisgICAgICAgIChlcT8gc2V4cCBh dG9tKSkpCisgIChkZWZpbmUgKHNleHAtdXNlcy10ZXN0cz8/IHNleHApCisgICAgIlRlc3QgaWYg U0VYUCBjb250YWlucyB0aGUgc3ltYm9sICd0ZXN0cz8nLiIKKyAgICAoc2V4cC1jb250YWlucy1h dG9tPyBzZXhwICd0ZXN0cz8pKQorICAoZGVmaW5lIChjaGVjay1jaGVjay1wcm9jZWR1cmUgZXhw cmVzc2lvbikKKyAgICAobWF0Y2ggZXhwcmVzc2lvbgorICAgICAgKGAoLChvciAnbGV0ICdsZXQq KSAuICxfKQorICAgICAgIChjaGVjay1jaGVjay1wcm9jZWR1cmUgKGNhciAobGFzdC1wYWlyIGV4 cHJlc3Npb24pKSkpCisgICAgICAoYCgsKG9yICdsYW1iZGEgJ2xhbWJkYSopICxfIC4gLGNvZGUp CisgICAgICAgKGlmIChzZXhwLXVzZXMtdGVzdHM/PyBjb2RlKQorICAgICAgICAgICAnKCkKKyAg ICAgICAgICAgKGxpc3QgKG1ha2Utd2FybmluZyBwYWNrYWdlCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgOzsgVFJBTlNMQVRPUlM6IGNoZWNrIGFuZCAjOnRlc3RzPyBhcmUgYQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IFNjaGVtZSBzeW1ib2wgYW5kIGtleXdvcmQg cmVzcGVjdGl2ZWx5CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgYW5kIHNob3Vs ZCBub3QgYmUgdHJhbnNsYXRlZC4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoR18g InRoZSAnY2hlY2snIHBoYXNlIHNob3VsZCByZXNwZWN0ICM6dGVzdHM/IikKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAjOmZpZWxkICdhcmd1bWVudHMpKSkpCisgICAgICAoXyAnKCkp KSkKKyAgKGRlZmluZSAoY2hlY2stcGhhc2VzLWRlbHRhIGRlbHRhKQorICAgIChtYXRjaCBkZWx0 YQorICAgICAgKGAocmVwbGFjZSAnY2hlY2sgLGV4cHJlc3Npb24pCisgICAgICAgKGNoZWNrLWNo ZWNrLXByb2NlZHVyZSBleHByZXNzaW9uKSkKKyAgICAgIChfICcoKSkpKQorICAoZGVmaW5lIChj aGVjay1waGFzZXMtZGVsdGFzIGRlbHRhcykKKyAgICAobWF0Y2ggZGVsdGFzCisgICAgICAoKCkg JygpKQorICAgICAgKChoZWFkIC4gdGFpbCkKKyAgICAgICAoYXBwZW5kIChjaGVjay1waGFzZXMt ZGVsdGEgaGVhZCkKKyAgICAgICAgICAgICAgIChjaGVjay1waGFzZXMtZGVsdGFzIHRhaWwpKSkK KyAgICAgIChfIChsaXN0IChtYWtlLXdhcm5pbmcgcGFja2FnZQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICA7OyBUUkFOU0xBVE9SUzogbW9kaWZ5LXBoYXNlcyBpcyBhIFNjaGVtZQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBzeW50YXggYW5kIG11c3Qgbm90IGJlIHRyYW5z bGF0ZWQuCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChHXyAiaW5jb3JyZWN0IGNhbGwg dG8g4oCYbW9kaWZ5LXBoYXNlc+KAmSIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICM6 ZmllbGQgJ2FyZ3VtZW50cykpKSkpCisgIChhcHBseSAobGFtYmRhKiAoIzprZXkgcGhhc2VzICM6 YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAgICAgKGRlZmluZSBwaGFzZXMvc2V4cAorICAgICAg ICAgICAgIChpZiAoZ2V4cD8gcGhhc2VzKQorICAgICAgICAgICAgICAgICAoZ2V4cC0+YXBwcm94 aW1hdGUtc2V4cCBwaGFzZXMpCisgICAgICAgICAgICAgICAgIHBoYXNlcykpCisgICAgICAgICAg IChtYXRjaCBwaGFzZXMvc2V4cAorICAgICAgICAgICAgIChgKG1vZGlmeS1waGFzZXMgLF8gLiAs Y2hhbmdlcykKKyAgICAgICAgICAgICAgKGNoZWNrLXBoYXNlcy1kZWx0YXMgY2hhbmdlcykpCisg ICAgICAgICAgICAgKF8gJygpKSkpCisgICAgICAgICAocGFja2FnZS1hcmd1bWVudHMgcGFja2Fn ZSkpKQorCiAoZGVmaW5lKiAoY2hlY2stZGVyaXZhdGlvbiBwYWNrYWdlICM6a2V5IHN0b3JlKQog ICAiRW1pdCBhIHdhcm5pbmcgaWYgd2UgZmFpbCB0byBjb21waWxlIFBBQ0tBR0UgdG8gYSBkZXJp dmF0aW9uLiIKICAgKGRlZmluZSAodHJ5IHN0b3JlIHN5c3RlbSkKQEAgLTE1OTAsNiArMTY0NCwx MCBAQCB0aGVtIGZvciBQQUNLQUdFLiIKICAgICAgKGRlc2NyaXB0aW9uICJNYWtlIHN1cmUgdGhl ICdsaWNlbnNlJyBmaWVsZCBpcyBhIDxsaWNlbnNlPiBcCiBvciBhIGxpc3QgdGhlcmVvZiIpCiAg ICAgIChjaGVjayAgICAgICBjaGVjay1saWNlbnNlKSkKKyAgIChsaW50LWNoZWNrZXIKKyAgICAg KG5hbWUgICAgICAgICdvcHRpb25hbC10ZXN0cykKKyAgICAgKGRlc2NyaXB0aW9uICJNYWtlIHN1 cmUgdGVzdHMgYXJlIG9ubHkgcnVuIHdoZW4gcmVxdWVzdGVkIikKKyAgICAgKGNoZWNrICAgICAg IGNoZWNrLW9wdGlvbmFsLXRlc3RzKSkKICAgIChsaW50LWNoZWNrZXIKICAgICAgKG5hbWUgICAg ICAgICdtaXJyb3ItdXJsKQogICAgICAoZGVzY3JpcHRpb24gIlN1Z2dlc3QgJ21pcnJvcjovLycg VVJMcyIpCmRpZmYgLS1naXQgYS90ZXN0cy9saW50LnNjbSBiL3Rlc3RzL2xpbnQuc2NtCmluZGV4 IGZhZTM0NmU3MjQuLjRlZjQwMGE5YTAgMTAwNjQ0Ci0tLSBhL3Rlc3RzL2xpbnQuc2NtCisrKyBi L3Rlc3RzL2xpbnQuc2NtCkBAIC05LDYgKzksNyBAQAogOzs7IENvcHlyaWdodCDCqSAyMDE4LCAy MDE5IEFydW4gSXNhYWMgPGFydW5pc2FhY0BzeXN0ZW1yZWJvb3QubmV0PgogOzs7IENvcHlyaWdo dCDCqSAyMDIwIFRpbW90aHkgU2FtcGxlIDxzYW1wbGV0QG5neXJvLmNvbT4KIDs7OyBDb3B5cmln aHQgwqkgMjAyMSBYaW5nbHUgQ2hlbiA8cHVibGljQHlvY3RvY2VsbC54eXo+Cis7OzsgQ29weXJp Z2h0IMKpIDIwMjEgTWF4aW1lIERldm9zIDxtYXhpbWVkZXZvc0B0ZWxlbmV0LmJlPgogOzs7CiA7 OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTM4LDcgKzM5LDcgQEAK ICAgIzp1c2UtbW9kdWxlIChndWl4IGxpbnQpCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCB1aSkKICAg Izp1c2UtbW9kdWxlIChndWl4IHN3aCkKLSAgIzp1c2UtbW9kdWxlICgoZ3VpeCBnZXhwKSAjOnNl bGVjdCAobG9jYWwtZmlsZSkpCisgICM6dXNlLW1vZHVsZSAoKGd1aXggZ2V4cCkgIzpzZWxlY3Qg KGdleHAgbG9jYWwtZmlsZSBnZXhwPykpCiAgICM6dXNlLW1vZHVsZSAoKGd1aXggdXRpbHMpICM6 c2VsZWN0IChjYWxsLXdpdGgtdGVtcG9yYXJ5LWRpcmVjdG9yeSkpCiAgICM6dXNlLW1vZHVsZSAo KGd1aXggaW1wb3J0IGhhY2thZ2UpICM6c2VsZWN0ICglaGFja2FnZS11cmwpKQogICAjOnVzZS1t b2R1bGUgKChndWl4IGltcG9ydCBzdGFja2FnZSkgIzpzZWxlY3QgKCVzdGFja2FnZS11cmwpKQpA QCAtNzQ0LDYgKzc0NSw4MCBAQAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzaGEy NTYgJW51bGwtc2hhMjU2KSkpKSkpCiAgICAgKGNoZWNrLXNvdXJjZS11bnN0YWJsZS10YXJiYWxs IHBrZykpKQogCisoZGVmaW5lIChwYWNrYWdlLXdpdGgtcGhhc2UtY2hhbmdlcyBjaGFuZ2VzKQor ICAoZHVtbXktcGFja2FnZSAieCIKKyAgICAgICAgICAgICAgICAgKGFyZ3VtZW50cyBgKCM6cGhh c2VzCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAsKGlmIChnZXhwPyBjaGFuZ2VzKQor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjfihtb2RpZnktcGhhc2VzICVzdGFu ZGFyZC1waGFzZXMKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICMkQGNo YW5nZXMpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGAobW9kaWZ5LXBoYXNl cyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICxAY2hhbmdlcykpKSkpKQorCisodGVzdC1lcXVhbCAib3B0aW9uYWwtdGVzdHM6IG5vIGNoZWNr IHBoYXNlIgorICAnKCkKKyAgKGxldCAoKHBrZyAocGFja2FnZS13aXRoLXBoYXNlLWNoYW5nZXMg JygpKSkpCisgICAgKGNoZWNrLW9wdGlvbmFsLXRlc3RzIHBrZykpKQorCisodGVzdC1lcXVhbCAi b3B0aW9uYWwtdGVzdHM6IGNoZWNrIHBoYXNlIHJlc3BlY3RzICM6dGVzdHM/IgorICAnKCkKKyAg KGxldCAoKHBrZyAocGFja2FnZS13aXRoLXBoYXNlLWNoYW5nZXMKKyAgICAgICAgICAgICAgJygo cmVwbGFjZSAnY2hlY2sKKyAgICAgICAgICAgICAgICAgIChsYW1iZGEqICgjOmtleSB0ZXN0cz8g IzphbGxvdy1vdGhlci1rZXlzPykKKyAgICAgICAgICAgICAgICAgICAgKHdoZW4gdGVzdHM/Cisg ICAgICAgICAgICAgICAgICAgICAgKGludm9rZSAiLi90aGUtdGVzdC1zdWl0ZSIpKSkpKSkpKQor ICAgIChjaGVjay1vcHRpb25hbC10ZXN0cyBwa2cpKSkKKworKHRlc3QtZXF1YWwgIm9wdGlvbmFs LXRlc3RzOiBjaGVjayBwaGFzZSBpZ25vcmVzICM6dGVzdHM/IgorICAidGhlICdjaGVjaycgcGhh c2Ugc2hvdWxkIHJlc3BlY3QgIzp0ZXN0cz8iCisgIChsZXQgKChwa2cgKHBhY2thZ2Utd2l0aC1w aGFzZS1jaGFuZ2VzCisgICAgICAgICAgICAgICcoKHJlcGxhY2UgJ2NoZWNrCisgICAgICAgICAg ICAgICAgICAobGFtYmRhIF8KKyAgICAgICAgICAgICAgICAgICAgKGludm9rZSAiLi90aGUtdGVz dC1zdWl0ZSIpKSkpKSkpCisgICAgKHNpbmdsZS1saW50LXdhcm5pbmctbWVzc2FnZQorICAgICAo Y2hlY2stb3B0aW9uYWwtdGVzdHMgcGtnKSkpKQorCisodGVzdC1lcXVhbCAib3B0aW9uYWwtdGVz dHM6IGRvIG5vdCBjcmFzaCB3aGVuICM6cGhhc2VzIGlzIGludmFsaWQiCisgICJpbmNvcnJlY3Qg Y2FsbCB0byDigJhtb2RpZnktcGhhc2Vz4oCZIgorICAobGV0ICgocGtnIChwYWNrYWdlLXdpdGgt cGhhc2UtY2hhbmdlcyAndGhpcy1pcy1ub3QtYS1saXN0KSkpCisgICAgKHNpbmdsZS1saW50LXdh cm5pbmctbWVzc2FnZQorICAgICAoY2hlY2stb3B0aW9uYWwtdGVzdHMgcGtnKSkpKQorCisodGVz dC1lcXVhbCAib3B0aW9uYWwtdGVzdHM6IGFsbG93IEctZXhwcyAobm8gd2FybmluZykiCisgICco KQorICAobGV0ICgocGtnIChwYWNrYWdlLXdpdGgtcGhhc2UtY2hhbmdlcyAjfigpKSkpCisgICAg KGNoZWNrLW9wdGlvbmFsLXRlc3RzIHBrZykpKQorCisodGVzdC1lcXVhbCAib3B0aW9uYWwtdGVz dHM6IGFsbG93IEctZXhwcyAod2FybmluZykiCisgICJ0aGUgJ2NoZWNrJyBwaGFzZSBzaG91bGQg cmVzcGVjdCAjOnRlc3RzPyIKKyAgKGxldCAoKHBrZyAocGFja2FnZS13aXRoLXBoYXNlLWNoYW5n ZXMKKyAgICAgICAgICAgICAgI34oKHJlcGxhY2UgJ2NoZWNrCisgICAgICAgICAgICAgICAgICAg KGxhbWJkYSBfCisgICAgICAgICAgICAgICAgICAgICAoaW52b2tlICIvdGhlLXRlc3Qtc3VpdGUi KSkpKSkpKQorICAgIChzaW5nbGUtbGludC13YXJuaW5nLW1lc3NhZ2UKKyAgICAgKGNoZWNrLW9w dGlvbmFsLXRlc3RzIHBrZykpKSkKKworKHRlc3QtZXF1YWwgIm9wdGlvbmFsLXRlc3RzOiBjb21w bGljYXRlZCAnY2hlY2snIHBoYXNlIgorICAidGhlICdjaGVjaycgcGhhc2Ugc2hvdWxkIHJlc3Bl Y3QgIzp0ZXN0cz8iCisgIChsZXQgKChwa2cgKHBhY2thZ2Utd2l0aC1waGFzZS1jaGFuZ2VzCisg ICAgICAgICAgICAgICcoKHJlcGxhY2UgJ2NoZWNrCisgICAgICAgICAgICAgICAgICAobGFtYmRh KiAoIzprZXkgaW5wdXRzIHRlc3RzPyAjOmFsbG93LW90aGVyLWtleXMpCisgICAgICAgICAgICAg ICAgICAgIChsZXQgKChzb21ldGhpbmcgKHN0dWZmIGZyb20gaW5wdXRzIG9yIG5hdGl2ZS1pbnB1 dHMpKSkKKyAgICAgICAgICAgICAgICAgICAgICAoZGVsZXRlLWZpbGUgImRhdGV1dGlsL3Rlc3Qv dGVzdF91dGlscy5weSIpCisgICAgICAgICAgICAgICAgICAgICAgKGludm9rZSAicHl0ZXN0IiAi LXZ2IikpKSkpKSkpCisgICAgKHNpbmdsZS1saW50LXdhcm5pbmctbWVzc2FnZQorICAgICAoY2hl Y2stb3B0aW9uYWwtdGVzdHMgcGtnKSkpKQorCisodGVzdC1lcXVhbCAib3B0aW9uYWwtdGVzdHM6 ICdjaGVjaycgcGhhc2UgaXMgbm90IGZpcnN0IHBoYXNlIgorICAidGhlICdjaGVjaycgcGhhc2Ug c2hvdWxkIHJlc3BlY3QgIzp0ZXN0cz8iCisgIChsZXQgKChwa2cgKHBhY2thZ2Utd2l0aC1waGFz ZS1jaGFuZ2VzCisgICAgICAgICAgICAgICcoKGFkZC1hZnRlciAndW5wYWNrCisgICAgICAgICAg ICAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAgICAgICAgICAgIChjaGRpciAibGlidGVz dGNhc2UtMC4wLjAiKSkpCisgICAgICAgICAgICAgICAgKHJlcGxhY2UgJ2NoZWNrCisgICAgICAg ICAgICAgICAgICAobGFtYmRhIF8gKGludm9rZSAiLi90ZXN0LXN1aXRlIikpKSkpKSkKKyAgICAo c2luZ2xlLWxpbnQtd2FybmluZy1tZXNzYWdlCisgICAgIChjaGVjay1vcHRpb25hbC10ZXN0cyBw a2cpKSkpCisKICh0ZXN0LWVxdWFsICJzb3VyY2U6IDIwMCIKICAgJygpCiAgICh3aXRoLWh0dHAt c2VydmVyIGAoKDIwMCAsJWxvbmctc3RyaW5nKSkKLS0gCjIuMzIuMAoK --=-yWm4rju4VxtiXUuUDipg-- --=-ce0ZMArvV6NrAugx+U+G Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYNxIHRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lQfAP9IgkU3DnISH3cWxQCopB3aJh3i DL5fPJcnW41fT5k3xAEAiD21lY7yA4HxQibRtNg9iFhNhmuNaasPo4nPInrfQQM= =2wb0 -----END PGP SIGNATURE----- --=-ce0ZMArvV6NrAugx+U+G-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 30 07:55:42 2021 Received: (at 48320-done) by debbugs.gnu.org; 30 Jun 2021 11:55:42 +0000 Received: from localhost ([127.0.0.1]:56599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyYog-0005U3-MG for submit@debbugs.gnu.org; Wed, 30 Jun 2021 07:55:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyYof-0005Tr-Gm for 48320-done@debbugs.gnu.org; Wed, 30 Jun 2021 07:55:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35538) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyYoZ-0008KF-7a; Wed, 30 Jun 2021 07:55:35 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=57696 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyYoY-0003fr-W5; Wed, 30 Jun 2021 07:55:35 -0400 From: Mathieu Othacehe To: Maxime Devos Subject: Re: [PATCH v3] lint: Verify if #:tests? is respected in the 'check' phase. References: <2b0fee1845a66e1fb126b4bbf1c9892b7c648a3a.camel@telenet.be> <44f0c8b823b0f6f8e5388ff6c1d90e76fa09bf2c.camel@telenet.be> <87h7hhvu0n.fsf@gnu.org> Date: Wed, 30 Jun 2021 13:55:32 +0200 In-Reply-To: (Maxime Devos's message of "Wed, 30 Jun 2021 12:31:57 +0200") Message-ID: <87pmw3lg7f.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48320-done Cc: 48320-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, > Indeed. I added a test case and replaced "or" with "append". The linter > now detects about 300 additional cases. Great, pushed on master. We now have some work to fix those ~600 packages! Thanks, Mathieu From unknown Fri Aug 15 12:49:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 29 Jul 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator