Subject: Re: bug#48319: [PATCH] Check if #:tests? is unconditionally #t; not acceptable when cross-compiling

From: Mathieu Othacehe <[email-masked]>
Date: Fri, 04 Jun 2021 14:50:53 +0200

Hello Maxime,

> +                          ;; TRANSLATORS: #:tests? and #t are Scheme constants
> +                          ;; and must not be translated.
> +                          (G_ "#:tests? does not need to be explicitly set to #t")
> +                          #:field 'arguments))

This patch looks fine, and I remember fixing multiple packages failing
to cross-compile because #:tests was hard-coded to #t.

I'm not sure about the warning message though. What about:

"#:tests? must not be explicitly set to #t"

as "does not need" implies it could be sometimes correct, whereas it is
always a mistake.

WDYT?

Thanks,

Mathieu