GNU bug report logs - #48302
[PATCH] Abbreviate `find' properties in M-x rgrep on MS Windows

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Sat, 8 May 2021 22:18:01 UTC

Severity: normal

Tags: patch

Done: Michael Albinus <michael.albinus <at> gmx.de>

Bug is archived. No further changes may be made.

Full log


Message #20 received at 48302 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 48302 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] Re: bug#48302: [PATCH] Abbreviate `find' properties
 in M-x rgrep on MS Windows
Date: Tue, 11 May 2021 09:11:01 +0200
Jim Porter <jporterbugs <at> gmail.com> writes:

Hi Jim,

> Thanks for the pointers. Attached is an updated patch that tests the 4
> cases you described.

Thanks. LGTM. Just one nit:

> +    (should (equal (grep-tests--get-rgrep-abbreviation) nil))))

This is (should-not (grep-tests--get-rgrep-abbreviation))

Eli, do you have further comments? Otherwise, I would commit it in Jim's
name.

Best regards, Michael.




This bug report was last modified 4 years and 11 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.