GNU bug report logs - #48302
[PATCH] Abbreviate `find' properties in M-x rgrep on MS Windows

Previous Next

Full log

Message #11 received at 48302 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 48302 <at> debbugs.gnu.org
Subject: Re: bug#48302: [PATCH] Abbreviate `find' properties in M-x rgrep on
 MS Windows
Date: Sun, 9 May 2021 13:07:42 -0700

[Message part 1 (text/plain, inline)]

On Sat, May 8, 2021 at 11:53 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> Thanks, but could you also add a test for this issue to the test
> suite?

I see some grep-related tests in
`test/lisp/progmodes/compile-tests.el', but those only cover
`grep-regexp-alist', not `grep-mode-font-lock-keywords'. Testing
grep.el's font-lock didn't seem like it would belong in
`compile-tests.el', so I've added `test/lisp/progmodes/grep-tests.el'
and included a (very) simple test for find-abbreviation. It uses the
shell-quoting semantics of whatever the current system is; it would be
nice to test all shell-quoting styles in one test run, but I wasn't
sure how to do that. Still, if automated tests are run on multiple
platforms, this should (hopefully) catch any bugs.

My Elisp skills are fairly basic, so I may have made some mistakes
here. Just let me know what (if anything) needs improved for the
tests.

[0001-Abbreviate-rgrep-command-when-using-MS-Windows-style.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.