GNU bug report logs - #48280
28.0.50; Fix moving directories with the same name to trash

Previous Next

Package: emacs;

Reported by: Codruț Constantin Gușoi <mail <at> codrut.pro>

Date: Fri, 7 May 2021 20:00:02 UTC

Severity: normal

Tags: fixed, patch

Merged with 47960

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Codruț Constantin Gușoi <mail <at> codrut.pro>
To: 48280 <at> debbugs.gnu.org
Subject: bug#48280: 28.0.50; Fix moving directories with the same name to trash
Date: Fri, 07 May 2021 19:31:23 +0000
[Message part 1 (text/plain, inline)]
Hello,

I've attached a patch for this bug I was dealing with while trying out
28.0.50 commit a2842a11728336fc8110eedb5176ecfbe71bbc79.

Refs: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47135
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47135>

To reproduce, save this to a `bug.el` file:

```elisp

(setq delete-by-moving-to-trash t)

(let ((test-dir "~/test123"))
   (progn
     (message "Creating directory: 1")
     (make-directory test-dir)
     (message "Deleting directory: 1")
     (delete-directory test-dir t t)

     (message "Creating directory: 2")
     (make-directory test-dir)
     (message "Deleting directory: 2")
     (delete-directory test-dir t t)

     (message "Success!")))
```

And execute with: `emacs -nw -Q -l ./bug.el`.

Expected: "Success!"
Actual: "Renaming: Not a directory, /home/me/test123,
/home/me/.local/share/Trash/files/test123Wiibmk"

Please let me know what you think, looking forward to getting this fixed.

Cheers,
Codruț

www.codrut.pro
[0001-Fix-moving-directories-with-the-same-name-to-trash.patch (text/x-patch, attachment)]

This bug report was last modified 4 years and 57 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.