From debbugs-submit-bounces@debbugs.gnu.org Fri May 07 08:22:29 2021 Received: (at submit) by debbugs.gnu.org; 7 May 2021 12:22:29 +0000 Received: from localhost ([127.0.0.1]:43581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lezUz-00068P-CG for submit@debbugs.gnu.org; Fri, 07 May 2021 08:22:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:34606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lezUx-00068J-Da for submit@debbugs.gnu.org; Fri, 07 May 2021 08:22:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lezUx-0007HG-7k for guix-patches@gnu.org; Fri, 07 May 2021 08:22:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45260) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lezUw-00065A-42; Fri, 07 May 2021 08:22:26 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41568 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lezUv-0005ra-Sy; Fri, 07 May 2021 08:22:26 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH] gnu: ocaml: Depend on libiberty. Date: Fri, 7 May 2021 14:22:18 +0200 Message-Id: <20210507122218.25615-1-ludo@gnu.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Debbugs-Cc: Julien Lepiller Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) From: Ludovic Courtès Currently gcc:lib does not include libiberty so this change restores the initial intent. * gnu/packages/ocaml.scm (ocaml-4.11)[inputs]: Replace "gcc:lib" by "libiberty". --- gnu/packages/ocaml.scm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Hi there! I noticed that “guix graph ocaml” looked weird; this change clarifies the original intent. In fact, the addition of gcc:lib was useless AFAICS: --8<---------------cut here---------------start------------->8--- $ guix build -e '(@@ (gnu packages commencement) gcc-final)' /gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7.5.0-lib /gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0 $ ls /gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7.5.0-lib/lib/*ibert* ls: ne eblas atingi '/gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7.5.0-lib/lib/*ibert*': Dosiero aŭ dosierujo ne ekzistas --8<---------------cut here---------------end--------------->8--- With this change I see that libiberty is indeed used while building ocaml@4.11: --8<---------------cut here---------------start------------->8--- ../boot/ocamlrun ../boot/ocamlc -g -nostdlib -I ../boot -use-prims ../runtime/primitives -I .. -c -absname -w +a-4-9-41-42-44-45-48 -strict-sequence -warn-error A -principal -safe-string -strict-formats -bin-annot -I ../utils -I ../parsing -I ../typing -I ../bytecomp -I ../middle_end -I ../middle_end/closure -I ../middle_end/flambda -I ../middle_end/flambda/base_types -I ../driver -I ../toplevel -I ../file_formats -I ../lambda - opnames.ml gcc -O2 -fno-strict-aliasing -fwrapv -Wall -Wdeclaration-after-statement -fno-common -fexcess-precision=standard -fno-tree-vrp -ffunction-sections -o objinfo_helper objinfo_helper.o -lbfd -ldl -liberty -lz --8<---------------cut here---------------end--------------->8--- There’s no ‘-liberty’ in the build log of 4.09 though. According to ‘guix refresh -l ocaml ocaml@4.09’, this change is OK for ‘master’. Thoughts? Ludo’. diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm index 427ea38ccc..272f5bf268 100644 --- a/gnu/packages/ocaml.scm +++ b/gnu/packages/ocaml.scm @@ -200,8 +200,7 @@ This package produces a native @command{ocamlc} and a bytecode @command{ocamllex ("pkg-config" ,pkg-config))) (inputs `(("libx11" ,libx11) - ;; For libiberty, needed for objdump support. - ("gcc:lib" ,(canonical-package gcc) "lib") + ("libiberty" ,libiberty) ;needed for objdump support ("zlib" ,zlib))) ;also needed for objdump support (arguments `(#:phases -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Fri May 07 08:52:28 2021 Received: (at 48275) by debbugs.gnu.org; 7 May 2021 12:52:28 +0000 Received: from localhost ([127.0.0.1]:43713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lezxz-0006Qj-TT for submit@debbugs.gnu.org; Fri, 07 May 2021 08:52:28 -0400 Received: from lepiller.eu ([89.234.186.109]:36566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lezxx-0006Qa-8F for 48275@debbugs.gnu.org; Fri, 07 May 2021 08:52:26 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 0973d9c8; Fri, 7 May 2021 12:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:cc:from:message-id; s= dkim; bh=uYBpXx+/JQdlvu3xi8BG4RmVRaWEocmQiXysgi8TWmo=; b=ScFySq8 517D2LNco98JAOMp5cw+y73GwdQQczQq9PGEU3QIOsn747V3wsOP452xEKpT4gen 7w3d6raRtYhS0ou2SeKYvC/2F1Xb8KTZK92dbpDZ93ry+gW540io+KPjjKyq+24P tYco8LU209/t0aLjhshtQ3aiHeowBkKCozXHjjGJ+3BIflJvNy5+gJ7nEX+RTn+u GVgZUQs5nuRdlwlrLBlCkSvwpW9MlUdxvj+IQLRdDbWZ8UtorSjDq5cvqyxZ173Q gYrPpJNkAbiqrMzJS0GxM9aGUWU6MH/TwUyPC+KKHk+PtoT/akSKri8nOU6tr4Yp 3Tw4vXnxJQLCpMA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id be289fec (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 7 May 2021 12:52:22 +0000 (UTC) Date: Fri, 07 May 2021 08:52:13 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20210507122218.25615-1-ludo@gnu.org> References: <20210507122218.25615-1-ludo@gnu.org> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----ZYR170UADF0EET6EMPFL7XI05RCZEM" Content-Transfer-Encoding: 7bit Subject: Re: [bug#48275] [PATCH] gnu: ocaml: Depend on libiberty. To: =?ISO-8859-1?Q?Ludovic_Court=E8s?= ,48275@debbugs.gnu.org From: Julien Lepiller Message-ID: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48275 Cc: =?ISO-8859-1?Q?Ludovic_Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------ZYR170UADF0EET6EMPFL7XI05RCZEM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable LGTM, thanks ! Le 7 mai 2021 08:22:18 GMT-04:00, "Ludovic Court=C3=A8s" = a =C3=A9crit : >From: Ludovic Court=C3=A8s > >Currently gcc:lib does not include libiberty so this change restores >the >initial intent=2E > >* gnu/packages/ocaml=2Escm (ocaml-4=2E11)[inputs]: Replace "gcc:lib" by >"libiberty"=2E >--- > gnu/packages/ocaml=2Escm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >Hi there! > >I noticed that =E2=80=9Cguix graph ocaml=E2=80=9D looked weird; this chan= ge clarifies >the original intent=2E In fact, the addition of gcc:lib was useless >AFAICS: > >--8<---------------cut here---------------start------------->8--- >$ guix build -e '(@@ (gnu packages commencement) gcc-final)' >/gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7=2E5=2E0-lib >/gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7=2E5=2E0 >$ ls >/gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7=2E5=2E0-lib/lib/*ibert* >ls: ne eblas atingi >'/gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7=2E5=2E0-lib/lib/*ibert= *': >Dosiero a=C5=AD dosierujo ne ekzistas >--8<---------------cut here---------------end--------------->8--- > >With this change I see that libiberty is indeed used while building >ocaml@4=2E11: > >--8<---------------cut here---------------start------------->8--- >=2E=2E/boot/ocamlrun =2E=2E/boot/ocamlc -g -nostdlib -I =2E=2E/boot -use-= prims >=2E=2E/runtime/primitives -I =2E=2E -c -absname -w +a-4-9-41-42-44-45-48 >-strict-sequence -warn-error A -principal -safe-string -strict-formats >-bin-annot -I =2E=2E/utils -I =2E=2E/parsing -I =2E=2E/typing -I =2E=2E/b= ytecomp -I >=2E=2E/middle_end -I =2E=2E/middle_end/closure -I =2E=2E/middle_end/flamb= da -I >=2E=2E/middle_end/flambda/base_types -I =2E=2E/driver -I =2E=2E/toplevel = -I >=2E=2E/file_formats -I =2E=2E/lambda - opnames=2Eml >gcc -O2 -fno-strict-aliasing -fwrapv -Wall >-Wdeclaration-after-statement -fno-common -fexcess-precision=3Dstandard >-fno-tree-vrp -ffunction-sections -o objinfo_helper objinfo_helper=2Eo >-lbfd -ldl -liberty -lz >--8<---------------cut here---------------end--------------->8--- > >There=E2=80=99s no =E2=80=98-liberty=E2=80=99 in the build log of 4=2E09 = though=2E > >According to =E2=80=98guix refresh -l ocaml ocaml@4=2E09=E2=80=99, this c= hange is OK >for =E2=80=98master=E2=80=99=2E > >Thoughts? > >Ludo=E2=80=99=2E > >diff --git a/gnu/packages/ocaml=2Escm b/gnu/packages/ocaml=2Escm >index 427ea38ccc=2E=2E272f5bf268 100644 >--- a/gnu/packages/ocaml=2Escm >+++ b/gnu/packages/ocaml=2Escm >@@ -200,8 +200,7 @@ This package produces a native @command{ocamlc} and >a bytecode @command{ocamllex > ("pkg-config" ,pkg-config))) > (inputs > `(("libx11" ,libx11) >- ;; For libiberty, needed for objdump support=2E >- ("gcc:lib" ,(canonical-package gcc) "lib") >+ ("libiberty" ,libiberty) ;needed for objdump >support >("zlib" ,zlib))) ;also needed for objdump support > (arguments > `(#:phases >--=20 >2=2E31=2E1 ------ZYR170UADF0EET6EMPFL7XI05RCZEM Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable LGTM, thanks !

L= e 7 mai 2021 08:22:18 GMT-04:00, "Ludovic Court=C3=A8s" <ludo@gnu=2Eorg&= gt; a =C3=A9crit :
From: Ludovic Court=C3=A8s <ludovic=2Ecourtes@inr=
ia=2Efr>

Currently gcc:lib does not include libiberty so this cha=
nge restores the
initial intent=2E

* gnu/packages/ocaml=2Escm (oc=
aml-4=2E11)[inputs]: Replace "gcc:lib" by
"libiberty"=2E
 gnu/package=
s/ocaml=2Escm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Hi there!

I noticed that =E2=80=9Cguix graph ocaml=E2=80=9D loo=
ked weird; this change clarifies
the original intent=2E  In fact, the ad=
dition of gcc:lib was useless AFAICS:

--8<---------------cut here=
---------------start------------->8---
$ guix build -e '(@@ (gnu pack=
ages commencement) gcc-final)'
/gnu/store/01b4w3m6mp55y531kyi1g8shh722kw=
qm-gcc-7=2E5=2E0-lib
/gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7=
=2E5=2E0
$ ls /gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7=2E5=2E0-=
lib/lib/*ibert*
ls: ne eblas atingi '/gnu/store/01b4w3m6mp55y531kyi1g8sh=
h722kwqm-gcc-7=2E5=2E0-lib/lib/*ibert*': Dosiero a=C5=AD dosierujo ne ekzis=
tas
--8<---------------cut here---------------end--------------->8=
---

With this change I see that libiberty is indeed used while build=
ing
ocaml@4=2E11:

--8<---------------cut here---------------st=
art------------->8---
=2E=2E/boot/ocamlrun =2E=2E/boot/ocamlc -g -nos=
tdlib -I =2E=2E/boot -use-prims =2E=2E/runtime/primitives -I =2E=2E -c -abs=
name -w +a-4-9-41-42-44-45-48 -strict-sequence -warn-error A -principal -sa=
fe-string -strict-formats -bin-annot -I =2E=2E/utils -I =2E=2E/parsing -I =
=2E=2E/typing -I =2E=2E/bytecomp -I =2E=2E/middle_end -I =2E=2E/middle_end/=
closure -I =2E=2E/middle_end/flambda -I =2E=2E/middle_end/flambda/base_type=
s -I =2E=2E/driver -I =2E=2E/toplevel -I =2E=2E/file_formats -I =2E=2E/lamb=
da - opnames=2Eml
gcc  -O2 -fno-strict-aliasing -fwrapv -Wall -Wdeclarat=
ion-after-statement -fno-common -fexcess-precision=3Dstandard -fno-tree-vrp=
 -ffunction-sections -o objinfo_helper objinfo_helper=2Eo -lbfd -ldl  -libe=
rty -lz
--8<---------------cut here---------------end---------------&=
gt;8---

There=E2=80=99s no =E2=80=98-liberty=E2=80=99 in the build l=
og of 4=2E09 though=2E

According to =E2=80=98guix refresh -l ocaml o=
caml@4=2E09=E2=80=99, this change is OK
for =E2=80=98master=E2=80=99=2E<=
br>
Thoughts?

Ludo=E2=80=99=2E

diff --git a/gnu/packages/o=
caml=2Escm b/gnu/packages/ocaml=2Escm
index 427ea38ccc=2E=2E272f5bf268 1=
00644
--- a/gnu/packages/ocaml=2Escm
+++ b/gnu/packages/ocaml=2Escm@@ -200,8 +200,7 @@ This package produces a native @command{ocamlc} and a=
 bytecode @command{ocamllex
        ("pkg-config" ,pkg-config)))
    =
 (inputs
      `(("libx11" ,libx11)
-       ;; For libiberty, needed =
for objdump support=2E
-       ("gcc:lib" ,(canonical-package gcc) "lib"=
)
+       ("libiberty" ,libiberty)               ;needed for objdump sup=
port
        ("zlib" ,zlib)))                       ;also needed for obj=
dump support
     (arguments
      `(#:phases
------ZYR170UADF0EET6EMPFL7XI05RCZEM-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 17:53:12 2021 Received: (at 48275-done) by debbugs.gnu.org; 9 May 2021 21:53:12 +0000 Received: from localhost ([127.0.0.1]:56721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfrMO-00048i-6z for submit@debbugs.gnu.org; Sun, 09 May 2021 17:53:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfrMM-00048V-6w for 48275-done@debbugs.gnu.org; Sun, 09 May 2021 17:53:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45292) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfrMG-00018F-Se; Sun, 09 May 2021 17:53:04 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60710 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfrMG-0004A5-K6; Sun, 09 May 2021 17:53:04 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Julien Lepiller Subject: Re: bug#48275: [PATCH] gnu: ocaml: Depend on libiberty. References: <20210507122218.25615-1-ludo@gnu.org> Date: Sun, 09 May 2021 23:53:03 +0200 In-Reply-To: (Julien Lepiller's message of "Fri, 07 May 2021 08:52:13 -0400") Message-ID: <87zgx360cg.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48275-done Cc: 48275-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Julien Lepiller skribis: > LGTM, thanks ! Pushed as 28ae35850357acfda42d3c82c29df37149a6b8d0, thank you. Ludo=E2=80=99. From unknown Tue Jun 17 22:12:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 07 Jun 2021 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator