From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 19:23:18 2021 Received: (at submit) by debbugs.gnu.org; 6 May 2021 23:23:18 +0000 Received: from localhost ([127.0.0.1]:40343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lenKw-0002Bj-FX for submit@debbugs.gnu.org; Thu, 06 May 2021 19:23:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:47444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lenKt-0002Bc-2n for submit@debbugs.gnu.org; Thu, 06 May 2021 19:23:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lenKs-0005gW-TH for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 19:23:14 -0400 Received: from mout.gmx.net ([212.227.17.20]:36461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lenKq-0005EH-Ug for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 19:23:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620343391; bh=HPethnI2fKuAuLM2w2EP5w6MNEDL6ZQ7q+HAMlPyK+M=; h=X-UI-Sender-Class:Date:From:To:Subject; b=HdTSM2CiLeNITChuhwi0wt4Qp/Ypx5xMtytnG6yuwvcMqnmBAxOFASJy3+DCGZVv3 9O4IOw0DLiuhQAO2H6+kNQIXqiC7GcsHZm2WYRgvFgLu+U7MyYxWNHVMoTGlAT93lE Dbjxg6W8zIRBNiB45Rh4Ia3j7rZ+h1vLkZrU8/NI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N3bSt-1lWr0P2kTr-010euo for ; Fri, 07 May 2021 01:23:10 +0200 Date: Thu, 6 May 2021 19:23:08 -0400 From: Boruch Baum To: Emacs Bug Reporting Subject: 27.1: log-edit-generate-changelog-from-diff FAILURE Message-ID: <20210506232308.cd6dfmj566mbzczz@E15-2016.optimum.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:crD79lMo/1/oUFmCNAavSHLR5TaleqnGFBZWKmy3mPkVgffiGNs dUpSeey4SZQ4BwHuGj4J5Gnav8CfzzxurvHUF+vTOxAcKpeVhbwWoj/5oAnAjICu+ap57ez Wwol+MnDz+5fj32xpBZzmeUKLd4RFhJC5B+/nVGLG4S7H0Qy1HasY3NSQOqk9LOcORMDX9h q41YPQpwvcP4Y9AhirZaA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:4v4H3QngWAk=:KYpk2xsbUDd2LBEpefJvlo etbUdo01VGbPQXiNlUJXe6ijo3WQB8PUa5Jx2xSX1FnddFwLKPywxnbQIpNMLlsQ9REveVjzg kyxMlOrgPNH8KLSt8u2qOJxiNRDofKpQv8lKGhUO4V28BVOPU4QBoputip0ueh1uOcCuy9cSs hocHE9xGeALrSh24e0MUUSAryfGwvPM8v1WSFxZepSTjCZXsTfBuY3l6sFOwA1qPut+1XEskI 0HkQm+/15DDjLZaartfJBWiPxyShR4RIYQPMhU9ePlnporyOfRU4SDlMjMwPZp+GuCwfd8voA r3bceCAwJjkwX7/VJnWbVrWDw3iKUxpVvB+gDzuteBLoAUs5ypcAKAEZ4tZcE6i8x4e0X/bVk 68GKsguiL75u6wBvv+yWEFgWm4JHJEQfACNaJwIAcmVKbvJSwGN3QHB13rees1ZMYRESZ5J4A WDR/RKJkavbooacK7ZEjiTFcxqSD3vV3eN0do6TQEFM8SNz/JyXL48WMBA/k83KSoHt4ijEty PjIlvsuihdzW6GnXbv3GoTZYqvHqrpkPl+SIH7q/lqJdTfmQ95tbx7pmkU3ZCkiu53v+caShp r5pG2tIuF2JoWROjB8roH5zqzOQkivQcFxNrFKzRw0o45xU+JIwOlYCXcw/QghkK8/4Bkbg0A Qjkjx59RbQlzmqS57CVZlRckCvytKib/N6jekVoF3e4WVsOdeoDda6EmnmoMEPEgcabZ/MKuX uIBWGViuQU0W28DQeZvv+Si5ufcgO46Eizj9IuBOagDlOr+6t77GP6PaoyetEl+zImx6MjWif ZXxnb1dSgw6Ke5odTqn6rtKCp63U9YYyTqoWpfSwFukWETYASklK1lyzh86WoSxELp5rKFcOd P9FTsMQl5kDOQ/MFNan4XdfUPtXdS/6AMbXdfG6uGY5mZ6lDg9hT4JfrKgSSiuwsnLJuz4hLw erkbSR8tHKjNhODwZQJM6w+HC8kOG9Hx8MFhqW821AVQJ8cILAd4s36TUHPTyqDW1jYCEiP4g 9U6cM0X5br1wXxw/ELkBgv4+4JPYOj+0EptJukmKuGxcrUAM7UsSbfDyF64QeqlgzNfDRFVdV YFyGjylT7RNClpnaQcaZ2ifEIb+l1e3OgDjdG+zXaGoQNjmj/vPanlC5C2s2+jOLesdm9Ih+q LcN6jG0cwejqJO/ZpXr4v3VHHmS6hWsAr1MrH+5b5VynC1ZXEsbZFIR1cYooEe+xas6+U= Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=212.227.17.20; envelope-from=boruch_baum@gmx.com; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2021-03-27, modified by Debian ref: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D47784#45 1] Attempting to run function log-edit-generate-changelog-from-diff returns an error message: 'Diff functionality has not been setup.' 2] The docstring for function log-edit-generate-changelog-from-diff gives no indication how to set up 'diff functionality' or otherwise guidance on how to use the function. 3] The source of the error message is function log-edit-show-diff. It, too, lacks a useful docstring. 4] The code in function log-edit-show-diff indicates that the configuration is performed via variable log-edit-diff-function. However: 4.1] That variable lacks a docstring. 4.2] Setting it to a 'reasonable' value of 'ediff returns an error (wrong-number-of-arguments (2 . 3) 0) At this point, I stopped chasing down the issue. Counting three documentation issues, one default configuration bug. If I'm the first end-user world-wide trying to use this, do I get a valuable prize? =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 21:26:40 2021 Received: (at 48269) by debbugs.gnu.org; 7 May 2021 01:26:40 +0000 Received: from localhost ([127.0.0.1]:40861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lepGK-0003Mi-6W for submit@debbugs.gnu.org; Thu, 06 May 2021 21:26:40 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:38459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lepGH-0003Ma-LZ for 48269@debbugs.gnu.org; Thu, 06 May 2021 21:26:38 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 6F4145C00DD; Thu, 6 May 2021 21:26:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 06 May 2021 21:26:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=pqiExniEkDWNUffTsETZlbjgqa WAHR3htm6iDFUFoyQ=; b=D6G0LKG4bs1Y3DjnQeeskaPVz7kw4wLZjLJkUX+zNI cN6yYz60NiArJzxEAbEheGi6kiX93uV8WKDYf0OH8QCLIUZQsm44aXV1MKv+nfUM Trm5vLJRIrsE+zm4MC15QBGwHZrbITCj46SjT3HEEUHYIs9CBv7OWKmLMwtjGeZE Mib1X4glUZDLd91vAATjE9g/J3CbpcvRDEl3A5dqw+nzcwRw8KDVls1qqCICUjuL OvneW8yGkDgzll6VqEqq3vLJpcHeHteqxrcdheCsh2Ug02E9Qt7PIHqBl8UdXnWG GqawFy84AgsxxfcCPeZZgqwZYgZPlJ+1W7rPXK4+BnHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=pqiExn iEkDWNUffTsETZlbjgqaWAHR3htm6iDFUFoyQ=; b=V8AwG9/5TRy0V6bHfVWmQx 7xQkfIx0Yc2rdZFIG73J4wQKUIGEWjuL6YvBpZQV8ExJKQoMEDz0pY6okOuogGHm ohNTzfG8aU8LXuTz+Cb1VOVhIMtKsq965PUBfUFZyPy4WxMd0cDfgiPzLR7p2jau Az1ZxVddUgRQwmcjKRxuOi8vK/JNopyvjxOO2xbVfyX+fVWiXKcc3sm17+e+Be0+ R6cZ1olksjRNRWkuLUIMXvZG3I9h55bxLBn2AVqZimSYwNMnUi78tSfYF3aUItIc +KfZ0cLl54uoeBx9CuPfs02U8pQK2LrgnNzjzQt4qgZ4W0stQEjuzuO2hnd3z2gA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeguddggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehttdertddtredtnecuhfhrohhmpefhihhlihhp phcuifhunhgsihhnuceofhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmheqnecuggftrf grthhtvghrnheptdffhefgffejtddvvdehueetheeiheegudeghffgueetgfdvfeeuudfh feduveeinecuffhomhgrihhnpehgnhhurdhorhhgnecukfhppeekfedruddtvddrudegje drudduheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehfghhunhgsihhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Received: from fgunbin.local (unknown [83.102.147.115]) by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 May 2021 21:26:31 -0400 (EDT) From: Filipp Gunbin To: Boruch Baum Subject: Re: bug#48269: 27.1: log-edit-generate-changelog-from-diff FAILURE In-Reply-To: <20210506232308.cd6dfmj566mbzczz@E15-2016.optimum.net> (Boruch Baum's message of "Thu, 6 May 2021 19:23:08 -0400") References: <20210506232308.cd6dfmj566mbzczz@E15-2016.optimum.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Date: Fri, 07 May 2021 04:26:29 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48269 Cc: 48269@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 06/05/2021 19:23 -0400, Boruch Baum wrote: > GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, > cairo version 1.16.0) of 2021-03-27, modified by Debian > > ref: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47784#45 > > 1] Attempting to run function log-edit-generate-changelog-from-diff > returns an error message: 'Diff functionality has not been setup.' > > 2] The docstring for function log-edit-generate-changelog-from-diff > gives no indication how to set up 'diff functionality' or otherwise > guidance on how to use the function. > > 3] The source of the error message is function log-edit-show-diff. It, > too, lacks a useful docstring. > > 4] The code in function log-edit-show-diff indicates that the > configuration is performed via variable log-edit-diff-function. > However: > > 4.1] That variable lacks a docstring. > > 4.2] Setting it to a 'reasonable' value of 'ediff returns an error > (wrong-number-of-arguments (2 . 3) 0) Give an emacs -Q recipe? From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 22:47:31 2021 Received: (at 48269) by debbugs.gnu.org; 7 May 2021 02:47:31 +0000 Received: from localhost ([127.0.0.1]:41169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leqWZ-000499-Ao for submit@debbugs.gnu.org; Thu, 06 May 2021 22:47:31 -0400 Received: from mout.gmx.net ([212.227.17.20]:56117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leqWX-000493-RA for 48269@debbugs.gnu.org; Thu, 06 May 2021 22:47:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620355640; bh=yqKQTQzGmRviETVLIlp8c+M6T5tEDhuJH/zFhSRdYTM=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=PjD4P1gjA/6Yi0In7tof3ubddQpv0n6L3GPDst20P9RfQHJI4g7VBejz2mc2vHPz0 E5z88YuhuKnTi+RlTy/3qXaSLkQMs8igi69k+U0IZoxh+C1git2yhA80t2EmRgwoVy iyfojKeVUt3341mO0eqdHkmBFPuGF5JSS8gTNdNE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1M8ygY-1lZupy1BCA-006AWc; Fri, 07 May 2021 04:47:20 +0200 Date: Thu, 6 May 2021 22:47:17 -0400 From: Boruch Baum To: Filipp Gunbin Subject: Re: bug#48269: 27.1: log-edit-generate-changelog-from-diff FAILURE Message-ID: <20210507024717.rvxxe7fkbf2iloag@E15-2016.optimum.net> References: <20210506232308.cd6dfmj566mbzczz@E15-2016.optimum.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:wPm2dm3y+j9C45gDCjtnn4AJ6WPK+U6QU9dgN84B9gs8QmNK3Zj 8l83zFoUgvANjreWlq+tSwp+SBZT0lpEkXmbS4nVoTMaRlY/1HAKjlpOSJJeBybUeDLDcHK felGkIAp4AZvaQiFKcIhDnASw+x+9KZjAw0+DwNvK3BS8exPyB/u927WUqXiwJOas0ESrz5 7aiHxegxXqsRn2EUp4rGQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:dClbhMos5T8=:QM23UJb38wNBRLm4/Tj76I jSeg0NSNb0LNVzO//FDB9jQB4V8PKVS6rSnXGlVhmBG52+RtseNnoBZ7MCvPgbgVUTZVNeiWO q+T2B8DramPXh/7tyQXbsCmia9/vxP/eyvBipalDOvcWekddavJyDOTsATAyeEpoeBVvvIAHO 7dc8QxB4vMcdursSWIUM7exHvLML0JOYWWcBs2NAZUEpOkLHeB/EwUOVIepEIviaMO8MT14NO vxeKSO/9vxD22RKbGcQPPVJ25gTdOpsVyLDVVcGiGJNVrvOfuBrQcFqp7A4faqKKJppVpB5Oe dkMyxHOr5aMZUxdwjqbkVeHs0cPH7mg7q83+dAtl3vDEn7et9CaLbS7avTfJHsBTPGQG5wG+x VfkU7HKCyt7zitKfo6vxrKgRkF6BZZmBMWc0S+R9GV1iY0iEmNKFjmLj2eGKEuxgc8fyxEnow uuircl65AImxkBt3iRm9TZ01TFS10aSFfYN7hQY9NqbbdyqPr+mgt7S7w7vxmbgmXFiPlsqTg 403Dl376DDXM4Nl/2hM/VgHDxSg2+ne0IQ9c7t3/I8N9HgC986SMvkRbF7jfunBNMGf0Wnz0d Ff8Cz20rO5CxNHIK0JADcxldGjPiZ6yTfNXTOIW7U7qkNAH6/p5XZyyvE0aLFdMCDcLJUFKnO sTkuSoyrr7FwQNXweA6M8QVuQtsuoD0j/KuhHG5wg0R0nfMM0HFwD9l8dxNPwws1XAxfJ3oOP +eEhj43RYgQj4+kaZpO18hUnlrLzB02xnrixXVFDJWEjqdiVU2XZKycsJwGeko/WKi4y11PAu 4Cyjh62IGXxxJkRnavYlMXJ7tbcmFa+9sr9KglQu2CQgXuFxFLtX30Er9BtJkVtoOIEJeiTzs FPrke/Yutz6M+4Kje4shW0BgQGL7e9k5dcNbQeEJq7sC6I0cZ5/jH3bLV6Ps6/ys+xSUG3SnH gOdBU54nHW0QCJVdAVRdeXrGWF7ijQSoPPQ/BdT3JOaNhSujoQ4ZYDvyh7mntQ1CPqgKi64D/ 5rXpntY5lkPtgUzHM4pO52Smqe4/oaLmWq/lbU7gWvfwTmFFEazN1+lbRkKh+YYJz6Ix2KxnU 70t8Im3eD2JEN+Tc2JPnGwyXAUP9xG62YwhhImaBnkgHYzrumKks3VTxg35p1kQm8XxnmzxuW N3S4c8+rq9aBvj+Sj/5md/t2uUvU5b/CIEiUhGjNIVaWW96hiTRerl7bAoHkz/UUtwLAQ= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48269 Cc: 48269@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2021-05-07 04:26, Filipp Gunbin wrote: > Give an emacs -Q recipe? Really? OK. Fine... Revving up \emacs -Q -nw ... Performing now C-x f on a pre-existing elisp file ... Adding a few blank lines ... M-x log-edit-generate-changelog-from-diff Yep. Same result as reported. You don't want me to check the docstrings with "\emacs -Q", do you? =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From debbugs-submit-bounces@debbugs.gnu.org Fri May 07 02:21:11 2021 Received: (at 48269) by debbugs.gnu.org; 7 May 2021 06:21:11 +0000 Received: from localhost ([127.0.0.1]:42009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1letrL-0006fT-GV for submit@debbugs.gnu.org; Fri, 07 May 2021 02:21:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1letrH-0006fL-B9 for 48269@debbugs.gnu.org; Fri, 07 May 2021 02:21:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43718) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1letrC-0001GJ-6W; Fri, 07 May 2021 02:21:02 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1306 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1letrA-0002hH-Vl; Fri, 07 May 2021 02:21:02 -0400 Date: Fri, 07 May 2021 09:20:52 +0300 Message-Id: <83im3vcbej.fsf@gnu.org> From: Eli Zaretskii To: Boruch Baum In-Reply-To: <20210507024717.rvxxe7fkbf2iloag@E15-2016.optimum.net> (message from Boruch Baum on Thu, 6 May 2021 22:47:17 -0400) Subject: Re: bug#48269: 27.1: log-edit-generate-changelog-from-diff FAILURE References: <20210506232308.cd6dfmj566mbzczz@E15-2016.optimum.net> <20210507024717.rvxxe7fkbf2iloag@E15-2016.optimum.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48269 Cc: 48269@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 6 May 2021 22:47:17 -0400 > From: Boruch Baum > Cc: 48269@debbugs.gnu.org > > Revving up \emacs -Q -nw ... > Performing now C-x f on a pre-existing elisp file ... You mean, "C-x C-f", I presume? > Adding a few blank lines ... > M-x log-edit-generate-changelog-from-diff > > Yep. Same result as reported. So the problem seems to be that the doc strings don't say the command should be invoked from a *vc-log* buffer, is that right? The user manual explains that, so next time when the doc string is not enough, may I suggest to try looking up the command/variable in the manual? > You don't want me to check the docstrings with "\emacs -Q", do you? Please don't mock people when they ask clarifying questions about your bug reports. It probably means there's some misunderstanding or lack of information, and clearing that would help use fix the problems you report. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 12:55:31 2021 Received: (at 48269) by debbugs.gnu.org; 9 May 2021 16:55:31 +0000 Received: from localhost ([127.0.0.1]:56284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfmiJ-0003ki-6F for submit@debbugs.gnu.org; Sun, 09 May 2021 12:55:31 -0400 Received: from mout.gmx.net ([212.227.15.18]:53367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfmiF-0003kc-MF for 48269@debbugs.gnu.org; Sun, 09 May 2021 12:55:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620579318; bh=Ro0nwbSguCf/pfdSmcGm0syEqCG7Aq2UlQ7StSjKXFI=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=jEp1DJU4h/kTlFFjaAFJISdjyCFoyw/g6hAPZ7p9NZhrWZu8M+NfDYWC7zyVGnrSW 0BqdpZ/FN/1KrWnyk5U4FOJBJF8X4Jt4JuSFEFCKAvQ8MrYqTCLTWijYEwAD3Ayy2K hmNlwC1/7nEmmvP1ZhRCxPYGC0cyQVEeIu5O8oCs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([96.224.230.212]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MDywo-1lpirK0VuO-009yzi; Sun, 09 May 2021 18:55:18 +0200 Date: Sun, 9 May 2021 12:55:15 -0400 From: Boruch Baum To: Eli Zaretskii Subject: Re: bug#48269: 27.1: log-edit-generate-changelog-from-diff FAILURE Message-ID: <20210509165515.6vg4g3tobx2sok6f@E15-2016.optimum.net> References: <20210506232308.cd6dfmj566mbzczz@E15-2016.optimum.net> <20210507024717.rvxxe7fkbf2iloag@E15-2016.optimum.net> <83im3vcbej.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83im3vcbej.fsf@gnu.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:4FL0A8JGq2LIdCJrWVJO1qhmUDJqVRBH4pqltIdbEg+0ZfucTB0 0NY1eXNV0TlKoKQFNuHx91dOxjNH43fuGzZWuAKqnFj4+6AFesPbEnb6u4bEAlql898wBKt +VYkZ6bPonzja/sF/tvSfBeHcFZuikc8lyVFmSMo6eSXVkq1Z7aFwxGy2MRw8iKSJwTSWCP MOG9ixAUUYP/LviqTyjAA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ChYu96ykNQk=:PJqGKjEzAsC9+7IQP+03Vi zWoupLC74O1B4Wvho0RMjRLwFTa3w66VXTZ5wdePkvph8Ks477/XT+osQxhna+QLLvfeLaTZT P7V6G5c+O61E55jUkm28igfRRbV8xcjdlEw3BjAIjr0UxyBFHuSl3U0zWN+fyKS2v0fb7Kssr GyaxzJhTZKua3mjPEvAslfBUtUMHZpvvqv/gEDGjOHgM+uAw6f8lBe1D44h0JueT5R0yaiF4q +rgMsWoj4Pxv3uMMY4RPK2rcdy37F15NfJBjs11k5SE7krgJ9iQ8laLQyvzd2HR+rOhZql/g3 v/IjaDyviIqQp5KmgKshb1P2XQ1V7YnQYkybKVrbUr3sk4Cap/HpZOCNh/14KYNnz9oDCcUKg Yb5XoLqnXfjdKWwDxNxoRV3N9ys2Med+M3qGSLGEW927fhhODJzZ46NK25ISDrhc+cO9Je1OA UZxAaECO5JedINNFxdxKagsbIBupOLA5rf2BaBM+1yi+yjap7jVVwV1oJ7XCI/1u41zKk2aOl KwoXX4JyD7i7nBP+3eGGmIIzay2OsaZcO/wvD+6YJzNLsZbXvAa2OY0RaaBMJDscoMdz+Zo4Y rt/Bk0PO7Yn70Tt/e2H7HleTdbcwbwaIR7T8pp1TL22gnfJyMZpj8mrDvaUW3FJJnkJFEMrdR y6Zra9P2H36cPN6mTiuY6kUBH4ycFSJtJgGDQyw78y2v4fV9miJ+W/Ky0VisPuhQCcGH/bgfx TThRseV45djznKPjan9WjtpLiR/krKeksDGqrV/nZrBoz74VYC/bTTV31y0+f8pEqsdbWAHbP 8yRxar3H/PRf02lHqrwXG7XVO87Cwn/m44HONKMubtUPkfw6jjt8szfhVv3FuCaR96uJsoKGs KoBMO2J0Ws0fCzlsEz60JIohU7bhAPqPPeF+rLtvPmovO10cs2OuwmzTLQJfx+ASXN+HgupqZ 7vcdP2pnN0MeYOOkj56VUh5Ln/lm+4Kc2s7dlFkLjUuQLgJ7a1obVMAbRmHXPd8AHaQ8ZYtTI c3zfelY/JTH4yUW0cHf42yJ/g43pFe1fhpq5t9xVGTSdfQFd9EteVGAHbcZ+85/UMSI7V1NMV m/ucyisvYXmIw9bhhGse2GzD1a2gfxM8R5w9GAaLukFPXk2RsXMvpNQfm+NXkJxdyUW4ETEU2 +sL800A5aU4wG6of2MDjYZ847mkXvnz2wruoU5wsCLEP6GHj2RewC17/duFfQfv1nBmi4= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48269 Cc: 48269@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2021-05-07 09:20, Eli Zaretskii wrote: > > Date: Thu, 6 May 2021 22:47:17 -0400 > > From: Boruch Baum > > So the problem seems to be that the doc strings don't say the command > should be invoked from a *vc-log* buffer, is that right? There could be a sanity-check at the beginning of the function in the form= : (unless (eq major-mode foo) (user-error "Not in foo buffer")) > The user manual explains that, so next time when the doc string is > not enough, Umm... In this case, a mix of subjective 'not enough' and objective non-existent. Important to make that distinction. > may I suggest to try looking up the command/variable in the manual? For me personally that's a great suggestion, but if that's going to be your position for all emacs users, you're taking a major step back from a long strong precedent of emacs documentation standards and one of the features that makes emacs such an attractive environment to work in. And here's the content of the log-edit.el commentary (don't blink): That was quick. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 13:15:42 2021 Received: (at 48269) by debbugs.gnu.org; 9 May 2021 17:15:42 +0000 Received: from localhost ([127.0.0.1]:56396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfn1b-0006A0-H2 for submit@debbugs.gnu.org; Sun, 09 May 2021 13:15:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfn1Z-00069Q-UW for 48269@debbugs.gnu.org; Sun, 09 May 2021 13:15:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38476) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfn1T-0003X2-Q4; Sun, 09 May 2021 13:15:20 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4365 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfn1T-0004UK-5a; Sun, 09 May 2021 13:15:19 -0400 Date: Sun, 09 May 2021 20:15:22 +0300 Message-Id: <83mtt37rrp.fsf@gnu.org> From: Eli Zaretskii To: Boruch Baum In-Reply-To: <20210509165515.6vg4g3tobx2sok6f@E15-2016.optimum.net> (message from Boruch Baum on Sun, 9 May 2021 12:55:15 -0400) Subject: Re: bug#48269: 27.1: log-edit-generate-changelog-from-diff FAILURE References: <20210506232308.cd6dfmj566mbzczz@E15-2016.optimum.net> <20210507024717.rvxxe7fkbf2iloag@E15-2016.optimum.net> <83im3vcbej.fsf@gnu.org> <20210509165515.6vg4g3tobx2sok6f@E15-2016.optimum.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48269 Cc: 48269@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Date: Sun, 9 May 2021 12:55:15 -0400 > From: Boruch Baum > Cc: fgunbin@fastmail.fm, 48269@debbugs.gnu.org > > On 2021-05-07 09:20, Eli Zaretskii wrote: > > > Date: Thu, 6 May 2021 22:47:17 -0400 > > > From: Boruch Baum > > > > So the problem seems to be that the doc strings don't say the command > > should be invoked from a *vc-log* buffer, is that right? > > There could be a sanity-check at the beginning of the function in the form: > > (unless (eq major-mode foo) > (user-error "Not in foo buffer")) Yes, but my question was about the doc string: if it said the function should be invoked from a *vc-log* buffer, would that have helped you? Since your original report was against the doc string, I think it's important to understand how we could improve it. > > may I suggest to try looking up the command/variable in the manual? > > For me personally that's a great suggestion, but if that's going to > be your position for all emacs users you're taking a major step back > from a long strong precedent of emacs documentation standards and > one of the features that makes emacs such an attractive environment > to work in. I was just trying to help you (and all the other Emacs users) to find the information more efficiently next time. No matter how hard we work on it, there will always be deficiencies in Emacs documentation (as in any other software documentation), so relying on the developers to get everything 110% correct is impractical, assuming we all have something else to do other than read the documentation. From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 14:45:09 2021 Received: (at 48269) by debbugs.gnu.org; 9 May 2021 18:45:09 +0000 Received: from localhost ([127.0.0.1]:56611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfoQE-00085z-N0 for submit@debbugs.gnu.org; Sun, 09 May 2021 14:45:09 -0400 Received: from mout.gmx.net ([212.227.15.19]:33137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfoQB-00085l-Uc for 48269@debbugs.gnu.org; Sun, 09 May 2021 14:44:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620585887; bh=LIxe+J3kWiTohZgmSorZzTZuHXJ3HFEBIrU4pBJJvPw=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=YKclQWnNW6jZx7T3iGUB7ZjsXsDptM9iBNxOSTHhyc6Q5sGT/g2eefU9QaOP6o7ly Bpugn64285xnX2GBzRH8Aaw7LGCpexbDgXLWxvQaLRIAsb4fjyMJ9pcp0bhdXTCL22 rEZtui1ytqXGfj5FmnloNIrsgaGFm7Q+OsFsieXM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([96.224.230.212]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MsHns-1lMlMa2eoU-00tncl; Sun, 09 May 2021 20:44:46 +0200 Date: Sun, 9 May 2021 14:44:43 -0400 From: Boruch Baum To: Eli Zaretskii Subject: Re: bug#48269: 27.1: log-edit-generate-changelog-from-diff FAILURE Message-ID: <20210509184443.h2jvva6enamdegwd@E15-2016.optimum.net> References: <20210506232308.cd6dfmj566mbzczz@E15-2016.optimum.net> <20210507024717.rvxxe7fkbf2iloag@E15-2016.optimum.net> <83im3vcbej.fsf@gnu.org> <20210509165515.6vg4g3tobx2sok6f@E15-2016.optimum.net> <83mtt37rrp.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83mtt37rrp.fsf@gnu.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:t+Z9T64JqS2HXyTP5FpP1zaQV1JBkd1w6oZQ5awOQ+WDDARLJcI VEKHq63LIk09KORdmV1WUuv8WAeZdn44mRcOv3GbKE+FRcVT+ktdSmezkeUuuzMFUGss47g 56QJQjiSWxJYoplcvXrgzy1xW9wE0XRXQ4s0awdVYK5HDxME0/EXL+BGmivH6U4SO9AWZ0Q BXqZ6BR4c5vANQ1/BXXSw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ebJ6C8h6SY4=:AJuLu5gq1TmVZS0FPKxOxe Spb9hAulDn3d8NQCzAeTXKTHOIRFsr8NbjGhf4x4psq9VTES1EjfoUkrN9uu+d7+UGTHX44r9 Kaiske1s+L93T1Bl2HHynBkRjvc18KDQ4kcDa22xAlkcndYbbfAGdfh5XEqF6NwCvscJvhTGF ubxEMBjXkrKhO6Fh2Fzs+8CCfYejHv4IeF8eDAgVR1P5/Ch7X7vh3CtkPEQ1hKFTREidoWCxk uFCbHmt8rIoup6NaavuuOzy2VkYGOU34KXv40A7w8kyNbMMumAyLI3HWLsEIB7JfAQY+hRWnY 5fsPElxZ/JVz2cDGgbcpDlh9dI8evfK/t2Pv8LT5p18S9GP1sWwjBUcq6IgbKYuyabg6+gQvT 7tdC0N6urg0AQwMZSk8CmCgWz0SHYgMkEBDV8BfhodCLaJhEzWC8GhOd25UVrlz/xPVTwa4Yl 5GvR4AXVORbFvmfFp9Rk70XvYWzV7/isnttAVrGC5VPlyi+ytYk2hHSEsAY9E6XMOUTsrzghh YshYAuTArboKtHiBaAfSxoxLyBmkmCWz9EjV9hjUKiE4UP43NSGfPy2sIK1vXe2Ix/iSK8r1K xqH4CGs1+g+Uqqo8MBsYVa0dTt+WdpLy3nkfM14NS4JoPDl+VSGRHpqjDnieSbHmpdQ6SCFak Zr8Hlw26xCa/MUF7YWYp9PwMEbF4pkgdGPv7sFE1LhtyxTkC5GBXnmym78DxamyIu0ai76m7c Z3NtCsmBh9H+WvZI6Hjz9AH/SPEBCC+qCORn5e/7/fH95VoKklzG+elDUJh3GK+OCyShm9ZDs WwQqeGcdkL7Tsehu/lTcWfObaQVr8F+xeIVliwZZREO/6U5wejiZYtzxeNu+jTgGrxRlArFU6 QwksV1Jh/pkVjxkI4cXebB8lGvAMguqv5V7OcXL6DWfTOO//H5/ZFP8dPJh2iwF8EQ2JndNyM 5ph0XFSm1G74bwNgGdKLm/ueua+LxjV+9oID+qJqkn6NR0niXfoA3fc4M+VCHdWI6+zBy6Qei xs3m3Ii8LVjKoPuAgy/n09M00wylLeQaXLQeJKqsETZ0tEPIWlviIWBQtl6ac9qXucmwK1gKb GUEK/6ruOQuWNjLkwh6lFDtTEjJsMrKHvhvDauETB0ySeFsWXuHpEUeQJL34m/ubXDAy3VeTp /TTMRTM63mSNBeWzN+ALI7LXLyqE9M8LAOx5n4fgb7VjNCiFXsa2Pcvjv3dSC0AU9ABPk= Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 48269 Cc: 48269@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2021-05-09 20:15, Eli Zaretskii wrote: > > Date: Sun, 9 May 2021 12:55:15 -0400 > > From: Boruch Baum > > Cc: fgunbin@fastmail.fm, 48269@debbugs.gnu.org > > > > On 2021-05-07 09:20, Eli Zaretskii wrote: > > > > Date: Thu, 6 May 2021 22:47:17 -0400 > > > > From: Boruch Baum > > > > > > So the problem seems to be that the doc strings don't say the comman= d > > > should be invoked from a *vc-log* buffer, is that right? > > > > There could be a sanity-check at the beginning of the function in the = form: > > > > (unless (eq major-mode foo) > > (user-error "Not in foo buffer")) > > Yes, but my question was about the doc string: if it said the function > should be invoked from a *vc-log* buffer, would that have helped you? > Since your original report was against the doc string, I think it's > important to understand how we could improve it. The short answer then, is yes. But the long answer, adding a sanity check to the code, would avoid needing to look at the docstring. > > > > may I suggest to try looking up the command/variable in the manual? > > > > For me personally that's a great suggestion, but if that's going to > > be your position for all emacs users you're taking a major step back > > from a long strong precedent of emacs documentation standards and > > one of the features that makes emacs such an attractive environment > > to work in. > > I was just trying to help you (and all the other Emacs users) to find > the information more efficiently next time. No matter how hard we > work on it, there will always be deficiencies in Emacs documentation > (as in any other software documentation), so relying on the developers > to get everything 110% correct is impractical, assuming we all have > something else to do other than read the documentation. The most efficent way seems to me to add the sanity-check to the code. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 14:54:54 2021 Received: (at 48269) by debbugs.gnu.org; 9 May 2021 18:54:54 +0000 Received: from localhost ([127.0.0.1]:56615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfoZp-0008Jb-Dz for submit@debbugs.gnu.org; Sun, 09 May 2021 14:54:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfoZl-0008JM-Hr for 48269@debbugs.gnu.org; Sun, 09 May 2021 14:54:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40482) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfoZf-000501-Vf; Sun, 09 May 2021 14:54:43 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2554 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfoZf-0007ku-Iv; Sun, 09 May 2021 14:54:43 -0400 Date: Sun, 09 May 2021 21:54:44 +0300 Message-Id: <83bl9j7n63.fsf@gnu.org> From: Eli Zaretskii To: Boruch Baum In-Reply-To: <20210509184443.h2jvva6enamdegwd@E15-2016.optimum.net> (message from Boruch Baum on Sun, 9 May 2021 14:44:43 -0400) Subject: Re: bug#48269: 27.1: log-edit-generate-changelog-from-diff FAILURE References: <20210506232308.cd6dfmj566mbzczz@E15-2016.optimum.net> <20210507024717.rvxxe7fkbf2iloag@E15-2016.optimum.net> <83im3vcbej.fsf@gnu.org> <20210509165515.6vg4g3tobx2sok6f@E15-2016.optimum.net> <83mtt37rrp.fsf@gnu.org> <20210509184443.h2jvva6enamdegwd@E15-2016.optimum.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48269 Cc: 48269@debbugs.gnu.org, fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 9 May 2021 14:44:43 -0400 > From: Boruch Baum > Cc: fgunbin@fastmail.fm, 48269@debbugs.gnu.org > > > > There could be a sanity-check at the beginning of the function in the form: > > > > > > (unless (eq major-mode foo) > > > (user-error "Not in foo buffer")) > > > > Yes, but my question was about the doc string: if it said the function > > should be invoked from a *vc-log* buffer, would that have helped you? > > Since your original report was against the doc string, I think it's > > important to understand how we could improve it. > > The short answer then, is yes. But the long answer, adding a sanity > check to the code, would avoid needing to look at the docstring. Assuming the text of the user-error message could be detailed enough to make sense. A doc string doesn't have to be short, so it's easier to explain complex stuff there. From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 18:58:38 2021 Received: (at 48269) by debbugs.gnu.org; 9 May 2021 22:58:39 +0000 Received: from localhost ([127.0.0.1]:56783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfsNi-0007yc-Bb for submit@debbugs.gnu.org; Sun, 09 May 2021 18:58:38 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:38731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfsNe-0007xz-3z for 48269@debbugs.gnu.org; Sun, 09 May 2021 18:58:36 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id EF0235C010A; Sun, 9 May 2021 18:58:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 09 May 2021 18:58:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=N96nSkhFBFCnKystR8K20RnKOl iaiEFBwpL9IByK4dI=; b=rK6k4Xxvu3NIR8BTNk5hBV0/9qQPKMeWHkQ+3aoH9a oLFqoEnmRxFQ/DCYQcb96UWauuBdHLhZO8XYmK7Z1w5yWkWVRUM1xX4k2T8H8B91 iyIgQo9MXsb3yYg/zuMeIVS9poH5KvCe7jALRUoKX1ARCph9JLlR23jVxcK5BHSl nP21e8pkmzSI2wdYoPaZ4av/r6zVltFtH0tUk39xSerH2oiaIYIfGPV4iuQwFCJW ptYen/jpHIGfq1qqwRrm19kLuPWuuI43risdv7MAL1BSqnOYA+V7n6ccswEOSxpn VhJbhEP65JB18w5ZLq4bEmHF+4UDyfLsn2Gm5JDvEQuw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=N96nSk hFBFCnKystR8K20RnKOliaiEFBwpL9IByK4dI=; b=flKRZt5NCshpFlUearirUw v2nM2NMg+VMb6IivDMzDqcL1vyag2vt/YApYd5UfW4XQlf+vq5aGXCtB7EfwGTQp 3Ml8UzW0pzO7heEhyyTA1zsO4zGXESzJTgjXU2X0jARD7S0SI/vkvvtNZ1FCfSUa YtHNCpJ45PEQ37R4Fq54ijhLVcoN11aihcvtCLUigRHtkat6LWIM4ebDlliYQ+DA TwUFL5O26Xeqjcj/jsn5kDcQCXv6JtU+YHqGYGzJrJyv+cSLxhQ4RxnIRtTZGat/ qpMnR6xUjjRXCcwJFF1EDelV3J6/iYXSW65JLm4g04GHE0EoONvJ9xsYaJOz7wwQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegjedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehttdertddtredtnecuhfhrohhmpefhihhlihhp phcuifhunhgsihhnuceofhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmheqnecuggftrf grthhtvghrnhepvdevkeffvdeuvefhuddtjeehkedvueefveettddtveduudfgieffieev ieevhfdtnecukfhppeekfedruddtvddrudegjedrudduheenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehfghhunhgsihhnsehfrghsthhmrghi lhdrfhhm X-ME-Proxy: Received: from fgunbin.local (unknown [83.102.147.115]) by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 May 2021 18:58:27 -0400 (EDT) From: Filipp Gunbin To: Boruch Baum Subject: Re: bug#48269: 27.1: log-edit-generate-changelog-from-diff FAILURE In-Reply-To: <20210509184443.h2jvva6enamdegwd@E15-2016.optimum.net> (Boruch Baum's message of "Sun, 9 May 2021 14:44:43 -0400") References: <20210506232308.cd6dfmj566mbzczz@E15-2016.optimum.net> <20210507024717.rvxxe7fkbf2iloag@E15-2016.optimum.net> <83im3vcbej.fsf@gnu.org> <20210509165515.6vg4g3tobx2sok6f@E15-2016.optimum.net> <83mtt37rrp.fsf@gnu.org> <20210509184443.h2jvva6enamdegwd@E15-2016.optimum.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Date: Mon, 10 May 2021 01:58:25 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48269 Cc: Eli Zaretskii , 48269@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 09/05/2021 14:44 -0400, Boruch Baum wrote: >> I was just trying to help you (and all the other Emacs users) to find >> the information more efficiently next time. No matter how hard we >> work on it, there will always be deficiencies in Emacs documentation >> (as in any other software documentation), so relying on the developers >> to get everything 110% correct is impractical, assuming we all have >> something else to do other than read the documentation. > > The most efficent way seems to me to add the sanity-check to the code. Frankly, I don't get it: the function we talk about starts with its mode's prefix (log-edit), is bound to key in that (and derived) modes, so why would a user just randomly call it in an unprepared buffer? I mean, the sanity check will be an over-defense, IMO. Filipp From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 20:14:09 2021 Received: (at 48269) by debbugs.gnu.org; 10 May 2021 00:14:09 +0000 Received: from localhost ([127.0.0.1]:56813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lftYm-0001Q2-Kj for submit@debbugs.gnu.org; Sun, 09 May 2021 20:14:09 -0400 Received: from mout.gmx.net ([212.227.15.15]:40175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lftYj-0001PN-9J for 48269@debbugs.gnu.org; Sun, 09 May 2021 20:14:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620605636; bh=avkpLUqxeinnZKyPgCShLnEFkGJdMH+6nG/d6LJhf9U=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=LPw2YTgH8YwAhEZsiz9Zu2pQErq5HF73QN8TAVfc3KI8ADOskZH+5AKjzkHpyjJmv dsnERHEGaPT6fAy2elUNm2ZuwZSGi6S6yBAmm8oAWfEoP4bW3JftMY2Of5ipIJQprz vMeGFCf+XQpn4tXr7H8qn/XUgV8gmD82tW1VIzkw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([96.224.230.212]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MV63g-1m7qHF2FHS-00S7If; Mon, 10 May 2021 02:13:55 +0200 Date: Sun, 9 May 2021 20:13:52 -0400 From: Boruch Baum To: Filipp Gunbin Subject: Re: bug#48269: 27.1: log-edit-generate-changelog-from-diff FAILURE Message-ID: <20210510001352.pnv3qh3cjk6wez45@E15-2016.optimum.net> References: <20210506232308.cd6dfmj566mbzczz@E15-2016.optimum.net> <20210507024717.rvxxe7fkbf2iloag@E15-2016.optimum.net> <83im3vcbej.fsf@gnu.org> <20210509165515.6vg4g3tobx2sok6f@E15-2016.optimum.net> <83mtt37rrp.fsf@gnu.org> <20210509184443.h2jvva6enamdegwd@E15-2016.optimum.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:RhtW2FGaE/iNPnyIRTB/hyz0+dvDxQLQ8+AiH/zrJhwY2VhfDNw D02lWJatLari/mxROeRu7GqrJFh1J24TGDrzW49MiuXRMPivKHwLuFjrkn7drN88j4Vuohr 6IS29niL4N6EbobHRPTbJQXTStuHsDesVXNyDtIyOThIwgV8ILefbeZWpSn5cW3f4cAPE0h inkFzri6aeANf2Q4c4hjg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:2mRLTsQ+BR8=:pGFLKOovs7lgu34rHmI3jc 56kgXCfvrceA7xUeNt4V3wTbM4ES/al5ekl8laQq0Y9kN4AfWc2fLYqgZGuWhMZCB65m+PLTQ HjfkhLd1xNjVwGcWT01H0N/fTRF0aXREV3y1kMoOWcVzMPLvMKVfSk7UzjWP7ilZPfjMg1g2z NQcfuXuiZ8achXLZOeoZihCvlADUwVegTtl4l3va8Sc4qz2tz8N7DA0CB84JflkNln1IEor7J oDM3ajuNXdXHSEoaWN09FYpxeVYENyxAwiotOKUYxvnzMC5LwsCHmBYzV64X0Bz9ZqRYwzp+9 vH5Ap9RtkhfN6MYCuFmYtDCgoaGszDGfOKKrUcvCfYDfaxarzfroDj+bRCCJPcM6QTDIADg/t 1Pg93a4vOBKNLL6EC/isxOsPhW4rsX8OklsUiwfSNrbeC0f+URclwCNumhPeYqwvmwoRRoDU3 JeKmE160jx7wc4m3pQNgKJT51xtxyRa26bQ0aX/CTnL7I/PEeS7Vwp7Ae/ZIrjC++2WetvVas elsPNkQqrx3lVZY42Z+J7ULc5iYfxqr+oAmMfBtHbdqgNUixyeLS0jTwcx31IXjDOGRufNfT+ rIHaCgR8cqHExmueM2d229LPeuHwISqaHvr+nauFUv+992/hXaJFIHMsDldYBV9QaP2fLERNy 698DHbMl8U0PI3b8/QIXdcp11ZYYzvzeo0JZmQly6iqEGu0ua+mf8WCTCSYfWTdNi9sm+iRLq +vNicQiY4S2hl1uskouZNeLlEYY4V/7+Smm/inX4QY+PP/t9Xc95KykoO1V9YUmoL6HwPcU+g HWbO28h+x2Y5PxfBIMk6viIcaZxCra8mzpBHiY+rc2OKVTW2zVtHGO3Z7rt11bLhby8MwcEB9 9x7G58f6x6pWhT0N2i4RTGzUfR68wpei5R5DfQ73noU4YbBTv7MYp71e29gruI745pFtjevxR 1/IQXeoYzZ6j3DXP1ENHQVpaeptApq37VXuqs58zeLne8g+psKU3J1YvGlSAJ/u/Oj/8dhHN5 BSnGMK2x2Vbb/BotBl+gAwGlykqDVK8mePocR/gICW58noebw4BT+MByre5K2z48TLtlXXd6B awZOuK8Y3wZOiqYQHaRLGBUayEbvvArXOUmmGdghnSNHQJJPykpoOqBOUg6dK70kMfEpGfaBm QXHh2dRVWLioj+Husn3svSR+aQ79vxHLIbfVYH7uVi4tEqjjSyTrA5HU3lFID6uwwxbsU= Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48269 Cc: Eli Zaretskii , 48269@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2021-05-10 01:58, Filipp Gunbin wrote: > Frankly, I don't get it: the function we talk about starts with its > mode's prefix (log-edit), is bound to key in that (and derived) modes, > so why would a user just randomly call it in an unprepared buffer? Good point. Short answer: it was directly recommended in a another emacs bug report thread that I do so. Longer answer: I wasn't given instructions in that other thread about 'preparing a buffer', only that the command was an alternative to 'C-x 4 a' when operating on version-controlled file and there was no need or desire for a Changelog file. That's also how I interpreted an excerpt from the emacs NEWS file posted there. As I had the file under git, using magit, and 'C-x 4 a' (from add-log.el) is known to work without any 'buffer preparation', why shouldn't commands from log-edit.el? > I mean, the sanity check will be an over-defense, IMO. I'm not so sure, but as I've yet to read up on how to 'prepare a buffer' and get the command working, I'm not yet in position to take a step back and assess whether what happened in my case is reasonable to happen to others. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From debbugs-submit-bounces@debbugs.gnu.org Tue May 11 09:34:20 2021 Received: (at 48269) by debbugs.gnu.org; 11 May 2021 13:34:20 +0000 Received: from localhost ([127.0.0.1]:35411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgSWi-0000TM-H1 for submit@debbugs.gnu.org; Tue, 11 May 2021 09:34:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgSWg-0000T6-GN for 48269@debbugs.gnu.org; Tue, 11 May 2021 09:34:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JnEJTIzzJXuw3AvwquKCpXM9f3Ca+PTw8RfjKv6buo4=; b=jXBU7biuN79C+6fUY5+bT457re IjbVLly85XgUhBtunjglkmpykQKTMfqzcmgb9RyV5p87M7qOn77A5wj6T9iWn2f+INWeMVSYPkPow LMiAyYASLR6grx0XohTLpsFevKdzXkGINjCdYpL9801wMhTBPWYMBGIs5v/Ig/SLaQUo=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgSWY-0005Wq-9E; Tue, 11 May 2021 15:34:12 +0200 From: Lars Ingebrigtsen To: Filipp Gunbin Subject: Re: bug#48269: 27.1: log-edit-generate-changelog-from-diff FAILURE References: <20210506232308.cd6dfmj566mbzczz@E15-2016.optimum.net> <20210507024717.rvxxe7fkbf2iloag@E15-2016.optimum.net> <83im3vcbej.fsf@gnu.org> <20210509165515.6vg4g3tobx2sok6f@E15-2016.optimum.net> <83mtt37rrp.fsf@gnu.org> <20210509184443.h2jvva6enamdegwd@E15-2016.optimum.net> X-Now-Playing: Coil's _Love's Secret Domain (2)_: "Further back and faster (didgeridoo)" Date: Tue, 11 May 2021 15:34:09 +0200 In-Reply-To: (Filipp Gunbin's message of "Mon, 10 May 2021 01:58:25 +0300") Message-ID: <8735uto0mm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Filipp Gunbin writes: > Frankly, I don't get it: the function we talk about starts with its > mode's prefix (log-edit), is bound to key in that (and derived) modes, > so why would a user just randomly call it in an unprepa [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48269 Cc: Eli Zaretskii , Boruch Baum , 48269@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Filipp Gunbin writes: > Frankly, I don't get it: the function we talk about starts with its > mode's prefix (log-edit), is bound to key in that (and derived) modes, > so why would a user just randomly call it in an unprepared buffer? I > mean, the sanity check will be an over-defense, IMO. I agree -- this doesn't seem to be a bug, and I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 11 09:34:25 2021 Received: (at control) by debbugs.gnu.org; 11 May 2021 13:34:25 +0000 Received: from localhost ([127.0.0.1]:35414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgSWm-0000Te-ON for submit@debbugs.gnu.org; Tue, 11 May 2021 09:34:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgSWl-0000TE-Pd for control@debbugs.gnu.org; Tue, 11 May 2021 09:34:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DXnMDQ/YcKf1an4T3s1WfTymppI3ChMF7YRT8namjxI=; b=FmMmjGIveGoESTXom4ifrBHBFD 7jTE8HAV+jUnjEM5T76Eup4QgD3eobE6ca0eqcYPvjP9iteXiLw4eBA97bSttBu+RbQ5HVXbmGymq cCXQGzlLMqx/mweLsf7jYmU/4rqKJHKHdrN94q6yinQSGG8wFqTCnP7lOCcreYGcq+js=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgSWd-0005Wy-Pe for control@debbugs.gnu.org; Tue, 11 May 2021 15:34:18 +0200 Date: Tue, 11 May 2021 15:34:15 +0200 Message-Id: <871rado0mg.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #48269 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 48269 notabug close 48269 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 48269 notabug close 48269 quit From unknown Tue Jun 17 01:43:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 09 Jun 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator