GNU bug report logs - #48264
28.0.50; Changing the default for DEFVAR_PER_BUFFER variables takes O(#buffers) time

Previous Next

Package: emacs;

Reported by: Spencer Baugh <sbaugh <at> catern.com>

Date: Thu, 6 May 2021 20:25:01 UTC

Severity: normal

Found in version 28.0.50

Full log


Message #98 received at 48264 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> catern.com>
Cc: 48264 <at> debbugs.gnu.org
Subject: Re: bug#48264: [PATCH v3 08/15] Set non-buffer-local BVARs to Qunbound
Date: Fri, 07 May 2021 16:00:59 +0300
> From: Spencer Baugh <sbaugh <at> catern.com>
> Cc: 48264 <at> debbugs.gnu.org
> Date: Fri, 07 May 2021 08:54:33 -0400
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> -   Setting the default value also goes through the alist of buffers
> >> -   and stores into each buffer that does not say it has a local value.  */
> >> +*/
> >
> > This is a spurious change, please undo it.
> >
> >> @@ -1107,8 +1109,7 @@ BUFFER_CHECK_INDIRECTION (struct buffer *b)
> >>     that have special slots in each buffer.
> >>     The default value occupies the same slot in this structure
> >>     as an individual buffer's value occupies in that buffer.
> >> -   Setting the default value also goes through the alist of buffers
> >> -   and stores into each buffer that does not say it has a local value.  */
> >> +*/
> >
> > Likewise.
> 
> Not sure what you mean about this being a spurious change

I was talking about the added newline.  Sorry for not being more clear
about that.




This bug report was last modified 2 years and 290 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.