GNU bug report logs - #48264
28.0.50; Changing the default for DEFVAR_PER_BUFFER variables takes O(#buffers) time

Previous Next

Full log

Message #77 received at 48264 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> catern.com>
Cc: 48264 <at> debbugs.gnu.org
Subject: Re: bug#48264: [PATCH v3 00/15] Speeding up setting the default for
 DEFVAR_PER_BUFFER vars
Date: Fri, 07 May 2021 14:05:40 +0300

> From: Spencer Baugh <sbaugh <at> catern.com>
> Date: Thu,  6 May 2021 17:33:31 -0400
> Cc: Spencer Baugh <sbaugh <at> catern.com>
> 
> This patch series fixes bug#48264 by speeding up changes to the
> default value for DEFVAR_PER_BUFFER vars, whether by let or
> set-default.  Such changes are now constant time, and run as fast as
> changes to non-default values.

[...]

I think some of this (the "new implementation") should be in some
commentary in buffer.c, and at least some of the rest should be in the
commit log message.  It makes no sense, IMNSHO, to have such a
detailed description here, and then lose it when installing the
changes.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.