GNU bug report logs - #48264
28.0.50; Changing the default for DEFVAR_PER_BUFFER variables takes O(#buffers) time

Previous Next

Full log

Message #224 received at 48264 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Spencer Baugh <sbaugh <at> catern.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>, 48264 <at> debbugs.gnu.org
Subject: Re: bug#48264: [PATCH v3 15/15] Add and use BVAR_FIELD macros
Date: Sun, 09 May 2021 12:08:49 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> If you think such a conditionally-compiled runtime check would be
>> acceptable for applying these changes, I can go ahead and write that.
>
> Yes, I think so.  But if Lars or Stefan think differently, I might
> reconsider.

I'd prefer compile time checks, certainly...  but I see that Spencer has
added a way to get those without adding the awkward struct accessor
macros now, so I guess the question is moot.

But listing the permanently local variables in a list like this:

+/* This structure is used purely as a list of field names that are
+   permitted for use with BVAR; it's never actually instantiated.  */
+struct bvar_permanent_locals {

at least requires commentary in the struct they're defined in so that we
don't remember to update the list when we add new permanently local
variables...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.