GNU bug report logs - #48264
28.0.50; Changing the default for DEFVAR_PER_BUFFER variables takes O(#buffers) time

Previous Next

Package: emacs;

Reported by: Spencer Baugh <sbaugh <at> catern.com>

Date: Thu, 6 May 2021 20:25:01 UTC

Severity: normal

Found in version 28.0.50

Full log


Message #221 received at 48264 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> catern.com>
Cc: monnier <at> iro.umontreal.ca, 48264 <at> debbugs.gnu.org
Subject: Re: bug#48264: [PATCH v3 15/15] Add and use BVAR_FIELD macros
Date: Sun, 09 May 2021 11:10:33 +0300
> From: Spencer Baugh <sbaugh <at> catern.com>
> Cc: 48264 <at> debbugs.gnu.org
> Date: Sat, 08 May 2021 15:03:46 -0400
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> >> From: Spencer Baugh <sbaugh <at> catern.com>
> >> Cc: 48264 <at> debbugs.gnu.org
> >> Date: Sat, 08 May 2021 09:35:31 -0400
> >> If you think such a conditionally-compiled runtime check would be
> >> acceptable for applying these changes, I can go ahead and write that.
> >
> > Yes, I think so.  But if Lars or Stefan think differently, I might
> > reconsider.
> 
> In the process of implementing the runtime check, I, of course, came up
> with a better compile-time check. How about this?

LGTM, thanks.  But could you please run your benchmarks again, with
this implementation, to make sure we still get only a 1 - 2% slowdown
at worst?  I wouldn't expect the addition to matter in an optimized
build, but just to be sure...




This bug report was last modified 2 years and 330 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.