GNU bug report logs - #48264
28.0.50; Changing the default for DEFVAR_PER_BUFFER variables takes O(#buffers) time

Previous Next

Full log

View this message in rfc822 format

From: Spencer Baugh <sbaugh <at> catern.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 48264 <at> debbugs.gnu.org
Subject: bug#48264: [PATCH v3 12/15] Set buffer_defaults fields without a default to Qunbound
Date: Sat, 08 May 2021 09:22:52 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:
>> From: Spencer Baugh <sbaugh <at> catern.com>
>> Cc: 48264 <at> debbugs.gnu.org
>> Date: Fri, 07 May 2021 17:35:05 -0400
>> 
>> OK, in the end I was able to get moving init_{syntax,category}_once
>> after init_buffer_once to work, by initializing the two variables to
>> Qnil in buffer.c.  I assume it wasn't working before because they were
>> Qunbound rather than Qnil, and something is checking NILP to see if the
>> variables are initialized. (Although not sure what).
>> 
>> So, I was able to remove the special case.
>
> Great, thanks.  Please be sure to bootstrap as part of your tests, to
> make sure this doesn't get in the way then, and also run all of the
> tests in the test suite, fingers crossed.

Ype, the latest revision of the patch series passes `make check` after
every individual commit.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.