GNU bug report logs - #48264
28.0.50; Changing the default for DEFVAR_PER_BUFFER variables takes O(#buffers) time

Previous Next

Full log

Message #131 received at 48264 <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> catern.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 48264 <at> debbugs.gnu.org
Subject: Re: bug#48264: [PATCH v3 06/15] Rearrange set_internal for buffer
 forwarded symbols
Date: Fri, 07 May 2021 10:26:20 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:
>> From: Spencer Baugh <sbaugh <at> catern.com>
>> Date: Thu,  6 May 2021 17:33:37 -0400
>> Cc: Spencer Baugh <sbaugh <at> catern.com>
>> 
>> --- a/src/data.c
>> +++ b/src/data.c
>> @@ -1320,6 +1320,9 @@ store_symval_forwarding (lispfwd valcontents, Lisp_Object newval,
>>  	if (buf == NULL)
>>  	  buf = current_buffer;
>>  	set_per_buffer_value (buf, offset, newval);
>> +        int idx = PER_BUFFER_IDX (offset);
>> +        if (idx > 0)
>> +          SET_PER_BUFFER_VALUE_P (buf, idx, 1);
>
> It looks like you customized indent-tabs-mode to nil in C modes (or
> maybe don't use Emacs?) because your indentation uses only spaces.
> Please use our conventions in C sources, which uses TABs and spaces,
> per indent-tabs-mode's default value.
>
> This is a general comment, because I see signs of this in all of your
> patches.

Sorry about that, I reverted indent-tabs-mode to t a while ago, but I
forgot to convert some of these some of these patches to use tabs.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.