Subject: Re: bug#48264: [PATCH v3 02/15] Take offset not idx in PER_BUFFER_VALUE_P

From: Spencer Baugh <[email-masked]>
Date: Fri, 07 May 2021 08:45:56 -0400

Eli Zaretskii <[email-masked]> writes:
>> From: Spencer Baugh <[email-masked]>
>> Date: Thu,  6 May 2021 17:33:33 -0400
>> Cc: Spencer Baugh <[email-masked]>
>> 
>> This improves clarity and allows us to more easily change how
>> PER_BUFFER_VALUE_P works.
>> 
>> * src/buffer.h (PER_BUFFER_VALUE_P): Move to be in scope of
>> PER_BUFFER_IDX.  Take offset instead of idx, and perform the common
>> "idx == -1" check internally.
>> * src/data.c (store_symval_forwarding, set_internal)
>> (set_default_internal, Flocal_variable_p):
>> * src/buffer.c (buffer_local_variables_1): Pass offset not idx to
>> PER_BUFFER_VALUE_P, and remove idx == -1 checks.
>
> This moves an INLINE function from a header to a C file, which I'd
> prefer to avoid (due to all kind of subtle issues with inline
> functions).  Can't you move PER_BUFFER_IDX to the header instead?

You may have misread; PER_BUFFER_IDX and PER_BUFFER_VALUE_P are both
still in the header.