Subject: bug#48264: [PATCH v3 03/15] Add and use BUFFER_DEFAULT_VALUE_P

From: Spencer Baugh <[email-masked]>
Date: Fri, 07 May 2021 10:30:51 -0400

Eli Zaretskii <[email-masked]> writes:
>> From: Spencer Baugh <[email-masked]>
>> Cc: [email-masked]
>> Date: Fri, 07 May 2021 09:38:20 -0400
>> 
>> > It's the other way around here: the test "if (idx > 0)" is clear,
>> > whereas "if (BUFFER_DEFAULT_VALUE_P (offset))" makes me go look up the
>> > definition of the macro, because the name is not expressive enough,
>> > and the argument "offset" doesn't help, either.
>> 
>> Sure; what about the name "BUFFER_VAR_HAS_DEFAULT_VALUE_P"?
>
> Much better.  Maybe BVAR_HAS_DEFAULT_VALUE_P? it's shorter.

Will change to that - with that change, is this patch fine, or would you
still prefer comments on the usage sites?