GNU bug report logs - #48263
[PATCH 1/2] gnu: python-hypercorn: Rename to hypercorn.

Previous Next

Package: guix-patches;

Reported by: Vinicius Monego <monego <at> posteo.net>

Date: Thu, 6 May 2021 19:19:01 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Vinicius Monego <monego <at> posteo.net>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 48263 <at> debbugs.gnu.org
Subject: [bug#48263] [bug#49123] [PATCH 09/24] gnu: python-hyperframe: Update to 6.0.1.
Date: Thu, 12 Aug 2021 00:04:13 +0000
Maxime Devos <maximedevos <at> telenet.be> writes:

> A comment about the commit message though:
>> * gnu/packages/python-web.scm (hypercorn): Update to 0.11.2.
>> (python-h11): Update to 0.12.0.
>> [arguments]: Add 'test-target' keyword. Do not replace check 
>> phase.
>> [native-inputs]: Add python-pytest-runner.
>> ---
>> Both packages have to updated at the same time
>> or the hypercorn tests will fail (if either is updated 
>> first). I
>> rebuilt the h11 dependents succesfully.
>
> Why not include this rationale in the commit message itself?

It would be an implicit fact for me, and it's uncommon to explain
changes in the commit message. But if it improves clarity, I'm OK 
with
including it.




This bug report was last modified 3 years and 194 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.