GNU bug report logs - #48261
28.0.50; Optimize `eql' to `eq' for fixnums

Previous Next

Package: emacs;

Reported by: Philipp Stephani <p.stephani2 <at> gmail.com>

Date: Thu, 6 May 2021 17:21:02 UTC

Severity: normal

Tags: patch

Found in version 28.0.50

Done: Philipp Stephani <p.stephani2 <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 48261 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattiase <at> acm.org>
To: 48261 <at> debbugs.gnu.org, Philipp <p.stephani2 <at> gmail.com>
Subject: bug#48261: 28.0.50; Optimize `eql' to `eq' for fixnums
Date: Fri, 7 May 2021 11:23:40 +0200

Good!

+  (and (fixnump o) (<= -536870912 o 536870911)))

Maybe write (<= (- (ash 1 29)) o (1- (ash 1 29))) instead.

+                            (cl-every

Are you sure this is a good idea? See comment in the beginning of bytecomp.el.
Maybe just hold your nose and keep the existing (memq nil (mapcar ...)) hack; the list is usually short.

(We really should have fast, readable, always-available standard functions or macros for 'some' and 'every' on lists.)
This bug report was last modified 4 years and 64 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.