From unknown Wed Aug 20 02:46:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#48259 <48259@debbugs.gnu.org> To: bug#48259 <48259@debbugs.gnu.org> Subject: Status: [PATCH 1/2] gnu: Replace go-github-com-golang-protobuf-proto with go-github-com-golang-protobuf Reply-To: bug#48259 <48259@debbugs.gnu.org> Date: Wed, 20 Aug 2025 09:46:48 +0000 retitle 48259 [PATCH 1/2] gnu: Replace go-github-com-golang-protobuf-proto = with go-github-com-golang-protobuf reassign 48259 guix-patches submitter 48259 Dion Mendel severity 48259 normal tag 48259 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 12:35:40 2021 Received: (at submit) by debbugs.gnu.org; 6 May 2021 16:35:40 +0000 Received: from localhost ([127.0.0.1]:38440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1legyN-0004ou-0X for submit@debbugs.gnu.org; Thu, 06 May 2021 12:35:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:47278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1legyJ-0004oo-P0 for submit@debbugs.gnu.org; Thu, 06 May 2021 12:35:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1legyJ-00080e-FG for guix-patches@gnu.org; Thu, 06 May 2021 12:35:31 -0400 Received: from fossa.birch.relay.mailchannels.net ([23.83.209.62]:25864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1legyF-0008HD-6u for guix-patches@gnu.org; Thu, 06 May 2021 12:35:31 -0400 X-Sender-Id: dreamhost|x-authsender|smtp@dm9.info Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D370F362680 for ; Thu, 6 May 2021 16:35:18 +0000 (UTC) Received: from pdx1-sub0-mail-a40.g.dreamhost.com (100-96-17-237.trex.outbound.svc.cluster.local [100.96.17.237]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 78B9C36283D for ; Thu, 6 May 2021 16:35:17 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|smtp@dm9.info Received: from pdx1-sub0-mail-a40.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.17.237 (trex/6.2.1); Thu, 06 May 2021 16:35:18 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|smtp@dm9.info X-MailChannels-Auth-Id: dreamhost X-Harbor-Gusty: 1474530377fedbea_1620318918657_2595187630 X-MC-Loop-Signature: 1620318918656:2951685924 X-MC-Ingress-Time: 1620318918656 Received: from pdx1-sub0-mail-a40.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a40.g.dreamhost.com (Postfix) with ESMTP id 2FE648BABD for ; Thu, 6 May 2021 09:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=dm9.info; h=date:from:to :subject:message-id:mime-version:content-type :content-transfer-encoding; s=dm9.info; bh=Sxe5yAF2Pqv6Q0B4OsLG5 W8NjWs=; b=PWksNn+akV6YK2lWFMHpVBbLNNJS4bfedEWSAtC5xpIzCVKXKAqnD 1H2/ekXADKz4IN/mkP4P2Ob7RfTcrqLZ0CJXK6XOIXiSAs/trJpKqUjkTJu9ZMQr RzMX2/z0WDEZETAy8ei/UJ6H/5Cbe9LuiIkRlmjjoMDlb0wNLwcZjk= Received: from mail.localdomain (61-245-140-70.3df58c.per.nbn.aussiebb.net [61.245.140.70]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: smtp@dm9.info) by pdx1-sub0-mail-a40.g.dreamhost.com (Postfix) with ESMTPSA id A81FE7E5A7 for ; Thu, 6 May 2021 09:35:16 -0700 (PDT) Received: by mail.localdomain (Postfix, from userid 2001) id E1304507973; Fri, 7 May 2021 00:35:11 +0800 (AWST) Date: Fri, 7 May 2021 00:35:11 +0800 X-DH-BACKEND: pdx1-sub0-mail-a40 From: Dion Mendel To: guix-patches@gnu.org Subject: [PATCH 1/2] gnu: Replace go-github-com-golang-protobuf-proto with go-github-com-golang-protobuf Message-ID: <20210506163511.GB27260@dm9.info> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="XsQoSWH+UP9D9v3l" Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Content-Transfer-Encoding: 7bit Received-SPF: none client-ip=23.83.209.62; envelope-from=guix@dm9.info; helo=fossa.birch.relay.mailchannels.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --XsQoSWH+UP9D9v3l Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Hi guix, The github.com/golang/protobuf module contains several packages. Only proto is currently packaged. This change updates the module from 1.3.1 to 1.5.2 and packages the entire module. This is needed as I am preparing to package lxd (github.com/lxc/lxd), which depends on the unpackaged packages from golang/protobuf. This change replaces go-github-com-golang-protobuf-proto with go-github-com-golang-protobuf. There are currently two packages that depend on go-github-com-golang-protobuf-proto. I have tested this changeset by building both of these packages. go-github-com-lucas-clemente-quic-go: this is a source only package that no other package uses. syncthing: depends on go-github-com-golang-protobuf-proto via several intermediary packages. After building, I've run some of the syncthing executables and they appear to work. --XsQoSWH+UP9D9v3l Content-Type: text/x-diff; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-gnu-Add-go-golang-org-protobuf.patch" Content-Transfer-Encoding: quoted-printable >From 47de2a85a1ae1f0502a89d0097d3b36da7d20649 Mon Sep 17 00:00:00 2001 From: Dion Mendel Date: Thu, 6 May 2021 23:25:22 +0800 Subject: [PATCH 1/2] gnu: Add go-golang-org-protobuf. * gnu/packages/golang.scm (go-golang-org-protobuf): New variable. --- gnu/packages/golang.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 8c3c81ceda..f0fa0e1d36 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -25,6 +25,7 @@ ;;; Copyright =A9 2020 Martin Becze ;;; Copyright =A9 2021 Ricardo Wurmus ;;; Copyright =A9 2021 Guillaume Le Vaillant +;;; Copyright =A9 2021 Dion Mendel ;;; ;;; This file is part of GNU Guix. ;;; @@ -4832,6 +4833,35 @@ data serialization format.") (home-page "https://github.com/golang/protobuf") (license license:bsd-3))) =20 +(define-public go-golang-org-protobuf + (package + (name "go-golang-org-protobuf") + (version "1.26.0") + (home-page "https://github.com/protocolbuffers/protobuf-go") + (source (origin + (method git-fetch) + (uri (git-reference + (url home-page) + (commit (string-append "v" version)))) + (sha256 + (base32 + "0xq6phaps6d0vcv13ga59gzj4306l0ki9kikhmb52h6pq0iwfqlz"))= )) + (build-system go-build-system) + (arguments + `(#:import-path "google.golang.org/protobuf" + ; Source-only package + #:tests? #f + #:phases + (modify-phases %standard-phases + (delete 'build)))) + (propagated-inputs + `(("go-github-com-google-go-cmp-cmp" ,go-github-com-google-go-cmp-c= mp))) + (synopsis "Go support for Protocol Buffers") + (description "This project hosts the Go implementation for protocol = buffers, which is a +language-neutral, platform-neutral, extensible mechanism for serializing +structured data.") + (license license:bsd-3))) + (define-public go-github-com-mattn-go-zglob (package (name "go-github-com-mattn-go-zglob") --=20 2.31.1 --XsQoSWH+UP9D9v3l Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0002-gnu-Replace-go-github-com-golang-protobuf-proto-with.patch" >From 0f029698f12364a475211204498aeb3face1381e Mon Sep 17 00:00:00 2001 From: Dion Mendel Date: Thu, 6 May 2021 23:39:16 +0800 Subject: [PATCH 2/2] gnu: Replace go-github-com-golang-protobuf-proto with go-github-com-golang-protobuf The github.com/golang/protobuf module contains several packages. Only proto is currently packaged. This change updates the module from 1.3.1 to 1.5.2 and packages the entire module. * gnu/packages/golang.scm (go-github-com-golang-protobuf): New variable. (go-github-com-golang-protobuf-proto): Removed variable. (go-github-com-lucas-clemente-quic-go)[propagated-inputs]: Replace go-github-com-golang-protobuf-proto@1.3.1 with go-github-com-golang-protobuf@1.5.2. * gnu/packages/syncthing.scm (go-github-com-matttproud-golang-protobuf-extensions-pbutil) (go-github-com-prometheus-client-golang) (go-github-com-prometheus-client-model) (go-github-com-prometheus-common) [propagated-inputs]: Replace go-github-com-golang-protobuf-proto@1.3.1 with go-github-com-golang-protobuf@1.5.2. --- gnu/packages/golang.scm | 32 ++++++++++++++++++++++---------- gnu/packages/syncthing.scm | 16 ++++++++-------- 2 files changed, 30 insertions(+), 18 deletions(-) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index f0fa0e1d36..9a689d225b 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -4237,7 +4237,7 @@ implementation of generics.") ("go-github-com-cheekybits-genny" ,go-github-com-cheekybits-genny) ("go-github-com-marten-seemann-chacha20" ,go-github-com-marten-seemann-chacha20) ("go-github-com-marten-seemann-qtls" ,go-github-com-marten-seemann-qtls) - ("go-github-com-golang-protobuf-proto" ,go-github-com-golang-protobuf-proto))) + ("go-github-com-golang-protobuf" ,go-github-com-golang-protobuf))) (synopsis "QUIC in Go") (description "This package provides a Go language implementation of the QUIC network protocol.") @@ -4808,10 +4808,10 @@ test results.") (home-page "https://github.com/gotestyourself/gotestsum") (license license:asl2.0))) -(define-public go-github-com-golang-protobuf-proto +(define-public go-github-com-golang-protobuf (package - (name "go-github-com-golang-protobuf-proto") - (version "1.3.1") + (name "go-github-com-golang-protobuf") + (version "1.5.2") (source (origin (method git-fetch) (uri (git-reference @@ -4820,16 +4820,28 @@ test results.") (file-name (git-file-name name version)) (sha256 (base32 - "15am4s4646qy6iv0g3kkqq52rzykqjhm4bf08dk0fy2r58knpsyl")))) + "1mh5fyim42dn821nsd3afnmgscrzzhn3h8rag635d2jnr23r1zhk")))) (build-system go-build-system) (arguments - '(#:import-path "github.com/golang/protobuf/proto" - #:unpack-path "github.com/golang/protobuf" - ;; Requires unpackaged golang.org/x/sync/errgroup - #:tests? #f)) + '(#:import-path "github.com/golang/protobuf" + ; Source-only package + #:tests? #f + #:phases + (modify-phases %standard-phases + (delete 'build)))) + (propagated-inputs + `(("go-golang-org-protobuf" ,go-golang-org-protobuf))) (synopsis "Go support for Protocol Buffers") (description "This package provides Go support for the Protocol Buffers -data serialization format.") +data serialization format. + +It has been superseded by go-golang-org-protobuf, which contains an updated and +simplified API, support for protobuf reflection, and many other improvements. +We recommend that new code use the google.golang.org/protobuf module. + +Versions v1.4 and later of go-github-com-golang-protobuf are implemented in +terms of go-golang-org-protobuf. Programs which use both modules must use +at least version v1.4 of this one.") (home-page "https://github.com/golang/protobuf") (license license:bsd-3))) diff --git a/gnu/packages/syncthing.scm b/gnu/packages/syncthing.scm index e40f696720..67088ca6ca 100644 --- a/gnu/packages/syncthing.scm +++ b/gnu/packages/syncthing.scm @@ -838,8 +838,8 @@ bounds.") ;; Source-only package (delete 'build)))) (propagated-inputs - `(("go-github-com-golang-protobuf-proto" - ,go-github-com-golang-protobuf-proto))) + `(("go-github-com-golang-protobuf" + ,go-github-com-golang-protobuf))) (synopsis "Data model artifacts for Prometheus") (description "This package provides data model artifacts for Prometheus.") (home-page "https://github.com/prometheus/client_model") @@ -867,8 +867,8 @@ bounds.") '(#:import-path "github.com/matttproud/golang_protobuf_extensions/pbutil" #:unpack-path "github.com/matttproud/golang_protobuf_extensions")) (propagated-inputs - `(("go-github-com-golang-protobuf-proto" - ,go-github-com-golang-protobuf-proto))) + `(("go-github-com-golang-protobuf" + ,go-github-com-golang-protobuf))) (synopsis "Streaming Protocol Buffers in Go") (description "This package provides various Protocol Buffer extensions for the Go language, namely support for record length-delimited @@ -907,8 +907,8 @@ message streaming.") ;; Source-only package (delete 'build)))) (propagated-inputs - `(("go-github-com-golang-protobuf-proto" - ,go-github-com-golang-protobuf-proto) + `(("go-github-com-golang-protobuf" + ,go-github-com-golang-protobuf) ("go-github-com-matttproud-golang-protobuf-extensions-pbutil" ,go-github-com-matttproud-golang-protobuf-extensions-pbutil) ("go-github-com-prometheus-client-model" @@ -968,8 +968,8 @@ system, kernel, and process metrics from the @file{/proc} pseudo file system.") (propagated-inputs `(("go-github-com-beorn7-perks-quantile" ,go-github-com-beorn7-perks-quantile) - ("go-github-com-golang-protobuf-proto" - ,go-github-com-golang-protobuf-proto) + ("go-github-com-golang-protobuf" + ,go-github-com-golang-protobuf) ("go-github-com-prometheus-client-model" ,go-github-com-prometheus-client-model) ("go-github-com-prometheus-common" -- 2.31.1 --XsQoSWH+UP9D9v3l-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 08 11:50:53 2021 Received: (at 48259) by debbugs.gnu.org; 8 May 2021 15:50:53 +0000 Received: from localhost ([127.0.0.1]:50933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfPED-0002dv-DC for submit@debbugs.gnu.org; Sat, 08 May 2021 11:50:53 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:32831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfPEB-0002df-4Z for 48259@debbugs.gnu.org; Sat, 08 May 2021 11:50:51 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 305E31324; Sat, 8 May 2021 11:50:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 08 May 2021 11:50:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=aw5/YjmO7p3OZlbLm5YZvkjO z2Uwv/ZeJyxeZ+8JQ5A=; b=jb4OsyLHEhGcMDh5msBbKiu+PjBc0peRqL/6Wkx8 TOLQlQP8S9LGvloPCbod89no0NiECiSCPEQz3cIQWgn5UxWC/qAx0gKcBTwp4+Vo tNsI8sV/X0qyAJDw/QLo7kTC1NfXvbEKgGPL+fGCIRebApbJeqLCiXQbWRyn1dJL G6s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=aw5/Yj mO7p3OZlbLm5YZvkjOz2Uwv/ZeJyxeZ+8JQ5A=; b=vjNbM7Z5cPxPoufYGLYgpU MIsWm35y+ZD6CmKDsenn31pv5Ay0PW2tvU4Hq2jnLkFm2MpgLg9y5ar5b2iAADUq VrM8zTBFQ0mftIXdklU55jxEdpGBdZlMCpJyV7yQBBTyp3Rgg14Lk7Exm5qpMxo5 3/OIhjf/b08sZ484zbkfdqvq53Jpc+liRMl138R9e6I7Cq8GF0m1kD4prvkS4pva FRm/K7gYTmh2L6FinqWJX7Xm6jcz1sUNbAyVSCqaDeu5lCQ1P1sLSg91F1UXeoRx 2hZoN4tCLU0uydFoNr0C1NF2w0OFxxTUN1oGDf7T/y2HVzgZfJvBWF+KD+rQB9Fg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeggedgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepvddvudegffefiedttdfhfedvuefhgf ekieekgeekveetgefhfeetgfegueduffeinecuffhomhgrihhnpehgnhhurdhorhhgnecu kfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 8 May 2021 11:50:44 -0400 (EDT) Date: Sat, 8 May 2021 11:50:42 -0400 From: Leo Famulari To: Dion Mendel Subject: Re: [bug#48259] [PATCH 1/2] gnu: Replace go-github-com-golang-protobuf-proto with go-github-com-golang-protobuf Message-ID: References: <20210506163511.GB27260@dm9.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210506163511.GB27260@dm9.info> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48259 Cc: 48259@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, May 07, 2021 at 12:35:11AM +0800, Dion Mendel wrote: > syncthing: depends on go-github-com-golang-protobuf-proto via several > intermediary packages. After building, I've run some of the syncthing > executables and they appear to work. Just to clarify, since commit ed3ef756f521a0df8596a88b66f65b7a1ad99252, Syncthing does not depend on any Go packages, but instead uses its bundled copies of all its dependencies. https://git.savannah.gnu.org/cgit/guix.git/commit/?id=ed3ef756f521a0df8596a88b66f65b7a1ad99252 From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 08:37:08 2021 Received: (at 48259) by debbugs.gnu.org; 9 May 2021 12:37:08 +0000 Received: from localhost ([127.0.0.1]:55405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfigG-0005HH-Dk for submit@debbugs.gnu.org; Sun, 09 May 2021 08:37:08 -0400 Received: from antelope.elm.relay.mailchannels.net ([23.83.212.4]:15633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfigF-0005H9-1c for 48259@debbugs.gnu.org; Sun, 09 May 2021 08:37:07 -0400 X-Sender-Id: dreamhost|x-authsender|smtp@dm9.info Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BB31434253E for <48259@debbugs.gnu.org>; Sun, 9 May 2021 12:37:05 +0000 (UTC) Received: from pdx1-sub0-mail-a83.g.dreamhost.com (100-98-55-119.trex.outbound.svc.cluster.local [100.98.55.119]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 539EA3415A6 for <48259@debbugs.gnu.org>; Sun, 9 May 2021 12:37:05 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|smtp@dm9.info Received: from pdx1-sub0-mail-a83.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.98.55.119 (trex/6.2.1); Sun, 09 May 2021 12:37:05 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|smtp@dm9.info X-MailChannels-Auth-Id: dreamhost X-Stupid-Ruddy: 452baade0a171cf2_1620563825547_2952866905 X-MC-Loop-Signature: 1620563825547:3304613073 X-MC-Ingress-Time: 1620563825547 Received: from pdx1-sub0-mail-a83.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a83.g.dreamhost.com (Postfix) with ESMTP id C02DA876C9 for <48259@debbugs.gnu.org>; Sun, 9 May 2021 05:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=dm9.info; h=date:from:to :subject:message-id:references:mime-version:content-type :in-reply-to; s=dm9.info; bh=4XyZpJZmpClzg5k4GSx08975pnY=; b=0jc fzZyVVAh9HUzb5UB1NFB6g0bMA3togL9Pvv25PtyiMvGxZseAVHQFc7YJ1KIMrA8 j85Deozk5a2yDEsW8+N/pl+WEOHMuVlog75P6tw/vqy1HGlHB0rqlZvuSt5+L5IZ 1rtGm1dYp4WOsvb3Uv85fHgm/ZqLibFy5lBvvF7w= Received: from mail.localdomain (61-245-140-70.3df58c.per.nbn.aussiebb.net [61.245.140.70]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: smtp@dm9.info) by pdx1-sub0-mail-a83.g.dreamhost.com (Postfix) with ESMTPSA id 821537E5F3 for <48259@debbugs.gnu.org>; Sun, 9 May 2021 05:37:04 -0700 (PDT) Received: by mail.localdomain (Postfix, from userid 2001) id 67838508E7F; Sun, 9 May 2021 20:37:00 +0800 (AWST) Date: Sun, 9 May 2021 20:37:00 +0800 X-DH-BACKEND: pdx1-sub0-mail-a83 From: Dion Mendel To: 48259@debbugs.gnu.org Subject: Re: [bug#48259] [PATCH 1/2] gnu: Replace go-github-com-golang-protobuf-proto with go-github-com-golang-protobuf Message-ID: <20210509123700.GA5323@dm9.info> References: <20210506163511.GB27260@dm9.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48259 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, May 08, 2021 at 11:50:42AM -0400, Leo Famulari wrote: > >Just to clarify, since commit ed3ef756f521a0df8596a88b66f65b7a1ad99252, >Syncthing does not depend on any Go packages, but instead uses its >bundled copies of all its dependencies. Is it acceptable to use bundled copies of dependencies? The manual (section 16.6, checklist #6) says otherwise. If it's okay, this would make packaging lxd much simpler. I've had to package around 90 Go libraries so far. If using lxd's bundled copies of dependencies would be accepted, then I withdraw this patch request. From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 11:17:39 2021 Received: (at 48259) by debbugs.gnu.org; 9 May 2021 15:17:40 +0000 Received: from localhost ([127.0.0.1]:55814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lflBb-0000c1-KN for submit@debbugs.gnu.org; Sun, 09 May 2021 11:17:39 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lflBY-0000bv-2H for 48259@debbugs.gnu.org; Sun, 09 May 2021 11:17:38 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id AC3DC5C00F4; Sun, 9 May 2021 11:17:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 09 May 2021 11:17:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=Y0jtdb2UpV/PhgHC1j1wAw+D c71cMhghHUqh6spVxzs=; b=Lrb9lSM78pxrUOZKa1ISPbqLtHYNWP6EmAa13cZY DjokxyLxlOA3rtwYtPpvbj03j2LPzTjDPKfWrSl1sN8Gj5zct0DZcLbDkVG5P7Hy tIly3urqmn75AtWajYkLVbB6rHruoVN9P1Vts50AztF0gqivPEoQLOPRSrbOFzOg rgs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Y0jtdb 2UpV/PhgHC1j1wAw+Dc71cMhghHUqh6spVxzs=; b=PEW79gKvlRinGfqxxS2HFQ pVvOoWnf3ARS/ZLOS4QwWjfwtY29mfCOU4+6pIoIInPoL0gea2bKcMWY3AvxIco6 8YrxkmkfMfbxgDI6QBgDMVsjYCEVj16OIkUpZFXvVb8jTdcjPjGS1ky0TXwQCUNy OTY+qa6vRYNyyqG/KSuFCxZdFri9jXZdOTeSmr3BJhlLQgn8St0yr4ybgfi1dgtR 6zL6//c6lZfNyadWV+mZWieyKG9y+JyRBDr/7YyXvbniZpm9shDxVvG6qXvQi3Al w/thJ1pS1RdeP7LBEkrR290D37bFd2PaTUpZ8mbQVhXamaBBMEUDw/ZDGBqEe7Cg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegiedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepheegfedvkefgudeuheejtdejtddvie ehleekvefhledvjeevffdtveelveegieejnecuffhomhgrihhnpehgnhhurdhorhhgpdhg ihhthhhusgdrtghomhenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgr rhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 May 2021 11:17:29 -0400 (EDT) Date: Sun, 9 May 2021 11:17:27 -0400 From: Leo Famulari To: Dion Mendel Subject: Re: [bug#48259] [PATCH 1/2] gnu: Replace go-github-com-golang-protobuf-proto with go-github-com-golang-protobuf Message-ID: References: <20210506163511.GB27260@dm9.info> <20210509123700.GA5323@dm9.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210509123700.GA5323@dm9.info> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48259 Cc: 48259@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, May 09, 2021 at 08:37:00PM +0800, Dion Mendel wrote: > Is it acceptable to use bundled copies of dependencies? The manual (section > 16.6, checklist #6) says otherwise. This item, from the manual section Submitting Patches, says: "Make sure the package does not use bundled copies of software already available as separate packages." So, already, there is some wiggle room based on whether or not things are "already available as separate packages." Using bundled dependnencies is strongly discouraged and you are expected to try to avoid it. With Syncthing, there were unfixed security vulnerabilities in our package, and our go-build-system could not build later versions of Syncthing. So, until our go-build-system is overhauled [0], we'll use Syncthing's bundled dependencies. They are all free software anyways. With Go, the old distro model of "no bundling" is not idiomatic, so the future of Go in Guix may look different from how it is now. Go software typically has no concept of "versions" and every program pins its dependencies at specific Git commits. So, to unbundle everything would leave us with hundreds or thousands of versions of popular libraries. We'll have to be creative in how we deal with that. But for now, we try to unbundle. > If it's okay, this would make packaging lxd much simpler. I've had to > package around 90 Go libraries so far. > > If using lxd's bundled copies of dependencies would be accepted, then I > withdraw this patch request. Please, either try packaging them "by hand" or with the Go module importer [1]. Code reviewers will ask you to explain why you are using the bundled dependencies. [0] The work to overhaul go-build-system is progressing. [1] https://guix.gnu.org/manual/devel/en/html_node/Invoking-guix-import.html#Invoking-guix-import I guess it would be a command like: `guix import go github.com/lcx/lxd --recursive -pin-versions` But, it depends on LXD using the standard Go module mechanisms. If it doesn't, maybe each top-level dependency can be imported along with its dependency graph. From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 22:58:49 2021 Received: (at 48259) by debbugs.gnu.org; 10 May 2021 02:58:49 +0000 Received: from localhost ([127.0.0.1]:56883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfw88-0005H0-UP for submit@debbugs.gnu.org; Sun, 09 May 2021 22:58:49 -0400 Received: from olivedrab.birch.relay.mailchannels.net ([23.83.209.135]:6882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfw85-0005Gq-OQ for 48259@debbugs.gnu.org; Sun, 09 May 2021 22:58:47 -0400 X-Sender-Id: dreamhost|x-authsender|smtp@dm9.info Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6326C542709 for <48259@debbugs.gnu.org>; Mon, 10 May 2021 02:58:44 +0000 (UTC) Received: from pdx1-sub0-mail-a9.g.dreamhost.com (100-96-17-237.trex.outbound.svc.cluster.local [100.96.17.237]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D858F542723 for <48259@debbugs.gnu.org>; Mon, 10 May 2021 02:58:43 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|smtp@dm9.info Received: from pdx1-sub0-mail-a9.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.17.237 (trex/6.2.1); Mon, 10 May 2021 02:58:44 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|smtp@dm9.info X-MailChannels-Auth-Id: dreamhost X-Lettuce-Grain: 23fd0c0f1e295a67_1620615524093_3885365568 X-MC-Loop-Signature: 1620615524093:919797917 X-MC-Ingress-Time: 1620615524092 Received: from pdx1-sub0-mail-a9.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTP id 7F63686AFB for <48259@debbugs.gnu.org>; Sun, 9 May 2021 19:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=dm9.info; h=date:from:to :subject:message-id:references:mime-version:content-type :in-reply-to; s=dm9.info; bh=tRj0PAe6bXLMP3CmVCvCJ79KerU=; b=Zq9 LbMur+qHHHhhguqTd7UBiXApHTGn0fAG9hyALGpzgcpWx/sfd1/zZgvRIZu6qM1M jB952HM8MEmPvzR8zMUzO3vKDQNbD+mbZ4tcUwjki48P02VLluf6nsKgyzkMiemW VoJ4JpZD2MR4VfSqWOtLI4QxU5ALUBRPBkVEQYDc= Received: from mail.localdomain (61-245-140-70.3df58c.per.nbn.aussiebb.net [61.245.140.70]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: smtp@dm9.info) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTPSA id ACA4B861BE for <48259@debbugs.gnu.org>; Sun, 9 May 2021 19:58:42 -0700 (PDT) Received: by mail.localdomain (Postfix, from userid 2001) id ABD9650926D; Mon, 10 May 2021 10:58:38 +0800 (AWST) Date: Mon, 10 May 2021 10:58:38 +0800 X-DH-BACKEND: pdx1-sub0-mail-a9 From: Dion Mendel To: 48259@debbugs.gnu.org Subject: Re: [bug#48259] [PATCH 1/2] gnu: Replace go-github-com-golang-protobuf-proto with go-github-com-golang-protobuf Message-ID: <20210510025838.GA7449@dm9.info> References: <20210506163511.GB27260@dm9.info> <20210509123700.GA5323@dm9.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48259 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, May 09, 2021 at 11:17:27AM -0400, Leo Famulari wrote: >But for now, we try to unbundle. Okay, thank you for clarification. When this changeset passes review and is applied, I'll continue with packaging lxd and its dependencies. (Thanks for pointing me towards guix import). From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 15:17:23 2024 Received: (at 48259-done) by debbugs.gnu.org; 23 Jun 2024 19:17:23 +0000 Received: from localhost ([127.0.0.1]:46775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLSiI-0005ay-Uk for submit@debbugs.gnu.org; Sun, 23 Jun 2024 15:17:23 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:48146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLSiG-0005aV-4X for 48259-done@debbugs.gnu.org; Sun, 23 Jun 2024 15:17:21 -0400 Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-35f090093d8so2518358f8f.0 for <48259-done@debbugs.gnu.org>; Sun, 23 Jun 2024 12:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719170174; x=1719774974; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=HBY5jnfPAuWvk43aoAG6n9E3BIQr/4/fVbOtJbg1b/Y=; b=hlertz5JPJzDF9ITtoDf6WjJJTOEZNwEcsDDLIAfSyRLs2L47Dr0JMfdC1kXhuObC2 uz+96OxYTQCLuQOE9CkN/rpBnFFHBvDe1R0HQHbreKRZUK2ktcaBCKbsYLgMPP04eGIF HTrR8cZRLnYUr9M9G2L7lRcx/0m7Gid7aHeslwNuZUdMMj+AKiLkBv8GTCSZeGhoPL0j od4pjYkLWvlr99BkGNNszTn8LuHD79f5QeMamFUXuwHEGyDa+uWdd09wvSJ7ot0HSKfT W8UhJAG0p5tOxlh5XVrRjk60OrpjwQ5Jt4OTcAwC3l4gc5zPhJjD/RERVGCcWxH8pfhm LpEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719170174; x=1719774974; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HBY5jnfPAuWvk43aoAG6n9E3BIQr/4/fVbOtJbg1b/Y=; b=Q+wqqGfQB/LAaiZLgif9aoqY+y+D5UCDgMkoqqeKTRzumlAdxRHYM+88Nxrp54U0mA zVV9E3VbnIe9lD8s509clSDMwJ2PLAPONHl3aXUGdAzy3KeWtkd9BYmoC0kEydOQis2E 9+tZ2ha+PoOw9ltChls1wYhGd51oP1IgY/qAVipzg2oEivAaPzp+JRV7i+QJy+xQNCVu jAz3iMIS0s2zyfcG84DTb6m2CR6ZlBzHE3ai/2ndz8mPLW3gC0JZYwKIJ19bJXIUQ8WZ 4ikbgL7xXfun+Uh/UMu2r/tmND3uydP6QmUyE7WhF+GpHz1uXXWD5top+9bIkq89BlUV eQcQ== X-Gm-Message-State: AOJu0Yx0LEU3gQqlOewyGmX8BK7ZSebwVP8bkfT/gPgifVkqvgtMm83p fNqBZuTybFl4XFegzSQQbYqY7r/hJsL/48KtbomWZAGC3VydpdYDnQVt+f79 X-Google-Smtp-Source: AGHT+IFjcdEtHXHyH3iJ49rFzGmT2HJx5kLcOlNeTL6EzQlTELsmqkus4lxmCNNB164J7kZFmiRW9Q== X-Received: by 2002:a5d:484a:0:b0:363:c25:ddc9 with SMTP id ffacd0b85a97d-366e7a639dbmr2212829f8f.65.1719170173565; Sun, 23 Jun 2024 12:16:13 -0700 (PDT) Received: from guxtil (bagu-15-b2-v4wan-170076-cust245.vm21.cable.virginm.net. [77.98.0.246]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d0c54e4sm150795125e9.23.2024.06.23.12.16.12 for <48259-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jun 2024 12:16:12 -0700 (PDT) From: Sharlatan Hellseher To: 48259-done@debbugs.gnu.org Subject: [PATCH 1/2] gnu: Replace go-github-com-golang-protobuf-proto with go-github-com-golang-protobuf Date: Sun, 23 Jun 2024 20:16:10 +0100 Message-ID: <87h6dj79mt.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48259-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi, It was placed as , in -- Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmZ4dHoACgkQdtcnv/Ys 0rXOOhAA0GT2tVjPdztx56W32WiXW+CPbiwgxj6zGHZ4Q5YfcKehAILjPQc9ytfJ ksIagMoHj3p9uvT/mbDSw6JJOHKe1GFKI51W68Y9VmXGg23r3oPFxKbIgWsoeu8v KJM2p0Z7EneufoFLGPXpKmqrj+gu0vdhlDIuPT0sBlHacQCppiTEESYzyBY/KVi/ jKsnIcBZ/J0356neJUEZDy13ydQd9wX8eJFErxb6avTXcbsZNiDUUz0D9oDkIygm HN7Yvz1pQx/mNgEaVBKK4dhezozQDk2Ta3UwTTHBPsnYuoQKGtWvAde1aRlK0xgL I+GtLx383NzILJ2FQGxRml/+AxtLzp44Iw8ERcHBAtKgpMDb5Y8IOvPLo+9JDavo okSu6dZGCKSoM2ecZR9b921R861fDjIcxDVYB8ryj20hVejB0OmV0AsvcNdVbseb nhlQBKSf7yen+J09+tH9XNb7pldoCeGsN9bNz3UEApp0xD5dp0CYEj840DsGM1/H xYQZ7K4160Dvg5aEzNKQvQ6GxEJ6CnX4O+SccaXSEtL1L9VuKwuehJPp6Gn9AP+C o4fekkekR/KdC6IdLQjUbsj3QHAsn/gnbke7GSWykKz+dj7CU1K0g6hsZML3T1nK 63jlNecI3Nao07BuhE6GvxKT6Fyozr4NPz1Z4Q/cozzlIs/97J8= =7IR/ -----END PGP SIGNATURE----- --=-=-=-- From unknown Wed Aug 20 02:46:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 22 Jul 2024 11:24:22 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator