GNU bug report logs - #48233
[PATCH 0/3] Modest improvements to the guix-install.sh script.

Previous Next

Full log

Message #17 received at 48233 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,48233 <at> debbugs.gnu.org
Subject: Re: [bug#48233] [PATCH 1/3] guix-install.sh: Please the shellcheck
 linter.
Date: Wed, 05 May 2021 06:50:09 -0400

Le 5 mai 2021 00:32:00 GMT-04:00, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> a écrit :
> 
>     wget --help | grep -q '\--show-progress' && \
>         _PROGRESS_OPT="-q --show-progress" || _PROGRESS_OPT=""
>-    wget $_PROGRESS_OPT -P "$dl_path" "${url}/${bin_ver}.tar.xz"
>"${url}/${bin_ver}.tar.xz.sig"
> 
>-    if [[ "$?" -eq 0 ]]; then
>-       _msg "${PAS}download completed."
>+    if wget "$_PROGRESS_OPT" -P "$dl_path" \
>+            "${url}/${bin_ver}.tar.xz" "${url}/${bin_ver}.tar.xz.sig";

"$_PROGRESS_OPT" gets expanded to a single "-q --show-progress", which I doubt exists in wget :). The previous version didn't have quotes.

Otherwise, LGTM. 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.