GNU bug report logs - #48230
[PATCH] tests: go: Rename and fix duplicate test.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Subject: bug#48230: closed (Re: [PATCH] tests: go: Rename and fix
 duplicate test.)
Date: Wed, 05 May 2021 05:05:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#48230: [PATCH] tests: go: Rename and fix duplicate test.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 48230 <at> debbugs.gnu.org.

-- 
48230: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48230
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: francois.joulaud <at> radiofrance.com, 48230-done <at> debbugs.gnu.org
Subject: Re: [PATCH] tests: go: Rename and fix duplicate test.
Date: Wed, 05 May 2021 01:03:54 -0400

Hi Tobias!

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> * tests/go.scm: Rename "go-version omited 'v' character" to
> "go-version without 'v' prefix" and change the code to match.
> ---
>
> Hi all,
>
> Found on a typo hunt.

Eh, thank you!

> This is my best-effort guess at what was intended.  Maybe I'm
> mistaken: is GO-VERSION->GIT-REF supposed to normalise "1.0.2" to
> "v1.0.2" instead?  Let me know!

I wasn't sure anymore, so I looked at the code; go-version->git-ref is a
no-op (leaves the version string intact) unless it matches
%go-pseudo-version-rx.

>  tests/go.scm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/go.scm b/tests/go.scm
> index c33a834f69..565a0d451d 100644
> --- a/tests/go.scm
> +++ b/tests/go.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright  2021 Franois Joulaud <francois.joulaud <at> radiofrance.com>
> +;;; Copyright  2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -158,9 +159,9 @@ require github.com/kr/pretty v0.2.1
>    "v1.0.2"
>    (go-version->git-ref "v1.0.2"))
>  
> -(test-equal "go-version omited 'v' character"
> -  "v1.0.2"
> -  (go-version->git-ref "v1.0.2"))
> +(test-equal "go-version without 'v' prefix"
> +  "1.0.2"
> +  (go-version->git-ref "1.0.2"))

That test doesn't have much value based on my above analysis.  I suggest
we drop it; it's testing the same thing as the "v1.0.2" case.

I've removed it and pushed with commit 2354d79b88.

Thank you!

Maxim

[Message part 3 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: guix-patches <at> gnu.org
Cc: francois.joulaud <at> radiofrance.com, maxim.cournoyer <at> gmail.com
Subject: [PATCH] tests: go: Rename and fix duplicate test.
Date: Tue,  4 May 2021 22:55:48 +0200

* tests/go.scm: Rename "go-version omited 'v' character" to
"go-version without 'v' prefix" and change the code to match.
---

Hi all,

Found on a typo hunt.

This is my best-effort guess at what was intended.  Maybe I'm mistaken: is GO-VERSION->GIT-REF supposed to normalise "1.0.2" to "v1.0.2" instead?  Let me know!

Kind regards,

T G-R

 tests/go.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/go.scm b/tests/go.scm
index c33a834f69..565a0d451d 100644
--- a/tests/go.scm
+++ b/tests/go.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright � 2021 Fran�ois Joulaud <francois.joulaud <at> radiofrance.com>
+;;; Copyright � 2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -158,9 +159,9 @@ require github.com/kr/pretty v0.2.1
   "v1.0.2"
   (go-version->git-ref "v1.0.2"))
 
-(test-equal "go-version omited 'v' character"
-  "v1.0.2"
-  (go-version->git-ref "v1.0.2"))
+(test-equal "go-version without 'v' prefix"
+  "1.0.2"
+  (go-version->git-ref "1.0.2"))
 
 (test-equal "go-version with embedded git-ref"
   "65e3620a7ae7"
-- 
2.31.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.