From unknown Fri Aug 15 16:19:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#48230 <48230@debbugs.gnu.org> To: bug#48230 <48230@debbugs.gnu.org> Subject: Status: [PATCH] tests: go: Rename and fix duplicate test. Reply-To: bug#48230 <48230@debbugs.gnu.org> Date: Fri, 15 Aug 2025 23:19:04 +0000 retitle 48230 [PATCH] tests: go: Rename and fix duplicate test. reassign 48230 guix-patches submitter 48230 Tobias Geerinckx-Rice severity 48230 normal tag 48230 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue May 04 16:56:00 2021 Received: (at submit) by debbugs.gnu.org; 4 May 2021 20:56:00 +0000 Received: from localhost ([127.0.0.1]:55374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le25I-0008PP-0i for submit@debbugs.gnu.org; Tue, 04 May 2021 16:56:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:42544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le25E-0008PJ-NE for submit@debbugs.gnu.org; Tue, 04 May 2021 16:55:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1le25E-0003VV-8M for guix-patches@gnu.org; Tue, 04 May 2021 16:55:56 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:47042) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1le25C-0000OT-7H for guix-patches@gnu.org; Tue, 04 May 2021 16:55:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=jjppBQJmzoe6aO6RhcJQfGjObTgqZhBKisYXDq7uWII=; h=date:subject:cc:to: from; b=H2sP2OT55Kv0F7Y4tIolwgeJ4YBMaD6S16zOPHgyDmXxoXZPv+PX1ArY0TWDL6 usgAEWEcquR/DWE7FVlzks4L1iIak5PmO1VmrNqMuH6I513GRo/vI8/B5EkZ8qElGx9uV2 mABpCDBqMCBuFaDKWd8AbmBxHoNFp/ZYq29S5b/y3cSZQImR76rHz9OPb9lZ3o01VFQrxc pD0rCPy7kkUtpqRnEeN1k4NEAOdu3f/tw27coFwjPozXJuRsbp7gYvPTN4VyGtos1qeUot SMrq9wrZuPLQ4X6r6Bp9ILgP21AX8dR0bN2CpiaQfPBzzQALP6DB6CNiKiLG/INB2Nfr/Q == Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 41b309fa (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Tue, 4 May 2021 20:55:59 +0000 (UTC) From: Tobias Geerinckx-Rice To: guix-patches@gnu.org Subject: [PATCH] tests: go: Rename and fix duplicate test. Date: Tue, 4 May 2021 22:55:48 +0200 Message-Id: <20210504205548.4232-1-me@tobias.gr> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: francois.joulaud@radiofrance.com, maxim.cournoyer@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * tests/go.scm: Rename "go-version omited 'v' character" to "go-version without 'v' prefix" and change the code to match. --- Hi all, Found on a typo hunt. This is my best-effort guess at what was intended. Maybe I'm mistaken: is GO-VERSION->GIT-REF supposed to normalise "1.0.2" to "v1.0.2" instead? Let me know! Kind regards, T G-R tests/go.scm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/go.scm b/tests/go.scm index c33a834f69..565a0d451d 100644 --- a/tests/go.scm +++ b/tests/go.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2021 François Joulaud +;;; Copyright © 2021 Tobias Geerinckx-Rice ;;; ;;; This file is part of GNU Guix. ;;; @@ -158,9 +159,9 @@ require github.com/kr/pretty v0.2.1 "v1.0.2" (go-version->git-ref "v1.0.2")) -(test-equal "go-version omited 'v' character" - "v1.0.2" - (go-version->git-ref "v1.0.2")) +(test-equal "go-version without 'v' prefix" + "1.0.2" + (go-version->git-ref "1.0.2")) (test-equal "go-version with embedded git-ref" "65e3620a7ae7" -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Wed May 05 01:04:06 2021 Received: (at 48230-done) by debbugs.gnu.org; 5 May 2021 05:04:06 +0000 Received: from localhost ([127.0.0.1]:57607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le9hd-0000v1-PA for submit@debbugs.gnu.org; Wed, 05 May 2021 01:04:05 -0400 Received: from mail-qt1-f181.google.com ([209.85.160.181]:44949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le9hZ-0000ua-CA for 48230-done@debbugs.gnu.org; Wed, 05 May 2021 01:04:03 -0400 Received: by mail-qt1-f181.google.com with SMTP id y12so305625qtx.11 for <48230-done@debbugs.gnu.org>; Tue, 04 May 2021 22:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=QlmbDZwsqK5f46uyl7lgSMMil8ZWe6acfTocMyu3mYI=; b=JFYwkXzzYL3e1aimyl9KhYzgfoFX3e8qhpGUGVehUcLhuzvEFXnY+xjXt/u0zMVYUo hl4d7swPcuU4uZ1LkTURF1AqRc8CobJvPDUk5+2kVx52aMgwRnNiPirWI8QBcVw5SHep foHkLJUVaXY0kS4ZepJdKrKEICk/VIE6NnliECC53WTsAsDTt1gBUtbh1tj6nnp2Cp8u ZIVkVv2EJ+xJ9sluGn3fJc8L3TjYz0YN0DGUCVybEhVg6oDA3xRu85KxO+4d8+aiErp+ /cT4Uxv6DlygWSeXywqpLaElAAKKNUBsDdOmRyTh72DcJHI0mZ0C8+7KC0byHRQIS7aq zWlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=QlmbDZwsqK5f46uyl7lgSMMil8ZWe6acfTocMyu3mYI=; b=BXdEGkBTtRYoPefAmYBosVp/BrR3pciLhuy7kdvNlxx3px8USo7eVhkycVh73+jaOo W5IFA09211EM0TkRnFioCdIsmX2Wleij2Zlc9WQIcB7X+JXq7r9ZKUxjz47MAzCkuEOD EKOaN2ZsHEXSwakdwlTgrcXE9qx57sgQldXj74elGKLHy9R2uq8cXrJpCnBEo9xpE/D3 ZoVqMUKLwCbyciUn5jkIyZ0xKNXwZZ16vJjuDMx9sg+ZzRPT3Hxu7aTPun1I7itBSAuU fAw1/N3yXZtCjnH+zYlEDGtFUQ3ZoGS6+sAqQ0Z8Pgovn4gZ3j1qPnQkDd6KmdHtu/MU gEyg== X-Gm-Message-State: AOAM53286UlnUUpDJc82NlvtziqoWO3toA7i5imWwLEl153XMcrYAZrD P0DNsQavN8e61lzQyDdscF4= X-Google-Smtp-Source: ABdhPJxkJh4wFJ9+HBuQvmRud5SIWD4VDMdkFswwClu084BrVngVBPJTNB1YNjbEG83yUJg6kT22ig== X-Received: by 2002:aed:316b:: with SMTP id 98mr25689041qtg.48.1620191035931; Tue, 04 May 2021 22:03:55 -0700 (PDT) Received: from hurd (mtl.savoirfairelinux.net. [208.88.110.46]) by smtp.gmail.com with ESMTPSA id h4sm4016824qtm.88.2021.05.04.22.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 May 2021 22:03:55 -0700 (PDT) From: Maxim Cournoyer To: Tobias Geerinckx-Rice Subject: Re: [PATCH] tests: go: Rename and fix duplicate test. References: <20210504205548.4232-1-me@tobias.gr> Date: Wed, 05 May 2021 01:03:54 -0400 In-Reply-To: <20210504205548.4232-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Tue, 4 May 2021 22:55:48 +0200") Message-ID: <87y2ctkc05.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48230-done Cc: francois.joulaud@radiofrance.com, 48230-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Tobias! Tobias Geerinckx-Rice writes: > * tests/go.scm: Rename "go-version omited 'v' character" to > "go-version without 'v' prefix" and change the code to match. > --- > > Hi all, > > Found on a typo hunt. Eh, thank you! > This is my best-effort guess at what was intended. Maybe I'm > mistaken: is GO-VERSION->GIT-REF supposed to normalise "1.0.2" to > "v1.0.2" instead? Let me know! I wasn't sure anymore, so I looked at the code; go-version->git-ref is a no-op (leaves the version string intact) unless it matches %go-pseudo-version-rx. > tests/go.scm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tests/go.scm b/tests/go.scm > index c33a834f69..565a0d451d 100644 > --- a/tests/go.scm > +++ b/tests/go.scm > @@ -1,5 +1,6 @@ > ;;; GNU Guix --- Functional package management for GNU > ;;; Copyright 2021 Franois Joulaud > +;;; Copyright 2021 Tobias Geerinckx-Rice > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -158,9 +159,9 @@ require github.com/kr/pretty v0.2.1 > "v1.0.2" > (go-version->git-ref "v1.0.2")) > > -(test-equal "go-version omited 'v' character" > - "v1.0.2" > - (go-version->git-ref "v1.0.2")) > +(test-equal "go-version without 'v' prefix" > + "1.0.2" > + (go-version->git-ref "1.0.2")) That test doesn't have much value based on my above analysis. I suggest we drop it; it's testing the same thing as the "v1.0.2" case. I've removed it and pushed with commit 2354d79b88. Thank you! Maxim From unknown Fri Aug 15 16:19:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 02 Jun 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator