From debbugs-submit-bounces@debbugs.gnu.org Tue May 04 09:25:57 2021 Received: (at submit) by debbugs.gnu.org; 4 May 2021 13:25:57 +0000 Received: from localhost ([127.0.0.1]:53209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldv3k-0007k7-Vc for submit@debbugs.gnu.org; Tue, 04 May 2021 09:25:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:47628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldv3h-0007k0-U1 for submit@debbugs.gnu.org; Tue, 04 May 2021 09:25:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldv3h-0001OH-Mt for guix-patches@gnu.org; Tue, 04 May 2021 09:25:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51587) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldv3h-00073r-5Q; Tue, 04 May 2021 09:25:53 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59068 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ldv3g-0000j9-Ez; Tue, 04 May 2021 09:25:53 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 0/2] Avoid Bash wrapper in 'guix' package Date: Tue, 4 May 2021 15:25:42 +0200 Message-Id: <20210504132542.10540-1-ludo@gnu.org> X-Mailer: git-send-email 2.31.1 X-Debbugs-Cc: Maxim Cournoyer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! The first patch here addresses a locale warning coming from Bash that I noticed while using 1.3.0rc1 on Debian. Concretely, without this patch, users will see the Bash locale warning every time ‘guix substitute’ starts (so at least once per session). The second patch is stylistic: it avoids missing phases, which I find more readable. Tested with a native x86_64-linux build and with ‘--target=aarch64-linux-gnu’ from x86_64-linux. I’d like to have these in ‘version-1.3.0’. Thoughts? Ludo’. Ludovic Courtès (2): gnu: guix: Avoid Bash wrapper. gnu: guix: Phases refer to #:system and #:target. gnu/packages/package-management.scm | 74 +++++++++++++++-------------- 1 file changed, 38 insertions(+), 36 deletions(-) -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Tue May 04 09:40:17 2021 Received: (at 48224) by debbugs.gnu.org; 4 May 2021 13:40:17 +0000 Received: from localhost ([127.0.0.1]:53289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldvHc-0007sa-WB for submit@debbugs.gnu.org; Tue, 04 May 2021 09:40:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldvHa-0007sI-MA for 48224@debbugs.gnu.org; Tue, 04 May 2021 09:40:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51834) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldvHV-0005ph-F0; Tue, 04 May 2021 09:40:09 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59102 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ldvHU-0006JJ-Cg; Tue, 04 May 2021 09:40:09 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 48224@debbugs.gnu.org Subject: [PATCH 1/2] gnu: guix: Avoid Bash wrapper. Date: Tue, 4 May 2021 15:39:57 +0200 Message-Id: <20210504133958.11011-1-ludo@gnu.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48224 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) The Bash wrapper created by 'wrap-program' creates an extra indirection and may annoyingly emit locale warnings: /gnu/store/…-bash-minimal-5.0.16/bin/bash: warning: setlocale: LC_ALL: cannot change locale (wtf) This warning would typically show up when running Guix, as produced by 'guix pack guix', on a foreign distro, annihilating efforts made in 1d4ab335b22a93e01c2eb1eb3e93fc6534157040 and 8a973abc6f7eebfcd8a904bfbb99cb9f86f66ef0. * gnu/packages/package-management.scm (guix)[arguments]: In 'wrap-program' phase, remove 'string-join' call for PATH and GOPATH. Replace 'wrap-program' call with a 'substitute*' form. Remove (when target ...) form. [inputs]: Remove "bash-minimal" added in commit 38b9af7c92344a17b6680ebd2aeea14171f84a1c and no longer needed. --- gnu/packages/package-management.scm | 56 ++++++++++++++++------------- 1 file changed, 31 insertions(+), 25 deletions(-) diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm index 827166c938..1a637f9ec8 100644 --- a/gnu/packages/package-management.scm +++ b/gnu/packages/package-management.scm @@ -326,31 +326,38 @@ $(prefix)/etc/openrc\n"))) (open-pipe* OPEN_READ (string-append guile "/bin/guile") "-c" "(display (effective-version))"))) - (path (string-join - (map (cut string-append <> - "/share/guile/site/" - effective) - (delete #f deps*)) - ":")) - (gopath (string-join - (map (cut string-append <> - "/lib/guile/" effective - "/site-ccache") - (delete #f deps*)) - ":")) + (path (map (cut string-append <> + "/share/guile/site/" + effective) + (delete #f deps*))) + (gopath (map (cut string-append <> + "/lib/guile/" effective + "/site-ccache") + (delete #f deps*))) (locpath (string-append locales "/lib/locale"))) - (wrap-program (string-append out "/bin/guix") - `("GUILE_LOAD_PATH" ":" prefix (,path)) - `("GUILE_LOAD_COMPILED_PATH" ":" prefix (,gopath)) - `("GUIX_LOCPATH" ":" suffix (,locpath))) - - (when target - ;; XXX Touching wrap-program rebuilds world - (let ((bash (assoc-ref inputs "bash"))) - (substitute* (string-append out "/bin/guix") - (("^#!.*/bash") (string-append "#! " bash "/bin/bash"))))) - #t))) + ;; Modify 'guix' directly instead of using + ;; 'wrap-command'. This avoids the indirection + ;; through Bash, which in turn avoids getting Bash's + ;; own locale warnings. + (substitute* (string-append out "/bin/guix") + (("!#") + (string-append + "!#\n\n" + (object->string + `(set! %load-path (append ',path %load-path))) + "\n" + (object->string + `(set! %load-compiled-path + (append ',gopath %load-compiled-path))) + "\n" + (object->string + `(let ((path (getenv "GUIX_LOCPATH"))) + (setenv "GUIX_LOCPATH" + (if path + (string-append path ":" ,locpath) + ,locpath)))) + "\n\n")))))) ;; The 'guix' executable has 'OUT/libexec/guix/guile' as ;; its shebang; that should remain unchanged, thus remove @@ -405,8 +412,7 @@ $(prefix)/etc/openrc\n"))) `(("boot-guile/i686" ,(bootstrap-guile-origin "i686-linux"))) '()) ,@(if (%current-target-system) - `(("bash" ,bash-minimal) - ("xz" ,xz)) + `(("xz" ,xz)) '()) ;; Tests also rely on these bootstrap executables. -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Tue May 04 09:40:18 2021 Received: (at 48224) by debbugs.gnu.org; 4 May 2021 13:40:18 +0000 Received: from localhost ([127.0.0.1]:53291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldvHe-0007sh-Bc for submit@debbugs.gnu.org; Tue, 04 May 2021 09:40:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldvHc-0007sL-E6 for 48224@debbugs.gnu.org; Tue, 04 May 2021 09:40:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51835) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldvHW-0005po-Ak; Tue, 04 May 2021 09:40:10 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59102 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ldvHV-0006JJ-PF; Tue, 04 May 2021 09:40:10 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 48224@debbugs.gnu.org Subject: [PATCH 2/2] gnu: guix: Phases refer to #:system and #:target. Date: Tue, 4 May 2021 15:39:58 +0200 Message-Id: <20210504133958.11011-2-ludo@gnu.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210504133958.11011-1-ludo@gnu.org> References: <20210504133958.11011-1-ludo@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48224 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/package-management.scm (guix)[arguments]: In 'copy-bootstrap-guile' and 'wrap-program' phases, refer to #:system and #:target instead of unquoting (%current-system) and (%current-target-system). --- gnu/packages/package-management.scm | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm index 1a637f9ec8..5c6937adb8 100644 --- a/gnu/packages/package-management.scm +++ b/gnu/packages/package-management.scm @@ -261,11 +261,9 @@ $(prefix)/etc/openrc\n"))) (intern (assoc-ref inputs "boot-guile") #f) ;; On x86_64 some tests need the i686 Guile. - ,@(if (and (not (%current-target-system)) - (string=? (%current-system) - "x86_64-linux")) - '((intern (assoc-ref inputs "boot-guile/i686") #f)) - '()) + (when (and (not target) + (string=? system "x86_64-linux")) + (intern (assoc-ref inputs "boot-guile/i686") #f)) ;; Copy the bootstrap executables. (for-each (lambda (input) @@ -299,9 +297,9 @@ $(prefix)/etc/openrc\n"))) ;; Make sure the 'guix' command finds GnuTLS, ;; Guile-JSON, and Guile-Git automatically. (let* ((out (assoc-ref outputs "out")) - (guile ,@(if (%current-target-system) - '((assoc-ref native-inputs "guile")) - '((assoc-ref inputs "guile")))) + (guile (if target + (assoc-ref native-inputs "guile") + (assoc-ref inputs "guile"))) (avahi (assoc-ref inputs "guile-avahi")) (gcrypt (assoc-ref inputs "guile-gcrypt")) (guile-lib (assoc-ref inputs "guile-lib")) @@ -318,9 +316,7 @@ $(prefix)/etc/openrc\n"))) (locales (assoc-ref inputs "glibc-utf8-locales")) (deps (list gcrypt json sqlite gnutls git bs ssh zlib lzlib zstd guile-lib)) - (deps* ,@(if (%current-target-system) - '(deps) - '((cons avahi deps)))) + (deps* (if target deps (cons avahi deps))) (effective (read-line (open-pipe* OPEN_READ -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Tue May 04 15:22:31 2021 Received: (at 48224) by debbugs.gnu.org; 4 May 2021 19:22:31 +0000 Received: from localhost ([127.0.0.1]:54929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le0co-0007Og-SE for submit@debbugs.gnu.org; Tue, 04 May 2021 15:22:31 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:60124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le0cl-0007OZ-FQ for 48224@debbugs.gnu.org; Tue, 04 May 2021 15:22:29 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by michel.telenet-ops.be with bizsmtp id 0jNQ2500H0mfAB406jNRZk; Tue, 04 May 2021 21:22:26 +0200 Message-ID: <09cee506693a26af13b7fbc318f7a09528161bbc.camel@telenet.be> Subject: Re: [bug#48224] [PATCH 2/2] gnu: guix: Phases refer to #:system and #:target. From: Maxime Devos To: Ludovic =?ISO-8859-1?Q?Court=E8s?= , 48224@debbugs.gnu.org Date: Tue, 04 May 2021 21:21:24 +0200 In-Reply-To: <20210504133958.11011-2-ludo@gnu.org> References: <20210504133958.11011-1-ludo@gnu.org> <20210504133958.11011-2-ludo@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-vyd+lAXi5P8IDrMI97jE" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1620156146; bh=9PYFJlTyH/uVFhQXjFIY1EPai2pBFP8+oyH4sb1bavU=; h=Subject:From:To:Date:In-Reply-To:References; b=CdHLGzQ6dpZs4f4nP0lQTznCo6aEDUBc+phbnZBwKzTUHeszqnHTGlHpdpLz1bzW3 K+NGEc9e7CZyG74pYg6irGMSIHK2VfDI10NDwIll737pLadyC558jvFKIlzY5r6NJa J5DiWJduaYmMa2c4FW5d7phuKCL8tFkx9r/HQ2bBcTHsJ3Tu0swjOu3wOCrukjXyvq w3YtcdBUz5RbUOzTH9U3RywkCdeOMXogSh5fujhW4Pr5j+8BjsQKRQAe1aHs45ILl9 030ubcmIVDCpWhxSK6oC6x3aLTCRuUpFEK//NkgKxvyLyjUM8XLEyB3rnpjyjzIMBY zBYN0Nxzeu/Nw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48224 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-vyd+lAXi5P8IDrMI97jE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > The second patch is stylistic: it avoids missing phases, which I > find more readable. I don't see any missing phases. (I read this as =E2=80=98The second patch i= s stylistic: it avoids making the existence of a phase dependent on %current-target-system.=E2=80=99) > - (guile ,@(if (%current-target-system) > - '((assoc-ref native-inputs = "guile")) > - '((assoc-ref inputs "guile"= )))) > + (guile (if target > + (assoc-ref native-inputs "gui= le") > + (assoc-ref inputs "guile"))) Something I tend to do is (assoc-ref (or native-inputs inputs) "guile") Do you have any particular preference? > (deps (list gcrypt json sqlite gnutls g= it > bs ssh zlib lzlib zstd guil= e-lib)) > - (deps* ,@(if (%current-target-system) > - '(deps) > - '((cons avahi deps)))) > + (deps* (if target deps (cons avahi deps)= )) Why not simply ;; avahi is #f (not in 'inputs') when cross-compiling. ;; Remove it. (deps* (delete #f avahi)) ? Then, when guile-avahi becomes cross-compilable at some point, we only need to adjust 'propagated-inputs' and not anything else. Also, was this code (deps* ,@(if (%current-target-system) '(deps) ...)) nee= ded in the first place? guile2.2-guix inherits its phases from guix, and guile2.2= -guix does not have a guile-zlib or guile-lzlib input. Greetings, Maxime. --=-vyd+lAXi5P8IDrMI97jE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYJGetxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lKCAQDII0Euh3ERQWLQkV5IwF9598e9 7EFyt3bCCrCOSwfdwQD+L08KkO2TPoYUOc9FQzDcEBWyjskAmMYJP2Ld35e+qQI= =feig -----END PGP SIGNATURE----- --=-vyd+lAXi5P8IDrMI97jE-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 04 19:05:25 2021 Received: (at 48224) by debbugs.gnu.org; 4 May 2021 23:05:25 +0000 Received: from localhost ([127.0.0.1]:55953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le46W-0001Du-Vo for submit@debbugs.gnu.org; Tue, 04 May 2021 19:05:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le46T-0001Dm-3l for 48224@debbugs.gnu.org; Tue, 04 May 2021 19:05:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33650) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1le46N-0004DT-Ak; Tue, 04 May 2021 19:05:15 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34412 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1le46D-00037g-Ng; Tue, 04 May 2021 19:05:13 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxime Devos Subject: Re: bug#48224: [PATCH 0/2] Avoid Bash wrapper in 'guix' package References: <20210504133958.11011-1-ludo@gnu.org> <20210504133958.11011-2-ludo@gnu.org> <09cee506693a26af13b7fbc318f7a09528161bbc.camel@telenet.be> Date: Wed, 05 May 2021 01:05:03 +0200 In-Reply-To: <09cee506693a26af13b7fbc318f7a09528161bbc.camel@telenet.be> (Maxime Devos's message of "Tue, 04 May 2021 21:21:24 +0200") Message-ID: <878s4uksm8.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48224 Cc: 48224@debbugs.gnu.org, Vagrant Cascadian X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Pushed to =E2=80=98master=E2=80=99 with followup commits to address the =E2= =80=98guile2.2-guix=E2=80=99 issues you mentioned: dd3e4fe6e7 gnu: guile2.2-guix: Add missing dependencies. 2238bd8ddc gnu: guile-lzlib: Add Guile 2.2 variant. 2a9af22540 gnu: guile-zlib: Add Guile 2.2 variant. c3f20a6678 gnu: guix: Phases refer to #:system, #:target, and #:native-in= puts. e42bfd236e gnu: guix: Avoid Bash wrapper. 55f7cd701c gnu: guix: Add run-time dependency on Guile-Lib. I=E2=80=99ll cherry-pick to =E2=80=98version-1.3.0=E2=80=99. =E2=80=98guile2.2-guix=E2=80=99 fails tests/swh.scm though, because (guix s= wh) relies on #:verify-certificate?, which Guile 2.2 didn=E2=80=99t have. I wonder how Vagrant addressed that for Debian? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue May 04 19:26:40 2021 Received: (at 48224) by debbugs.gnu.org; 4 May 2021 23:26:41 +0000 Received: from localhost ([127.0.0.1]:56036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le4R6-0001Ne-P8 for submit@debbugs.gnu.org; Tue, 04 May 2021 19:26:40 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:45604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le4R4-0001NP-2L for 48224@debbugs.gnu.org; Tue, 04 May 2021 19:26:39 -0400 Received: from localhost (97-120-1-76.ptld.qwest.net [97.120.1.76]) (Authenticated sender: vagrant@aikidev.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 422D91A904; Tue, 4 May 2021 16:26:32 -0700 (PDT) From: Vagrant Cascadian To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Maxime Devos Subject: Re: bug#48224: [PATCH 0/2] Avoid Bash wrapper in 'guix' package In-Reply-To: <878s4uksm8.fsf_-_@gnu.org> References: <20210504133958.11011-1-ludo@gnu.org> <20210504133958.11011-2-ludo@gnu.org> <09cee506693a26af13b7fbc318f7a09528161bbc.camel@telenet.be> <878s4uksm8.fsf_-_@gnu.org> Date: Tue, 04 May 2021 16:26:13 -0700 Message-ID: <87y2cursh6.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48224 Cc: 48224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-05-05, Ludovic Court=C3=A8s wrote: > Pushed to =E2=80=98master=E2=80=99 with followup commits to address the = =E2=80=98guile2.2-guix=E2=80=99 > issues you mentioned: > > dd3e4fe6e7 gnu: guile2.2-guix: Add missing dependencies. > 2238bd8ddc gnu: guile-lzlib: Add Guile 2.2 variant. > 2a9af22540 gnu: guile-zlib: Add Guile 2.2 variant. > c3f20a6678 gnu: guix: Phases refer to #:system, #:target, and #:native-= inputs. > e42bfd236e gnu: guix: Avoid Bash wrapper. > 55f7cd701c gnu: guix: Add run-time dependency on Guile-Lib. > > I=E2=80=99ll cherry-pick to =E2=80=98version-1.3.0=E2=80=99. > > =E2=80=98guile2.2-guix=E2=80=99 fails tests/swh.scm though, because (guix= swh) relies on > #:verify-certificate?, which Guile 2.2 didn=E2=80=99t have. I wonder how > Vagrant addressed that for Debian? Heavy handedly sprinkling (test-skip 1): https://salsa.debian.org/debian/guix/-/blob/debian/devel/debian/patches/0= 029-tests-swh.scm-Disable-tests-the-fail-with-guile-2.2.patch https://salsa.debian.org/debian/guix/-/blob/debian/devel/debian/patches/0= 032-Disable-origin-visit-no-snapshots-test.patch It would be nice to be able to automatically skip tests using known guile 3 features when building with guile 2.2; maybe that will require flagging each test individually or maybe there is a clever way to do that dynamically? live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYJHYFQAKCRDcUY/If5cW qnzcAP96/2Vyig4NV5DdhMbUTbV/2/LvmecpvNodX/zmIJ5/eQD/X5IlPnckxLN8 lph4II1y5uTE1a7l1vvC4pTP/NitNAg= =6OVb -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 17:53:51 2021 Received: (at control) by debbugs.gnu.org; 9 May 2021 21:53:51 +0000 Received: from localhost ([127.0.0.1]:56724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfrN0-00049h-Jq for submit@debbugs.gnu.org; Sun, 09 May 2021 17:53:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfrMy-00049S-W9 for control@debbugs.gnu.org; Sun, 09 May 2021 17:53:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45300) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfrMt-0001WP-P5 for control@debbugs.gnu.org; Sun, 09 May 2021 17:53:43 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60714 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfrMt-0004AQ-As for control@debbugs.gnu.org; Sun, 09 May 2021 17:53:43 -0400 Date: Sun, 09 May 2021 23:53:42 +0200 Message-Id: <87y2cn60bd.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #48224 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 48224 quit From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 17:56:21 2021 Received: (at 48224) by debbugs.gnu.org; 9 May 2021 21:56:22 +0000 Received: from localhost ([127.0.0.1]:56739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfrPR-0004Eg-CB for submit@debbugs.gnu.org; Sun, 09 May 2021 17:56:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfrPP-0004ET-Jq for 48224@debbugs.gnu.org; Sun, 09 May 2021 17:56:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45370) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfrPJ-0003Vj-8l; Sun, 09 May 2021 17:56:13 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60744 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfrPI-0004d5-UI; Sun, 09 May 2021 17:56:13 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Vagrant Cascadian Subject: Re: bug#48224: [PATCH 0/2] Avoid Bash wrapper in 'guix' package References: <20210504133958.11011-1-ludo@gnu.org> <20210504133958.11011-2-ludo@gnu.org> <09cee506693a26af13b7fbc318f7a09528161bbc.camel@telenet.be> <878s4uksm8.fsf_-_@gnu.org> <87y2cursh6.fsf@yucca> Date: Sun, 09 May 2021 23:56:11 +0200 In-Reply-To: <87y2cursh6.fsf@yucca> (Vagrant Cascadian's message of "Tue, 04 May 2021 16:26:13 -0700") Message-ID: <87tunb6078.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48224 Cc: 48224@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Vagrant Cascadian skribis: >> =E2=80=98guile2.2-guix=E2=80=99 fails tests/swh.scm though, because (gui= x swh) relies on >> #:verify-certificate?, which Guile 2.2 didn=E2=80=99t have. I wonder how >> Vagrant addressed that for Debian? > > Heavy handedly sprinkling (test-skip 1): > > https://salsa.debian.org/debian/guix/-/blob/debian/devel/debian/patches= /0029-tests-swh.scm-Disable-tests-the-fail-with-guile-2.2.patch > https://salsa.debian.org/debian/guix/-/blob/debian/devel/debian/patches= /0032-Disable-origin-visit-no-snapshots-test.patch This patch addresses the problem: https://git.savannah.gnu.org/cgit/guix.git/commit/?h=3Dversion-1.3.0&id= =3D626e61959089b9c7d1faa5dd6b15f8ed94f551fb (It=E2=80=99s in 1.3.0rc2.) HTH! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 23:46:19 2021 Received: (at 48224) by debbugs.gnu.org; 13 May 2021 03:46:19 +0000 Received: from localhost ([127.0.0.1]:40998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lh2Ik-0006Vd-VJ for submit@debbugs.gnu.org; Wed, 12 May 2021 23:46:19 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:33052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lh2Ii-0006VQ-KK for 48224@debbugs.gnu.org; Wed, 12 May 2021 23:46:17 -0400 Received: from localhost (97-120-1-76.ptld.qwest.net [97.120.1.76]) (Authenticated sender: vagrant@aikidev.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 391E41AF2E; Wed, 12 May 2021 20:46:10 -0700 (PDT) From: Vagrant Cascadian To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#48224: [PATCH 0/2] Avoid Bash wrapper in 'guix' package In-Reply-To: <87tunb6078.fsf_-_@gnu.org> References: <20210504133958.11011-1-ludo@gnu.org> <20210504133958.11011-2-ludo@gnu.org> <09cee506693a26af13b7fbc318f7a09528161bbc.camel@telenet.be> <878s4uksm8.fsf_-_@gnu.org> <87y2cursh6.fsf@yucca> <87tunb6078.fsf_-_@gnu.org> Date: Wed, 12 May 2021 20:45:47 -0700 Message-ID: <87fsyrqot0.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48224 Cc: 48224@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-05-09, Ludovic Court=C3=A8s wrote: > Vagrant Cascadian skribis: >>> =E2=80=98guile2.2-guix=E2=80=99 fails tests/swh.scm though, because (gu= ix swh) relies on >>> #:verify-certificate?, which Guile 2.2 didn=E2=80=99t have. I wonder h= ow >>> Vagrant addressed that for Debian? >> >> Heavy handedly sprinkling (test-skip 1): >> >> https://salsa.debian.org/debian/guix/-/blob/debian/devel/debian/patche= s/0029-tests-swh.scm-Disable-tests-the-fail-with-guile-2.2.patch >> https://salsa.debian.org/debian/guix/-/blob/debian/devel/debian/patche= s/0032-Disable-origin-visit-no-snapshots-test.patch > > This patch addresses the problem: > > https://git.savannah.gnu.org/cgit/guix.git/commit/?h=3Dversion-1.3.0&id= =3D626e61959089b9c7d1faa5dd6b15f8ed94f551fb > > (It=E2=80=99s in 1.3.0rc2.) Just tested 1.3.0 with the tests enabled again, and they passed! Thanks! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYJyg6wAKCRDcUY/If5cW qm7SAQCdC1WGi4X9tHObc6SMH7dcQZV9uDJSA7wNgyW0lPVLdAEAvTb+6sW0fC2O I2a/mhZojik9BC8tga0RPsfV0FrdRAE= =LEf5 -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Jun 17 01:46:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 10 Jun 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator