From debbugs-submit-bounces@debbugs.gnu.org Tue May 04 05:21:43 2021 Received: (at submit) by debbugs.gnu.org; 4 May 2021 09:21:43 +0000 Received: from localhost ([127.0.0.1]:52021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldrFP-00074T-Fz for submit@debbugs.gnu.org; Tue, 04 May 2021 05:21:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:38964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldrFK-00074N-9K for submit@debbugs.gnu.org; Tue, 04 May 2021 05:21:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldrFK-000430-2M for guix-patches@gnu.org; Tue, 04 May 2021 05:21:38 -0400 Received: from mout-p-201.mailbox.org ([2001:67c:2050::465:201]:50030) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1ldrFF-0004ab-B3 for guix-patches@gnu.org; Tue, 04 May 2021 05:21:37 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4FZDqT1PbHzQjxG for ; Tue, 4 May 2021 11:21:25 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1620120083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7HDqoi7gMoDp/ULg0qHOGyl1htMWr16/S6PkP7UZh3M=; b=Yjd2KHMu0RMRC3PwT+1xUj7TvSSinxIjavXeItp5MqFIEYOIzYcixTUlgIYFQWrCHKObHx wc2GEjV1AKHjtnP4mxcpJKCzCdSC/ZogMMq/vYmQHzHcT0ToZd2ScvECnoTrW2LEM1y0+y lk7lY/oRe66PRHVPd8Z4OWCGPA/ppZIczwpAqDhfY7Q0/BG0p+3XDOWR8eTVU5gg1pcL7j EflhM9E6o2hN9FuKdG9CUDbbszXkqZYwBqU/RypKI9m4mwPg1ogTPxNRzMauvZ+SU+mOyL YmMHLdN09UufOZ/AeN90DO/iwQNYjui5XbaYZRbb0oWfbt7kRx5mj5rxhMeO2w== Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id CpPFpfykXHtn for ; Tue, 4 May 2021 11:21:21 +0200 (CEST) From: Brendan Tildesley To: guix-patches@gnu.org Subject: [PATCH] gnu: xfce4-session: Add xset to propagated-inputs. Date: Tue, 4 May 2021 19:20:51 +1000 Message-Id: <20210504092051.24383-1-mail@brendan.scot> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: ** X-Rspamd-Score: 2.11 / 15.00 / 15.00 X-Rspamd-Queue-Id: EE3AF1404 X-Rspamd-UID: 937465 Received-SPF: pass client-ip=2001:67c:2050::465:201; envelope-from=mail@brendan.scot; helo=mout-p-201.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) * gnu/packages/xfce.scm (xfce4-session):[propagated-inputs]: Add xset so that xflock4 can turn off the monitor. --- gnu/packages/xfce.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm index 9655d8ccf7..f1e40a94b8 100644 --- a/gnu/packages/xfce.scm +++ b/gnu/packages/xfce.scm @@ -718,6 +718,8 @@ your system in categories, so you can quickly find and launch them.") ("libsm" ,libsm) ("libwnck" ,libwnck) ("libxfce4ui" ,libxfce4ui))) + (propagated-inputs + `(("xset" ,xset))) (home-page "https://www.xfce.org/") (synopsis "Xfce session manager") (description -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Wed May 05 09:23:59 2021 Received: (at 48220) by debbugs.gnu.org; 5 May 2021 13:23:59 +0000 Received: from localhost ([127.0.0.1]:60188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHVP-0007n5-DI for submit@debbugs.gnu.org; Wed, 05 May 2021 09:23:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHVO-0007mz-A7 for 48220@debbugs.gnu.org; Wed, 05 May 2021 09:23:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44207) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leHVH-0001pX-UR; Wed, 05 May 2021 09:23:51 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35996 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1leHVH-0000OT-GG; Wed, 05 May 2021 09:23:51 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Brendan Tildesley Subject: Re: bug#48220: [PATCH] gnu: xfce4-session: Add xset to propagated-inputs. References: <20210504092051.24383-1-mail@brendan.scot> Date: Wed, 05 May 2021 15:23:50 +0200 In-Reply-To: <20210504092051.24383-1-mail@brendan.scot> (Brendan Tildesley's message of "Tue, 4 May 2021 19:20:51 +1000") Message-ID: <87v97xjoux.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48220 Cc: 48220@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Brendan, Brendan Tildesley skribis: > * gnu/packages/xfce.scm (xfce4-session):[propagated-inputs]: Add xset so > that xflock4 can turn off the monitor. Can=E2=80=99t we instead patch =E2=80=98scripts/xflock4=E2=80=99 so that it= refers to =E2=80=98xset=E2=80=99 by its absolute file name? However, my understanding is that the xset code is already a fallback: --8<---------------cut here---------------start------------->8--- # else run another access locking utility, if installed for lock_cmd in \ "xlock -mode blank" \ "slock" do set -- $lock_cmd if command -v -- $1 >/dev/null 2>&1; then $lock_cmd >/dev/null 2>&1 & # turn off display backlight: xset dpms force off exit fi done --8<---------------cut here---------------end--------------->8--- Probably we should ensure the first =E2=80=98for=E2=80=99 loop works as exp= ected. Perhaps we need to replace =E2=80=98xfce4-screensaver-command=E2=80=99 by i= ts absolute file name there. WDYT? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed May 05 22:39:11 2021 Received: (at 48220) by debbugs.gnu.org; 6 May 2021 02:39:11 +0000 Received: from localhost ([127.0.0.1]:35952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leTux-0007Qw-F6 for submit@debbugs.gnu.org; Wed, 05 May 2021 22:39:11 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:21842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leTuv-0007Qq-7r for 48220@debbugs.gnu.org; Wed, 05 May 2021 22:39:10 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4FbHpH3z8NzQk20; Thu, 6 May 2021 04:39:03 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1620268741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8C+BiHavEy6rD6+a4VDg/RML+exW7U09fx2cJmtm+GY=; b=s9QxxFi/UXguLEi4SDBGDEKBsmQBEraOCFBpUbis9rUO/U4dp6qGLlh4r3lxg7iEdRinPP 0fVlHnyJyGETU3w4lIUZHQMijvld3BtcC4CfhDR5FOilr00/1+9cM6xzdtHTSfMoxKgsoR gdhcQFtgDIK7+JGJUvPyu6hxBRsWJBkDD7abABTt0RXH4t2pNr4LdeDnZjOR0CdwI3+0dJ IVbDseUkuPrOiU/iVJCSMbxKQS7vRzfW28yyD1m/ZPVLvfw2HZgVdxaVkk3Pjy/SjF3Ddb VqmOKQ2gVVhASPXZIuPY8jJ1Plu86TDkDCBvqaJIz74qd/r367VO1AU99OyRBQ== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter02.heinlein-hosting.de (spamfilter02.heinlein-hosting.de [80.241.56.116]) (amavisd-new, port 10030) with ESMTP id XfJoPkIOdQ6Q; Thu, 6 May 2021 04:38:59 +0200 (CEST) Date: Thu, 6 May 2021 04:38:58 +0200 (CEST) From: Brendan Tildesley To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Message-ID: <615974577.179836.1620268738791@office.mailbox.org> In-Reply-To: <87v97xjoux.fsf@gnu.org> References: <20210504092051.24383-1-mail@brendan.scot> <87v97xjoux.fsf@gnu.org> Subject: Re: bug#48220: [PATCH] gnu: xfce4-session: Add xset to propagated-inputs. MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_179835_493377898.1620268738709" X-Priority: 3 Importance: Normal X-MBO-SPAM-Probability: X-Rspamd-Score: -6.17 / 15.00 / 15.00 X-Rspamd-Queue-Id: 3C4B017E8 X-Rspamd-UID: aa6372 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48220 Cc: 48220@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) ------=_Part_179835_493377898.1620268738709 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable > On 05/05/2021 3:23 PM Ludovic Court=C3=A8s wrote: >=20 > =20 > Hi Brendan, >=20 > Brendan Tildesley skribis: >=20 > > * gnu/packages/xfce.scm (xfce4-session):[propagated-inputs]: Add xset s= o > > that xflock4 can turn off the monitor. >=20 > Can=E2=80=99t we instead patch =E2=80=98scripts/xflock4=E2=80=99 so that = it refers to =E2=80=98xset=E2=80=99 by > its absolute file name? >=20 I can. It felt weird just patching one command and not others though. > However, my understanding is that the xset code is already a fallback: >=20 > --8<---------------cut here---------------start------------->8--- > # else run another access locking utility, if installed > for lock_cmd in \ > "xlock -mode blank" \ > "slock" > do > set -- $lock_cmd > if command -v -- $1 >/dev/null 2>&1; then > $lock_cmd >/dev/null 2>&1 & > =09# turn off display backlight: > =09xset dpms force off > exit > fi > done > --8<---------------cut here---------------end--------------->8--- >=20 > Probably we should ensure the first =E2=80=98for=E2=80=99 loop works as e= xpected. > Perhaps we need to replace =E2=80=98xfce4-screensaver-command=E2=80=99 by= its absolute > file name there. >=20 Currently xfce4-screensaver is not installed in the xfce package at all by = default, so it isn't used. I could add it, but for me it was glitchy/flickering and = I would keep=20 clearing the password as I was entering it so I couldn't log back in. It ev= en does it in a VM. I do have a recent amd graphics card with proprietary linux though= , my computer can't boot otherwise :(. If you run guix environment --ad-hoc xfce4-screensaver then xfce4-screensaver &; xfce4-screensaver-command --lock does it work for you? I'm not sure what is best, should we be maximal and include xfce4-screensav= er in the xfce package, or be minimal and make people have to install it manually? > WDYT? >=20 > Thanks, > Ludo=E2=80=99. ------=_Part_179835_493377898.1620268738709 Content-Type: text/x-patch; charset=ISO-8859-1; name=0001-gnu-xfce4-session-Add-xset-to-propagated-inputs.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-xfce4-session-Add-xset-to-propagated-inputs.patch X-Part-Id: d6d958cff74c452c9c1165769ec3bd2e RnJvbSBlMWU5NjhmMjEzNzRiMmMxMjVkMWZjMTM0OGE1MzFmMTZmYWM2YjRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcmVuZGFuIFRpbGRlc2xleSA8bWFpbEBicmVuZGFuLnNjb3Q+ CkRhdGU6IFR1ZSwgMjcgQXByIDIwMjEgMTU6MzQ6NTAgKzEwMDAKU3ViamVjdDogW1BBVENIXSBn bnU6IHhmY2U0LXNlc3Npb246IEFkZCB4c2V0IHRvIHByb3BhZ2F0ZWQtaW5wdXRzLgoKKiBnbnUv cGFja2FnZXMveGZjZS5zY20gKHhmY2U0LXNlc3Npb24pOltwcm9wYWdhdGVkLWlucHV0c106IEFk ZCB4c2V0IHNvCnRoYXQgeGZsb2NrNCBjYW4gdHVybiBvZmYgdGhlIG1vbml0b3IuCi0tLQogZ251 L3BhY2thZ2VzL3hmY2Uuc2NtIHwgMiArKwogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygr KQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy94ZmNlLnNjbSBiL2dudS9wYWNrYWdlcy94ZmNl LnNjbQppbmRleCA5NjU1ZDhjY2Y3Li5mMWU0MGE5NGI4IDEwMDY0NAotLS0gYS9nbnUvcGFja2Fn ZXMveGZjZS5zY20KKysrIGIvZ251L3BhY2thZ2VzL3hmY2Uuc2NtCkBAIC03MTgsNiArNzE4LDgg QEAgeW91ciBzeXN0ZW0gaW4gY2F0ZWdvcmllcywgc28geW91IGNhbiBxdWlja2x5IGZpbmQgYW5k IGxhdW5jaCB0aGVtLiIpCiAgICAgICAgKCJsaWJzbSIgLGxpYnNtKQogICAgICAgICgibGlid25j ayIgLGxpYnduY2spCiAgICAgICAgKCJsaWJ4ZmNlNHVpIiAsbGlieGZjZTR1aSkpKQorICAgIChw cm9wYWdhdGVkLWlucHV0cworICAgICBgKCgieHNldCIgLHhzZXQpKSkKICAgICAoaG9tZS1wYWdl ICJodHRwczovL3d3dy54ZmNlLm9yZy8iKQogICAgIChzeW5vcHNpcyAiWGZjZSBzZXNzaW9uIG1h bmFnZXIiKQogICAgIChkZXNjcmlwdGlvbgotLSAKMi4zMS4xCgo= ------=_Part_179835_493377898.1620268738709 Content-Type: text/x-patch; charset=ISO-8859-1; name=0001-gnu-xfce4-session-Allow-xflock4-to-use-xset.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-xfce4-session-Allow-xflock4-to-use-xset.patch X-Part-Id: 6cc49077d11b49858d69583e299352ff RnJvbSBlZDY2Y2Y1MGEzYjkyOTRlZmZjOGJiYWUwNGIwZjI1NjRiZDU1YzEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcmVuZGFuIFRpbGRlc2xleSA8bWFpbEBicmVuZGFuLnNjb3Q+ CkRhdGU6IFRodSwgNiBNYXkgMjAyMSAxMjozNDo1NSArMTAwMApTdWJqZWN0OiBbUEFUQ0hdIGdu dTogeGZjZTQtc2Vzc2lvbjogQWxsb3cgeGZsb2NrNCB0byB1c2UgeHNldC4KCiogZ251L3BhY2th Z2VzL3hmY2Uuc2NtICh4ZmNlNC1zZXNzaW9uKToKW2lucHV0c106IEFkZCB4c2V0LgpbYXJndW1l bnRzXTogQWRkIGEgcGhhc2UgdG8gdXNlIGV4YWN0IHN0b3JlIHBhdGggdG8geHNldCBpbiB4Zmxv Y2s0LgotLS0KIGdudS9wYWNrYWdlcy94ZmNlLnNjbSB8IDExICsrKysrKysrKy0tCiAxIGZpbGUg Y2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2du dS9wYWNrYWdlcy94ZmNlLnNjbSBiL2dudS9wYWNrYWdlcy94ZmNlLnNjbQppbmRleCA4YWEyNzcw ZWU4Li4xNjQ2MzFjZjRkIDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMveGZjZS5zY20KKysrIGIv Z251L3BhY2thZ2VzL3hmY2Uuc2NtCkBAIC03MDcsNyArNzA3LDEzIEBAIHlvdXIgc3lzdGVtIGlu IGNhdGVnb3JpZXMsIHNvIHlvdSBjYW4gcXVpY2tseSBmaW5kIGFuZCBsYXVuY2ggdGhlbS4iKQog ICAgICAgIChsaXN0IChzdHJpbmctYXBwZW5kICItLXdpdGgteHNlc3Npb24tcHJlZml4PSIgJW91 dHB1dCkpCiAgICAgICAgOzsgRGlzYWJsZSBpY29uIGNhY2hlIHVwZGF0ZS4KICAgICAgICAjOm1h a2UtZmxhZ3MKLSAgICAgICAnKCJndGtfdXBkYXRlX2ljb25fY2FjaGU9dHJ1ZSIpKSkKKyAgICAg ICAnKCJndGtfdXBkYXRlX2ljb25fY2FjaGU9dHJ1ZSIpCisgICAgICAgIzpwaGFzZXMKKyAgICAg ICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAoYWRkLWFmdGVyICd1 bnBhY2sgJ3BhdGNoLXhmbG9jaworICAgICAgICAgICAobGFtYmRhIF8KKyAgICAgICAgICAgICAo c3Vic3RpdHV0ZSogInNjcmlwdHMveGZsb2NrNCIKKyAgICAgICAgICAgICAgICgoInhzZXQiKSAo d2hpY2ggInhzZXQiKSkpKSkpKSkKICAgICAobmF0aXZlLWlucHV0cwogICAgICBgKCgicGtnLWNv bmZpZyIgLHBrZy1jb25maWcpCiAgICAgICAgKCJpbnRsdG9vbCIgLGludGx0b29sKSkpCkBAIC03 MTcsNyArNzIzLDggQEAgeW91ciBzeXN0ZW0gaW4gY2F0ZWdvcmllcywgc28geW91IGNhbiBxdWlj a2x5IGZpbmQgYW5kIGxhdW5jaCB0aGVtLiIpCiAgICAgICAgKCJwb2xraXQiICxwb2xraXQpCiAg ICAgICAgKCJsaWJzbSIgLGxpYnNtKQogICAgICAgICgibGlid25jayIgLGxpYnduY2spCi0gICAg ICAgKCJsaWJ4ZmNlNHVpIiAsbGlieGZjZTR1aSkpKQorICAgICAgICgibGlieGZjZTR1aSIgLGxp YnhmY2U0dWkpCisgICAgICAgKCJ4c2V0IiAseHNldCkpKQogICAgIChob21lLXBhZ2UgImh0dHBz Oi8vd3d3LnhmY2Uub3JnLyIpCiAgICAgKHN5bm9wc2lzICJYZmNlIHNlc3Npb24gbWFuYWdlciIp CiAgICAgKGRlc2NyaXB0aW9uCi0tIAoyLjMxLjEKCg== ------=_Part_179835_493377898.1620268738709-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 08:03:17 2021 Received: (at 48220) by debbugs.gnu.org; 6 May 2021 12:03:17 +0000 Received: from localhost ([127.0.0.1]:37473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lecir-0003rZ-2b for submit@debbugs.gnu.org; Thu, 06 May 2021 08:03:17 -0400 Received: from flashner.co.il ([178.62.234.194]:34312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lecio-0003rN-QF for 48220@debbugs.gnu.org; Thu, 06 May 2021 08:03:15 -0400 Received: from localhost (unknown [31.210.177.125]) by flashner.co.il (Postfix) with ESMTPSA id BA50940041; Thu, 6 May 2021 12:03:08 +0000 (UTC) Date: Thu, 6 May 2021 15:03:06 +0300 From: Efraim Flashner To: Brendan Tildesley Subject: Re: [bug#48220] [PATCH] gnu: xfce4-session: Add xset to propagated-inputs. Message-ID: Mail-Followup-To: Efraim Flashner , Brendan Tildesley , Ludovic =?utf-8?Q?Court=C3=A8s?= , 48220@debbugs.gnu.org References: <20210504092051.24383-1-mail@brendan.scot> <87v97xjoux.fsf@gnu.org> <615974577.179836.1620268738791@office.mailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yP+X7DGQ7v5ZxAKB" Content-Disposition: inline In-Reply-To: <615974577.179836.1620268738791@office.mailbox.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48220 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 48220@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --yP+X7DGQ7v5ZxAKB Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 06, 2021 at 04:38:58AM +0200, Brendan Tildesley wrote: >=20 > > On 05/05/2021 3:23 PM Ludovic Court=C3=A8s wrote: > >=20 > > =20 > > Hi Brendan, > >=20 > > Brendan Tildesley skribis: > >=20 > > > * gnu/packages/xfce.scm (xfce4-session):[propagated-inputs]: Add xset= so > > > that xflock4 can turn off the monitor. > >=20 > > Can=E2=80=99t we instead patch =E2=80=98scripts/xflock4=E2=80=99 so tha= t it refers to =E2=80=98xset=E2=80=99 by > > its absolute file name? > >=20 >=20 > I can. It felt weird just patching one command and not others though. >=20 > > However, my understanding is that the xset code is already a fallback: >=20 > >=20 > > --8<---------------cut here---------------start------------->8--- > > # else run another access locking utility, if installed > > for lock_cmd in \ > > "xlock -mode blank" \ > > "slock" > > do > > set -- $lock_cmd > > if command -v -- $1 >/dev/null 2>&1; then > > $lock_cmd >/dev/null 2>&1 & > > # turn off display backlight: > > xset dpms force off > > exit > > fi > > done > > --8<---------------cut here---------------end--------------->8--- > >=20 > > Probably we should ensure the first =E2=80=98for=E2=80=99 loop works as= expected. > > Perhaps we need to replace =E2=80=98xfce4-screensaver-command=E2=80=99 = by its absolute > > file name there. > >=20 >=20 > Currently xfce4-screensaver is not installed in the xfce package at all b= y default, > so it isn't used. I could add it, but for me it was glitchy/flickering an= d I would keep=20 > clearing the password as I was entering it so I couldn't log back in. It = even does it > in a VM. I do have a recent amd graphics card with proprietary linux thou= gh, my computer > can't boot otherwise :(. >=20 > If you run guix environment --ad-hoc xfce4-screensaver > then > xfce4-screensaver &; xfce4-screensaver-command --lock > does it work for you? >=20 > I'm not sure what is best, should we be maximal and include xfce4-screens= aver in the xfce > package, or be minimal and make people have to install it manually? > > WDYT? > >=20 > > Thanks, > > Ludo=E2=80=99. Are you using %desktop-services in your OS config? By default they come with a screen-locker-service for both slock and xlockmore. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --yP+X7DGQ7v5ZxAKB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmCT2vcACgkQQarn3Mo9 g1G0MA//fDullq0+dDvHEEfueeo3oZyxdnRNPmEwBk80d9L4+2bfY6wX45hmr8mJ 21+rjqdxGF/x6wzig2g4jBg2uSxNq8Nh/gvTHt0XbfIBdO9LSyc0WJqyJQf/dMku TaU5/s0sqD6izRmUFOH76Qp0PgWOm7vM/AE1FkF+R79Bg6mrW7mVFmffqS8yCVNv ChMbuQSYs6bFadCMhHkyrAQs1zqgI7FHxgkqSZU3Ib0Cw20b9L+IWrPg+hCuXBup 8RNedFl1cTxgIO0EtaShKf58rNWBC61vmXtjhBaG+g2N2p1y2t/8aP7hUYujmaZ/ Jc+FtbE8HDXvptvbAvMraMTi7q2DppXnluIqgZAvOD7dT7jVRJgtCQdLlTGzI4NU vg4YRW5hIkWPEWK783xYVYMpxRSwcXWRQha21oFRw1pU+uhwGcxzipLumX2jVJvW v3kyPk8DGxjY57+LDA2KMjOeMmvkJSZNQvlGiU1LXUu7WMEyuoKemtYytN0H0ruc pLHOAoT/BXOeCZFilpj4ciDEshkQyHjgJqJYc9lm3Ko29PV05/Zj8d7VwGGl7PtG nTrawiD0kEKrPrda7pI0u6PLbYrUTuiI4H6cOZiwyR14rAUIDeuqgKYEJ6AddZxj FuBools/ytRe4KebmCSo9sg45zpuTCTp8u4Eies2Uag9x5G/4uc= =/BB+ -----END PGP SIGNATURE----- --yP+X7DGQ7v5ZxAKB-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 08:13:26 2021 Received: (at 48220) by debbugs.gnu.org; 6 May 2021 12:13:26 +0000 Received: from localhost ([127.0.0.1]:37490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lecsf-0003yS-N0 for submit@debbugs.gnu.org; Thu, 06 May 2021 08:13:25 -0400 Received: from mout-p-202.mailbox.org ([80.241.56.172]:17060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lecsd-0003yK-2l for 48220@debbugs.gnu.org; Thu, 06 May 2021 08:13:24 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4FbXXr6qkrzQk2f; Thu, 6 May 2021 14:13:16 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1620303195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eX/y6bCDUn2lq7LSxrFiNXghGD/PNtjylm4BgjcyzmI=; b=EzopiYOqKY0y3XWbNZ6yUz2cOq3JwL2lCp+1uVWWGjdPdsx3pw0Uhmawm0C31z3cw8Tkju 3T1CWlZcin+L5DqCLdFj1lWhPwqUPUw23FgyVQ+mZ7pvokbvCCuD2eFBiXec0kfhFr/Y+0 by0p3eRUXCLyldnjzzJYD7GFYfv4vzO9sHH4oeIGXJKER+lsa1+Ir0+8MQN5eSVrItBqaW DFkJYNbjwOflfBc0e9/SER+rnrwImN/eu/TfuP6Wkip2YdRRF6NX4q++V+VJiS8AZIbr9u NTe6jkMvRGkGCDUqmvaA4JE9iTYy+5KxBRPQ08HNiKc1ZVd2OKK/SyXKz1MI1g== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id OrraFaIoyuM5; Thu, 6 May 2021 14:13:13 +0200 (CEST) Date: Thu, 6 May 2021 14:13:12 +0200 (CEST) From: Brendan Tildesley To: Efraim Flashner Message-ID: <658388374.187505.1620303193042@office.mailbox.org> In-Reply-To: References: <20210504092051.24383-1-mail@brendan.scot> <87v97xjoux.fsf@gnu.org> <615974577.179836.1620268738791@office.mailbox.org> Subject: Re: [bug#48220] [PATCH] gnu: xfce4-session: Add xset to propagated-inputs. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-MBO-SPAM-Probability: X-Rspamd-Score: -7.92 / 15.00 / 15.00 X-Rspamd-Queue-Id: DAC0B17BE X-Rspamd-UID: 294b66 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48220 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 48220@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > On 05/06/2021 2:03 PM Efraim Flashner wrote: >=20 > =20 > On Thu, May 06, 2021 at 04:38:58AM +0200, Brendan Tildesley wrote: > >=20 > > > On 05/05/2021 3:23 PM Ludovic Court=C3=A8s wrote: > > >=20 > > > =20 > > > Hi Brendan, > > >=20 > > > Brendan Tildesley skribis: > > >=20 > > > > * gnu/packages/xfce.scm (xfce4-session):[propagated-inputs]: Add xs= et so > > > > that xflock4 can turn off the monitor. > > >=20 > > > Can=E2=80=99t we instead patch =E2=80=98scripts/xflock4=E2=80=99 so t= hat it refers to =E2=80=98xset=E2=80=99 by > > > its absolute file name? > > >=20 > >=20 > > I can. It felt weird just patching one command and not others though. > >=20 > > > However, my understanding is that the xset code is already a fallback= : > >=20 > > >=20 > > > --8<---------------cut here---------------start------------->8--- > > > # else run another access locking utility, if installed > > > for lock_cmd in \ > > > "xlock -mode blank" \ > > > "slock" > > > do > > > set -- $lock_cmd > > > if command -v -- $1 >/dev/null 2>&1; then > > > $lock_cmd >/dev/null 2>&1 & > > > =09# turn off display backlight: > > > =09xset dpms force off > > > exit > > > fi > > > done > > > --8<---------------cut here---------------end--------------->8--- [...] > Are you using %desktop-services in your OS config? By default they come > with a screen-locker-service for both slock and xlockmore. >=20 Yep, those ones work but they merely produce a black screen with the backli= ght on, then the xset command in the above script actually turns off the screen to = save power. if any of xfce4-screensaver, gnome-screensaver, or xscreensaver are availab= le, then it will use those first. From debbugs-submit-bounces@debbugs.gnu.org Sat May 08 06:23:42 2021 Received: (at 48220-done) by debbugs.gnu.org; 8 May 2021 10:23:42 +0000 Received: from localhost ([127.0.0.1]:49344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfK7Z-0002ym-Vt for submit@debbugs.gnu.org; Sat, 08 May 2021 06:23:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfK7X-0002yd-FP for 48220-done@debbugs.gnu.org; Sat, 08 May 2021 06:23:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56446) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfK7J-0004Se-Bz; Sat, 08 May 2021 06:23:26 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60474 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfK7H-00011V-B8; Sat, 08 May 2021 06:23:25 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Brendan Tildesley Subject: Re: bug#48220: [PATCH] gnu: xfce4-session: Add xset to propagated-inputs. References: <20210504092051.24383-1-mail@brendan.scot> <87v97xjoux.fsf@gnu.org> <615974577.179836.1620268738791@office.mailbox.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 =?utf-8?Q?Flor=C3=A9al?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 08 May 2021 12:23:21 +0200 In-Reply-To: <615974577.179836.1620268738791@office.mailbox.org> (Brendan Tildesley's message of "Thu, 6 May 2021 04:38:58 +0200 (CEST)") Message-ID: <87zgx58qxy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48220-done Cc: 48220-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Brendan Tildesley skribis: [...] >> However, my understanding is that the xset code is already a fallback: > >>=20 >> --8<---------------cut here---------------start------------->8--- >> # else run another access locking utility, if installed >> for lock_cmd in \ >> "xlock -mode blank" \ >> "slock" >> do >> set -- $lock_cmd >> if command -v -- $1 >/dev/null 2>&1; then >> $lock_cmd >/dev/null 2>&1 & >> # turn off display backlight: >> xset dpms force off >> exit >> fi >> done >> --8<---------------cut here---------------end--------------->8--- >>=20 >> Probably we should ensure the first =E2=80=98for=E2=80=99 loop works as = expected. >> Perhaps we need to replace =E2=80=98xfce4-screensaver-command=E2=80=99 b= y its absolute >> file name there. >>=20 > > Currently xfce4-screensaver is not installed in the xfce package at all b= y default, > so it isn't used. I could add it, but for me it was glitchy/flickering an= d I would keep=20 > clearing the password as I was entering it so I couldn't log back in. It = even does it > in a VM. I do have a recent amd graphics card with proprietary linux thou= gh, my computer > can't boot otherwise :(. Hmm OK. We should address this in a separate issue. > If you run guix environment --ad-hoc xfce4-screensaver > then > xfce4-screensaver &; xfce4-screensaver-command --lock > does it work for you? I get: --8<---------------cut here---------------start------------->8--- $ xfce4-screensaver & xfce4-screensaver-command --lock [1] 19108 ** Message: 12:20:44.361: Screensaver is not running! Start xfce4-screensav= er first --8<---------------cut here---------------end--------------->8--- =E2=80=A6 but I=E2=80=99m not running Xfce. I should prolly try in a VM. > I'm not sure what is best, should we be maximal and include xfce4-screens= aver in the xfce > package, or be minimal and make people have to install it manually? I=E2=80=99d lean towards including xfce4-screensaver, since that=E2=80=99s = the intended use of Xfce, but only once it actually works. > From ed66cf50a3b9294effc8bbae04b0f2564bd55c10 Mon Sep 17 00:00:00 2001 > From: Brendan Tildesley > Date: Thu, 6 May 2021 12:34:55 +1000 > Subject: [PATCH] gnu: xfce4-session: Allow xflock4 to use xset. > > * gnu/packages/xfce.scm (xfce4-session): > [inputs]: Add xset. > [arguments]: Add a phase to use exact store path to xset in xflock4. [...] > + (add-after 'unpack 'patch-xflock > + (lambda _ > + (substitute* "scripts/xflock4" > + (("xset") (which "xset")))))))) Applied after changing =E2=80=98which=E2=80=99 to refer to the =E2=80=9Cxse= t=E2=80=9D input so that it works correctly when cross-compiling. Closing, and let=E2=80=99s discuss xfce4-screensaver separately! Thanks, Ludo=E2=80=99. From unknown Sat Jun 21 10:43:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 05 Jun 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator