GNU bug report logs - #48205
[PATCH] gnu: emacs-org: Make build reproducible

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Morgan.J.Smith <at> outlook.com
Cc: 48205 <at> debbugs.gnu.org
Subject: [bug#48205] [PATCH] gnu: emacs-org: Make build reproducible
Date: Tue, 11 May 2021 12:28:46 +0200

Hi,

Morgan.J.Smith <at> outlook.com skribis:

> From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
>
> * gnu/packages/emacs-xyz.scm (emacs-org)[phases]: Remove loaddefs and use
> autoloads instead

[...]

> +         (add-after 'fix-org-version 'use-autoloads
> +           (lambda _
> +             (delete-file "org-loaddefs.el")
> +             (substitute* (find-files "." ".*.el")
> +                 (("org-loaddefs.el") "org-autoloads.el"))
> +             #t))

You can drop the trailing #t.

Could you explain in a comment in the phase what it does?  It’s not
clear to me how this relates to making the build bit-reproducible.

Remember that ‘find-files’ takes a regexp as its second argument; thus,
to match .el files, you need to write "\\.el$".

Could you send an updated patch?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.