From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 May 2021 07:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 48153@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161993880310654 (code B ref -1); Sun, 02 May 2021 07:01:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 May 2021 07:00:03 +0000 Received: from localhost ([127.0.0.1]:40946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld65B-0002l7-Qi for submit@debbugs.gnu.org; Sun, 02 May 2021 03:00:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:56814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld659-0002l1-WA for submit@debbugs.gnu.org; Sun, 02 May 2021 03:00:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ld659-0006Cm-Ky for bug-gnu-emacs@gnu.org; Sun, 02 May 2021 02:59:59 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:43620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ld655-0005GW-Qy for bug-gnu-emacs@gnu.org; Sun, 02 May 2021 02:59:59 -0400 Received: by mail-wr1-x42f.google.com with SMTP id x7so2239185wrw.10 for ; Sat, 01 May 2021 23:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=OvVHI7k6MNXLDA5ieEKx8PcDZcJ+8XxcwshoCcKv+Kk=; b=ganWf4ugFfprWs2csdg/lNhv3hOjvdQr11hQBGu2+douV5GUmg0MEyuyrttivwkI/k olTzwx+L6TGSU3KSjxMWTA07K9mJMvw6xji5vpjz90Twhe7Lbvq0x7r8bGlI5a8pJWXT UlSOSbK850DUSpmLTXxLI0cQdLt/Lp9tbR5JkP0zTDCm5K1MI+ND4UGi4NWaBds1CziD xc6ELpM04kELRORYPzqEu0jlNsMjDrnub4PzURDN2/c5OxDkdG1+ANzToDhlGov1TD2P KpDwtX02CI4fA5uaKX71/VHk81nxDMUhmEadNJZbPpntBc2d0Zbykj8aCPo25g3/x1b3 wj0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=OvVHI7k6MNXLDA5ieEKx8PcDZcJ+8XxcwshoCcKv+Kk=; b=oIjfUylnhseaSl1ltap8NHxE5GjV9xVt1i2PEAEnkr6LOvhw+nIBtAw9g/n99ZU7w2 eOCoGokMRCO+GuF3cpJy6yf2p7Kqp6oxShSX2EGDbreIQUnB6PbOGMx9XGh8YLe44LXv grfvMfbeleRMuIaGlpk6ALVwF3dp5gAZAZnu93rTB9vC9Do4paaShI7rOzMJshqY10Zv w6G++Ul3O6gOceTaK2iBQlKfsWgKjZIWFV2rHPupqIKvQo0sa6dTUhSilqe/dde6RO0R Rm316nnQ17zaTGxj6wLAHdw5TER4yJmXFenTUHXhP+VXgE+MZQ4wOs8YUECrvwkgzzRd wBEw== X-Gm-Message-State: AOAM531PoZTGfI2+qF7Ai88w36rxPNpaMWkzmofAb53GbnRfXOKyzPkt zhm4sQ11P2cxQU4YszBcWqXoPQm3TXinQQ== X-Google-Smtp-Source: ABdhPJx4gafEtA/40vOgali2xf98051KAkvLNv9b/gzKoLGo3zaWffU8dYlRfsYMBcqdJszhJdMhtA== X-Received: by 2002:a5d:674c:: with SMTP id l12mr17426106wrw.357.1619938792524; Sat, 01 May 2021 23:59:52 -0700 (PDT) Received: from mg559.lan ([137.220.76.130]) by smtp.gmail.com with ESMTPSA id n124sm18170782wmn.40.2021.05.01.23.59.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 May 2021 23:59:51 -0700 (PDT) From: Jimmy Yuen Ho Wong Date: Sun, 02 May 2021 07:58:32 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=wyuenho@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) After typing C-x b or C-x C-f, the minor mode maps from the buffer that launched the minibuffer will override the keymap given to `read-from-minibuffer`, this seems to be a regression in emacs 28 master. Reproduction: 1. Turn on `ido-mode` 2. Turn on some minor mode that rebinds `C-k` with `(define-key some-minor-mode-map (kbd "C-k") 'some-func)` 3. C-x b 4. Select a buffer and type C-k Expectation: C-k should be bound to `ido-kill-buffer-at-head` and calls it, but instead `some-func` is called. Since C-k is bound in `ido-completion-map`, and it is given to `read-from-minibuffer`, all the bindings in `ido-completion-map` should take precedence. Additional info: After some debugging with `enable-recursive-minibuffers`, I typed Shift-Meta-; to open a recursive eval buffer inside the `ido-switch-buffer` buffer, `(cl-loop for buf in (buffer-list) if (minibufferp buf) do (with-current-buffer buf (key-binding (kbd "C-k"))))` reveals that indeed C-k isn't bound inside any minibuffer buffers. In GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin20.4.0, NS appkit-2022.44 Version 11.3 (Build 20E232)) of 2021-05-02 built on mg559.lan Repository revision: f1adb6b77a948e4f2f3223940edb15e56c30466d Repository branch: HEAD Windowing system distributor 'Apple', version 10.3.2022 System Description: macOS 11.3 Configured using: 'configure --prefix=/opt/local --disable-silent-rules --without-dbus --without-gconf --without-libotf --without-m17n-flt --with-gmp --with-gnutls --with-json --with-xml2 --with-modules --infodir /opt/local/share/info/emacs --with-ns --with-lcms2 --without-harfbuzz --without-imagemagick --without-xaw3d --with-native-compilation --with-rsvg 'CFLAGS=-pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk -arch x86_64' 'CPPFLAGS=-I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk' 'LDFLAGS=-L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-no_pie -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk -arch x86_64'' Configured features: ACL GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS XIM ZLIB Important settings: value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: projectile-rails-global-mode: t projectile-mode: t eldoc-box-hover-at-point-mode: t company-box-mode: t company-prescient-mode: t prescient-persist-mode: t rainbow-mode: t elisp-def-mode: t display-line-numbers-mode: t subword-mode: t form-feed-mode: t beginend-prog-mode: t imenu-list-minor-mode: t purpose-mode: t diff-hl-flydiff-mode: t crm-custom-mode: t override-global-mode: t dap-tooltip-mode: t dap-ui-many-windows-mode: t dap-ui-controls-mode: t dap-ui-mode: t treemacs-filewatch-mode: t treemacs-follow-mode: t treemacs-git-mode: deferred treemacs-fringe-indicator-mode: t global-git-commit-mode: t magit-auto-revert-mode: t shell-dirtrack-mode: t winner-mode: t which-key-mode: t which-function-mode: t smooth-scrolling-mode: t show-smartparens-global-mode: t show-smartparens-mode: t smartparens-global-mode: t smartparens-mode: t show-paren-mode: t server-mode: t savehist-mode: t save-place-mode: t rxt-global-mode: t rxt-mode: t recentf-mode: t minibuffer-depth-indicate-mode: t ido-vertical-mode: t ido-ubiquitous-mode: t global-whitespace-cleanup-mode: t whitespace-cleanup-mode: t global-tree-sitter-mode: t global-so-long-mode: t global-origami-mode: t origami-mode: t global-move-dup-mode: t move-dup-mode: t global-flycheck-mode: t global-diff-hl-show-hunk-mouse-mode: t diff-hl-show-hunk-mouse-mode: t global-diff-hl-mode: t diff-hl-mode: t global-company-mode: t company-mode: t global-auto-revert-mode: t flx-ido-mode: t ido-everywhere: t icomplete-vertical-mode: t icomplete-mode: t fido-mode: t editorconfig-mode: t desktop-save-mode: t delete-selection-mode: t dap-auto-configure-mode: t dap-mode: t yas-minor-mode: t auto-compile-on-save-mode: t auto-compile-mode: t amx-mode: t abridge-diff-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t window-divider-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t temp-buffer-resize-mode: t buffer-read-only: t size-indication-mode: t column-number-mode: t line-number-mode: t visual-line-mode: t transient-mark-mode: t Load-path shadows: /opt/local/share/emacs/site-lisp/cmake-mode hides /Users/jimmyyuenhowong/.emacs.d/elpa/cmake-mode-20210104.1831/cmake-mode /Users/jimmyyuenhowong/.emacs.d/elpa/transient-20210426.2141/transient hides /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/transient Features: (shadow sort mail-extr emacsbug sendmail visual-regexp-steroids visual-regexp misearch multi-isearch tabify cl-print jka-compr helpful trace edebug info-look elisp-refs two-column vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs diff-hl-dired all-the-icons-dired dired-collapse dired-hacks-utils projectile-rails rake inflections inf-ruby smartparens-ruby ruby-mode smie autoinsert projectile vc-git eldoc-box company-box company-box-doc frame-local company-box-icons dash-functional company-prescient prescient company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-yasnippet company-capf company-files company-cmake company-clang company-semantic company-template company-bbdb rainbow-mode elisp-def ert debug backtrace display-line-numbers cap-words superword subword smartparens-config smartparens-javascript smartparens-markdown smartparens-text smartparens-c form-feed editorconfig-core editorconfig-core-handle editorconfig-fnmatch beginend window-purpose-x shut-up imenu-list hideshow window-purpose window-purpose-fixes window-purpose-prefix-overload window-purpose-switch window-purpose-layout window-purpose-core window-purpose-configuration eieio-compat window-purpose-utils windmove dired-hide-dotfiles shrink-path magit-lfs forge-list forge-commands forge-semi forge-bitbucket buck forge-gogs gogs forge-gitea gtea forge-gitlab glab forge-github ghub-graphql treepy gsexp ghub let-alist gnutls forge-notify forge-revnote forge-pullreq forge-issue forge-topic bug-reference forge-post forge-repo forge forge-core forge-db closql magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log diff-hl-flydiff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util dumb-jump popup rg rg-info-hack rg-menu rg-ibuffer rg-result wgrep-rg wgrep rg-history rg-header ibuf-ext ibuffer ibuffer-loaddefs grep lsp-metals view lsp-metals-treeview lsp-metals-protocol yard-mode typescript-mode json-mode json-reformat json-snatcher js cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs reformatter cl-lib-highlight eterm-256color term disp-table ehelp xterm-color native-complete emacsql-sqlite emacsql emacsql-compiler url-http url-auth url-gw lsp-sourcekit lsp lsp-pyright lsp-jedi tree-sitter-langs tree-sitter-langs-build tar-mode arc-mode archive-mode tree-sitter-hl iedit iedit-lib mc-hide-unmatched-lines-mode mc-mark-more mc-cycle-cursors multiple-cursors-core rect icomplete-vertical crm-custom pager-default-keybindings pager browse-kill-ring paradox paradox-menu paradox-commit-list paradox-execute paradox-github paradox-core parse-time iso8601 use-package-bind-key bind-key use-package-delight osx-trash exec-path-from-shell all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons spaceline-config spaceline-segments spaceline powerline powerline-separators powerline-themes solarized-dark-theme solarized-theme solarized solarized-faces delight quelpa-use-package use-package-core quelpa lisp-mnt help-fns radix-tree dap-mouse dap-ui lsp-treemacs lsp-treemacs-themes treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-interface treemacs-extensions treemacs-mouse-interface treemacs-tags treemacs-persistence treemacs-filewatch-mode treemacs-follow-mode treemacs-rendering treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals treemacs-fringe-indicator treemacs-scope pulse treemacs-faces treemacs-icons treemacs-themes treemacs-core-utils pfuture hl-line treemacs-logging treemacs-customization treemacs-macros gdb-mi gud bui bui-list bui-info bui-entry bui-core bui-history bui-button bui-utils lsp-lens magit-diff smerge-mode diff git-commit log-edit message rfc822 mml mml-sec epa derived gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor shell pcomplete magit-mode transient format-spec magit-git magit-section magit-utils crm winner which-key which-func smooth-scrolling smartparens paren server savehist saveplace pcre2el rxt re-builder recentf mb-depth ido-vertical-mode ido-completing-read+ memoize cus-edit pp minibuf-eldef help-at-pt whitespace-cleanup-mode whitespace tree-sitter tree-sitter-load tree-sitter-cli tsc tsc-dyn tsc-dyn-get dired-aux dired dired-loaddefs tsc-obsolete so-long origami origami-parsers move-dup flycheck find-func diff-hl-show-hunk diff-hl-inline-popup diff-hl log-view pcvs-util vc-dir vc vc-dispatcher diff-mode company autorevert flx-ido advice flx ido icomplete editorconfig desktop frameset delsel dap-mode dap-launch posframe dap-overlays lsp-mode lsp-protocol yasnippet-snippets yasnippet xref project tree-widget wid-edit spinner network-stream puny nsm rmc markdown-mode color thingatpt noutline outline easy-mmode lv inline imenu ht filenotify f ewoc epg epg-config dash compile text-property-search comint ansi-color ring auto-compile packed amx s abridge-diff cus-load edmacro kmacro cl info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source eieio eieio-core eieio-loaddefs password-cache json map url-vars comp comp-cstr warnings subr-x rx cl-seq cl-macs cl-extra help-mode seq byte-opt bytecomp byte-compile cconv gv pcase cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process nativecomp emacs) Memory information: ((conses 16 1144104 503139) (symbols 48 53507 0) (strings 32 202614 92506) (string-bytes 1 7453813) (vectors 16 153419) (vector-slots 8 3884557 589614) (floats 8 2540 3047) (intervals 56 8434 5150) (buffers 992 29)) From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 May 2021 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jimmy Yuen Ho Wong Cc: 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162005492821965 (code B ref 48153); Mon, 03 May 2021 15:16:02 +0000 Received: (at 48153) by debbugs.gnu.org; 3 May 2021 15:15:28 +0000 Received: from localhost ([127.0.0.1]:46905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldaIC-0005iD-Gs for submit@debbugs.gnu.org; Mon, 03 May 2021 11:15:28 -0400 Received: from heytings.org ([95.142.160.155]:35812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldaIB-0005i7-6G for 48153@debbugs.gnu.org; Mon, 03 May 2021 11:15:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1620054926; bh=WooOhoqY/4V2m6qczaj6oHX5V/7P5ewwqBCqZys23XI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=qN+EXaWyWBebBO4MemcOK+tOnyOMHr51qDEekKe8/1uFq7uO+Zh18Nj7n5y1jnNPC Lkqak+jcrBUe95GVNhzQL1AOC7ANWp6NCdyv+HM7pSDs4+eehywjfbYjUBYnmKeU4I hY2ytri6ymwaxuqA2t7HVtdcQegDwlSyFMSO4kwrs2qt79nXo1C7A5WzlH2P/gqZKI 7TJLN8SWamTEt484ceXHqvbDG+ipyyNNB5Fho/8+WHdHNuF8skoABiBTV+X08NIMy1 pl+WyNyVQz+F0ZLN/U/0o9esoXCwFSyYOZpgmxOsZaBf2inJbnWBtlrc0KdGYRmnyO NQtOWeK2HJvKw== Date: Mon, 03 May 2021 15:15:25 +0000 From: Gregory Heytings In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > After typing C-x b or C-x C-f, the minor mode maps from the buffer that > launched the minibuffer will override the keymap given to > `read-from-minibuffer`, this seems to be a regression in emacs 28 > master. > > Reproduction: > > 1. Turn on `ido-mode` > 2. Turn on some minor mode that rebinds `C-k` with `(define-key > some-minor-mode-map (kbd "C-k") 'some-func)` > 3. C-x b > 4. Select a buffer and type C-k > > Expectation: > > C-k should be bound to `ido-kill-buffer-at-head` and calls it, but > instead `some-func` is called. > > Since C-k is bound in `ido-completion-map`, and it is given to > `read-from-minibuffer`, all the bindings in `ido-completion-map` should > take precedence. > Thanks for your bug report. I'm unable to reproduce your recipe on recent versions of the trunk (today, a week ago). I tried (define-minor-mode test-mode "" :keymap (let ((map (make-sparse-keymap))) (define-key map (kbd "C-k") '(lambda () (interactive) (message "BAD !"))) map)) and C-k is indeed bound to 'ido-kill-buffer-at-head'. I suspect this misbehavior is due to your configuration; if not, could you try to create a recipe starting with emacs -Q? From debbugs-submit-bounces@debbugs.gnu.org Mon May 03 20:51:22 2021 Received: (at control) by debbugs.gnu.org; 4 May 2021 00:51:22 +0000 Received: from localhost ([127.0.0.1]:49706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldjHW-00016E-Kx for submit@debbugs.gnu.org; Mon, 03 May 2021 20:51:22 -0400 Received: from mail-pg1-f179.google.com ([209.85.215.179]:43764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldjHU-000161-Ha for control@debbugs.gnu.org; Mon, 03 May 2021 20:51:20 -0400 Received: by mail-pg1-f179.google.com with SMTP id p12so5158131pgj.10 for ; Mon, 03 May 2021 17:51:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=htSUXgKaAgOpzsJeRWtbuEdadwyw4L2pdKGlpFqTmf8=; b=pieQjmWoXdkdOSMZuYT7bGKDX5X+EqGOH0lQ3i/lKr0++/ilVcJDHWw48Pz6EkhHWY UvEhXmwQRUqbE+2SGkbGV0riqSYsihSOJF66uafJL6EvQyfMqioBgJmOLfDLe5nJZo8Z QZYwGfDa9btkb3RCuI+umisuNKlJRS+oppOzkNWB1FZEW3iy0aQQxGq3FcxC2QMjlZHy CE1v7XiQqiJAmJVF8mZjQUE/M0klqi18g/u2QkssBduKW9trB9xS0EKiGHm8lJX0dzoe aFhvujyiNmb6GV7VHfp7UWaGlIPO2t79d1o56imuUcgheVooA+JZuLlYdHcDnlHNAklz iiiw== X-Gm-Message-State: AOAM5338eMvzvA8qX+eF6UsqWQehpjHwvX7qR3WXM9hP3uHEyapfHpnf q2sqyg1vnw33rCDmK9A3YaHwbxjdE2/j74eHSJIGEbS6 X-Google-Smtp-Source: ABdhPJyaIAfIwVf3eU+Ux5B7RBqqCdrODbOX2jbOLWuTavNRFqn2pL3c6ytenRY3XQhcRYDcufbOpKLIVbFZIp21vO0= X-Received: by 2002:a17:90b:d81:: with SMTP id bg1mr23844131pjb.179.1620089474786; Mon, 03 May 2021 17:51:14 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 3 May 2021 19:51:14 -0500 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 3 May 2021 19:51:14 -0500 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 48153 + moreinfo thanks Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.215.179 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.179 listed in wl.mailspike.net] 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 48153 + moreinfo thanks Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.179 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.215.179 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 BLANK_SUBJECT Subject is present but empty -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager tags 48153 + moreinfo thanks From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2021 12:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Gregory Heytings Cc: 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162013280028520 (code B ref 48153); Tue, 04 May 2021 12:54:01 +0000 Received: (at 48153) by debbugs.gnu.org; 4 May 2021 12:53:20 +0000 Received: from localhost ([127.0.0.1]:53032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lduYB-0007Pw-O0 for submit@debbugs.gnu.org; Tue, 04 May 2021 08:53:19 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:46843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lduY9-0007Pp-VQ for 48153@debbugs.gnu.org; Tue, 04 May 2021 08:53:18 -0400 Received: by mail-wm1-f46.google.com with SMTP id k4-20020a7bc4040000b02901331d89fb83so1261516wmi.5 for <48153@debbugs.gnu.org>; Tue, 04 May 2021 05:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=6cVH2R4vzFNcBvtd4HS0pItAPGF8TbevldO9LXi8FuY=; b=IXNZo07B7SUs10bidH8MUJ3TQnD3/YlB+tUzIi5TgJ27LiWMS5p1oyFS97V/VatyIu Kbp6o8UN8FSBla4KoasyjIpYO/v7FW6hQNtn9bFvADmZ0lLgy6yEiHXcbgHEeBldeJdh NgynVIlljP7/+yDRwcOzyhJYmmF3+HacOiTbyIwMoTCpuDeaZSEMyDsCU0T2Rzo5Ro9x pAKetsDKOdKs3kBULHejh7xDBM5IqtuQjKYmsaitrcdIv+QpaVSCFwOZr+jOqEfNroXF xfQpqWVdojnjBDehjHvEoqW4v6KcQ0LLOogkCPyOLq8f4XefjSw/fsxmry/IfMRAilgW a1Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=6cVH2R4vzFNcBvtd4HS0pItAPGF8TbevldO9LXi8FuY=; b=UYDEVqw4iqS90JCqHAjuVIBiWsq6vV7BaXIEFFMx873YgonXIgJgqpEsRqUL0GZhpa 7XqERZWMPJw3KWTSAKQTSdV6PRBM52U73G6/s/2yp6a8VutRrEXnAQ8Z+yi7yakqj4Sz lbgaMMeVImRfQ//rR87kHcC2yu6Y7XtqoC84LNt9K02XSQOppBlmQmM9e8o5nKckd43u ESGFjvsYVgZYpqcFHz0CebqAkDuRYAtCfKCpezpyqM83rbf/Y8USL7/K+g1A2pUn1roI LpO8CY77OqrsRrftKfnT6hSutibchzWgVfsvGzO9CvV+g+7VuaDEJT4Oc1WXvV0ypsN7 5ftA== X-Gm-Message-State: AOAM531V2DLQej3ymWTZhnzv1KUyEGkp5YwbIZa/n+OqyHoZ/vZXQxdy HboZVyHtuRwTSzsBbMCPLrA= X-Google-Smtp-Source: ABdhPJzFd+jw4M3/3KoMT48TOdb4v+Mkrupd6eAdZqBTEcnJnwyGf7dZYByY/Ueldsh+sVKRjmEKkQ== X-Received: by 2002:a05:600c:1991:: with SMTP id t17mr3866867wmq.100.1620132791823; Tue, 04 May 2021 05:53:11 -0700 (PDT) Received: from smtpclient.apple ([137.220.76.130]) by smtp.gmail.com with ESMTPSA id s15sm10681265wrt.19.2021.05.04.05.53.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 May 2021 05:53:11 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Jimmy Yuen Ho Wong Mime-Version: 1.0 (1.0) Date: Tue, 4 May 2021 13:53:10 +0100 Message-Id: References: In-Reply-To: X-Mailer: iPhone Mail (18E212) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sorry I missed a reproduction step. You have to turn on the minor mode for t= he minibuffers. In my config there actually is a global minor mode that turn= s the minor mode on even for the minibuffer. In Emacs 27, turning the minor mode on inside the minibuffer would not overr= ide the key map given to read-from-minibuffer. I was able to reproduce this on a pristine init.el with just these reproduct= ion steps plus turning the minor mode on for all buffers with a global minor= mode. My emacs has native compilation configured if that helps. > On 3 May 2021, at 4:15 pm, Gregory Heytings wrote: >=20 > =EF=BB=BF >>=20 >> After typing C-x b or C-x C-f, the minor mode maps from the buffer that l= aunched the minibuffer will override the keymap given to `read-from-minibuff= er`, this seems to be a regression in emacs 28 master. >>=20 >> Reproduction: >>=20 >> 1. Turn on `ido-mode` >> 2. Turn on some minor mode that rebinds `C-k` with `(define-key >> some-minor-mode-map (kbd "C-k") 'some-func)` >> 3. C-x b >> 4. Select a buffer and type C-k >>=20 >> Expectation: >>=20 >> C-k should be bound to `ido-kill-buffer-at-head` and calls it, but instea= d `some-func` is called. >>=20 >> Since C-k is bound in `ido-completion-map`, and it is given to `read-from= -minibuffer`, all the bindings in `ido-completion-map` should take precedenc= e. >>=20 >=20 > Thanks for your bug report. I'm unable to reproduce your recipe on recent= versions of the trunk (today, a week ago). I tried >=20 > (define-minor-mode test-mode "" :keymap (let ((map (make-sparse-keymap))) (= define-key map (kbd "C-k") '(lambda () (interactive) (message "BAD !"))) map= )) >=20 > and C-k is indeed bound to 'ido-kill-buffer-at-head'. I suspect this misb= ehavior is due to your configuration; if not, could you try to create a reci= pe starting with emacs -Q? From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2021 13:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Jimmy Yuen Ho Wong Cc: 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162013400229308 (code B ref 48153); Tue, 04 May 2021 13:14:01 +0000 Received: (at 48153) by debbugs.gnu.org; 4 May 2021 13:13:22 +0000 Received: from localhost ([127.0.0.1]:53142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldura-0007ce-2D for submit@debbugs.gnu.org; Tue, 04 May 2021 09:13:22 -0400 Received: from heytings.org ([95.142.160.155]:37186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldurY-0007cY-H2 for 48153@debbugs.gnu.org; Tue, 04 May 2021 09:13:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1620133999; bh=iEZtiUiFtBHYHWaCQmUM6qnjbSnmtBXm5h5xhp0Bf2s=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=E7SAy+dXaIawmwUsDdow5/FDpXO5159AQ3Itl+IObxujae8uO5sUE7zFytnNjmzNj GYPicTxFF82WFHEbAlaWdXMK6mzXdZYDPsy5FDSexkJ2s0xOriOSZQwNoEkp3MfGOD JeOLQR2XfodkdDVS2a04I5erK5EpcDcYJUPYjE5hGtmcMGHbksVbrXUuOalOKEuZX0 5G78Aw1y/hzO/LNyhXJNBwX6Y0+WLH09f6B2KdgDtfFYD2gbej3v6BREcrBrzk0jiU lbd+9ndmns4AXl5yr4whLZBhkoLfZcnHk6MOGwpohfmJiZNaqYc8zZFt8K35uNBWf3 pAxzWNZ7Z3oHA== Date: Tue, 04 May 2021 13:13:18 +0000 From: Gregory Heytings In-Reply-To: Message-ID: <1a73bd6c69bb5c6a8431@heytings.org> References: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Sorry I missed a reproduction step. You have to turn on the minor mode > for the minibuffers. In my config there actually is a global minor mode > that turns the minor mode on even for the minibuffer. > > In Emacs 27, turning the minor mode on inside the minibuffer would not > override the key map given to read-from-minibuffer. > > I was able to reproduce this on a pristine init.el with just these > reproduction steps plus turning the minor mode on for all buffers with a > global minor mode. > Thanks for your clarification. Could your perhaps mention what that minor mode is? Otherwise it's rather difficult to reproduce and debug your problem. From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2021 13:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Gregory Heytings Cc: 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162013638430824 (code B ref 48153); Tue, 04 May 2021 13:54:01 +0000 Received: (at 48153) by debbugs.gnu.org; 4 May 2021 13:53:04 +0000 Received: from localhost ([127.0.0.1]:53371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldvTz-000816-R8 for submit@debbugs.gnu.org; Tue, 04 May 2021 09:53:04 -0400 Received: from mail-lj1-f177.google.com ([209.85.208.177]:37675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldvTy-00080c-Fc for 48153@debbugs.gnu.org; Tue, 04 May 2021 09:53:02 -0400 Received: by mail-lj1-f177.google.com with SMTP id b7so7433797ljr.4 for <48153@debbugs.gnu.org>; Tue, 04 May 2021 06:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dnJTrB7ANsLWw7koTjUuuHy+pweQ0qNdLNT19Hq5XTA=; b=qtaGh6qhBL1SgQbwDIgN6IPhgFfRsKirjYYindQhvDZe2VaOnOP+jJ6UuXITNZEC/q 1qr7y9zLMvyihFBZ0cIQXFL53iv6w/uNrbwQ84sBCrwPKxd2Q6q7ycfdzVXESuVeqPSl G2anDxQezAHzFiglKv8ed84S8VgHHas0ndetp4EKEXVwPQuvdL1FM3v6zKBxz1mW+qqD x4T2t4eNSHSEmWgjdEHyTpSg0+lpViWSQUoqiffGZoEoVhsUwXjD7uUAsYiX/whqMWxz LvDMoV6MNS9g7zrBKSqDoRGH6gWmCDiy+uz71iCXs3KtpdsVymBX15+XdWBa2dhEQiBM nLNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dnJTrB7ANsLWw7koTjUuuHy+pweQ0qNdLNT19Hq5XTA=; b=n33Xr9cV3h8uz1B5pedqs3tYVttP2FG89EtICz0IR7U16pzvx6FFTdaFNpp3HZ7dvL i5sJQMpZoswMYjawqCO3SexaxkPwW70Z+0mLatEpY7Gamw3Iu1O6G1ismb6TJJdnbLcs ugWWzUXh5+/1+mm4+R/9euDAUzLW1wrQtvMC1VKshnX7Z56Px+kMpTMZHY2I6BaN9jYG MXRXr6VxyJeVed9lkvK8Fyc0mu+E2IrOIwEdU6d16X886T2EIu0dlk0uUau26yY71E4B ImtTcGuE3uXuNzRw+OLJiHTkhhfao9WshSBJx4s8MvdhQ2N0W7bLYd5a3KOhbHRmFViK VA7w== X-Gm-Message-State: AOAM531XPSndjk4+gmCpd7A6AO19Cn8RoMDyGdGwL32jkANuAAF5GUuU mCNP94dXk9TWjT6Rst1EscD358Mdqqr/Tbu0IiE= X-Google-Smtp-Source: ABdhPJzPU6eHl0g7Pp0eeqmUjlJZcfXq0gixTYQpay5DqtEz2F2yX3xdgnOFGYPjOa50QCkOBKRlzioSQtLitZeqBYQ= X-Received: by 2002:a2e:9592:: with SMTP id w18mr5805218ljh.203.1620136376201; Tue, 04 May 2021 06:52:56 -0700 (PDT) MIME-Version: 1.0 References: <1a73bd6c69bb5c6a8431@heytings.org> In-Reply-To: <1a73bd6c69bb5c6a8431@heytings.org> From: Jimmy Yuen Ho Wong Date: Tue, 4 May 2021 14:52:20 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) It's literally just a global minor mode defined for your test minor mode, basically `(define-global-minor-mode test-global-mode test-mode (lambda() t))` Jimmy On Tue, May 4, 2021 at 2:13 PM Gregory Heytings wrote: > > > > > > Sorry I missed a reproduction step. You have to turn on the minor mode > > for the minibuffers. In my config there actually is a global minor mode > > that turns the minor mode on even for the minibuffer. > > > > In Emacs 27, turning the minor mode on inside the minibuffer would not > > override the key map given to read-from-minibuffer. > > > > I was able to reproduce this on a pristine init.el with just these > > reproduction steps plus turning the minor mode on for all buffers with a > > global minor mode. > > > > Thanks for your clarification. Could your perhaps mention what that minor > mode is? Otherwise it's rather difficult to reproduce and debug your > problem. From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2021 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Jimmy Yuen Ho Wong Cc: 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162013692931196 (code B ref 48153); Tue, 04 May 2021 14:03:02 +0000 Received: (at 48153) by debbugs.gnu.org; 4 May 2021 14:02:09 +0000 Received: from localhost ([127.0.0.1]:53417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldvcm-000876-WA for submit@debbugs.gnu.org; Tue, 04 May 2021 10:02:09 -0400 Received: from heytings.org ([95.142.160.155]:37252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldvck-000870-Mx for 48153@debbugs.gnu.org; Tue, 04 May 2021 10:02:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1620136925; bh=fu7Kpz8+uqdK+eqJ1hx7mZ9s+ei/V2BR1xPqpQlgLYs=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=nV3LKW1QwDyr7gzF0npkcngCVGOr+r0qjkoz98z/RG49wLw8LtaGUMez2rqKNP/tv 6rnZZhW8PJoS0We08Rf/4jJlyejCJsAz5mBtVoVD1HQr0nH7mDeN3gIzbJdTFL/mNR 9d30yA0VlBP1S1W5IoXXws1U1dfbEr3PSANZEwOj8cLI27Ogf2ekPW4LyCAPLBkrNK fcmc5LPHEIcQs0BqLsu/lkfcGUXHShH5iKSJzUsIsXSVMz61WAvYvz33yDBWYuDMgL rxw3TADJox5VDRVY5VvUTBGZmO1y6XjPdKYhVSt9AJ+QHguwj4IRkDuwIgBuUWjMzr +IQ+yZ464ZH5w== Date: Tue, 04 May 2021 14:02:04 +0000 From: Gregory Heytings In-Reply-To: Message-ID: <1a73bd6c69374497d37b@heytings.org> References: <1a73bd6c69bb5c6a8431@heytings.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > It's literally just a global minor mode defined for your test minor > mode, basically `(define-global-minor-mode test-global-mode test-mode > (lambda() t))` > In that case, you should disable (or rather, not enable) that minor mode for minibuffers, for example: (define-global-minor-mode test-global-mode test-mode (lambda () (or (minibufferp) (test-mode 1)))) From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2021 14:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Jimmy Yuen Ho Wong Cc: 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162013858231936 (code B ref 48153); Tue, 04 May 2021 14:30:02 +0000 Received: (at 48153) by debbugs.gnu.org; 4 May 2021 14:29:42 +0000 Received: from localhost ([127.0.0.1]:53533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldw3R-0008J2-TF for submit@debbugs.gnu.org; Tue, 04 May 2021 10:29:42 -0400 Received: from heytings.org ([95.142.160.155]:37296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldw3O-0008Iw-Gz for 48153@debbugs.gnu.org; Tue, 04 May 2021 10:29:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1620138576; bh=vKgxcEnDR9Z/g5qSbWqSWZKmJ61GPuC+0ba2rGUd/5g=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=gJTL7n8cfD85Y7lcZbu/2bIWQgF638DEUOk7+nSJ4hl+iX9oZYsc75wWw3vt285Dm 7hsvRpzBKpG5KKlBMv5lhEjjzNXgOz8+ddIhVcqAhRjjfKVLdB/Lu/symmNyhxl1K8 1qWxEidDcfRZXexJ2Jzdk10YBcb84xThYV581drjROz3PqyDwQKrMgwIrx2p9pwesX RIlCJRlalmZLNrarzrDLYiuVBCc+wunvmrhkV4Juae+Tli/SqPMNoaYnrdl1BbyGVe d/TAweKEBaBpkTCaIlcb7kTomPHYAWaCSJ3oU99cfHwJNzNcg3MixiPUVsj8tde0IY JQ9ENkP59GOJw== Date: Tue, 04 May 2021 14:29:36 +0000 From: Gregory Heytings In-Reply-To: <1a73bd6c69374497d37b@heytings.org> Message-ID: <1a73bd6c69101f3312ad@heytings.org> References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> It's literally just a global minor mode defined for your test minor >> mode, basically `(define-global-minor-mode test-global-mode test-mode >> (lambda() t))` > > In that case, you should disable (or rather, not enable) that minor mode > for minibuffers, for example: > > (define-global-minor-mode test-global-mode test-mode (lambda () (or > (minibufferp) (test-mode 1)))) > (Note that this does not answer your question "In Emacs 27, turning the minor mode on inside the minibuffer would not override the key map given to read-from-minibuffer", with the above the effect is the same in Emacs 27 and 28 AFAICS. Without seeing the minor mode, I cannot help you more, I don't have a crystal ball.) From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2021 16:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Gregory Heytings Cc: 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162014493811868 (code B ref 48153); Tue, 04 May 2021 16:16:02 +0000 Received: (at 48153) by debbugs.gnu.org; 4 May 2021 16:15:38 +0000 Received: from localhost ([127.0.0.1]:54078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldxhx-00035M-Ux for submit@debbugs.gnu.org; Tue, 04 May 2021 12:15:38 -0400 Received: from mail-lf1-f54.google.com ([209.85.167.54]:35717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldxhv-00035F-JR for 48153@debbugs.gnu.org; Tue, 04 May 2021 12:15:36 -0400 Received: by mail-lf1-f54.google.com with SMTP id x19so14140486lfa.2 for <48153@debbugs.gnu.org>; Tue, 04 May 2021 09:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XxFu3NAV/idbhwuwLMT7IAxZwvhspYrHEMjMtVBIe7o=; b=YPKqY8YhlQrTg8e13UHTDJeg5aN4VG4xJ8pc5VIHA3EbtTZKWbCX4NYSjLnliERLxl zgKCbxWHCJY0W7HboCYrgnz7MdpqkrP+RJlvSaqUEMl8UsO+gMcehRxyta77zyY2+6C6 xD+pGnrPnaOykWA3qYOBZAzrvwLQ7QY2a4zBn2dvqWKiHPu+8K404MyEHUkmH6Z6V/rw zLtr36fFjT+BVVuQsST3xpNBAK8PywnFrYbOCzpzBqEb4G5yLbBA8pppUnHMF0TexWpv i5NMZNw55V8lHhrzjj2PXd4TO43MMimmypmZFv2BZDUzcbrtDhzYwR+El0qqR1smHe5Y Hcww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XxFu3NAV/idbhwuwLMT7IAxZwvhspYrHEMjMtVBIe7o=; b=i0ebtjHrmL1j0kmu0AQUPruJkJch/TFjB9/2e6NlvWdY68GMqWGZGWwolUwETzMIhY xFwj9lZmB9QR1Xdf4G8hRlkXoZd20sjD1UQsNUS8+WmaR1jMuUrRDT6KIHcePCo7B15C ZAWjIiwM9MutjEY7SPKSEfpWQ5CHL7WWBQfgkCLqFajlynJIko6/06AJim5OUDuXkbgf tQkZfivqG+zy5eNlhc4nrnW4rhX111pOztxF7MvfvoUhJzBgP7M51JBUVXznzJAszGR9 zwDRhFLxD4f6yVil2xxf6iC7DvkyQseFiAAD6hRmT6Bte8CYZ/Tqna+h+2XL+CxVNWLZ 9gQQ== X-Gm-Message-State: AOAM533kVYQNwSu5AOPG7nqrAnRH7a07Xh2JmnCOqiZQZYLjN5gxkxT6 5CIDuVLqKRsieQ8YhVRoNjF11bU5p5VIsMeXU2o= X-Google-Smtp-Source: ABdhPJzaCdZDUyv1J4rrbcpPI23Gv8C/vafFcCyWG15XJ2u8SrLZ5EIYufX+2XvMpegv0NnfO0uZQowjOG2mrAxvaLI= X-Received: by 2002:a05:6512:12c7:: with SMTP id p7mr16460721lfg.494.1620144929496; Tue, 04 May 2021 09:15:29 -0700 (PDT) MIME-Version: 1.0 References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> In-Reply-To: <1a73bd6c69101f3312ad@heytings.org> From: Jimmy Yuen Ho Wong Date: Tue, 4 May 2021 17:15:18 +0100 Message-ID: Content-Type: multipart/alternative; boundary="00000000000001e39305c1836376" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000001e39305c1836376 Content-Type: text/plain; charset="UTF-8" The minor mode is exactly the same as what you have in your previous email. What actually happens in my regular setup is the key bindings in multiple minor modes override the key map given to read-from-minibuffer. The problem is I don't want to turn off those minor mode as they used to work in the minibuffer in emacs 27 as intended, but not so in emacs 28. One mode is smartparens and another is move-dup. On Tue, 4 May 2021 at 3:29 pm Gregory Heytings wrote: > > >> It's literally just a global minor mode defined for your test minor > >> mode, basically `(define-global-minor-mode test-global-mode test-mode > >> (lambda() t))` > > > > In that case, you should disable (or rather, not enable) that minor mode > > for minibuffers, for example: > > > > (define-global-minor-mode test-global-mode test-mode (lambda () (or > > (minibufferp) (test-mode 1)))) > > > > (Note that this does not answer your question "In Emacs 27, turning the > minor mode on inside the minibuffer would not override the key map given > to read-from-minibuffer", with the above the effect is the same in Emacs > 27 and 28 AFAICS. Without seeing the minor mode, I cannot help you more, > I don't have a crystal ball.) > -- Jimmy Yuen Ho Wong --00000000000001e39305c1836376 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The minor mode is exactly the same as what you have in yo= ur previous email. What actually happens in my regular setup is the key bin= dings in multiple minor modes override the key map given to read-from-minib= uffer. The problem is I don't want to turn off those minor mode as they= used to work in the minibuffer in emacs 27 as intended, but not so in emac= s 28.

One mode is smartp= arens and another is move-dup.

On Tue, 4 May 2021 at 3:29 pm Gregory He= ytings <gregory@heytings.org= > wrote:

>> It's literally just a global minor mode defined for your test = minor
>> mode, basically `(define-global-minor-mode test-global-mode test-m= ode
>> (lambda() t))`
>
> In that case, you should disable (or rather, not enable) that minor mo= de
> for minibuffers, for example:
>
> (define-global-minor-mode test-global-mode test-mode (lambda () (or > (minibufferp) (test-mode 1))))
>

(Note that this does not answer your question "In Emacs 27, turning th= e
minor mode on inside the minibuffer would not override the key map given to read-from-minibuffer", with the above the effect is the same in Ema= cs
27 and 28 AFAICS.=C2=A0 Without seeing the minor mode, I cannot help you mo= re,
I don't have a crystal ball.)
--
Jimmy Yuen Ho Wong
--00000000000001e39305c1836376-- From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2021 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Jimmy Yuen Ho Wong Cc: 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162014621412634 (code B ref 48153); Tue, 04 May 2021 16:37:02 +0000 Received: (at 48153) by debbugs.gnu.org; 4 May 2021 16:36:54 +0000 Received: from localhost ([127.0.0.1]:54187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldy2Y-0003Hi-H3 for submit@debbugs.gnu.org; Tue, 04 May 2021 12:36:54 -0400 Received: from heytings.org ([95.142.160.155]:37454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldy2V-0003Hb-FC for 48153@debbugs.gnu.org; Tue, 04 May 2021 12:36:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1620146210; bh=7HobjAzw6v1Sz9V8UYDlZubNX8SqwXkn08eJmbCx47g=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Wo5OQKrTaXczakYAilKdY3+sW3hQKEgcpPvufTwSnOrbWq+5Y4mjY86LNwDSPRS57 mnJbilgRDeBwxnQrMmY9Noe931q5fjXjmNc1QVGF+WFNgz6dgUg9tt4rn+iTQdOGQB dxy1sMVfQLuyPaFCCPJJmZnnITnkRUS5dbFkZPqVBnGqvBmjU7w+X89pwBAkbhPmKu pySbH/EbdoL91R1ramyNb070gmsAJOKhpAIWbTGOC44RK1OsLc6T02Lh5E+RBR3qcJ ki9IHxZyYp6n6fIrFJglDvz71Ldb0bssaa32fOA9bXTv7/3AZb+f39K0pwUIDZIe1P KRcgJqKCYCfAg== Date: Tue, 04 May 2021 16:36:49 +0000 From: Gregory Heytings In-Reply-To: Message-ID: <1a73bd6c691b937c82fc@heytings.org> References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > The minor mode is exactly the same as what you have in your previous > email. What actually happens in my regular setup is the key bindings in > multiple minor modes override the key map given to read-from-minibuffer. > The problem is I don't want to turn off those minor mode as they used to > work in the minibuffer in emacs 27 as intended, but not so in emacs 28. > The problem is that, with the test-mode in my previous mail, I cannot reproduce the issue. > > One mode is smartparens and another is move-dup. > But neither of these minor modes override C-k, which you mentioned in your original bug report? I tried move-dup, and its four bindings do not override the corresponding bindings in the minibuffer, with or without ido-mode. So I still cannot see the issue you see... From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2021 22:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Gregory Heytings Cc: 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.16201680864008 (code B ref 48153); Tue, 04 May 2021 22:42:01 +0000 Received: (at 48153) by debbugs.gnu.org; 4 May 2021 22:41:26 +0000 Received: from localhost ([127.0.0.1]:55859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le3jJ-00012Z-Nt for submit@debbugs.gnu.org; Tue, 04 May 2021 18:41:25 -0400 Received: from mail-lj1-f175.google.com ([209.85.208.175]:42497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le3jH-00012T-QS for 48153@debbugs.gnu.org; Tue, 04 May 2021 18:41:25 -0400 Received: by mail-lj1-f175.google.com with SMTP id w4so4511840ljw.9 for <48153@debbugs.gnu.org>; Tue, 04 May 2021 15:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EfpoXvY/HXRWOGP0ATHPUEqst+FSQZpTCeDDiV8s5kY=; b=ZKTmBbkt7SZnK3yQ1pzv0QeIoSqHsgp9CG933dCU8nfQ8WC9k/fEKNzHvwvVzmKgr5 g4xocibtIbNTiDJ5GexobT4B3oLd8fQe+vCs0AVMbxFMdONenWE1XEL3fpoXOwhlovaC x0vzl5vclA5bWqSuaoBgcbO9tUdscIiSfGTXVqPTmMgIZuw5NEEEhLtHHnscBPIUhq3L XaZKIf8amfiKSSOQMEK5VGWRo94E4kAfCOaACJGiT1YKbPxZ1xQ6whmEdIprCOYVC5u9 knLa74mVlf/k7Fe5yNvUO+5H/j/22bAIhM1LieBhPlKq9skZSjfBu8QKmilV0xqBJFWi XlpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EfpoXvY/HXRWOGP0ATHPUEqst+FSQZpTCeDDiV8s5kY=; b=TfySBLWbo9loUNxy77a3zEmpbsDlHcd0AS0p3qkoVbE8PcS2d4tCFJaoJMQ2FsXOOM XqkERNKsT5zzeZ8WFz2i5eGC/+ZsfZFEUIj3HENzIhI2ylgLa1+/tlgALj/a1HBjOU+c EMP7c2JaG/t6iHBcto411ajM6epDmJjeuRLmTkzbkOgkKQIiGrks2DnceY0PPoPKqibP w6SCGlikcZLmS+/kAkpeM9Mdm955jCi33z2HnPk7ZV2xDN8pUzkgunqILIiPq81Fnh7o lXN+fCGTvtpjnX+/+0Miz7g00xKmRFvCS+eUcWCu9Zg9ZWFWBj+Eo1mj7kKOVyeeqb50 yaog== X-Gm-Message-State: AOAM532cufXf8ZQpMfIyKHz+61f4cjpHb6VoUt6o9h3oE057iTEg/LXs 2HtV28ZhyRiflkar6nWfp+DBV9hSyVVmeU9hvmM= X-Google-Smtp-Source: ABdhPJxDLy/5huKC7vJCQEPTaSZTAcEk0s60iuQOcRSZQkA/Mn3TnAb//bRZ5HnEA3xUi/KU3lOkBQSdhFhRTqGz8sc= X-Received: by 2002:a2e:9592:: with SMTP id w18mr7413093ljh.203.1620168077532; Tue, 04 May 2021 15:41:17 -0700 (PDT) MIME-Version: 1.0 References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> <1a73bd6c691b937c82fc@heytings.org> In-Reply-To: <1a73bd6c691b937c82fc@heytings.org> From: Jimmy Yuen Ho Wong Date: Tue, 4 May 2021 23:40:41 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sorry I'm really bad at giving instructions. Here's some additional information. First of all, this is the entirety of the test init.el. (defun bad () (interactive) (message "BAD !")) (define-minor-mode test-mode "" :keymap (let ((map (make-sparse-keymap))) (define-key map (kbd "C-k") 'bad) map)) (define-global-minor-mode test-global-mode test-mode (lambda () (test-mode 1))) (test-global-mode 1) (ido-mode 1) (setf enable-recursive-minibuffers 1) Once emacs has started, C-x b C-h b should show that C-k is bound to `bad`. Second of all, in order to get the key map bindings to read-from-minibuffer overridden on emacs 27, it requires quitting from switch-to-buffer, and then C-x b C-h b again to see that C-k is bound to `bad`. In other words, on emacs 27, one has to pop up the minibuffer twice. On emacs 28, just opening the minibuffer the first time will see the key bindings overridden. I guess this is why I say this is a regression on emacs 28 but you said you couldn't reproduce it. I think both versions are wrong, it's just on emacs 28, it's wrong in a more obvious way. In any case, I'm not sure if the minor mode maps should override the key bindings in the keymap given to read-from-buffer. Jimmy On Tue, May 4, 2021 at 5:36 PM Gregory Heytings wrote: > > > > > > The minor mode is exactly the same as what you have in your previous > > email. What actually happens in my regular setup is the key bindings in > > multiple minor modes override the key map given to read-from-minibuffer. > > The problem is I don't want to turn off those minor mode as they used to > > work in the minibuffer in emacs 27 as intended, but not so in emacs 28. > > > > The problem is that, with the test-mode in my previous mail, I cannot > reproduce the issue. > > > > > One mode is smartparens and another is move-dup. > > > > But neither of these minor modes override C-k, which you mentioned in your > original bug report? > > I tried move-dup, and its four bindings do not override the corresponding > bindings in the minibuffer, with or without ido-mode. > > So I still cannot see the issue you see... From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 08:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Jimmy Yuen Ho Wong Cc: 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162020214920192 (code B ref 48153); Wed, 05 May 2021 08:10:02 +0000 Received: (at 48153) by debbugs.gnu.org; 5 May 2021 08:09:09 +0000 Received: from localhost ([127.0.0.1]:58457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leCai-0005Fc-Ro for submit@debbugs.gnu.org; Wed, 05 May 2021 04:09:09 -0400 Received: from heytings.org ([95.142.160.155]:38270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leCag-0005FK-4C for 48153@debbugs.gnu.org; Wed, 05 May 2021 04:09:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1620202144; bh=5oDmrCxwDIkeVIFjrX71G80w+/QW4M3m2GHiDAh4Hx8=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Z2oskSilOdFgMlUHe5xaqMTDeUZGCZO/5eIFJbYxgkwEa5CB3wIz4DIOFTiyRhfQX rxfpIRgG3nK1eeRliFzcXSKC/KEQW22V90aws24CDhazbkkpcUTYqohzKClYqbs2Qk ivytzi/7O+EUzYY/gtWFd5Ev23+h/YY75jMdlnSSiyXMYAlABV7Ej9vagQZtt+XsH2 DP+d1A35wqg7z3mwhIfrcgZoSYUWTAvo0wYp8o0EAVCb1a1JBQeeapKTE2COHwje/g QUoGS0zk4JZ5/Nt6MQkUFzrkhiUyDaCE/3Fnvsu0VfWxHlY3brqaAMdi0PO/ugEzhm XUhGuSSYPwcLQ== Date: Wed, 05 May 2021 08:09:04 +0000 From: Gregory Heytings In-Reply-To: Message-ID: <70f2eadd5f48937bb057@heytings.org> References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> <1a73bd6c691b937c82fc@heytings.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Second of all, in order to get the key map bindings to > read-from-minibuffer overridden on emacs 27, it requires quitting from > switch-to-buffer, and then C-x b C-h b again to see that C-k is bound to > `bad`. In other words, on emacs 27, one has to pop up the minibuffer > twice. On emacs 28, just opening the minibuffer the first time will see > the key bindings overridden. I guess this is why I say this is a > regression on emacs 28 but you said you couldn't reproduce it. I think > both versions are wrong, it's just on emacs 28, it's wrong in a more > obvious way. > Okay, now I finally see what you mean (and I can reproduce it). Indeed this is a recent change in the handling of minibuffers, the first time the minibuffer is entered is not anymore different from the other times. > > In any case, I'm not sure if the minor mode maps should override the key > bindings in the keymap given to read-from-buffer. > Why would they not? The minibuffer behaves, in that respect, like any other buffer. Note that they do so only when the minor mode is enabled in the minibuffer. With the example init file, using (define-global-minor-mode test-global-mode test-mode (lambda () (or (minibufferp) (test-mode 1)))) works as you want it with both Emacs 27 and 28. From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 09:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Gregory Heytings Cc: 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162020586825641 (code B ref 48153); Wed, 05 May 2021 09:12:02 +0000 Received: (at 48153) by debbugs.gnu.org; 5 May 2021 09:11:08 +0000 Received: from localhost ([127.0.0.1]:58809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leDYh-0006fV-O0 for submit@debbugs.gnu.org; Wed, 05 May 2021 05:11:07 -0400 Received: from mail-lf1-f42.google.com ([209.85.167.42]:43714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leDYf-0006f3-K6 for 48153@debbugs.gnu.org; Wed, 05 May 2021 05:11:06 -0400 Received: by mail-lf1-f42.google.com with SMTP id x2so1530903lff.10 for <48153@debbugs.gnu.org>; Wed, 05 May 2021 02:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NUm9oUTxPqjmfbjjyQSQDFQnXqBSD4G8msADx+l1R08=; b=cnvIQqSgulHUH7Ic2N3qIERYWnocOC9+aLRXl0X8VMOceZE8MEEuUBRgz2BAWFs86a icejFjPeayV+cjqMokXzNQI5yAtY6uGChtVG2kQSmq7AibzCWxQw280hV4AOQD4SptDa tsJJfpBlQOAYW6Kuz89FAFeyBNR6jrPbIbwrYOxUOrSObMp2mBk2QGTGZ7NyrEBqr6k4 ZZw/SfdW4mIjTx63J0S0OFFDyd5AZ1EsYRaTvHxNCM4JUyRtcpRgOU6Vi7SJUdHMJdI0 DEoFz2XR/qjujvC73CCN9y5TskJNDK4Baj8bKLXLx/+Izz0INT+PnWKzeqxAlEz3dWYz YNfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NUm9oUTxPqjmfbjjyQSQDFQnXqBSD4G8msADx+l1R08=; b=Yuu1OhtplyNZBBtVgPR0hvOixSxAcgGW0FZ4XE8SuRwPkfqwPXi9q7wd2kBtA4q9zk VF+AlrBBzm+BYsyaxPiKfIB6tJnSAMZn4LEOLMBoswqFvVO5zUSoWHSJlpIlpEWDIXfh LbR0tSe2GJjMOFA5gtgJnN5ZpgK3Ml1y1qZ607LnfwxEkj5OM6nfDufgdM+dr5JgNPWT 9oZE2NnORgEhjRLcrmpR4Fe8f0o5XhO+yYIiJ953/eLEOPLF52LzMinModM/G13xrixb BagQfPA52nnJb+ou3fHf93Xp+WYDIS66+XBloxwhQd8g4g8gZjt/SX/E7nAN7wvS0vZy Qytw== X-Gm-Message-State: AOAM5322/SmAAkUw47VGcV53T4cpX2ikz8oMG4g4a25eRllMlRUIEqmb SECk2NsiLA8BANzpT2R0ZBhtMDMBRBLfvLlzY8c= X-Google-Smtp-Source: ABdhPJzy3s/a7lUVWF4wswFzl7vrGe9xmmusB7upFwvxV3Fji1++tOBR1p+ENRWD4gJbSVace/ODE2oZ2DwletWguqQ= X-Received: by 2002:a05:6512:3f3:: with SMTP id n19mr17595986lfq.594.1620205859281; Wed, 05 May 2021 02:10:59 -0700 (PDT) MIME-Version: 1.0 References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> <1a73bd6c691b937c82fc@heytings.org> <70f2eadd5f48937bb057@heytings.org> In-Reply-To: <70f2eadd5f48937bb057@heytings.org> From: Jimmy Yuen Ho Wong Date: Wed, 5 May 2021 10:10:23 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Why would they not? The minibuffer behaves, in that respect, like any > other buffer. Note that they do so only when the minor mode is enabled in > the minibuffer. > Because the minibuffer does not behave like any other buffers. Setting `minor-mode-overriding-map-alist` has no effect, so I think either the minibuffer really needs to behave like any other buffer, or special-cased and documented the ways it differs from regular buffers. I have this code in my init.el, and it doesn't seem to work. (defun ido-resurrect-keybinding () (pcase-dolist (`(,minor-mode . ,keymap) (seq-filter (lambda (entry) (symbol-value (car entry))) minor-mode-map-alist)) (cl-loop for buf in (buffer-list) if (and (minibufferp buf) (with-current-buffer buf (symbol-value minor-mode))) do (map-keymap (lambda (event def) (when-let (key (and (or (characterp event) (and (symbolp event) (not (eq event 'remap)) (not (keymapp def)))) (if (characterp event) (format "%c" event) (vector event)))) (when (lookup-key ido-completion-map key) (let ((map (copy-keymap keymap))) (define-key map key nil) (with-current-buffer buf (push (cons minor-mode map) minor-mode-overriding-map-alist)))))) keymap)))) (with-eval-after-load 'ido (add-hook 'ido-setup-hook 'ido-resurrect-keybinding)) From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 12:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Jimmy Yuen Ho Wong , Stefan Monnier Cc: gregory@heytings.org, 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162021694410134 (code B ref 48153); Wed, 05 May 2021 12:16:01 +0000 Received: (at 48153) by debbugs.gnu.org; 5 May 2021 12:15:44 +0000 Received: from localhost ([127.0.0.1]:59784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leGRM-0002dO-Ad for submit@debbugs.gnu.org; Wed, 05 May 2021 08:15:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leGRK-0002dI-If for 48153@debbugs.gnu.org; Wed, 05 May 2021 08:15:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43009) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leGRE-0005G0-0E; Wed, 05 May 2021 08:15:36 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3177 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1leGR6-0000k6-QF; Wed, 05 May 2021 08:15:30 -0400 Date: Wed, 05 May 2021 15:15:18 +0300 Message-Id: <83r1il2x7t.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jimmy Yuen Ho Wong on Wed, 5 May 2021 10:10:23 +0100) References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> <1a73bd6c691b937c82fc@heytings.org> <70f2eadd5f48937bb057@heytings.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jimmy Yuen Ho Wong > Date: Wed, 5 May 2021 10:10:23 +0100 > Cc: 48153@debbugs.gnu.org > > > Why would they not? The minibuffer behaves, in that respect, like any > > other buffer. Note that they do so only when the minor mode is enabled in > > the minibuffer. > > Because the minibuffer does not behave like any other buffers. Setting > `minor-mode-overriding-map-alist` has no effect, so I think either the > minibuffer really needs to behave like any other buffer, or > special-cased and documented the ways it differs from regular buffers. I admit that I've lost the context in this discussion. I'm CC'ing Stefan in the hope he could tell whether we do or don't have a problem here; if Stefan is unable to do that, either, we will unfortunately have to get back to the beginning and explain what kind of problems the current behavior causes. Because in general what Jimmy described in the original report sounds the expected behavior to me. From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 13:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Jimmy Yuen Ho Wong Cc: 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162022000720557 (code B ref 48153); Wed, 05 May 2021 13:07:02 +0000 Received: (at 48153) by debbugs.gnu.org; 5 May 2021 13:06:47 +0000 Received: from localhost ([127.0.0.1]:60043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHEl-0005LV-6z for submit@debbugs.gnu.org; Wed, 05 May 2021 09:06:47 -0400 Received: from heytings.org ([95.142.160.155]:38636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHEi-0005LN-BL for 48153@debbugs.gnu.org; Wed, 05 May 2021 09:06:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1620220003; bh=GA40USNAE1hPDq5cHJdPmjbywITZcBi3k1kPFWGZK0A=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=ZNPb7v7pdP+CTxkbFR9EuqTbUevB5Gc3sHU9S02juVeCSWDtjFkfOBgr/VXWhaonm ykGTy7Zs88FD8oZUY9vb7W7kFYQC2QmyukpP6AvDFTOz6LnhvJ0KKlG+g8kKmmu7cW 2jHk4Km18kNRezgKvMcgUR063JxlhiupV3ynTdIUJRW90skWk/5wyq7DrwqNWwHs9z MsMN3IyzLIP1wml+8Joi5SdUrNvuAV+1dEdgcoROGZ0SsHDAepNGH5R0RjifaLA9+6 riLfQaEwDElyzOLs/v+DU5788kyJCIckm4IU9uxggak5JZsgMRUg2XMjfl4JqZjYR9 sLOPfmjgl54ZQ== Date: Wed, 05 May 2021 13:06:42 +0000 From: Gregory Heytings In-Reply-To: Message-ID: <70f2eadd5f2b88a8648a@heytings.org> References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> <1a73bd6c691b937c82fc@heytings.org> <70f2eadd5f48937bb057@heytings.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Okay, now ido enters into the loop again... I added your code (as is) to the init file you gave upthread, and I see the exact same behavior in Emacs 27 and 28. When the activation of test-mode is made conditional to (minibufferp), I again see the exact same behavior in Emacs 27 and 28. And with both Emacs 27 and 28, minor-mode-overriding-map-alist is nil after ido-resurrect-keybinding. From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Eli Zaretskii Cc: 48153@debbugs.gnu.org, Jimmy Yuen Ho Wong , Stefan Monnier Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162022037220880 (code B ref 48153); Wed, 05 May 2021 13:13:01 +0000 Received: (at 48153) by debbugs.gnu.org; 5 May 2021 13:12:52 +0000 Received: from localhost ([127.0.0.1]:60089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHKd-0005Qi-OF for submit@debbugs.gnu.org; Wed, 05 May 2021 09:12:51 -0400 Received: from heytings.org ([95.142.160.155]:38648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHKc-0005Qc-9I for 48153@debbugs.gnu.org; Wed, 05 May 2021 09:12:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1620220369; bh=quA5aoUFm5sneJZoyvswOgNEEq2TJMW2uBiyMbDW6WA=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=VPIZOfARuQRqxbQStYXSWETat17dNGgM0smY4tXGf0b44YNuHdfmQqEMTX//NJepS s9N77K6w1aYey7QaQW5IU0MTp1eIfhfQuyEmdzXuHwpPRFh6vQ3aMIDbOvbkW1cAB+ mvTtEwZszGxCNjHnxR0t4br/VuQsbV7clpe00ZqlG8U0DsFBsBgQH0ouWF9hmyjqYk YNAeYa7wDWBv/LbKO9zfD+INr4Z0CrZPFsda+KtvEo0qbcowR6lLcGoUF5SxbP9DaZ h+FoP82pB1yNf3jXJpVhKDVFS7SLgAeCfmNu6sNYHW+zJl1AJ+bSDH4gbo3WTMMing HKEyk3EYYYKoA== Date: Wed, 05 May 2021 13:12:49 +0000 From: Gregory Heytings In-Reply-To: <83r1il2x7t.fsf@gnu.org> Message-ID: <70f2eadd5fbd139e3c62@heytings.org> References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> <1a73bd6c691b937c82fc@heytings.org> <70f2eadd5f48937bb057@heytings.org> <83r1il2x7t.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> Why would they not? The minibuffer behaves, in that respect, like any >>> other buffer. Note that they do so only when the minor mode is >>> enabled in the minibuffer. >> >> Because the minibuffer does not behave like any other buffers. Setting >> `minor-mode-overriding-map-alist` has no effect, so I think either the >> minibuffer really needs to behave like any other buffer, or >> special-cased and documented the ways it differs from regular buffers. > > I admit that I've lost the context in this discussion. I'm CC'ing > Stefan in the hope he could tell whether we do or don't have a problem > here; if Stefan is unable to do that, either, we will unfortunately have > to get back to the beginning and explain what kind of problems the > current behavior causes. Because in general what Jimmy described in the > original report sounds the expected behavior to me. > I admit I'm lost, too. The description of the problem has changed several times, and what was described in the original report is the actual behavior. Of course I may be missing something; I'm not fortunate enough to have a crystal ball, like Stefan ;-) From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 13:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Gregory Heytings Cc: Eli Zaretskii , 48153@debbugs.gnu.org, Stefan Monnier Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162022110830019 (code B ref 48153); Wed, 05 May 2021 13:26:02 +0000 Received: (at 48153) by debbugs.gnu.org; 5 May 2021 13:25:08 +0000 Received: from localhost ([127.0.0.1]:60196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHWV-0007o7-Nv for submit@debbugs.gnu.org; Wed, 05 May 2021 09:25:08 -0400 Received: from mail-lj1-f179.google.com ([209.85.208.179]:33365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHWS-0007nl-PG for 48153@debbugs.gnu.org; Wed, 05 May 2021 09:25:06 -0400 Received: by mail-lj1-f179.google.com with SMTP id s25so2485246lji.0 for <48153@debbugs.gnu.org>; Wed, 05 May 2021 06:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+uc4fMVRKV2ZvD2LBNyWZCVJkUM5cmch9dXUEIGJZqY=; b=JZJL/1C8ygkOyjLuOxQULwnT42kBfsqr2weu4XhDymwTHIVBk3K268gX4QsNR8+DrC sSakw62/iEWkYFaCByeHcYTLIyhNobJJrafqMudfgsuQXyA59qpoHj9HB1N4m/QHk77c gr5s+hDTWE2JhIZS8diXR3T/h5bF7M3VTtlBfwqCcCm3Keco3N4MSmERmsmsbxP8paWv lybJ2FJeyuRvcM9CEG4wyASW5qia0fAGMWsIuOPC8rphSfBTO7gmVaD8WkNuN/dGuz15 Dhcp869vhVwsjLxukFyHDAG4/UPxKov5Qv9nqXg5JEJSP0FuELj94tX0isfznbI/lKQ1 ayxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+uc4fMVRKV2ZvD2LBNyWZCVJkUM5cmch9dXUEIGJZqY=; b=r7/cpNUgeb1K4Udfqrzb1AraPoSjhgTtBgwirJohd3sifWH9e0F7AfQWUcR3Usty8I DIDhxD/4h/wjLLfKLqmRuesvyJvujsqZPLaTDrd2q1UagAVNHCkVzXzw+H18YFd6xNku epN1zmRaK7tp2ysQ73AtKvquRBywoS7QMPTHA0K04h67Ftw6cQ3oKfjWPyfyurz4r/Lb p4zL3C/72SkNPWEoeaZphhkxuy6V8xg3FQWrWy2+HvQ23MuVU6PFaTfgWBMSqVxBNgU8 RwLqur4er6OdQJ0RYWFhjd4Z6gpAV2iwUvB3gc0AcBobWaS4enq0BNeBuHHxU5uwJ5Fl XCpw== X-Gm-Message-State: AOAM533/GtuypJYnwSwNSWvQw5tQ7koZJLG/ghB1m0pB5fC3ys7zd5wh 6uum3azCZ2+XxQs8tVqOZVKT/oAL31Qbtmo4qLC9q+PDiiE= X-Google-Smtp-Source: ABdhPJzRA2RozzfiStTWGr8ncpxgSROtJnVuMpWT1NXEonTdcozxMCSifmyirlNcJJH/mAoXiwmJW2C7PTTo+QQuozs= X-Received: by 2002:a05:651c:319:: with SMTP id a25mr21051207ljp.69.1620221098616; Wed, 05 May 2021 06:24:58 -0700 (PDT) MIME-Version: 1.0 References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> <1a73bd6c691b937c82fc@heytings.org> <70f2eadd5f48937bb057@heytings.org> <83r1il2x7t.fsf@gnu.org> <70f2eadd5fbd139e3c62@heytings.org> In-Reply-To: <70f2eadd5fbd139e3c62@heytings.org> From: Jimmy Yuen Ho Wong Date: Wed, 5 May 2021 14:24:22 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ok let me summarize the issue here. 1. On emacs 27, minor mode keybindings will only override the key bindings given to read-from-minibuffer after the second invocation of the minibuffer, but doesn't on the first invocation. 2. On emacs 28, minor mode keybindings override the key bindings given to read-from-minibuffer at all times. 3. But, `minor-mode-overriding-map-alist` does not override the override in effect in the minibuffer like other buffers. My expectation is when a keymap is explicitly given to read-from-minibuffer, the key bindings in it should take precedence, but it doesn't. As you can see from the snippet from my last email, both ido-completion-map and test-mode bind to C-k, I expect the C-k binding in ido-completion-map to take effect inside the minibuffer, without being overridden by any minor modes in effect inside the minibuffer. If this is not to be desired, I'd expect setting minor-mode-overriding-map-alist or the usual key binding lookup search algorithm to work inside the minibuffer. Does it make sense? Jimmy On Wed, May 5, 2021 at 2:12 PM Gregory Heytings wrote: > > > >>> Why would they not? The minibuffer behaves, in that respect, like any > >>> other buffer. Note that they do so only when the minor mode is > >>> enabled in the minibuffer. > >> > >> Because the minibuffer does not behave like any other buffers. Setting > >> `minor-mode-overriding-map-alist` has no effect, so I think either the > >> minibuffer really needs to behave like any other buffer, or > >> special-cased and documented the ways it differs from regular buffers. > > > > I admit that I've lost the context in this discussion. I'm CC'ing > > Stefan in the hope he could tell whether we do or don't have a problem > > here; if Stefan is unable to do that, either, we will unfortunately have > > to get back to the beginning and explain what kind of problems the > > current behavior causes. Because in general what Jimmy described in the > > original report sounds the expected behavior to me. > > > > I admit I'm lost, too. The description of the problem has changed several > times, and what was described in the original report is the actual > behavior. Of course I may be missing something; I'm not fortunate enough > to have a crystal ball, like Stefan ;-) From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 14:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Jimmy Yuen Ho Wong Cc: Gregory Heytings , 48153@debbugs.gnu.org Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162022353215928 (code B ref 48153); Wed, 05 May 2021 14:06:01 +0000 Received: (at 48153) by debbugs.gnu.org; 5 May 2021 14:05:32 +0000 Received: from localhost ([127.0.0.1]:60460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leI9b-00048q-Ss for submit@debbugs.gnu.org; Wed, 05 May 2021 10:05:32 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leI9a-00048k-M1 for 48153@debbugs.gnu.org; Wed, 05 May 2021 10:05:31 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0A7F81001FB; Wed, 5 May 2021 10:05:25 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 24CBD10019F; Wed, 5 May 2021 10:05:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1620223523; bh=sVdLuBd4I5jTKqsHFRpgflFDIq68AxHZeZEZmBwjnKU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HPRacr9lxhDP3vjeTs68N2bu3KY3EcPwIAkX4zdysBt9S67WMFOwPiihz+iR67XWO WzhdtLIGB3bbaECfogzKEb5oEYH7SjzMU0JgwybjZqweUDIQTW+wgqGDuppUaeOPlh PlJlntYNkpdUQirXb9b/aGQEUhW3Z/0ocJEXLGMpB8xUe1Sea3U4mqKxhbESCDlg4d 4OhQZW10O4aLx2f8Y65N+MsrJEL/5mkOO8fuvfzbCH+ezn4Tva6fEBG7JIgOt/oFyg 8uR1O4AweJ3ldfx2xwJC8LjmFfcUfAKVvCC1KiDLb/GkzQLDEpj55mnDjVH4nNncYA 9GNzfA+2REH0g== Received: from alfajor (76-10-140-76.dsl.teksavvy.com [76.10.140.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E85FE1201B5; Wed, 5 May 2021 10:05:22 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Wed, 05 May 2021 10:05:22 -0400 In-Reply-To: (Jimmy Yuen Ho Wong's message of "Tue, 4 May 2021 13:53:10 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Sorry I missed a reproduction step. You have to turn on the minor mode for > the minibuffers. In my config there actually is a global minor mode that > turns the minor mode on even for the minibuffer. > > In Emacs 27, turning the minor mode on inside the minibuffer would not > override the key map given to read-from-minibuffer. It would have helped to provide a precise recipe to start with, but indeed there's been a change in Emacs-28, in that the minibuffer now is setup in its own major mode, which may have the side-effect of enabling the buffer-local minor modes made global via `define-globalized-minor-mode` in some cases where this didn't happen before. [ I consider this change as a bug-fix. ] Note that `define-globalized-minor-mode` distinguishes between its MODE argument and the TURN-ON function specifically so that the mode can be enabled only in those buffers where it makes sense. So if your globalized minor mode shouldn't be used in minibuffers, you need to tweak its TURN-ON such that it tests `minibufferp` like in Gregory's example. > Because the minibuffer does not behave like any other buffers. Setting > `minor-mode-overriding-map-alist` has no effect, so I think either the I can't think of any reason why that would be the case. Do you have a simple test case (your `ido-resurrect-keybinding` is too complex for my little brain to understand what it's expected to do). Stefan From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Jimmy Yuen Ho Wong Cc: Gregory Heytings , 48153@debbugs.gnu.org, Eli Zaretskii Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162022429116499 (code B ref 48153); Wed, 05 May 2021 14:19:02 +0000 Received: (at 48153) by debbugs.gnu.org; 5 May 2021 14:18:11 +0000 Received: from localhost ([127.0.0.1]:60538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leILr-0004I3-Cs for submit@debbugs.gnu.org; Wed, 05 May 2021 10:18:11 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leILm-0004Hd-TP for 48153@debbugs.gnu.org; Wed, 05 May 2021 10:18:09 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5105480695; Wed, 5 May 2021 10:18:01 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 632F1807A1; Wed, 5 May 2021 10:17:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1620224279; bh=fjciGCTIFNiOqTH1HM0Z30SILT9iY12X5BUq3WhhglQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mFjzKD6oeN9C6AZQVR4enuVR5qTZGqFtZe/8wva98wMPQQsj9SUSpuWFF7zj8joCp j7r5wMLf+YtGBdeJEsNMysg46Kv6Ok+uAGQPjKlG+YO94QOF+mUy0K/xd0RzYL7tFF 0OZOjNHRocnyhoSSA8AIvFq9UIKHG8dMePheRVXM5vW+ZYeL98cK32TrCMpN7HyZ/P nZRgpgdZrKwF/gtziBx9lTyqNQahaLkM5cjq1a9qK3Y5rbwgaHNcy+D2V9Q43T12yP q59Cr6lVFbZmTad2Wz/1V9JWKJdpadH2V+LfoRafkzg16ScR2QzrKtRTjoYtx20kle XwpurQhFrE82A== Received: from alfajor (76-10-140-76.dsl.teksavvy.com [76.10.140.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F3E401209CF; Wed, 5 May 2021 10:17:58 -0400 (EDT) From: Stefan Monnier Message-ID: References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> <1a73bd6c691b937c82fc@heytings.org> <70f2eadd5f48937bb057@heytings.org> <83r1il2x7t.fsf@gnu.org> <70f2eadd5fbd139e3c62@heytings.org> Date: Wed, 05 May 2021 10:17:58 -0400 In-Reply-To: (Jimmy Yuen Ho Wong's message of "Wed, 5 May 2021 14:24:22 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > 1. On emacs 27, minor mode keybindings will only override the key > bindings given to read-from-minibuffer after the second invocation of > the minibuffer, but doesn't on the first invocation. Something like that, yes. That's only for minor modes defined via `define-globalized-minor-mode`. Not for global minor modes defined in the usual way via (define-minor-mode ... :global t ...). This change makes for a more predictable behavior and is a side-effect of the change described in etc/NEWS as: ** An active minibuffer now has major mode 'minibuffer-mode', not the erroneous 'minibuffer-inactive-mode' it formerly had. More specifically, the difference is that in Emacs<28 sometimes those globalized minor modes where not enabled (hence their keybindings are not active). > 2. On emacs 28, minor mode keybindings override the key bindings given > to read-from-minibuffer at all times. And this was also true in all previous versions of Emacs. > 3. But, `minor-mode-overriding-map-alist` does not override the > override in effect in the minibuffer like other buffers. That's the part of your bug report I haven't understood yet. > My expectation is when a keymap is explicitly given to > read-from-minibuffer, the key bindings in it should take precedence, > but it doesn't. No, this keymap is the "local map" a.k.a "major mode map", so it has lower precedence than minor keymaps. Always had. > As you can see from the snippet from my last email, both > ido-completion-map and test-mode bind to C-k, I expect the C-k binding > in ido-completion-map to take effect inside the minibuffer, without > being overridden by any minor modes in effect inside the minibuffer. This expectation is incorrect ;-) > If this is not to be desired, I'd expect setting > minor-mode-overriding-map-alist or the usual key binding lookup search > algorithm to work inside the minibuffer. This should be the case: minibuffers are treated exactly like all other buffers by the keymap code, AFAIK. Stefan From unknown Sat Jun 21 05:15:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 10:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Stefan Monnier Cc: Gregory Heytings , 48153@debbugs.gnu.org, Eli Zaretskii Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162029857010621 (code B ref 48153); Thu, 06 May 2021 10:57:02 +0000 Received: (at 48153) by debbugs.gnu.org; 6 May 2021 10:56:10 +0000 Received: from localhost ([127.0.0.1]:37369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lebfu-0002lF-3r for submit@debbugs.gnu.org; Thu, 06 May 2021 06:56:10 -0400 Received: from mail-lj1-f171.google.com ([209.85.208.171]:35713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lebfs-0002l8-Bv for 48153@debbugs.gnu.org; Thu, 06 May 2021 06:56:08 -0400 Received: by mail-lj1-f171.google.com with SMTP id e12so6481292ljn.2 for <48153@debbugs.gnu.org>; Thu, 06 May 2021 03:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hC1p8xUgFCvsCl2JqYpUK+GPI4QEgHjajFke5MlaFls=; b=E+AAL/2bi1AovtlnEr2xaqd+HXGAPh13t6PJ1Or9ynxs0mqICxVc4qFE16sRcH0DWb /b9zDlizJsbc+IVMbUPNoA9DrxjeJHYlwHwQeH99PDuJhS7KtpVjj7vE41aZscSralUs dO90iReKekKC4fvvZ2nQja6p/evmgxU3f4+jLSwIc2F3adycjwBwzUdSMT0s+xsq0twk 0ltZHNOeG8nFJHnSmdoK8voZdeU5AYyPZ/0X8qG3ZJK85qocZhkgYw/35/d4r3znsTsu ngKL4528b3j0fzr7zUMCKDlv4UrgqNcgRtiTzvz/s3AZSXlB+f4Q7KHvc3v+Ql/3/PBn l4yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hC1p8xUgFCvsCl2JqYpUK+GPI4QEgHjajFke5MlaFls=; b=G0uFbHWC5SXUx2Ovfo9axnnzxgAOtEA5ljAkEReeN5p/CbRWHteG/bF4EXEIczRLnT cNT2N9fQsvjSGSNErixW8TweMBFA/haaxh2FjHPiOdwAPBN4ui11E3SSsn13QOuTpzyX LYf1pZ9r255rk0gqAMieC4+CDXOyRTKF1OpXIayc1j7BrmWZOqn9w/unyBxWtIXgp12W +HIpG0c2eNux6z20Mf1pykJ2HklZkt+/dawNSrVAhih7fcewD4dEVv+2zu2XAgByHwgB IhGmfWtWnm5Zgz/4XS/s6WkxLXm6mpGgiWuWl90YeL9rIplNAkAdQ07zDdYRt0aV0XIY 4EYA== X-Gm-Message-State: AOAM533VUFsdtpFXPm3CQKF5p+uiXELb+l0UTqq5xeOTqCedkq2viafV A/g3EDXt21eYd4teXUx7wZmPgfpbRXu14hAcXUo= X-Google-Smtp-Source: ABdhPJy5YqXOU4D8HnPPLDtcSfB49AEWytoRrxRToPFUnWEDCGnjb8azuyDnUr8TkpQ0bACNDTaFkeU5hfWC3gXqc24= X-Received: by 2002:a05:651c:151:: with SMTP id c17mr389832ljd.398.1620298561809; Thu, 06 May 2021 03:56:01 -0700 (PDT) MIME-Version: 1.0 References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> <1a73bd6c691b937c82fc@heytings.org> <70f2eadd5f48937bb057@heytings.org> <83r1il2x7t.fsf@gnu.org> <70f2eadd5fbd139e3c62@heytings.org> In-Reply-To: From: Jimmy Yuen Ho Wong Date: Thu, 6 May 2021 11:55:25 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ok I think I've found a solution to my problem. There are a couple of things that I didn't understand and had to attach a function to print out which one is being called on 5 different hooks to find out the invocation order. This is call order I've found: 1. ido-setup-hook 2. minibuffer-mode-hook 3. minibuffer-setup-hook 4. minibuffer-exit-hook 5. minibuffer-inactive-mode-hook Specifically, the override keymaps are cleared between step 1 and 2, so if I loop thru the minibuffers in step 1 to assign to minor-mode-override-map-alist inside them, they will be reset in step 2 I suppose. So if I needed to "unshadow" the shadowed keybindings inside the minibuffer, I had to do these processing in minibuffer-setup-hook because that is called every time the minibuffer is entered. Thanks for your help, you can close this issue now. Jimmy On Wed, May 5, 2021 at 3:18 PM Stefan Monnier wrote: > > > 1. On emacs 27, minor mode keybindings will only override the key > > bindings given to read-from-minibuffer after the second invocation of > > the minibuffer, but doesn't on the first invocation. > > Something like that, yes. > That's only for minor modes defined via `define-globalized-minor-mode`. > Not for global minor modes defined in the usual way via (define-minor-mode > ... :global t ...). > > This change makes for a more predictable behavior and is a side-effect > of the change described in etc/NEWS as: > > ** An active minibuffer now has major mode 'minibuffer-mode', not the > erroneous 'minibuffer-inactive-mode' it formerly had. > > More specifically, the difference is that in Emacs<28 sometimes those > globalized minor modes where not enabled (hence their keybindings are > not active). > > > 2. On emacs 28, minor mode keybindings override the key bindings given > > to read-from-minibuffer at all times. > > And this was also true in all previous versions of Emacs. > > > 3. But, `minor-mode-overriding-map-alist` does not override the > > override in effect in the minibuffer like other buffers. > > That's the part of your bug report I haven't understood yet. > > > My expectation is when a keymap is explicitly given to > > read-from-minibuffer, the key bindings in it should take precedence, > > but it doesn't. > > No, this keymap is the "local map" a.k.a "major mode map", so it has > lower precedence than minor keymaps. Always had. > > > As you can see from the snippet from my last email, both > > ido-completion-map and test-mode bind to C-k, I expect the C-k binding > > in ido-completion-map to take effect inside the minibuffer, without > > being overridden by any minor modes in effect inside the minibuffer. > > This expectation is incorrect ;-) > > > If this is not to be desired, I'd expect setting > > minor-mode-overriding-map-alist or the usual key binding lookup search > > algorithm to work inside the minibuffer. > > This should be the case: minibuffers are treated exactly like all other > buffers by the keymap code, AFAIK. > > > Stefan > From unknown Sat Jun 21 05:15:54 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jimmy Yuen Ho Wong Subject: bug#48153: closed (Re: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer) Message-ID: References: X-Gnu-PR-Message: they-closed 48153 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: moreinfo Reply-To: 48153@debbugs.gnu.org Date: Sun, 09 May 2021 14:58:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1620572282-1593-1" This is a multi-part message in MIME format... ------------=_1620572282-1593-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #48153: 28.0.50; minor mode keymaps should not override keymap given to rea= d-from-minibuffer which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 48153@debbugs.gnu.org. --=20 48153: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D48153 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1620572282-1593-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 48153-done) by debbugs.gnu.org; 9 May 2021 14:57:21 +0000 Received: from localhost ([127.0.0.1]:55731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfkrw-0000PG-ST for submit@debbugs.gnu.org; Sun, 09 May 2021 10:57:21 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:1350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfkrs-0000P8-9z for 48153-done@debbugs.gnu.org; Sun, 09 May 2021 10:57:20 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A4A924408FA; Sun, 9 May 2021 10:57:10 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D773E44082C; Sun, 9 May 2021 10:57:08 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1620572228; bh=71Pc3JUXUCgTFjEihDDEq/wR0qEeEKTjnJitoJfJ5j4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=A4bQCSIu0nvwcwP40/2K50VZMhV4BOlHV7JZn4utqSXyFE8NgZepq13BE0vShqB5d 6O33eh8ZtxUgDlqQmPCy1nf1saS0DAADViY1sWHW7kw0LdCByIaCQl1j+qepkk1+Nr PYvpUaApLRzNRhR6uIbpMnMNVC2S/NnxOnSfSuEDCkgSPC/xAXAacoWZFy5eb5vIJ8 P3XcndimaSrSjVqJo0+dnH12ZSl+K3/3uPG7x1wHAtoOcs/j96f64ffa4X1WlAK5Lf Q6qG0DMYJaWAiG+WquiJHG4TaHx8SzHJQok2X6m1AzUYM2/aYEBDrPyNM2Uo4VVp41 Q/cdJD/JNofxw== Received: from alfajor (76-10-140-76.dsl.teksavvy.com [76.10.140.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9B2F3120445; Sun, 9 May 2021 10:57:08 -0400 (EDT) From: Stefan Monnier To: Jimmy Yuen Ho Wong Subject: Re: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Message-ID: References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> <1a73bd6c691b937c82fc@heytings.org> <70f2eadd5f48937bb057@heytings.org> <83r1il2x7t.fsf@gnu.org> <70f2eadd5fbd139e3c62@heytings.org> Date: Sun, 09 May 2021 10:57:07 -0400 In-Reply-To: (Jimmy Yuen Ho Wong's message of "Thu, 6 May 2021 11:55:25 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.083 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48153-done Cc: 48153-done@debbugs.gnu.org, Gregory Heytings , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Ok I think I've found a solution to my problem. There are a couple of > things that I didn't understand and had to attach a function to print > out which one is being called on 5 different hooks to find out the > invocation order. > > This is call order I've found: > > 1. ido-setup-hook > 2. minibuffer-mode-hook > 3. minibuffer-setup-hook > 4. minibuffer-exit-hook > 5. minibuffer-inactive-mode-hook > > Specifically, the override keymaps are cleared between step 1 and 2, > so if I loop thru the minibuffers in step 1 to assign to > minor-mode-override-map-alist inside them, they will be reset in step > 2 I suppose. Indeed, `ido-setup-hook` is run after IDO has configured its own keymaps and variables, but hasn't yet entered the minibuffer, so it's too early to work on `minor-mode-override-map-alist`. > So if I needed to "unshadow" the shadowed keybindings inside the > minibuffer, I had to do these processing in minibuffer-setup-hook > because that is called every time the minibuffer is entered. That's right. > Thanks for your help, you can close this issue now. Closing, thanks, Stefan ------------=_1620572282-1593-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 May 2021 07:00:03 +0000 Received: from localhost ([127.0.0.1]:40946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld65B-0002l7-Qi for submit@debbugs.gnu.org; Sun, 02 May 2021 03:00:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:56814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld659-0002l1-WA for submit@debbugs.gnu.org; Sun, 02 May 2021 03:00:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ld659-0006Cm-Ky for bug-gnu-emacs@gnu.org; Sun, 02 May 2021 02:59:59 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:43620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ld655-0005GW-Qy for bug-gnu-emacs@gnu.org; Sun, 02 May 2021 02:59:59 -0400 Received: by mail-wr1-x42f.google.com with SMTP id x7so2239185wrw.10 for ; Sat, 01 May 2021 23:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=OvVHI7k6MNXLDA5ieEKx8PcDZcJ+8XxcwshoCcKv+Kk=; b=ganWf4ugFfprWs2csdg/lNhv3hOjvdQr11hQBGu2+douV5GUmg0MEyuyrttivwkI/k olTzwx+L6TGSU3KSjxMWTA07K9mJMvw6xji5vpjz90Twhe7Lbvq0x7r8bGlI5a8pJWXT UlSOSbK850DUSpmLTXxLI0cQdLt/Lp9tbR5JkP0zTDCm5K1MI+ND4UGi4NWaBds1CziD xc6ELpM04kELRORYPzqEu0jlNsMjDrnub4PzURDN2/c5OxDkdG1+ANzToDhlGov1TD2P KpDwtX02CI4fA5uaKX71/VHk81nxDMUhmEadNJZbPpntBc2d0Zbykj8aCPo25g3/x1b3 wj0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=OvVHI7k6MNXLDA5ieEKx8PcDZcJ+8XxcwshoCcKv+Kk=; b=oIjfUylnhseaSl1ltap8NHxE5GjV9xVt1i2PEAEnkr6LOvhw+nIBtAw9g/n99ZU7w2 eOCoGokMRCO+GuF3cpJy6yf2p7Kqp6oxShSX2EGDbreIQUnB6PbOGMx9XGh8YLe44LXv grfvMfbeleRMuIaGlpk6ALVwF3dp5gAZAZnu93rTB9vC9Do4paaShI7rOzMJshqY10Zv w6G++Ul3O6gOceTaK2iBQlKfsWgKjZIWFV2rHPupqIKvQo0sa6dTUhSilqe/dde6RO0R Rm316nnQ17zaTGxj6wLAHdw5TER4yJmXFenTUHXhP+VXgE+MZQ4wOs8YUECrvwkgzzRd wBEw== X-Gm-Message-State: AOAM531PoZTGfI2+qF7Ai88w36rxPNpaMWkzmofAb53GbnRfXOKyzPkt zhm4sQ11P2cxQU4YszBcWqXoPQm3TXinQQ== X-Google-Smtp-Source: ABdhPJx4gafEtA/40vOgali2xf98051KAkvLNv9b/gzKoLGo3zaWffU8dYlRfsYMBcqdJszhJdMhtA== X-Received: by 2002:a5d:674c:: with SMTP id l12mr17426106wrw.357.1619938792524; Sat, 01 May 2021 23:59:52 -0700 (PDT) Received: from mg559.lan ([137.220.76.130]) by smtp.gmail.com with ESMTPSA id n124sm18170782wmn.40.2021.05.01.23.59.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 May 2021 23:59:51 -0700 (PDT) From: Jimmy Yuen Ho Wong To: bug-gnu-emacs@gnu.org Subject: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Date: Sun, 02 May 2021 07:58:32 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=wyuenho@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) After typing C-x b or C-x C-f, the minor mode maps from the buffer that launched the minibuffer will override the keymap given to `read-from-minibuffer`, this seems to be a regression in emacs 28 master. Reproduction: 1. Turn on `ido-mode` 2. Turn on some minor mode that rebinds `C-k` with `(define-key some-minor-mode-map (kbd "C-k") 'some-func)` 3. C-x b 4. Select a buffer and type C-k Expectation: C-k should be bound to `ido-kill-buffer-at-head` and calls it, but instead `some-func` is called. Since C-k is bound in `ido-completion-map`, and it is given to `read-from-minibuffer`, all the bindings in `ido-completion-map` should take precedence. Additional info: After some debugging with `enable-recursive-minibuffers`, I typed Shift-Meta-; to open a recursive eval buffer inside the `ido-switch-buffer` buffer, `(cl-loop for buf in (buffer-list) if (minibufferp buf) do (with-current-buffer buf (key-binding (kbd "C-k"))))` reveals that indeed C-k isn't bound inside any minibuffer buffers. In GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin20.4.0, NS appkit-2022.44 Version 11.3 (Build 20E232)) of 2021-05-02 built on mg559.lan Repository revision: f1adb6b77a948e4f2f3223940edb15e56c30466d Repository branch: HEAD Windowing system distributor 'Apple', version 10.3.2022 System Description: macOS 11.3 Configured using: 'configure --prefix=/opt/local --disable-silent-rules --without-dbus --without-gconf --without-libotf --without-m17n-flt --with-gmp --with-gnutls --with-json --with-xml2 --with-modules --infodir /opt/local/share/info/emacs --with-ns --with-lcms2 --without-harfbuzz --without-imagemagick --without-xaw3d --with-native-compilation --with-rsvg 'CFLAGS=-pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk -arch x86_64' 'CPPFLAGS=-I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk' 'LDFLAGS=-L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-no_pie -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk -arch x86_64'' Configured features: ACL GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS XIM ZLIB Important settings: value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: projectile-rails-global-mode: t projectile-mode: t eldoc-box-hover-at-point-mode: t company-box-mode: t company-prescient-mode: t prescient-persist-mode: t rainbow-mode: t elisp-def-mode: t display-line-numbers-mode: t subword-mode: t form-feed-mode: t beginend-prog-mode: t imenu-list-minor-mode: t purpose-mode: t diff-hl-flydiff-mode: t crm-custom-mode: t override-global-mode: t dap-tooltip-mode: t dap-ui-many-windows-mode: t dap-ui-controls-mode: t dap-ui-mode: t treemacs-filewatch-mode: t treemacs-follow-mode: t treemacs-git-mode: deferred treemacs-fringe-indicator-mode: t global-git-commit-mode: t magit-auto-revert-mode: t shell-dirtrack-mode: t winner-mode: t which-key-mode: t which-function-mode: t smooth-scrolling-mode: t show-smartparens-global-mode: t show-smartparens-mode: t smartparens-global-mode: t smartparens-mode: t show-paren-mode: t server-mode: t savehist-mode: t save-place-mode: t rxt-global-mode: t rxt-mode: t recentf-mode: t minibuffer-depth-indicate-mode: t ido-vertical-mode: t ido-ubiquitous-mode: t global-whitespace-cleanup-mode: t whitespace-cleanup-mode: t global-tree-sitter-mode: t global-so-long-mode: t global-origami-mode: t origami-mode: t global-move-dup-mode: t move-dup-mode: t global-flycheck-mode: t global-diff-hl-show-hunk-mouse-mode: t diff-hl-show-hunk-mouse-mode: t global-diff-hl-mode: t diff-hl-mode: t global-company-mode: t company-mode: t global-auto-revert-mode: t flx-ido-mode: t ido-everywhere: t icomplete-vertical-mode: t icomplete-mode: t fido-mode: t editorconfig-mode: t desktop-save-mode: t delete-selection-mode: t dap-auto-configure-mode: t dap-mode: t yas-minor-mode: t auto-compile-on-save-mode: t auto-compile-mode: t amx-mode: t abridge-diff-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t window-divider-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t temp-buffer-resize-mode: t buffer-read-only: t size-indication-mode: t column-number-mode: t line-number-mode: t visual-line-mode: t transient-mark-mode: t Load-path shadows: /opt/local/share/emacs/site-lisp/cmake-mode hides /Users/jimmyyuenhowong/.emacs.d/elpa/cmake-mode-20210104.1831/cmake-mode /Users/jimmyyuenhowong/.emacs.d/elpa/transient-20210426.2141/transient hides /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/transient Features: (shadow sort mail-extr emacsbug sendmail visual-regexp-steroids visual-regexp misearch multi-isearch tabify cl-print jka-compr helpful trace edebug info-look elisp-refs two-column vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs diff-hl-dired all-the-icons-dired dired-collapse dired-hacks-utils projectile-rails rake inflections inf-ruby smartparens-ruby ruby-mode smie autoinsert projectile vc-git eldoc-box company-box company-box-doc frame-local company-box-icons dash-functional company-prescient prescient company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-yasnippet company-capf company-files company-cmake company-clang company-semantic company-template company-bbdb rainbow-mode elisp-def ert debug backtrace display-line-numbers cap-words superword subword smartparens-config smartparens-javascript smartparens-markdown smartparens-text smartparens-c form-feed editorconfig-core editorconfig-core-handle editorconfig-fnmatch beginend window-purpose-x shut-up imenu-list hideshow window-purpose window-purpose-fixes window-purpose-prefix-overload window-purpose-switch window-purpose-layout window-purpose-core window-purpose-configuration eieio-compat window-purpose-utils windmove dired-hide-dotfiles shrink-path magit-lfs forge-list forge-commands forge-semi forge-bitbucket buck forge-gogs gogs forge-gitea gtea forge-gitlab glab forge-github ghub-graphql treepy gsexp ghub let-alist gnutls forge-notify forge-revnote forge-pullreq forge-issue forge-topic bug-reference forge-post forge-repo forge forge-core forge-db closql magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log diff-hl-flydiff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util dumb-jump popup rg rg-info-hack rg-menu rg-ibuffer rg-result wgrep-rg wgrep rg-history rg-header ibuf-ext ibuffer ibuffer-loaddefs grep lsp-metals view lsp-metals-treeview lsp-metals-protocol yard-mode typescript-mode json-mode json-reformat json-snatcher js cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs reformatter cl-lib-highlight eterm-256color term disp-table ehelp xterm-color native-complete emacsql-sqlite emacsql emacsql-compiler url-http url-auth url-gw lsp-sourcekit lsp lsp-pyright lsp-jedi tree-sitter-langs tree-sitter-langs-build tar-mode arc-mode archive-mode tree-sitter-hl iedit iedit-lib mc-hide-unmatched-lines-mode mc-mark-more mc-cycle-cursors multiple-cursors-core rect icomplete-vertical crm-custom pager-default-keybindings pager browse-kill-ring paradox paradox-menu paradox-commit-list paradox-execute paradox-github paradox-core parse-time iso8601 use-package-bind-key bind-key use-package-delight osx-trash exec-path-from-shell all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons spaceline-config spaceline-segments spaceline powerline powerline-separators powerline-themes solarized-dark-theme solarized-theme solarized solarized-faces delight quelpa-use-package use-package-core quelpa lisp-mnt help-fns radix-tree dap-mouse dap-ui lsp-treemacs lsp-treemacs-themes treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-interface treemacs-extensions treemacs-mouse-interface treemacs-tags treemacs-persistence treemacs-filewatch-mode treemacs-follow-mode treemacs-rendering treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals treemacs-fringe-indicator treemacs-scope pulse treemacs-faces treemacs-icons treemacs-themes treemacs-core-utils pfuture hl-line treemacs-logging treemacs-customization treemacs-macros gdb-mi gud bui bui-list bui-info bui-entry bui-core bui-history bui-button bui-utils lsp-lens magit-diff smerge-mode diff git-commit log-edit message rfc822 mml mml-sec epa derived gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor shell pcomplete magit-mode transient format-spec magit-git magit-section magit-utils crm winner which-key which-func smooth-scrolling smartparens paren server savehist saveplace pcre2el rxt re-builder recentf mb-depth ido-vertical-mode ido-completing-read+ memoize cus-edit pp minibuf-eldef help-at-pt whitespace-cleanup-mode whitespace tree-sitter tree-sitter-load tree-sitter-cli tsc tsc-dyn tsc-dyn-get dired-aux dired dired-loaddefs tsc-obsolete so-long origami origami-parsers move-dup flycheck find-func diff-hl-show-hunk diff-hl-inline-popup diff-hl log-view pcvs-util vc-dir vc vc-dispatcher diff-mode company autorevert flx-ido advice flx ido icomplete editorconfig desktop frameset delsel dap-mode dap-launch posframe dap-overlays lsp-mode lsp-protocol yasnippet-snippets yasnippet xref project tree-widget wid-edit spinner network-stream puny nsm rmc markdown-mode color thingatpt noutline outline easy-mmode lv inline imenu ht filenotify f ewoc epg epg-config dash compile text-property-search comint ansi-color ring auto-compile packed amx s abridge-diff cus-load edmacro kmacro cl info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source eieio eieio-core eieio-loaddefs password-cache json map url-vars comp comp-cstr warnings subr-x rx cl-seq cl-macs cl-extra help-mode seq byte-opt bytecomp byte-compile cconv gv pcase cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process nativecomp emacs) Memory information: ((conses 16 1144104 503139) (symbols 48 53507 0) (strings 32 202614 92506) (string-bytes 1 7453813) (vectors 16 153419) (vector-slots 8 3884557 589614) (floats 8 2540 3047) (intervals 56 8434 5150) (buffers 992 29)) ------------=_1620572282-1593-1--