GNU bug report logs - #48137
27.2; `package-install-file' fails when loading a package file with DOS line endings

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Ioannis Kappas <ioannis.kappas <at> gmail.com>, 48137 <at> debbugs.gnu.org
Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings
Date: Sat, 29 May 2021 09:59:01 -0400

>> From: Ioannis Kappas <ioannis.kappas <at> gmail.com>
>> Date: Sun, 16 May 2021 10:09:07 +0100
>> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 48137 <at> debbugs.gnu.org
>> 
>> On Sat, May 15, 2021 at 2:52 PM Ioannis Kappas <ioannis.kappas <at> gmail.com> wrote:
>> > I shall have a look next whether we could always load the package with
>> > `insert-file-contents-literally' but parse headers with the correct
>> > encoding (`find-operation-coding-system' looks like a promising fn
>> > to determine the correct encoding from a literal file buffer).
>> 
>> Please find below a patch to read package headers from a temporarily
>> decoded buffer, while keeping the literal buffer (which will be used
>> to install the package) intact.
>
> Stefan, any comments?

No particular comment from me, except: this is tricky enough that
it would benefit from some regression tests.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.