GNU bug report logs - #48137
27.2; `package-install-file' fails when loading a package file with DOS line endings

Previous Next

Package: emacs;

Reported by: Ioannis Kappas <ioannis.kappas <at> gmail.com>

Date: Sat, 1 May 2021 11:40:02 UTC

Severity: normal

Tags: patch

Found in version 27.2

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #38 received at 48137 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: ioannis.kappas <at> gmail.com, 48137 <at> debbugs.gnu.org
Subject: Re: bug#48137: 27.2; `package-install-file' fails when loading a
 package file with DOS line endings
Date: Tue, 04 May 2021 14:34:45 +0300
> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: ioannis.kappas <at> gmail.com,  48137 <at> debbugs.gnu.org
> Date: Mon, 03 May 2021 15:41:47 -0400
> 
> > I think it's wrong for package.el to try to decode these files.  It
> > should deliver the files to the disk exactly as they are received
> > through the wire.  And the only safe way of doing that is to treat
> > these files as raw bytes.
> 
> I'm not sure what you're referring to here.

To the suggestion to decode *.el files by package.el as part of the
installation.

> In the OP's case, i.e. `package-install-file` (which is a seldom used
> functionality, not part of the "normal" `package-install`) the file doesn't go
> through the wire: it's already "local" and we currently implement this
> code on top of `package-install-from-buffer`, so it has to work
> correctly with an already-decoded buffer.

If this works with buffer text, then how are DOS EOLs come into play
here?  There are no CRLF pairs in decoded buffer text.




This bug report was last modified 4 years ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.