GNU bug report logs - #48126
[PATCH] Add package for vim-solarized

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tissevert <tissevert+guix <at> marvid.fr>
Subject: bug#48126: closed (Re: [PATCH] Add package for vim-solarized)
Date: Sat, 15 May 2021 13:05:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#48126: [PATCH] Add package for vim-solarized

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 48126 <at> debbugs.gnu.org.

-- 
48126: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48126
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 48126-done <at> debbugs.gnu.org
Subject: Re: [PATCH] Add package for vim-solarized
Date: Sat, 15 May 2021 15:04:11 +0200

[Message part 3 (text/plain, inline)]

Tissevert,

I

- added a commit message following our particular flavour of the 
 ‘GNU ChangeLog format’,
- changed the URL to /solarized (the commit already referred to 
 that repository),
- explained that this package installs only the Vim files from 
 there,

and pushed the thing as 992aa56e7c5d10e7d8d260fe3b2d0ce15b00c17b.

Phew!  And thanks,

T G-R

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Tissevert <tissevert+guix <at> marvid.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add package for vim-solarized
Date: Fri, 30 Apr 2021 19:42:35 +0200

[Message part 6 (text/plain, inline)]

Hi Guix !

I here's my first attempt at packaging something, I noticed that vim-solarized
was missing so I tried to write a package for it.

The only warning I got was from the guix lint which told me it couldn't find
upstream releases. I believe this is due to vim-solarized particular structure:
it's a light «clone» of the main repository
https://github.com/altercation/solarized containing only the vim-files. It
doesn't have any tags/releases but the full repository does. I used the latest
commit on the master branch in git-reference for guix to retrieve it and the
corresponding version on the full repository as package version. Does that seem
right ? I found another copy in project vim-scripts
(https://github.com/vim-scripts/Solarized) which has made a tag (the same
version name that I chose) so we could be using either the full repository
(more unneeded data retrieved during the build) or this second copy (they do
provide a tag but isn't it better to remain as close as possible to the
original source ?).

I hope my patch is correct and thank you everyone for being such a welcoming
community and having made my experience with Guix so far absolutely great !

Tissevert

[0001-Add-package-for-vim-solarized.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.