From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 29 19:20:52 2021 Received: (at submit) by debbugs.gnu.org; 29 Apr 2021 23:20:52 +0000 Received: from localhost ([127.0.0.1]:57063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcFxk-000712-Nl for submit@debbugs.gnu.org; Thu, 29 Apr 2021 19:20:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:33304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcFxg-00070r-C0 for submit@debbugs.gnu.org; Thu, 29 Apr 2021 19:20:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47134) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcFxg-0005vH-6B for bug-guix@gnu.org; Thu, 29 Apr 2021 19:20:48 -0400 Received: from mx1.riseup.net ([198.252.153.129]:35122) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcFxe-00017N-7K for bug-guix@gnu.org; Thu, 29 Apr 2021 19:20:47 -0400 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4FWWhC0BF1zDsnp for ; Thu, 29 Apr 2021 16:20:43 -0700 (PDT) X-Riseup-User-ID: 62BA0BE34D10D19E1E789A8400B1E484A76B86B049DB6E175D9B171403A106CC Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4FWWhB2CFNz1yS8 for ; Thu, 29 Apr 2021 16:20:42 -0700 (PDT) Date: Thu, 29 Apr 2021 19:54:15 +0200 From: raingloom To: Guix Bugs Subject: tilde in Go package names (eg. sourcehut hosted packages) Message-ID: <20210429195415.3f0dfaa9@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=198.252.153.129; envelope-from=raingloom@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Trying to import kineto and getting this error when building it: guix build: error: invalid character `~' in name `go-git-sr-ht-~sircmpwn-kineto-0.0.0-20210225135222-edd4fe31f16f-checkout.drv' I know the names are significant in go-build-system so I'm not sure how to work around the issue without breaking anything. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 30 05:54:13 2021 Received: (at 48111) by debbugs.gnu.org; 30 Apr 2021 09:54:13 +0000 Received: from localhost ([127.0.0.1]:57530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcPqf-0007XI-7B for submit@debbugs.gnu.org; Fri, 30 Apr 2021 05:54:13 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:65464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcPqc-0007X7-SM for 48111@debbugs.gnu.org; Fri, 30 Apr 2021 05:54:12 -0400 Received: from [10.0.0.4] (91-114-247-246.adsl.highway.telekom.at [91.114.247.246]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FWnl20S8lz3xnV; Fri, 30 Apr 2021 11:54:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1619776446; bh=GCDeYejQlsm6ap/MB9eYILM1Jn7MmVjfcMyUaY4+AiM=; h=Subject:From:To:Date:In-Reply-To:References; b=rIb+RaSCCB1UPF0HLabMw93QSOBoDGwiBEekY6Ury2Vx+5/v5pD0JJSHodATqYweI Y1E4/iAOyN1xO5VPzVG3siB+hUDs6X6QaHe9Bng4v7mSl36gh0gWm3ATC27cmVeUhH JKxLnEkEGtlAB++6Vff4uR+wESJ1Ae1+papR8QS4= Message-ID: <9ea8a08c75fc1a7b26f0380ba3a42161f3d5c570.camel@student.tugraz.at> Subject: Re: tilde in Go package names (eg. sourcehut hosted packages) From: Leo Prikler To: raingloom , 48111@debbugs.gnu.org Date: Fri, 30 Apr 2021 11:53:40 +0200 In-Reply-To: <20210429195415.3f0dfaa9@riseup.net> References: <20210429195415.3f0dfaa9@riseup.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48111 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Donnerstag, den 29.04.2021, 19:54 +0200 schrieb raingloom: > Trying to import kineto and getting this error when building it: > > guix build: error: invalid character `~' in name > `go-git-sr-ht-~sircmpwn-kineto-0.0.0-20210225135222-edd4fe31f16f- > checkout.drv' > > I know the names are significant in go-build-system so I'm not sure > how > to work around the issue without breaking anything. The way Go works, I would hazard a guess, that module git.sr.ht/~sircmpwn/kineto and module git.sr.ht/sircmpwn/kineto name two different modules. However, as the latter can't exist since sr.ht prefixes user names with ~, I think a name transformation, that maps the former to the latter should be safe. On the other hand, since this just affects store file names, we might instead want to map "~" to "-" in the general case of it appearing anywhere. WDYT? Regards, Leo From debbugs-submit-bounces@debbugs.gnu.org Mon May 03 05:07:03 2021 Received: (at 48111) by debbugs.gnu.org; 3 May 2021 09:07:03 +0000 Received: from localhost ([127.0.0.1]:46211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldUXe-0001Wc-KN for submit@debbugs.gnu.org; Mon, 03 May 2021 05:07:03 -0400 Received: from mx1.riseup.net ([198.252.153.129]:57822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldUXa-0001Vy-SQ for 48111@debbugs.gnu.org; Mon, 03 May 2021 05:07:00 -0400 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4FYcY943sQzDqkN; Mon, 3 May 2021 02:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1620032813; bh=JsCNsyustO1+xjAvRZo1+MiHbtRu+S5cIwPvXVYoG0c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hQcOxMISoQ8BcBIS/U8PwPsfuC2vTxxPCh65uj8HFxYCDBrRarLEjjvVHBdC1kOaY j0IsB/vL6s6HKeTZS9BGakm3ZcPl03RBR72/yol5iJtqNtnVO8IOzIqP1Y2ctwBiWo V5t32nFaJZVyY2FE3DugeHhmbrJ92rjw6Kms2orE= X-Riseup-User-ID: 382E74E2F4DA5BE720E6DCCD1E93C8A41C402124C2068A7A7C891F732CA24B8A Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4FYcY84jFwz5vRy; Mon, 3 May 2021 02:06:52 -0700 (PDT) Date: Mon, 3 May 2021 04:16:15 +0200 From: raingloom To: Leo Prikler Subject: Re: tilde in Go package names (eg. sourcehut hosted packages) Message-ID: <20210503041615.733f9870@riseup.net> In-Reply-To: <9ea8a08c75fc1a7b26f0380ba3a42161f3d5c570.camel@student.tugraz.at> References: <20210429195415.3f0dfaa9@riseup.net> <9ea8a08c75fc1a7b26f0380ba3a42161f3d5c570.camel@student.tugraz.at> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 48111 Cc: 48111@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On Fri, 30 Apr 2021 11:53:40 +0200 Leo Prikler wrote: > Am Donnerstag, den 29.04.2021, 19:54 +0200 schrieb raingloom: > > Trying to import kineto and getting this error when building it: > > > > guix build: error: invalid character `~' in name > > `go-git-sr-ht-~sircmpwn-kineto-0.0.0-20210225135222-edd4fe31f16f- > > checkout.drv' > > > > I know the names are significant in go-build-system so I'm not sure > > how > > to work around the issue without breaking anything. > The way Go works, I would hazard a guess, that > module git.sr.ht/~sircmpwn/kineto > and > module git.sr.ht/sircmpwn/kineto > name two different modules. However, as the latter can't exist since > sr.ht prefixes user names with ~, I think a name transformation, that > maps the former to the latter should be safe. On the other hand, > since this just affects store file names, we might instead want to > map "~" to "-" in the general case of it appearing anywhere. WDYT? > > Regards, > Leo > It turns out that it's okay to change the names, only the input alist keys are significant. So it was relatively quick to fix this by hand. Not sure how the importer should handle it. I've been meaning to look at importers for a while, because I wanna tackle either a Chicken or an Akku importer, so, I'll try something Eventually (TM), but can't promise a deadline. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 04 18:51:14 2021 Received: (at 48111) by debbugs.gnu.org; 4 Jul 2021 22:51:14 +0000 Received: from localhost ([127.0.0.1]:43364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0AxG-0008HK-DE for submit@debbugs.gnu.org; Sun, 04 Jul 2021 18:51:14 -0400 Received: from out1.migadu.com ([91.121.223.63]:50732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0AxE-0008HB-8R for 48111@debbugs.gnu.org; Sun, 04 Jul 2021 18:51:13 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1625439070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=asWz7VW7UqX9xnffFZGw5axJppUjlzyAGZ/YSJtqWfw=; b=GVIWNjUq+H8rbxnhe7GTtz0Gf5RRjfwcK3e7aq5GBtOwHdKqbL90JTIgp8LSIK76p9vSRT p3VpjZUwCKKn/Cp7ZwRRV9VXSb9bpfo0xhlXM7v7jz6ie1mPXznWmAFKGzbXAmhya28zmm bUYlIumgd4cyhvJnsDlKHonQZmloZPo= From: Sarah Morgensen To: Leo Prikler Subject: Re: bug#48111: tilde in Go package names (eg. sourcehut hosted packages) References: <20210429195415.3f0dfaa9@riseup.net> <9ea8a08c75fc1a7b26f0380ba3a42161f3d5c570.camel@student.tugraz.at> Date: Sun, 04 Jul 2021 15:51:07 -0700 In-Reply-To: <9ea8a08c75fc1a7b26f0380ba3a42161f3d5c570.camel@student.tugraz.at> (Leo Prikler's message of "Fri, 30 Apr 2021 11:53:40 +0200") Message-ID: <86czrxae1w.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48111 Cc: 48111@debbugs.gnu.org, raingloom X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hello, Leo Prikler writes: > Am Donnerstag, den 29.04.2021, 19:54 +0200 schrieb raingloom: >> Trying to import kineto and getting this error when building it: >> >> guix build: error: invalid character `~' in name >> `go-git-sr-ht-~sircmpwn-kineto-0.0.0-20210225135222-edd4fe31f16f- >> checkout.drv' >> >> I know the names are significant in go-build-system so I'm not sure >> how >> to work around the issue without breaking anything. As far as I can tell, the go-build-system doesn't care about the actual package names, just #:import-path and #:unpack-path. The names should only be significant to the go importer insofar as go-module->guix-package-name does not generate collisions. > The way Go works, I would hazard a guess, that > module git.sr.ht/~sircmpwn/kineto > and > module git.sr.ht/sircmpwn/kineto > name two different modules. However, as the latter can't exist since > sr.ht prefixes user names with ~, I think a name transformation, that > maps the former to the latter should be safe. On the other hand, since > this just affects store file names, we might instead want to map "~" to > "-" in the general case of it appearing anywhere. WDYT? It might be slightly uglier, but I think it's better to keep a consistent policy of "replace any invalid characters with a hyphen", as it is less likely to generate collisions and it provides a hint to the reader that there *is* a character there. I have attached a patch to do so below, verified that a recursive import of the package mentioned above builds without modification (well, I had to update a dependency...) and verified that there are not currently any go packages using a tilde in their name with: $ egrep -r '"go-[^"]*~[^"]*"' gnu/packages --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-import-go-Replace-tildes-with-hyphens-in-package-nam.patch Content-Description: import: go: Replace tildes with hyphens in package names. >From 2c942a06cf94acdca07f2a59736c89521953af0f Mon Sep 17 00:00:00 2001 Message-Id: <2c942a06cf94acdca07f2a59736c89521953af0f.1625436903.git.iskarian@mgsn.dev> From: Sarah Morgensen Date: Sun, 4 Jul 2021 15:00:15 -0700 Subject: [PATCH] import: go: Replace tildes with hyphens in package names. Fixes . * guix/import/go.scm (go-module->guix-package-name): Replace tildes with hyphens. --- guix/import/go.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/guix/import/go.scm b/guix/import/go.scm index 5e23d6a2b3..d8f838f635 100644 --- a/guix/import/go.scm +++ b/guix/import/go.scm @@ -430,9 +430,9 @@ hence the need to derive this information." (define* (go-module->guix-package-name module-path #:optional version) "Converts a module's path to the canonical Guix format for Go packages. Optionally include a VERSION string to append to the name." - ;; Map dot, slash and underscore characters to hyphens. + ;; Map dot, slash, underscore and tilde characters to hyphens. (let ((module-path* (string-map (lambda (c) - (if (member c '(#\. #\/ #\_)) + (if (member c '(#\. #\/ #\_ #\~)) #\- c)) module-path))) base-commit: 9e63bafafbe7a7c2d9804fae62302ac8a7e90090 -- 2.31.1 --=-=-= Content-Type: text/plain -- Sarah --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 05 03:57:23 2021 Received: (at 48111-done) by debbugs.gnu.org; 5 Jul 2021 07:57:23 +0000 Received: from localhost ([127.0.0.1]:43785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0JTm-0004qO-W9 for submit@debbugs.gnu.org; Mon, 05 Jul 2021 03:57:23 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:21151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0JTi-0004qC-Pt for 48111-done@debbugs.gnu.org; Mon, 05 Jul 2021 03:57:21 -0400 Received: from nijino.local (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GJJ1l5dN7z3wD1; Mon, 5 Jul 2021 09:57:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625471836; bh=zmy3s+Oq9TMmLdpsvWk8H5EPKkzwwL88OjDNuxX69nQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=T8jsXQdUimJ5dIZcf8eAldd0U3+WjzxxkRRb7lMkS1/qYcXlRPuhoY9zd0SGCKI+8 G6//dmYLfZaKTGe2XlFBdGZ1muxIgq2kuFwOF6oX2FRoNOGVQ8booagA8XsRV3jXnS XiCORumQNCCmK3ouBjafDlmrhtQfhbzMpHdz4rqU= Message-ID: <99ccdaecd57d5766ee5920e811a934b9b2a58394.camel@student.tugraz.at> Subject: Re: bug#48111: tilde in Go package names (eg. sourcehut hosted packages) From: Leo Prikler To: Sarah Morgensen Date: Mon, 05 Jul 2021 09:57:14 +0200 In-Reply-To: <86czrxae1w.fsf@mgsn.dev> References: <20210429195415.3f0dfaa9@riseup.net> <9ea8a08c75fc1a7b26f0380ba3a42161f3d5c570.camel@student.tugraz.at> <86czrxae1w.fsf@mgsn.dev> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48111-done Cc: 48111-done@debbugs.gnu.org, raingloom X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Am Sonntag, den 04.07.2021, 15:51 -0700 schrieb Sarah Morgensen: > It might be slightly uglier, but I think it's better to keep a > consistent policy of "replace any invalid characters with a hyphen", > as it is less likely to generate collisions and it provides a hint to > the reader that there *is* a character there. Fair enough, that's a reasonable take. > I have attached a patch to do so below, verified that a recursive > import of the package mentioned above builds without modification > (well, I had to update a dependency...) and verified that there are > not currently any go packages using a tilde in their name with: > > $ egrep -r '"go-[^"]*~[^"]*"' gnu/packages I couldn't verify this as the importer delivered 410s, but the patch LGTM, so I pushed it. Thanks, Leo From unknown Sun Jun 15 08:47:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 02 Aug 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator