GNU bug report logs - #48089
Guile 3.0.6 returns zero-indexed locations for ‘read-error’

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andy Wingo <wingo <at> pobox.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#48089: closed (Guile 3.0.6 returns zero-indexed locations for
 ‘read-error’)
Date: Thu, 29 Apr 2021 20:06:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 29 Apr 2021 22:04:52 +0200
with message-id <8735v8luvv.fsf <at> pobox.com>
and subject line Re: bug#48089: Guile 3.0.6 returns zero-indexed locations for ‘read-error’
has caused the debbugs.gnu.org bug report #48089,
regarding Guile 3.0.6 returns zero-indexed locations for ‘read-error’
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
48089: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48089
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: bug-guile <at> gnu.org
Subject: Guile 3.0.6 returns zero-indexed locations for ‘read-error’
Date: Thu, 29 Apr 2021 00:33:54 +0200

Hi,

Guile 3.0.6 returns zero-indexed (instead of one-indexed) source code
locations for ‘read-error’.  Here’s a 3.0.6/3.0.5 comparison:

--8<---------------cut here---------------start------------->8---
$ /gnu/store/r2nr74rwhpqg16y1lyi6l0jn3lwx4yyz-guile-3.0.6/bin/guile  <(echo '(')
ice-9/read.scm:126:4: In procedure lp:
/dev/fd/63:1:0: unexpected end of input while searching for: )
$ guile  <(echo '(')
ERROR: In procedure primitive-load:
In procedure scm_i_lreadparen: /dev/fd/63:2:1: end of file
--8<---------------cut here---------------end--------------->8---

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Andy Wingo <wingo <at> pobox.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 48089-done <at> debbugs.gnu.org
Subject: Re: bug#48089: Guile 3.0.6 returns zero-indexed locations for
 ‘read-error’
Date: Thu, 29 Apr 2021 22:04:52 +0200

Done :)

On Thu 29 Apr 2021 11:33, Ludovic Courtès <ludo <at> gnu.org> writes:

> Ludovic Courtès <ludo <at> gnu.org> skribis:
>
>> Guile 3.0.6 returns zero-indexed (instead of one-indexed) source code
>> locations for ‘read-error’.  Here’s a 3.0.6/3.0.5 comparison:
>>
>> $ /gnu/store/r2nr74rwhpqg16y1lyi6l0jn3lwx4yyz-guile-3.0.6/bin/guile  <(echo '(')
>> ice-9/read.scm:126:4: In procedure lp:
>> /dev/fd/63:1:0: unexpected end of input while searching for: )
>> $ guile  <(echo '(')
>> ERROR: In procedure primitive-load:
>> In procedure scm_i_lreadparen: /dev/fd/63:2:1: end of file
>
> Here’s a test case waiting to succeed!  :-)
>
> diff --git a/test-suite/tests/reader.test b/test-suite/tests/reader.test
> index fad531b39..231e69553 100644
> --- a/test-suite/tests/reader.test
> +++ b/test-suite/tests/reader.test
> @@ -212,6 +212,18 @@
>  
>  
>  (with-test-prefix "mismatching parentheses"
> +  (pass-if-equal "read-error location"
> +      '("foo.scm:3:1: unexpected end of input while searching for: ~A" #\))
> +    (catch 'read-error
> +      (lambda ()
> +        ;; The missing closing paren error should be located on line 3,
> +        ;; column 1 (one-indexed).
> +        (call-with-input-string "\n    (hi there!\n"
> +          (lambda (port)
> +            (set-port-filename! port "foo.scm")
> +            (read port))))
> +      (lambda (key proc message args . _)
> +        (cons message args))))
>    (pass-if-exception "opening parenthesis"
>      exception:eof
>      (read-string "("))
>
>
> Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.