Subject: bug#48073: closed (Re: bug#48073: 27.2; [Eglot] Don't bind `completion-styles' buffer locally?)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 28 Apr 2021 12:04:01 +0000

Your bug report

#48073: 27.2; [Eglot] Don't bind `completion-styles' buffer locally?

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
48073: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48073
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#48073: 27.2; [Eglot] Don't bind `completion-styles' buffer locally?
From: João Távora <[email-masked]>
To: Augusto Stoffel <[email-masked]>, [email-masked]
Cc: Stefan Monnier <[email-masked]>
Date: Wed, 28 Apr 2021 13:03:26 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Augusto Stoffel <[email-masked]> writes:

> Here is a patch setting `completion-category-defaults'.
>
> From e9d877c9c7203ce999a935cdbc36c619255cf63c Mon Sep 17 00:00:00 2001
> From: Augusto Stoffel <[email-masked]>
> Date: Wed, 28 Apr 2021 08:50:10 +0200
> Subject: [PATCH] Add a completion-category-defaults entry

Thanks. Pushed to Eglot's upstream.  Closing this bug report.

João

Subject: 27.2; [Eglot] Don't bind `completion-styles' buffer locally?
From: Augusto Stoffel <[email-masked]>
To: [email-masked]
Date: Tue, 27 Apr 2021 21:20:17 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Binding `completion-styles' buffer locally can lead to problems on
alternative completion UIs, say if the minibuffer is involved (this used
to happen with Consult's compeltion in region until recently).

It seems that a more appropriate way to override the completion style
would be to include a category in the completion table metadata, and add
a corresponding entry to `completion-category-defaults', which can be
done globally.