GNU bug report logs - #48072
28.0.50: dired-read-shell-command: handle empty input properly [PATCH]

Previous Next

Full log

Message #8 received at 48072 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Boruch Baum <boruch_baum <at> gmx.com>
Cc: 48072 <at> debbugs.gnu.org
Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input
 properly [PATCH]
Date: Tue, 27 Apr 2021 22:19:22 +0300

> Date: Tue, 27 Apr 2021 15:02:43 -0400
> From: Boruch Baum <boruch_baum <at> gmx.com>
> 
> Function dired-read-shell-command was accepting an empty input. This is
> a bug because it then passes the empty input as a legitimate command
> which is silently processed (in error) by dired, eventually to return a
> completion message.

I'm not sure we want to disallow this.  (Wasn't there a similar
discussion recently?)

> validates the entered command as a valid shell executable.

This is certainly a mistake: a valid shell command doesn't have to be
a file that executable-find is able to find.  Shells are known to
support all kinds of internal and magic commands.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.