GNU bug report logs - #48063
28.0.50: apropos-value{,-internal}: suppress false positives

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48063 in the body.
You can then email your comments to 48063 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Boruch Baum <boruch_baum <at> gmx.com>
To: Emacs Bug Reporting <bug-gnu-emacs <at> gnu.org>
Subject: 28.0.50: apropos-value{,-internal}: suppress false positives
Date: Tue, 27 Apr 2021 11:17:27 -0400

[Message part 1 (text/plain, inline)]

Function apropos-value will always return false positive, some of which
entail printing out very long variable value strings. The attached patch
apropos-value.patch fixes those cases. The second patch just changes
what seems to be an indentation bug in the function.

The cases of false positives are:

+ variables reflecting the apropos request itself
  + (car minibuffer-history)
  + (car command-history)

+ variables internal to apropos:
  + apropos--current
  + apropos-pattern-quoted
  + pattern



--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

[apropos-value.patch (text/x-diff, attachment)]

[apropos-value-indent-change.patch (text/x-diff, attachment)]

Message #8 received at 48063 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Boruch Baum <boruch_baum <at> gmx.com>
Cc: 48063 <at> debbugs.gnu.org
Subject: Re: bug#48063: 28.0.50: apropos-value{,-internal}: suppress false
 positives
Date: Sun, 02 May 2021 10:23:12 +0200

Boruch Baum <boruch_baum <at> gmx.com> writes:

> Function apropos-value will always return false positive, some of which
> entail printing out very long variable value strings. The attached patch
> apropos-value.patch fixes those cases. The second patch just changes
> what seems to be an indentation bug in the function.

Thanks; applied to Emacs 28.  (This makes the command a lot more
useful -- these false positives have always annoyed me.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 48063 <at> debbugs.gnu.org (full text, mbox):

From: Boruch Baum <boruch_baum <at> gmx.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 48063 <at> debbugs.gnu.org
Subject: Re: bug#48063: 28.0.50: apropos-value{,-internal}: suppress false
 positives
Date: Sun, 2 May 2021 08:22:40 -0400

On 2021-05-02 10:23, Lars Ingebrigtsen wrote:
> Boruch Baum <boruch_baum <at> gmx.com> writes:
>
> > Function apropos-value will always return false positive, some of which
> > entail printing out very long variable value strings. The attached patch
> > apropos-value.patch fixes those cases. The second patch just changes
> > what seems to be an indentation bug in the function.
>
> Thanks; applied to Emacs 28.  (This makes the command a lot more
> useful -- these false positives have always annoyed me.)

Great!

--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.