From unknown Sat Jun 21 10:40:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48050: Pinebook Pro LCD and Audio support Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 26 Apr 2021 23:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48050 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 48050@debbugs.gnu.org Cc: Leo Famulari X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161948065514671 (code B ref -1); Mon, 26 Apr 2021 23:45:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 Apr 2021 23:44:15 +0000 Received: from localhost ([127.0.0.1]:47484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbAti-0003oX-KW for submit@debbugs.gnu.org; Mon, 26 Apr 2021 19:44:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:49246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbAte-0003oN-4C for submit@debbugs.gnu.org; Mon, 26 Apr 2021 19:44:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbAtd-0005JO-OU for bug-guix@gnu.org; Mon, 26 Apr 2021 19:44:09 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:33628) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbAtV-00028g-HN for bug-guix@gnu.org; Mon, 26 Apr 2021 19:44:09 -0400 Received: from localhost (97-120-1-76.ptld.qwest.net [97.120.1.76]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 9E5D51AF05; Mon, 26 Apr 2021 16:43:53 -0700 (PDT) From: Vagrant Cascadian Date: Mon, 26 Apr 2021 16:43:49 -0700 Message-ID: <87o8e0mx1m.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain The attached patch enables support for LCD display and limited audio support for pinebook-pro-rk3399. With this, the Pinebook Pro gets display output on the built-in LCD. Console works, wayland works (tested with sway), presumably X.org would work as well (untested). Audio output on headphones kind of works. Trackpad is still a little sketchy; might require enabling some more modules. This should basically obsolete the need for the wip-pinebook-pro branch; I haven't noticed any significant functionality difference. I believe the same patches and changes apply and work more-or-less unchanged for linux-libre 5.10 lts series (I tested against Debian's 5.10.x kernel), and it might be worth having an LTS kernel with this enabled. If that's considered desireable, I can update the patch to add that too. Since this will require rebuilding the linux-libre tarball, it is probably best to wait to merge this until the next batch of linux-libre updates (e.g. linux-libre 5.11.x and 5.10.x, no need to wait till 5.12). If USB-C DisplayPort ever becomes supported and working on pinebook-pro, this patch will need to be removed. live well, vagrant --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-linux-libre-Add-LCD-and-sound-support-for-Pinebo.patch Content-Transfer-Encoding: quoted-printable From=20478b620eb4f52e76bde691262ebc793e4e3fd384 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Mon, 26 Apr 2021 09:27:50 -0700 Subject: [PATCH] gnu: linux-libre: Add LCD and sound support for Pinebook P= ro. * gnu/packages/linux.scm (linux-libre-5.11-source): Add Pinebook Pro lcd patch. (linux-libre-arm64-generic): Enable audio module for Pinebook Pro. * gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch: New fi= le. * gnu/local.mk (dist_patch_DATA): Add patch. =2D-- gnu/local.mk | 1 + gnu/packages/linux.scm | 9 ++++- ...nux-libre-arm64-generic-pinebook-lcd.patch | 40 +++++++++++++++++++ 3 files changed, 48 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/linux-libre-arm64-generic-pinebook= -lcd.patch diff --git a/gnu/local.mk b/gnu/local.mk index e8b6effb36..5a2ae6ef48 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -1369,6 +1369,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/linkchecker-tests-require-network.patch \ %D%/packages/patches/linphone-desktop-without-sdk.patch \ %D%/packages/patches/linux-libre-support-for-Pinebook-Pro.patch \ + %D%/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch \ %D%/packages/patches/linux-pam-no-setfsuid.patch \ %D%/packages/patches/lirc-localstatedir.patch \ %D%/packages/patches/lirc-reproducible-build.patch \ diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 080ffab527..1c6e1502b2 100644 =2D-- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -481,7 +481,10 @@ corresponding UPSTREAM-SOURCE (an origin), using the g= iven DEBLOB-SCRIPTS." (define-public linux-libre-5.11-source (source-with-patches linux-libre-5.11-pristine-source (list %boot-logo-patch =2D %linux-libre-arm-export-__sync_icache_dcach= e-patch))) + %linux-libre-arm-export-__sync_icache_dcache-= patch + ;; Pinebook Pro patch to fix LCD display + (search-patch + "linux-libre-arm64-generic-pinebook-lcd.patc= h")))) =20 (define-public linux-libre-5.10-source (source-with-patches linux-libre-5.10-pristine-source @@ -1044,7 +1047,9 @@ It has been modified to remove all non-free binary bl= obs.") ("CONFIG_BATTERY_AXP20X" . m) ("CONFIG_PINCTRL_AXP209" . m) ("CONFIG_AXP20X_POWER" . m) =2D ("CONFIG_AXP20X_ADC" . m)) + ("CONFIG_AXP20X_ADC" . m) + ;; Pinebook PRO sound support + ("CONFIG_SND_SOC_ES8316" . m)) %default-extra-linux-options))) =20 (define-public linux-libre-arm64-generic-5.10 diff --git a/gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.pa= tch b/gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch new file mode 100644 index 0000000000..51ab544d5e =2D-- /dev/null +++ b/gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch @@ -0,0 +1,40 @@ +From 3a75704e99a118f2d8a4d70f07781558bde85770 Mon Sep 17 00:00:00 2001 +From: Jian-Hong Pan +Date: Thu, 24 Sep 2020 14:30:43 +0800 +Subject: [PATCH] arm64: dts: rockchip: disable USB type-c DisplayPort + +The cdn-dp sub driver probes the device failed on PINEBOOK Pro. + +kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missi= ng extcon or phy +kernel: cdn-dp: probe of fec00000.dp failed with error -22 + +Then, the device halts all of the DRM related device jobs. For example, +the operations: vop_component_ops, vop_component_ops and +rockchip_dp_component_ops cannot be bound to corresponding devices. So, +Xorg cannot find the correct DRM device. + +The USB type-C DisplayPort does not work for now. So, disable the +DisplayPort node until the type-C phy work has been done. + +Link: https://patchwork.kernel.org/patch/11794141/#23639877 +Signed-off-by: Jian-Hong Pan +--- + arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/a= rm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +index 219b7507a10f..45769764425d 100644 +--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts ++++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +@@ -380,7 +380,7 @@ + }; +=20 + &cdn_dp { +- status =3D "okay"; ++ status =3D "disabled"; + }; +=20 + &cpu_b0 { +--=20 +2.30.2 + =2D-=20 2.30.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYIdQNgAKCRDcUY/If5cW qh0lAQCz3curOzxZgqf81U6+0LRWXgNX3FOEqyxUmz4hFa+CHAEAg3Ts7q+BsA84 cpLdh8dHNoerZx8LCvljl4UG+Cn4PQY= =PXWu -----END PGP SIGNATURE----- --==-=-=-- From unknown Sat Jun 21 10:40:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48050: Pinebook Pro LCD and Audio support Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 27 Apr 2021 00:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48050 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 48050@debbugs.gnu.org Received: via spool by 48050-submit@debbugs.gnu.org id=B48050.161948230825508 (code B ref 48050); Tue, 27 Apr 2021 00:12:01 +0000 Received: (at 48050) by debbugs.gnu.org; 27 Apr 2021 00:11:48 +0000 Received: from localhost ([127.0.0.1]:47525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbBKO-0006dM-Hq for submit@debbugs.gnu.org; Mon, 26 Apr 2021 20:11:48 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:55382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbBKL-0006d7-RJ for 48050@debbugs.gnu.org; Mon, 26 Apr 2021 20:11:47 -0400 Received: from localhost (97-120-1-76.ptld.qwest.net [97.120.1.76]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 3E3461AF05 for <48050@debbugs.gnu.org>; Mon, 26 Apr 2021 17:11:39 -0700 (PDT) From: Vagrant Cascadian In-Reply-To: References: <87o8e0mx1m.fsf@yucca> Date: Mon, 26 Apr 2021 17:11:35 -0700 Message-ID: <87lf94mvrc.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Control: reassign 48050 guix-patches Reassigning to guix-patches. Unless this debbugs is all old-school and I have to send to instead control@debbugs.gnu.org ... will know shortly! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYIdWuAAKCRDcUY/If5cW qhtNAPwP/bN1xUs918PJGqvtrr677vsgi1By4z63VBRzGNMOJAEAk7bBwGSPcDre Vf+3miXIdmVz287AXa4Zvlu7329erAg= =8LE/ -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 21 10:40:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48050: Pinebook Pro LCD and Audio support Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 27 Apr 2021 06:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48050 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 48050@debbugs.gnu.org Cc: Leo Famulari Received: via spool by 48050-submit@debbugs.gnu.org id=B48050.16195055326066 (code B ref 48050); Tue, 27 Apr 2021 06:39:01 +0000 Received: (at 48050) by debbugs.gnu.org; 27 Apr 2021 06:38:52 +0000 Received: from localhost ([127.0.0.1]:47846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbHMy-0001Zl-ED for submit@debbugs.gnu.org; Tue, 27 Apr 2021 02:38:52 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:55870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbHMv-0001ZX-3I for 48050@debbugs.gnu.org; Tue, 27 Apr 2021 02:38:51 -0400 Received: from localhost (97-120-1-76.ptld.qwest.net [97.120.1.76]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 67D981AF05; Mon, 26 Apr 2021 23:38:41 -0700 (PDT) From: Vagrant Cascadian In-Reply-To: <87o8e0mx1m.fsf@yucca> References: <87o8e0mx1m.fsf@yucca> Date: Mon, 26 Apr 2021 23:38:16 -0700 Message-ID: <87lf94p6zr.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain On 2021-04-26, Vagrant Cascadian wrote: > The attached patch enables support for LCD display and limited audio > support for pinebook-pro-rk3399. Updated patch which adds battery support too. live well, vagrant --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-linux-libre-Add-LCD-battery-and-sound-support-fo.patch Content-Transfer-Encoding: quoted-printable From=204c2a728e1186367a4bdc5c4416d6d58eee13b0e7 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Mon, 26 Apr 2021 09:27:50 -0700 Subject: [PATCH] gnu: linux-libre: Add LCD, battery and sound support for Pinebook Pro. * gnu/packages/linux.scm (linux-libre-5.11-source): Add Pinebook Pro lcd patch. (linux-libre-arm64-generic): Enable audio and battery modules for Pinebook Pro. * gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch: New fi= le. * gnu/local.mk (dist_patch_DATA): Add patch. =2D-- gnu/local.mk | 1 + gnu/packages/linux.scm | 11 ++++- ...nux-libre-arm64-generic-pinebook-lcd.patch | 40 +++++++++++++++++++ 3 files changed, 50 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/linux-libre-arm64-generic-pinebook= -lcd.patch diff --git a/gnu/local.mk b/gnu/local.mk index e8b6effb36..5a2ae6ef48 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -1369,6 +1369,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/linkchecker-tests-require-network.patch \ %D%/packages/patches/linphone-desktop-without-sdk.patch \ %D%/packages/patches/linux-libre-support-for-Pinebook-Pro.patch \ + %D%/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch \ %D%/packages/patches/linux-pam-no-setfsuid.patch \ %D%/packages/patches/lirc-localstatedir.patch \ %D%/packages/patches/lirc-reproducible-build.patch \ diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 080ffab527..bd79b40ca6 100644 =2D-- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -481,7 +481,10 @@ corresponding UPSTREAM-SOURCE (an origin), using the g= iven DEBLOB-SCRIPTS." (define-public linux-libre-5.11-source (source-with-patches linux-libre-5.11-pristine-source (list %boot-logo-patch =2D %linux-libre-arm-export-__sync_icache_dcach= e-patch))) + %linux-libre-arm-export-__sync_icache_dcache-= patch + ;; Pinebook Pro patch to fix LCD display + (search-patch + "linux-libre-arm64-generic-pinebook-lcd.patc= h")))) =20 (define-public linux-libre-5.10-source (source-with-patches linux-libre-5.10-pristine-source @@ -1044,7 +1047,11 @@ It has been modified to remove all non-free binary b= lobs.") ("CONFIG_BATTERY_AXP20X" . m) ("CONFIG_PINCTRL_AXP209" . m) ("CONFIG_AXP20X_POWER" . m) =2D ("CONFIG_AXP20X_ADC" . m)) + ("CONFIG_AXP20X_ADC" . m) + ;; Pinebook PRO battery and sound support + ("CONFIG_BATTERY_CW2015" . m) + ("CONFIG_CHARGER_GPIO" . m) + ("CONFIG_SND_SOC_ES8316" . m)) %default-extra-linux-options))) =20 (define-public linux-libre-arm64-generic-5.10 diff --git a/gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.pa= tch b/gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch new file mode 100644 index 0000000000..51ab544d5e =2D-- /dev/null +++ b/gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch @@ -0,0 +1,40 @@ +From 3a75704e99a118f2d8a4d70f07781558bde85770 Mon Sep 17 00:00:00 2001 +From: Jian-Hong Pan +Date: Thu, 24 Sep 2020 14:30:43 +0800 +Subject: [PATCH] arm64: dts: rockchip: disable USB type-c DisplayPort + +The cdn-dp sub driver probes the device failed on PINEBOOK Pro. + +kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missi= ng extcon or phy +kernel: cdn-dp: probe of fec00000.dp failed with error -22 + +Then, the device halts all of the DRM related device jobs. For example, +the operations: vop_component_ops, vop_component_ops and +rockchip_dp_component_ops cannot be bound to corresponding devices. So, +Xorg cannot find the correct DRM device. + +The USB type-C DisplayPort does not work for now. So, disable the +DisplayPort node until the type-C phy work has been done. + +Link: https://patchwork.kernel.org/patch/11794141/#23639877 +Signed-off-by: Jian-Hong Pan +--- + arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/a= rm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +index 219b7507a10f..45769764425d 100644 +--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts ++++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +@@ -380,7 +380,7 @@ + }; +=20 + &cdn_dp { +- status =3D "okay"; ++ status =3D "disabled"; + }; +=20 + &cpu_b0 { +--=20 +2.30.2 + =2D-=20 2.30.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYIexWQAKCRDcUY/If5cW qhOuAP0RcXpdMzOkfxLmALLip/liZetks55NEmh4SXlnORQHIwEAt78dTssN9iGZ IKdeStBn1gHlpk6lm8opCs/cAQsboAA= =2EUB -----END PGP SIGNATURE----- --==-=-=-- From unknown Sat Jun 21 10:40:14 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Vagrant Cascadian Subject: bug#48050: closed (Re: bug#48050: Pinebook Pro LCD and Audio support) Message-ID: References: <87h7jowsqa.fsf@yucca> <87o8e0mx1m.fsf@yucca> X-Gnu-PR-Message: they-closed 48050 X-Gnu-PR-Package: guix Reply-To: 48050@debbugs.gnu.org Date: Thu, 29 Apr 2021 23:57:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1619740622-6089-1" This is a multi-part message in MIME format... ------------=_1619740622-6089-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #48050: Pinebook Pro LCD and Audio support which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 48050@debbugs.gnu.org. --=20 48050: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D48050 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1619740622-6089-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 48050-done) by debbugs.gnu.org; 29 Apr 2021 23:56:11 +0000 Received: from localhost ([127.0.0.1]:57108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcGVv-0001Z3-3T for submit@debbugs.gnu.org; Thu, 29 Apr 2021 19:56:11 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:33872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lcGVs-0001Yp-H3 for 48050-done@debbugs.gnu.org; Thu, 29 Apr 2021 19:56:09 -0400 Received: from localhost (97-120-1-76.ptld.qwest.net [97.120.1.76]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 492B41AF65; Thu, 29 Apr 2021 16:56:02 -0700 (PDT) From: Vagrant Cascadian To: 48050-done@debbugs.gnu.org Subject: Re: bug#48050: Pinebook Pro LCD and Audio support In-Reply-To: <87lf94p6zr.fsf@yucca> References: <87o8e0mx1m.fsf@yucca> <87lf94p6zr.fsf@yucca> Date: Thu, 29 Apr 2021 16:55:57 -0700 Message-ID: <87h7jowsqa.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48050-done Cc: Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On 2021-04-26, Vagrant Cascadian wrote: > On 2021-04-26, Vagrant Cascadian wrote: >> The attached patch enables support for LCD display and limited audio >> support for pinebook-pro-rk3399. > > Updated patch which adds battery support too. Fixed in linux-libre@5.11 and linux-libre@5.10, pushed to master. d018a11ee065e0f6bafb33fcc1a130aa7900b5a3 gnu: linux-libre-arm64-generic@5.10: Add eDP panel, audio and battery support for Pinebook Pro. e7fbf10066e3634ec2d284c07afb4fa625d18574 gnu: linux-libre-arm64-generic: Add eDP panel, battery and audio support for Pinebook Pro. live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYItHjgAKCRDcUY/If5cW qh0WAQDzYleRNSL+l+KKEo6v2njeoeEHLxqXnLJ2maGdWlS92wD/SheSTY9A5Nsw AeooIDxLj9gvy+Eepx+BNktEppXnBAk= =9ueH -----END PGP SIGNATURE----- --=-=-=-- ------------=_1619740622-6089-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 26 Apr 2021 23:44:15 +0000 Received: from localhost ([127.0.0.1]:47484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbAti-0003oX-KW for submit@debbugs.gnu.org; Mon, 26 Apr 2021 19:44:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:49246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbAte-0003oN-4C for submit@debbugs.gnu.org; Mon, 26 Apr 2021 19:44:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbAtd-0005JO-OU for bug-guix@gnu.org; Mon, 26 Apr 2021 19:44:09 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:33628) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbAtV-00028g-HN for bug-guix@gnu.org; Mon, 26 Apr 2021 19:44:09 -0400 Received: from localhost (97-120-1-76.ptld.qwest.net [97.120.1.76]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 9E5D51AF05; Mon, 26 Apr 2021 16:43:53 -0700 (PDT) From: Vagrant Cascadian To: bug-guix@gnu.org Subject: Pinebook Pro LCD and Audio support Date: Mon, 26 Apr 2021 16:43:49 -0700 Message-ID: <87o8e0mx1m.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain The attached patch enables support for LCD display and limited audio support for pinebook-pro-rk3399. With this, the Pinebook Pro gets display output on the built-in LCD. Console works, wayland works (tested with sway), presumably X.org would work as well (untested). Audio output on headphones kind of works. Trackpad is still a little sketchy; might require enabling some more modules. This should basically obsolete the need for the wip-pinebook-pro branch; I haven't noticed any significant functionality difference. I believe the same patches and changes apply and work more-or-less unchanged for linux-libre 5.10 lts series (I tested against Debian's 5.10.x kernel), and it might be worth having an LTS kernel with this enabled. If that's considered desireable, I can update the patch to add that too. Since this will require rebuilding the linux-libre tarball, it is probably best to wait to merge this until the next batch of linux-libre updates (e.g. linux-libre 5.11.x and 5.10.x, no need to wait till 5.12). If USB-C DisplayPort ever becomes supported and working on pinebook-pro, this patch will need to be removed. live well, vagrant --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-linux-libre-Add-LCD-and-sound-support-for-Pinebo.patch Content-Transfer-Encoding: quoted-printable From=20478b620eb4f52e76bde691262ebc793e4e3fd384 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Mon, 26 Apr 2021 09:27:50 -0700 Subject: [PATCH] gnu: linux-libre: Add LCD and sound support for Pinebook P= ro. * gnu/packages/linux.scm (linux-libre-5.11-source): Add Pinebook Pro lcd patch. (linux-libre-arm64-generic): Enable audio module for Pinebook Pro. * gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch: New fi= le. * gnu/local.mk (dist_patch_DATA): Add patch. =2D-- gnu/local.mk | 1 + gnu/packages/linux.scm | 9 ++++- ...nux-libre-arm64-generic-pinebook-lcd.patch | 40 +++++++++++++++++++ 3 files changed, 48 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/linux-libre-arm64-generic-pinebook= -lcd.patch diff --git a/gnu/local.mk b/gnu/local.mk index e8b6effb36..5a2ae6ef48 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -1369,6 +1369,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/linkchecker-tests-require-network.patch \ %D%/packages/patches/linphone-desktop-without-sdk.patch \ %D%/packages/patches/linux-libre-support-for-Pinebook-Pro.patch \ + %D%/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch \ %D%/packages/patches/linux-pam-no-setfsuid.patch \ %D%/packages/patches/lirc-localstatedir.patch \ %D%/packages/patches/lirc-reproducible-build.patch \ diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 080ffab527..1c6e1502b2 100644 =2D-- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -481,7 +481,10 @@ corresponding UPSTREAM-SOURCE (an origin), using the g= iven DEBLOB-SCRIPTS." (define-public linux-libre-5.11-source (source-with-patches linux-libre-5.11-pristine-source (list %boot-logo-patch =2D %linux-libre-arm-export-__sync_icache_dcach= e-patch))) + %linux-libre-arm-export-__sync_icache_dcache-= patch + ;; Pinebook Pro patch to fix LCD display + (search-patch + "linux-libre-arm64-generic-pinebook-lcd.patc= h")))) =20 (define-public linux-libre-5.10-source (source-with-patches linux-libre-5.10-pristine-source @@ -1044,7 +1047,9 @@ It has been modified to remove all non-free binary bl= obs.") ("CONFIG_BATTERY_AXP20X" . m) ("CONFIG_PINCTRL_AXP209" . m) ("CONFIG_AXP20X_POWER" . m) =2D ("CONFIG_AXP20X_ADC" . m)) + ("CONFIG_AXP20X_ADC" . m) + ;; Pinebook PRO sound support + ("CONFIG_SND_SOC_ES8316" . m)) %default-extra-linux-options))) =20 (define-public linux-libre-arm64-generic-5.10 diff --git a/gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.pa= tch b/gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch new file mode 100644 index 0000000000..51ab544d5e =2D-- /dev/null +++ b/gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch @@ -0,0 +1,40 @@ +From 3a75704e99a118f2d8a4d70f07781558bde85770 Mon Sep 17 00:00:00 2001 +From: Jian-Hong Pan +Date: Thu, 24 Sep 2020 14:30:43 +0800 +Subject: [PATCH] arm64: dts: rockchip: disable USB type-c DisplayPort + +The cdn-dp sub driver probes the device failed on PINEBOOK Pro. + +kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missi= ng extcon or phy +kernel: cdn-dp: probe of fec00000.dp failed with error -22 + +Then, the device halts all of the DRM related device jobs. For example, +the operations: vop_component_ops, vop_component_ops and +rockchip_dp_component_ops cannot be bound to corresponding devices. So, +Xorg cannot find the correct DRM device. + +The USB type-C DisplayPort does not work for now. So, disable the +DisplayPort node until the type-C phy work has been done. + +Link: https://patchwork.kernel.org/patch/11794141/#23639877 +Signed-off-by: Jian-Hong Pan +--- + arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/a= rm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +index 219b7507a10f..45769764425d 100644 +--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts ++++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +@@ -380,7 +380,7 @@ + }; +=20 + &cdn_dp { +- status =3D "okay"; ++ status =3D "disabled"; + }; +=20 + &cpu_b0 { +--=20 +2.30.2 + =2D-=20 2.30.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYIdQNgAKCRDcUY/If5cW qh0lAQCz3curOzxZgqf81U6+0LRWXgNX3FOEqyxUmz4hFa+CHAEAg3Ts7q+BsA84 cpLdh8dHNoerZx8LCvljl4UG+Cn4PQY= =PXWu -----END PGP SIGNATURE----- --==-=-=-- ------------=_1619740622-6089-1--