From unknown Thu Jun 19 14:05:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#48043 <48043@debbugs.gnu.org> To: bug#48043 <48043@debbugs.gnu.org> Subject: Status: UTF-8 magic comment is unwelcome with recent Ruby versions Reply-To: bug#48043 <48043@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:05:04 +0000 retitle 48043 UTF-8 magic comment is unwelcome with recent Ruby versions reassign 48043 emacs submitter 48043 Peter Oliver severity 48043 normal tag 48043 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 26 14:28:35 2021 Received: (at submit) by debbugs.gnu.org; 26 Apr 2021 18:28:35 +0000 Received: from localhost ([127.0.0.1]:47126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb5yE-0004O5-Db for submit@debbugs.gnu.org; Mon, 26 Apr 2021 14:28:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:35834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb5yB-0004Nu-JD for submit@debbugs.gnu.org; Mon, 26 Apr 2021 14:28:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lb5yB-0006Pv-27 for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 14:28:31 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:34806) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lb5y7-0001nJ-7d for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 14:28:30 -0400 Received: by mail-wm1-x32f.google.com with SMTP id n3-20020a05600c4f83b02901425630b2c2so1207361wmq.1 for ; Mon, 26 Apr 2021 11:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mavit.org.uk; s=google; h=date:from:to:subject:message-id:mime-version; bh=5fbb2IBkIV649ovCf/Oh2YxoVFazwcBGLpDPzjTMsVg=; b=QwqUtmb4fnPqJeqoR+Sz8Jz7UZV8vk4HMw215WH53Ih/c2hwnYQrX5ZzItV2kva9mx v28PdI8E8uk7GiX1NZF7qqUdwv1XOTaymF/4ncDZikF///VsoYZqEtz2BZ3STgMH9Tju Ve7QgVI6zo7+usPlId4UxS44Hi85/p9LjDbQk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version; bh=5fbb2IBkIV649ovCf/Oh2YxoVFazwcBGLpDPzjTMsVg=; b=MW8odRS33fqwONVNHIgwBUZ2uqQhlbSAOqHHje6YH94EeiXD/wpTA6y4iPxFFtLFDL nrrTUsYppP2uFycxA1XWE12Cl97ni6jQYo/BFyj6xRdnz1SKspEQpK1HsnVDWDwthZNj 6LJyI/gh9VHeCXiWf6LeWw8Ty/dkliprdSAE/fge+jGikAfoUSt1UIGqiHK852b2zPRX w4mnD0rSQSKiGJlWt2/74vFrYtpvrLP77AC0LYo6OovKc8KwvImyvCfkVw3chK6VJGAY K7F4hdVNRHE+DzJsFzWaH+f+aIKwaraaK2umr6oVIhVdQfpPF+Ntf5hoXlJvJ2mEFiw8 0rWA== X-Gm-Message-State: AOAM533VHr3t5DJk94VOmhTl/YQyjO/p175AP1xZDG/+gb4fS+rJ0wk5 2SbfFrRX4K1JuLopB40uYcgcBQcEoR2InA== X-Google-Smtp-Source: ABdhPJwLwapHbH5On5uKsGpF1BGEzyuwoRudr5itvrmVQJJUWH8PnEEZRiKVVGYhGeNtZSq3TEHFbg== X-Received: by 2002:a7b:c450:: with SMTP id l16mr21180025wmi.189.1619461703608; Mon, 26 Apr 2021 11:28:23 -0700 (PDT) Received: from froglet.home.mavit.org.uk (cpc118948-dudl14-2-0-cust32.16-1.cable.virginm.net. [82.37.201.33]) by smtp.gmail.com with ESMTPSA id s10sm1167014wrt.23.2021.04.26.11.28.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 11:28:22 -0700 (PDT) Received: from froglet.home.mavit.org.uk (localhost [127.0.0.1]) by froglet.home.mavit.org.uk (8.15.2/8.15.2) with ESMTPS id 13QISL5H064249 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Mon, 26 Apr 2021 19:28:21 +0100 Received: from localhost (mavit@localhost) by froglet.home.mavit.org.uk (8.15.2/8.15.2/Submit) with ESMTP id 13QISLgM064246 for ; Mon, 26 Apr 2021 19:28:21 +0100 X-Authentication-Warning: froglet.home.mavit.org.uk: mavit owned process doing -bs Date: Mon, 26 Apr 2021 19:28:21 +0100 (BST) From: Peter Oliver To: bug-gnu-emacs@gnu.org Subject: UTF-8 magic comment is unwelcome with recent Ruby versions Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463811583-1687245903-1619461701=:3326" Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=p.d.oliver@mavit.org.uk; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811583-1687245903-1619461701=:3326 Content-Type: text/plain; format=flowed; charset=US-ASCII When saving a ruby-mode buffer, if the content is not plain ASCII, then the default behaviour is to add a specially-formatted comment that indicates the encoding to the Ruby interpreter. E.g., # coding: utf-8 However, since Ruby 2.0 released in 2013, the default encoding for Ruby has been UTF-8. Consequently, users of other editors tend not to include this comment when using UTF-8. When you edit such a file with Emacs, you end up with a messy diff. Two patches are attached to address this: - The first patch adds a new choice to ruby-insert-encoding-magic-comment, unless-utf8, which causes the magic comment not to be inserted if the encoding is UTF-8. - The second patch, perhaps more controversially, makes this the default. -- Peter Oliver ---1463811583-1687245903-1619461701=:3326 Content-Type: text/plain; charset=UTF-8; name=0001-New-choice-for-ruby-insert-encoding-magic-comment-un.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=0001-New-choice-for-ruby-insert-encoding-magic-comment-un.patch RnJvbSBjNzUzZjcyMTZiM2FjZWRiNTcxMTdlN2U4NmFlMTM5ZDlkOWE5Yjk4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogUGV0ZXIgT2xpdmVy IDxnaXRAbWF2aXQub3JnLnVrPg0KRGF0ZTogTW9uLCAyNiBBcHIgMjAyMSAx NzoxNzoyOCArMDEwMA0KU3ViamVjdDogW1BBVENIIDEvMl0gTmV3IGNob2lj ZSBmb3IgcnVieS1pbnNlcnQtZW5jb2RpbmctbWFnaWMtY29tbWVudCwNCiB1 bmxlc3MtdXRmOA0KDQpXaXRoIHRoaXMgc2V0dGluZywgd2hlbiBzYXZpbmcs IGEgY29tbWVudCBkZXNjcmliaW5nIHRoZSBmaWxlIGVuY29kaW5nIHdpbGwN Cm5vdCBiZSBhZGRlZCBpZiBpdCBpcyBVVEYtOC4NCg0KVVRGLTggaXMgdGhl IGRlZmF1bHQgZW5jb2RpbmcgZm9yIFJ1YnkgMi4wIGFuZCBuZXdlci4NCi0t LQ0KIGV0Yy9ORVdTICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg IDQgKysNCiBsaXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUuZWwgICAgICAgICAg ICB8IDE1ICsrKysrKy0NCiB0ZXN0L2xpc3AvcHJvZ21vZGVzL3J1YnktbW9k ZS10ZXN0cy5lbCB8IDU0ICsrKysrKysrKysrKysrKysrKysrKysrKysrDQog MyBmaWxlcyBjaGFuZ2VkLCA3MSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQ0KDQpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUw0KaW5k ZXggOWJmMjMyYWMwMi4uOGMxMzI1Y2IwOSAxMDA2NDQNCi0tLSBhL2V0Yy9O RVdTDQorKysgYi9ldGMvTkVXUw0KQEAgLTUwMSw2ICs1MDEsMTAgQEAgZG9j dW1lbnRlZC4NCiBTTUlFIGlzIG5vdyBhbHdheXMgZW5hYmxlZCBhbmQgJ3J1 YnktdXNlLXNtaWUnIG9ubHkgY29udHJvbHMgd2hldGhlcg0KIGluZGVudGF0 aW9uIGlzIGRvbmUgdXNpbmcgU01JRSBvciB3aXRoIHRoZSBvbGQgYWQtaG9j IGNvZGUuDQogDQorKioqICdydWJ5LWluc2VydC1lbmNvZGluZy1tYWdpYy1j b21tZW50JyBoYXMgYSBuZXcgY2hvaWNlLCAndW5sZXNzLXV0ZjguDQorV2l0 aCB0aGlzIHNldHRpbmcsIHdoZW4gc2F2aW5nLCBhIGNvbW1lbnQgZGVzY3Jp YmluZyB0aGUgZmlsZSBlbmNvZGluZyB3aWxsDQorbm90IGJlIGFkZGVkIGlm IGl0IGlzIFVURi04Lg0KKw0KICoqIEljb21wbGV0ZQ0KIA0KICsrKw0KZGlm ZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS5lbCBiL2xpc3Av cHJvZ21vZGVzL3J1YnktbW9kZS5lbA0KaW5kZXggODRhYzhmZGIyOC4uODIy ZTFlMWMxNCAxMDA2NDQNCi0tLSBhL2xpc3AvcHJvZ21vZGVzL3J1YnktbW9k ZS5lbA0KKysrIGIvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLmVsDQpAQCAt MzA0LDkgKzMwNCwxNyBAQCBydWJ5LWluc2VydC1lbmNvZGluZy1tYWdpYy1j b21tZW50DQogVGhlIGVuY29kaW5nIHdpbGwgYmUgYXV0by1kZXRlY3RlZC4g IFRoZSBmb3JtYXQgb2YgdGhlIGVuY29kaW5nIGNvbW1lbnQNCiBpcyBjdXN0 b21pemFibGUgdmlhIGBydWJ5LWVuY29kaW5nLW1hZ2ljLWNvbW1lbnQtc3R5 bGUnLg0KIA0KK1doZW4gc2V0IHRvIGB1bmxlc3MtdXRmOCcsIGEgY29tbWVu dCB3aWxsIGFsd2F5cyBiZSBhZGRlZCB1bmxlc3MNCit0aGUgZW5jb2Rpbmcg aXMgQVNDSUkgb3IgVVRGLTguDQorDQogV2hlbiBzZXQgdG8gYGFsd2F5cy11 dGY4JyBhbiB1dGYtOCBjb21tZW50IHdpbGwgYWx3YXlzIGJlIGFkZGVkLA0K IGV2ZW4gaWYgaXQncyBub3QgcmVxdWlyZWQuIg0KLSAgOnR5cGUgJ2Jvb2xl YW4gOmdyb3VwICdydWJ5KQ0KKyAgOnR5cGUgJyhjaG9pY2UNCisgICAgICAg ICAgKGNvbnN0IDp0YWcgIk9uIiB0KQ0KKyAgICAgICAgICAoY29uc3QgOnRh ZyAiT24sIGFsd2F5cyBVVEYtOCIgYWx3YXlzLXV0ZjgpDQorICAgICAgICAg IChjb25zdCA6dGFnICJPbiB1bmxlc3MgVVRGLTgiIHVubGVzcy11dGY4KQ0K KyAgICAgICAgICAoY29uc3QgOnRhZyAiT2ZmIiBuaWwpKQ0KKyAgOmdyb3Vw ICdydWJ5KQ0KIA0KIChkZWZjdXN0b20gcnVieS1lbmNvZGluZy1tYWdpYy1j b21tZW50LXN0eWxlICdydWJ5DQogICAiVGhlIHN0eWxlIG9mIHRoZSBtYWdp YyBlbmNvZGluZyBjb21tZW50IHRvIHVzZS4iDQpAQCAtNzg5LDcgKzc5Nywx MCBAQCBydWJ5LW1vZGUtc2V0LWVuY29kaW5nDQogICAgICAgKHdoZW4gKHJ1 YnktLWVuY29kaW5nLWNvbW1lbnQtcmVxdWlyZWQtcCkNCiAgICAgICAgIChn b3RvLWNoYXIgKHBvaW50LW1pbikpDQogICAgICAgICAobGV0ICgoY29kaW5n LXN5c3RlbSAocnVieS0tZGV0ZWN0LWVuY29kaW5nKSkpDQotICAgICAgICAg ICh3aGVuIGNvZGluZy1zeXN0ZW0NCisgICAgICAgICAgKHdoZW4gKGFuZCBj b2Rpbmctc3lzdGVtDQorICAgICAgICAgICAgICAgICAgICAgKGlmIChlcSBy dWJ5LWluc2VydC1lbmNvZGluZy1tYWdpYy1jb21tZW50ICd1bmxlc3MtdXRm OCkNCisgICAgICAgICAgICAgICAgICAgICAgICAgKG5vdCAoc3RyaW5nPSBj b2Rpbmctc3lzdGVtICJ1dGYtOCIpKQ0KKyAgICAgICAgICAgICAgICAgICAg ICAgdCkpDQogICAgICAgICAgICAgKGlmIChsb29raW5nLWF0ICJeIyEiKSAo YmVnaW5uaW5nLW9mLWxpbmUgMikpDQogICAgICAgICAgICAgKGNvbmQgKChs b29raW5nLWF0ICJcXHMgKiMuKlxcKGVuXFwpP2NvZGluZ1xccyAqOlxccyAq XFwoWy1hLXowLTlfXSpcXCkiKQ0KICAgICAgICAgICAgICAgICAgICA7OyB1 cGRhdGUgZXhpc3RpbmcgZW5jb2RpbmcgY29tbWVudCBpZiBuZWNlc3NhcnkN CmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS10 ZXN0cy5lbCBiL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXRlc3Rz LmVsDQppbmRleCA0MmEwMTFjOGJjLi5lYWQ4YTk5ZWI0IDEwMDY0NA0KLS0t IGEvdGVzdC9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUtdGVzdHMuZWwNCisr KyBiL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXRlc3RzLmVsDQpA QCAtMzIsNiArMzIsMTIgQEAgcnVieS13aXRoLXRlbXAtYnVmZmVyDQogICAg ICAocnVieS1tb2RlKQ0KICAgICAgLEBib2R5KSkNCiANCisoZGVmbWFjcm8g cnVieS13aXRoLXRlbXAtZmlsZSAoY29udGVudHMgJnJlc3QgYm9keSkNCisg IGAocnVieS13aXRoLXRlbXAtYnVmZmVyICxjb250ZW50cw0KKyAgICAgKHNl dC12aXNpdGVkLWZpbGUtbmFtZSAicnVieS1tb2RlLXRlc3RzIikNCisgICAg ICxAYm9keQ0KKyAgICAgKGRlbGV0ZS1maWxlIGJ1ZmZlci1maWxlLW5hbWUp KSkNCisNCiAoZGVmdW4gcnVieS1zaG91bGQtaW5kZW50IChjb250ZW50IGNv bHVtbikNCiAgICJBc3NlcnQgaW5kZW50YXRpb24gQ09MVU1OIG9uIHRoZSBs YXN0IGxpbmUgb2YgQ09OVEVOVC4iDQogICAocnVieS13aXRoLXRlbXAtYnVm ZmVyIGNvbnRlbnQNCkBAIC04NDQsNiArODUwLDU0IEBAIHJ1YnktLWluc2Vy dC1jb2RpbmctY29tbWVudC1jdXN0b20tc3R5bGUNCiAgICAgICAocnVieS0t aW5zZXJ0LWNvZGluZy1jb21tZW50ICJ1dGYtOCIpDQogICAgICAgKHNob3Vs ZCAoc3RyaW5nPSAiIyBlbmNvZGluZzogdXRmLThcblxuIiAoYnVmZmVyLXN0 cmluZykpKSkpKQ0KIA0KKyhlcnQtZGVmdGVzdCBydWJ5LS1zZXQtZW5jb2Rp bmctd2hlbi1hc2NpaSAoKQ0KKyAgKHJ1Ynktd2l0aC10ZW1wLWZpbGUgImFz Y2lpIg0KKyAgICAobGV0ICgocnVieS1lbmNvZGluZy1tYWdpYy1jb21tZW50 LXN0eWxlICdydWJ5KQ0KKyAgICAgICAgICAocnVieS1pbnNlcnQtZW5jb2Rp bmctbWFnaWMtY29tbWVudCB0KSkNCisgICAgICAoc2V0cSBzYXZlLWJ1ZmZl ci1jb2Rpbmctc3lzdGVtICd1cy1hc2NpaSkNCisgICAgICAocnVieS1tb2Rl LXNldC1lbmNvZGluZykNCisgICAgICAoc2hvdWxkIChzdHJpbmc9ICJhc2Np aSIgKGJ1ZmZlci1zdHJpbmcpKSkpKSkNCisNCisoZXJ0LWRlZnRlc3QgcnVi eS0tc2V0LWVuY29kaW5nLWFsd2F5cy11dGY4LXdoZW4tYXNjaWkgKCkNCisg IChydWJ5LXdpdGgtdGVtcC1maWxlICJhc2NpaSINCisgICAgKGxldCAoKHJ1 YnktZW5jb2RpbmctbWFnaWMtY29tbWVudC1zdHlsZSAncnVieSkNCisgICAg ICAgICAgKHJ1YnktaW5zZXJ0LWVuY29kaW5nLW1hZ2ljLWNvbW1lbnQgJ2Fs d2F5cy11dGY4KSkNCisgICAgICAoc2V0cSBzYXZlLWJ1ZmZlci1jb2Rpbmct c3lzdGVtICd1cy1hc2NpaSkNCisgICAgICAocnVieS1tb2RlLXNldC1lbmNv ZGluZykNCisgICAgICAoc2hvdWxkIChzdHJpbmc9ICIjIGNvZGluZzogdXRm LThcbmFzY2lpIiAoYnVmZmVyLXN0cmluZykpKSkpKQ0KKw0KKyhlcnQtZGVm dGVzdCBydWJ5LS1zZXQtZW5jb2Rpbmctd2hlbi11dGY4ICgpDQorICAocnVi eS13aXRoLXRlbXAtZmlsZSAi8J+SjiINCisgICAgKGxldCAoKHJ1YnktZW5j b2RpbmctbWFnaWMtY29tbWVudC1zdHlsZSAncnVieSkNCisgICAgICAgICAg KHJ1YnktaW5zZXJ0LWVuY29kaW5nLW1hZ2ljLWNvbW1lbnQgdCkpDQorICAg ICAgKHNldHEgc2F2ZS1idWZmZXItY29kaW5nLXN5c3RlbSAndXRmLTgpDQor ICAgICAgKHJ1YnktbW9kZS1zZXQtZW5jb2RpbmcpDQorICAgICAgKHNob3Vs ZCAoc3RyaW5nPSAiIyBjb2Rpbmc6IHV0Zi04XG7wn5KOIiAoYnVmZmVyLXN0 cmluZykpKSkpKQ0KKw0KKyhlcnQtZGVmdGVzdCBydWJ5LS1zZXQtZW5jb2Rp bmctb2ZmICgpDQorICAocnVieS13aXRoLXRlbXAtZmlsZSAi8J+SjiINCisg ICAgKGxldCAoKHJ1YnktZW5jb2RpbmctbWFnaWMtY29tbWVudC1zdHlsZSAn cnVieSkNCisgICAgICAgICAgKHJ1YnktaW5zZXJ0LWVuY29kaW5nLW1hZ2lj LWNvbW1lbnQgbmlsKSkNCisgICAgICAoc2V0cSBzYXZlLWJ1ZmZlci1jb2Rp bmctc3lzdGVtICd1dGYtOCkNCisgICAgICAocnVieS1tb2RlLXNldC1lbmNv ZGluZykNCisgICAgICAoc2hvdWxkIChzdHJpbmc9ICLwn5KOIiAoYnVmZmVy LXN0cmluZykpKSkpKQ0KKw0KKyhlcnQtZGVmdGVzdCBydWJ5LS1zZXQtZW5j b2RpbmctdW5sZXNzLXV0Zjgtd2hlbi11dGY4ICgpDQorICAocnVieS13aXRo LXRlbXAtZmlsZSAi8J+SjiINCisgICAgKGxldCAoKHJ1YnktZW5jb2Rpbmct bWFnaWMtY29tbWVudC1zdHlsZSAncnVieSkNCisgICAgICAgICAgKHJ1Ynkt aW5zZXJ0LWVuY29kaW5nLW1hZ2ljLWNvbW1lbnQgJ3VubGVzcy11dGY4KSkN CisgICAgICAoc2V0cSBzYXZlLWJ1ZmZlci1jb2Rpbmctc3lzdGVtICd1dGYt OCkNCisgICAgICAocnVieS1tb2RlLXNldC1lbmNvZGluZykNCisgICAgICAo c2hvdWxkIChzdHJpbmc9ICLwn5KOIiAoYnVmZmVyLXN0cmluZykpKSkpKQ0K Kw0KKyhlcnQtZGVmdGVzdCBydWJ5LS1zZXQtZW5jb2RpbmctdW5sZXNzLXV0 Zjgtd2hlbi1sYXRpbi0xNSAoKQ0KKyAgKHJ1Ynktd2l0aC10ZW1wLWZpbGUg IuKThyINCisgICAgKGxldCAoKHJ1YnktZW5jb2RpbmctbWFnaWMtY29tbWVu dC1zdHlsZSAncnVieSkNCisgICAgICAgICAgKHJ1YnktaW5zZXJ0LWVuY29k aW5nLW1hZ2ljLWNvbW1lbnQgJ3VubGVzcy11dGY4KSkNCisgICAgICAoc2V0 cSBzYXZlLWJ1ZmZlci1jb2Rpbmctc3lzdGVtICdpc28tODg1OS0xNSkNCisg ICAgICAocnVieS1tb2RlLXNldC1lbmNvZGluZykNCisgICAgICAoc2hvdWxk IChzdHJpbmc9ICIjIGNvZGluZzogaXNvLTg4NTktMTVcbuKThyIgKGJ1ZmZl ci1zdHJpbmcpKSkpKSkNCisNCiAoZXJ0LWRlZnRlc3QgcnVieS0taW5kZW50 L2NvbnZlcnRlZC1mcm9tLW1hbnVhbC10ZXN0ICgpDQogICA6dGFncyAnKDpl eHBlbnNpdmUtdGVzdCkNCiAgIDs7IENvbnZlcnRlZCBmcm9tIG1hbnVhbCB0 ZXN0Lg0KLS0gDQoyLjI2LjMNCg0K ---1463811583-1687245903-1619461701=:3326 Content-Type: text/plain; charset=UTF-8; name=0002-Default-ruby-insert-encoding-magic-comment-to-unless.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=0002-Default-ruby-insert-encoding-magic-comment-to-unless.patch RnJvbSAwYzgwMzJkYWUyM2QwN2Q1MDg2YmQzZmU4YmI3Y2QzM2FjNjU0YmQ2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogUGV0ZXIgT2xpdmVy IDxnaXRAbWF2aXQub3JnLnVrPg0KRGF0ZTogTW9uLCAyNiBBcHIgMjAyMSAx NzoyNDo1OSArMDEwMA0KU3ViamVjdDogW1BBVENIIDIvMl0gRGVmYXVsdCBy dWJ5LWluc2VydC1lbmNvZGluZy1tYWdpYy1jb21tZW50IHRvDQogJ3VubGVz cy11dGY4DQpNSU1FLVZlcnNpb246IDEuMA0KQ29udGVudC1UeXBlOiB0ZXh0 L3BsYWluOyBjaGFyc2V0PVVURi04DQpDb250ZW50LVRyYW5zZmVyLUVuY29k aW5nOiA4Yml0DQoNCk1vc3QgdXNlcnMgZG9u4oCZdCByZXF1aXJlIGEgbWFn aWMgY29tbWVudCBpZiB0aGVpciBmaWxlcyBhcmUgZW5jb2RlZA0KdXNpbmcg VVRGLTgsIHNpbmNlIHRoYXQgaGFzIGJlZW4gdGhlIGRlZmF1bHQgc2luY2Ug UnVieSAyLjAuDQotLS0NCiBldGMvTkVXUyAgICAgICAgICAgICAgICAgICAg fCA0ICsrKysNCiBsaXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUuZWwgfCA1ICsr Ky0tDQogMiBmaWxlcyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDIgZGVs ZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdT DQppbmRleCA4YzEzMjVjYjA5Li45NjFhM2E3NmIxIDEwMDY0NA0KLS0tIGEv ZXRjL05FV1MNCisrKyBiL2V0Yy9ORVdTDQpAQCAtNTA1LDYgKzUwNSwxMCBA QCBpbmRlbnRhdGlvbiBpcyBkb25lIHVzaW5nIFNNSUUgb3Igd2l0aCB0aGUg b2xkIGFkLWhvYyBjb2RlLg0KIFdpdGggdGhpcyBzZXR0aW5nLCB3aGVuIHNh dmluZywgYSBjb21tZW50IGRlc2NyaWJpbmcgdGhlIGZpbGUgZW5jb2Rpbmcg d2lsbA0KIG5vdCBiZSBhZGRlZCBpZiBpdCBpcyBVVEYtOC4NCiANCisqKiog J3J1YnktaW5zZXJ0LWVuY29kaW5nLW1hZ2ljLWNvbW1lbnQnIGRlZmF1bHRz IHRvICd1bmxlc3MtdXRmOC4NCitNb3N0IHVzZXJzIGRvbuKAmXQgcmVxdWly ZSBhIG1hZ2ljIGNvbW1lbnQgaWYgdGhlaXIgZmlsZXMgYXJlIGVuY29kZWQN Cit1c2luZyBVVEYtOCwgc2luY2UgdGhhdCBoYXMgYmVlbiB0aGUgZGVmYXVs dCBzaW5jZSBSdWJ5IDIuMC4NCisNCiAqKiBJY29tcGxldGUNCiANCiArKysN CmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUuZWwgYi9s aXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUuZWwNCmluZGV4IDgyMmUxZTFjMTQu LjNiMDRkM2Q4M2UgMTAwNjQ0DQotLS0gYS9saXNwL3Byb2dtb2Rlcy9ydWJ5 LW1vZGUuZWwNCisrKyBiL2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS5lbA0K QEAgLTI5OSw3ICsyOTksNyBAQCBydWJ5LWVuY29kaW5nLW1hcA0KIGV4cGxp Y2l0bHkgZGVjbGFyZWQgaW4gbWFnaWMgY29tbWVudC4iDQogICA6dHlwZSAn KHJlcGVhdCAoY29ucyAoc3ltYm9sIDp0YWcgIkZyb20iKSAoc3ltYm9sIDp0 YWcgIlRvIikpKSkNCiANCi0oZGVmY3VzdG9tIHJ1YnktaW5zZXJ0LWVuY29k aW5nLW1hZ2ljLWNvbW1lbnQgdA0KKyhkZWZjdXN0b20gcnVieS1pbnNlcnQt ZW5jb2RpbmctbWFnaWMtY29tbWVudCAndW5sZXNzLXV0ZjgNCiAgICJJbnNl cnQgYSBtYWdpYyBSdWJ5IGVuY29kaW5nIGNvbW1lbnQgdXBvbiBzYXZlIGlm IHRoaXMgaXMgbm9uLW5pbC4NCiBUaGUgZW5jb2Rpbmcgd2lsbCBiZSBhdXRv LWRldGVjdGVkLiAgVGhlIGZvcm1hdCBvZiB0aGUgZW5jb2RpbmcgY29tbWVu dA0KIGlzIGN1c3RvbWl6YWJsZSB2aWEgYHJ1YnktZW5jb2RpbmctbWFnaWMt Y29tbWVudC1zdHlsZScuDQpAQCAtMzE0LDcgKzMxNCw4IEBAIHJ1YnktaW5z ZXJ0LWVuY29kaW5nLW1hZ2ljLWNvbW1lbnQNCiAgICAgICAgICAgKGNvbnN0 IDp0YWcgIk9uLCBhbHdheXMgVVRGLTgiIGFsd2F5cy11dGY4KQ0KICAgICAg ICAgICAoY29uc3QgOnRhZyAiT24gdW5sZXNzIFVURi04IiB1bmxlc3MtdXRm OCkNCiAgICAgICAgICAgKGNvbnN0IDp0YWcgIk9mZiIgbmlsKSkNCi0gIDpn cm91cCAncnVieSkNCisgIDpncm91cCAncnVieQ0KKyAgOnZlcnNpb24gIjI4 LjEiKQ0KIA0KIChkZWZjdXN0b20gcnVieS1lbmNvZGluZy1tYWdpYy1jb21t ZW50LXN0eWxlICdydWJ5DQogICAiVGhlIHN0eWxlIG9mIHRoZSBtYWdpYyBl bmNvZGluZyBjb21tZW50IHRvIHVzZS4iDQotLSANCjIuMjYuMw0KDQo= ---1463811583-1687245903-1619461701=:3326-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 26 17:05:09 2021 Received: (at 48043) by debbugs.gnu.org; 26 Apr 2021 21:05:09 +0000 Received: from localhost ([127.0.0.1]:47363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb8Pk-0006M7-Te for submit@debbugs.gnu.org; Mon, 26 Apr 2021 17:05:09 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:38570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb8Pi-0006LZ-7m for 48043@debbugs.gnu.org; Mon, 26 Apr 2021 17:05:08 -0400 Received: by mail-wr1-f41.google.com with SMTP id k14so7387403wrv.5 for <48043@debbugs.gnu.org>; Mon, 26 Apr 2021 14:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8KqLtbhHFqprb2nKJH2WBYGa1kYmj/YVliQT6oxEDLY=; b=lMnR7nG1BBXgsCO1qxH3Huv7pwEdhFBZjRHgKvO68DZp6GfQhHIuQKo9o+yfE6gkNi DkqCu6Ea5TWeM5nDddqYbPA8FMFi9tkQM9t3MRNWRk8CbzoNl154nH0xqd1ubKqvPjYN 5xzwD9krXzWWSmOO0CwRSxAdyuDiz1kEsbPSwRX+9LlyRa7pItRmtPwJggVOSyIRVsO0 Mh8+FMKFZ4JHc1QEtaaywyURPdZmHpggSfPcIXqMTCyj/SWjSY7E9uEsVQ4fHQ9+p1a2 FWMZMDFCEXEa4mfvnG2MMC/piOfOUk1UGFW+mYrhTIS1j1sTZjRkvx8a6OmKahyhlJl4 SNdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8KqLtbhHFqprb2nKJH2WBYGa1kYmj/YVliQT6oxEDLY=; b=p8K+1SiAfRy7vX/Jh6X6HyjqFhZ6TRuS237cS00PL8SuTOnUkziJojQtrMbbTqRZqa lGTlOw+HWZjrCDZDpyiPmjj/fJqPhh4oZ44q7myD+S1mtqbJ/kkBAuYcqEYfbiMy1ZSf TvyKvru2JeJr7ok1MPuEDHr+1JpNbY16PIZWbwGbGl85DtmWnObQkh/jWa8ZIZXw4IJ3 GvXHqm/r6TC0zu5HxKG0TomS8vt+FwRp5fIIaeQSOdJn2OeT0l5W+pt3gqrL2xgSaMKi XAprm5ww5ByAVk5snL0hnMVPstMcgKTKXk+9LxVIcpsAAUrW9wvEyU5MmoVPtaqIOR2P h2Sw== X-Gm-Message-State: AOAM533M5Qon4l+rRz054PwLcGqO8fXyc5pRc0Ioq/qOg9bgjfzTZflt YwYALHbiOUTGlgO/pn/YbpeyFZ5m9cM= X-Google-Smtp-Source: ABdhPJxw1TG8Fzy6ZuJ4Z0r6j+zBlU1GbzBULnfvKNm8LQamjvCTZyuR6VopDPjcq0tir3oTbURiHw== X-Received: by 2002:adf:efc9:: with SMTP id i9mr25655756wrp.173.1619471100421; Mon, 26 Apr 2021 14:05:00 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id u5sm547279wmg.25.2021.04.26.14.04.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Apr 2021 14:04:59 -0700 (PDT) From: Dmitry Gutov Subject: Re: bug#48043: UTF-8 magic comment is unwelcome with recent Ruby versions To: Peter Oliver , 48043@debbugs.gnu.org References: Message-ID: <5a8e33ff-2ca9-7125-2fac-1874a9f69900@yandex.ru> Date: Tue, 27 Apr 2021 00:04:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 48043 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi! On 26.04.2021 21:28, Peter Oliver wrote: > When saving a ruby-mode buffer, if the content is not plain ASCII, then > the default behaviour is to add a specially-formatted comment that > indicates the encoding to the Ruby interpreter.  E.g., > > # coding: utf-8 > > However, since Ruby 2.0 released in 2013, the default encoding for Ruby > has been UTF-8.  Consequently, users of other editors tend not to > include this comment when using UTF-8.  When you edit such a file with > Emacs, you end up with a messy diff. > > Two patches are attached to address this: > > - The first patch adds a new choice to > ruby-insert-encoding-magic-comment, unless-utf8, which causes the magic > comment not to be inserted if the encoding is UTF-8. > > - The second patch, perhaps more controversially, makes this the default. Both changes make sense to me. However, I've looked at the existing code and found a prior change which intended for this to be more customizable already, yet had a minor bug. Please try out the following patch: diff --git a/lisp/progmodes/ruby-mode.el b/lisp/progmodes/ruby-mode.el index 84ac8fdb28..35772827ce 100644 --- a/lisp/progmodes/ruby-mode.el +++ b/lisp/progmodes/ruby-mode.el @@ -291,6 +291,7 @@ ruby-deep-indent-paren-style (defcustom ruby-encoding-map '((us-ascii . nil) ;; Do not put coding: us-ascii + (utf-8 . nil) ;; Default since Ruby 2.0 (shift-jis . cp932) ;; Emacs charset name of Shift_JIS (shift_jis . cp932) ;; MIME charset name of Shift_JIS (japanese-cp932 . cp932)) ;; Emacs charset name of CP932 @@ -760,7 +761,7 @@ ruby--insert-coding-comment (defun ruby--detect-encoding () (if (eq ruby-insert-encoding-magic-comment 'always-utf8) - "utf-8" + 'utf-8 (let ((coding-system (or save-buffer-coding-system buffer-file-coding-system))) @@ -769,12 +770,11 @@ ruby--detect-encoding (or (coding-system-get coding-system 'mime-charset) (coding-system-change-eol-conversion coding-system nil)))) (if coding-system - (symbol-name - (if ruby-use-encoding-map - (let ((elt (assq coding-system ruby-encoding-map))) - (if elt (cdr elt) coding-system)) - coding-system)) - "ascii-8bit")))) + (if ruby-use-encoding-map + (let ((elt (assq coding-system ruby-encoding-map))) + (if elt (cdr elt) coding-system)) + coding-system) + 'ascii-8bit)))) (defun ruby--encoding-comment-required-p () (or (eq ruby-insert-encoding-magic-comment 'always-utf8) @@ -796,7 +796,7 @@ ruby-mode-set-encoding (unless (string= (match-string 2) coding-system) (goto-char (match-beginning 2)) (delete-region (point) (match-end 2)) - (insert coding-system))) + (insert (symbol-name coding-system)))) ((looking-at "\\s *#.*coding\\s *[:=]")) (t (when ruby-insert-encoding-magic-comment (ruby--insert-coding-comment coding-system)))) From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 27 10:12:28 2021 Received: (at control) by debbugs.gnu.org; 27 Apr 2021 14:12:28 +0000 Received: from localhost ([127.0.0.1]:50431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbORw-0007u4-C7 for submit@debbugs.gnu.org; Tue, 27 Apr 2021 10:12:28 -0400 Received: from mail-pf1-f180.google.com ([209.85.210.180]:36684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbORl-0007tP-28 for control@debbugs.gnu.org; Tue, 27 Apr 2021 10:12:18 -0400 Received: by mail-pf1-f180.google.com with SMTP id c3so22662909pfo.3 for ; Tue, 27 Apr 2021 07:12:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=meUFFueaAjvCQtr0MUqh5pvpnVqNVavfN5wP19wvPoQ=; b=oj2am6wX3gW8KQSLNOYIWTJ5JOWo0SQRDVqVHhNlJiBF8hxusBWG2Jz0Q8DQxiu6TY SV7ARdfcJk8SoC+Bukzb/Cshij4e/GugJ8IDlcPkhXPWxaH+wVeyRCRS4Co5a1si+Rq/ 2n2z9xi02IKZZOstbhktUyIpcydau5Q1ppblsFcsN3VHcBPiBaiJtWQaRD7tfQESFVyx g2Fz+y4bSCsdQG1QybiJhG8KEEM8AyPC5sWM4Gc5PilSQoCXSh27W0yD+WzcAI6zj/vR q3xD3b1q6E+9jQ60rnq+HlOUKYBMp/0lVu6zUuq63GS2GAVogjlU8vtOAoaBf5re2Bo/ t8tQ== X-Gm-Message-State: AOAM532Stcshavg8BGfM0zmwXpodyzx4ym0Xv/4v16qfqhvCSFZQXgKo tCX8B3MGZ/2NQUah+26RVgtQjL59RDTPST0EW2xaz5Ub X-Google-Smtp-Source: ABdhPJyfptV5wRjBRQq/r4z1dVi91kDw9DOJ10DzocM+xcZQYKWUO37FnAEShqHV9HeNVjxI+Yr2teTB67nxAnSgHIM= X-Received: by 2002:a63:942:: with SMTP id 63mr22405947pgj.67.1619532731536; Tue, 27 Apr 2021 07:12:11 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 27 Apr 2021 09:12:11 -0500 From: Stefan Kangas MIME-Version: 1.0 Date: Tue, 27 Apr 2021 09:12:11 -0500 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 48043 + patch thanks Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.210.180 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.210.180 listed in list.dnswl.org] 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 48043 + patch thanks Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.210.180 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.210.180 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders tags 48043 + patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 27 11:29:31 2021 Received: (at 48043) by debbugs.gnu.org; 27 Apr 2021 15:29:31 +0000 Received: from localhost ([127.0.0.1]:50593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbPeV-0005kK-5f for submit@debbugs.gnu.org; Tue, 27 Apr 2021 11:29:31 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:34494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbPeP-0005k1-F2 for 48043@debbugs.gnu.org; Tue, 27 Apr 2021 11:29:29 -0400 Received: by mail-wr1-f41.google.com with SMTP id t18so2325005wry.1 for <48043@debbugs.gnu.org>; Tue, 27 Apr 2021 08:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mavit.org.uk; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=CcsY4YtoVvnhfohuR1LK1TNDkXz11reMSslhdZwAIvc=; b=BUa/XgksIvTNmYGML+jLzQOsvzukMWVFMZlILZXTzr5vj2Ok3HZMs1Qxz6qqr1gCPc m23clnwUDYdb/jJbYVPYJwZrgxsTUcyaAY3PgXVappHyauVBX8P+ckePU1BTI4paVILL PKX2qcMCVUiPp8ciA2l/gHWE0xdeOAvU8MXpI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=CcsY4YtoVvnhfohuR1LK1TNDkXz11reMSslhdZwAIvc=; b=QBKaBlQ3v6D3YfgxUlaHOwDY4cHmXZ9N970GnK4LTCWr+csV209GdTVh+YuHCMsTtw CKJVo0xdII7RpphjnDmsvWFOJnkDvswcx7A4iq/So7uTAQi2X9wuVaZkQlQEBBe12UHU L3RUKbcnJ6ggG7Us0Lkbc9boSidBNGaY6EpAhpwMa/45sRUDgI5erJQXzW0nu0PZx947 P6zeixGrRo+ZK9aBSpeU0iuCyGi4/JOBshOWX0hWHIhjAGpGDqepQ0Fav1fKS9/d7Mx/ 9oj3I031OD8NAaNXYJwmCKQ9RQo3GCncMyciJKb9xzOpHdTVH6gjI8XiJtDT5KXcAJim CT+Q== X-Gm-Message-State: AOAM533YRkcPVsst0gasj6S1/O5bLnoFtA5igxoOAKk1LD792Yjc2SLp T7j7klSE6bQbAoF5JvuSfXEb3A== X-Google-Smtp-Source: ABdhPJzrs1ZXMWtOWaT21zUC4z8G32hv3kgJW1ud+mMw857uF6I2xBw0VGRvk9//RQ8NfI+Uhbv0Ow== X-Received: by 2002:a5d:6548:: with SMTP id z8mr22616388wrv.116.1619537359643; Tue, 27 Apr 2021 08:29:19 -0700 (PDT) Received: from froglet.home.mavit.org.uk (cpc118948-dudl14-2-0-cust32.16-1.cable.virginm.net. [82.37.201.33]) by smtp.gmail.com with ESMTPSA id l14sm4533040wrv.94.2021.04.27.08.29.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 08:29:18 -0700 (PDT) Received: from froglet.home.mavit.org.uk (localhost [127.0.0.1]) by froglet.home.mavit.org.uk (8.15.2/8.15.2) with ESMTPS id 13RFTHVO042760 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 27 Apr 2021 16:29:17 +0100 Received: from localhost (mavit@localhost) by froglet.home.mavit.org.uk (8.15.2/8.15.2/Submit) with ESMTP id 13RFTH02042755; Tue, 27 Apr 2021 16:29:17 +0100 X-Authentication-Warning: froglet.home.mavit.org.uk: mavit owned process doing -bs Date: Tue, 27 Apr 2021 16:29:17 +0100 (BST) From: Peter Oliver To: Dmitry Gutov Subject: Re: bug#48043: UTF-8 magic comment is unwelcome with recent Ruby versions In-Reply-To: <5a8e33ff-2ca9-7125-2fac-1874a9f69900@yandex.ru> Message-ID: References: <5a8e33ff-2ca9-7125-2fac-1874a9f69900@yandex.ru> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463811583-1836946391-1619537357=:3611" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48043 Cc: 48043@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811583-1836946391-1619537357=:3611 Content-Type: text/plain; charset=US-ASCII; format=flowed On Tue, 27 Apr 2021, Dmitry Gutov wrote: > On 26.04.2021 21:28, Peter Oliver wrote: > >> Two patches are attached to address this: >> >> - The first patch adds a new choice to ruby-insert-encoding-magic-comment, >> unless-utf8, which causes the magic comment not to be inserted if the >> encoding is UTF-8. >> >> - The second patch, perhaps more controversially, makes this the default. > > Both changes make sense to me. > > However, I've looked at the existing code and found a prior change which > intended for this to be more customizable already, yet had a minor bug. > > Please try out the following patch: That works for me, and I think is more straightforward than my approach. Thanks. Attached is an additional patch which adapts the tests added in my patch for your patch. -- Peter Oliver ---1463811583-1836946391-1619537357=:3611 Content-Type: text/plain; charset=UTF-8; name=0001-Test-ruby-mode-set-encoding-with-a-few-different-enc.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=0001-Test-ruby-mode-set-encoding-with-a-few-different-enc.patch RnJvbSA2NzVjMDhjZWU4OTk0NDRmMzMxMTNiODA2ZDY3MDliNTY5YzQ0Nzkw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogUGV0ZXIgT2xpdmVy IDxnaXRAbWF2aXQub3JnLnVrPg0KRGF0ZTogVHVlLCAyNyBBcHIgMjAyMSAx NjoyNDo1OCArMDEwMA0KU3ViamVjdDogW1BBVENIXSBUZXN0IHJ1YnktbW9k ZS1zZXQtZW5jb2Rpbmcgd2l0aCBhIGZldyBkaWZmZXJlbnQgZW5jb2Rpbmdz DQpNSU1FLVZlcnNpb246IDEuMA0KQ29udGVudC1UeXBlOiB0ZXh0L3BsYWlu OyBjaGFyc2V0PVVURi04DQpDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4 Yml0DQoNCkZvbGxvd3Mgb24gZnJvbSBEbWl0cnkgR3V0b3bigJlzIHBhdGNo IGluDQpodHRwczovL2RlYmJ1Z3MuZ251Lm9yZy9jZ2kvYnVncmVwb3J0LmNn aT9idWc9NDgwNDMjOC4NCi0tLQ0KIHRlc3QvbGlzcC9wcm9nbW9kZXMvcnVi eS1tb2RlLXRlc3RzLmVsIHwgMzAgKysrKysrKysrKysrKysrKysrKysrKysr KysNCiAxIGZpbGUgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKQ0KDQpkaWZm IC0tZ2l0IGEvdGVzdC9saXNwL3Byb2dtb2Rlcy9ydWJ5LW1vZGUtdGVzdHMu ZWwgYi90ZXN0L2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS10ZXN0cy5lbA0K aW5kZXggNDJhMDExYzhiYy4uZmVjN2Q4NmE5NSAxMDA2NDQNCi0tLSBhL3Rl c3QvbGlzcC9wcm9nbW9kZXMvcnVieS1tb2RlLXRlc3RzLmVsDQorKysgYi90 ZXN0L2xpc3AvcHJvZ21vZGVzL3J1YnktbW9kZS10ZXN0cy5lbA0KQEAgLTMy LDYgKzMyLDEyIEBAIHJ1Ynktd2l0aC10ZW1wLWJ1ZmZlcg0KICAgICAgKHJ1 YnktbW9kZSkNCiAgICAgICxAYm9keSkpDQogDQorKGRlZm1hY3JvIHJ1Ynkt d2l0aC10ZW1wLWZpbGUgKGNvbnRlbnRzICZyZXN0IGJvZHkpDQorICBgKHJ1 Ynktd2l0aC10ZW1wLWJ1ZmZlciAsY29udGVudHMNCisgICAgIChzZXQtdmlz aXRlZC1maWxlLW5hbWUgInJ1YnktbW9kZS10ZXN0cyIpDQorICAgICAsQGJv ZHkNCisgICAgIChkZWxldGUtZmlsZSBidWZmZXItZmlsZS1uYW1lKSkpDQor DQogKGRlZnVuIHJ1Ynktc2hvdWxkLWluZGVudCAoY29udGVudCBjb2x1bW4p DQogICAiQXNzZXJ0IGluZGVudGF0aW9uIENPTFVNTiBvbiB0aGUgbGFzdCBs aW5lIG9mIENPTlRFTlQuIg0KICAgKHJ1Ynktd2l0aC10ZW1wLWJ1ZmZlciBj b250ZW50DQpAQCAtODQ0LDYgKzg1MCwzMCBAQCBydWJ5LS1pbnNlcnQtY29k aW5nLWNvbW1lbnQtY3VzdG9tLXN0eWxlDQogICAgICAgKHJ1YnktLWluc2Vy dC1jb2RpbmctY29tbWVudCAidXRmLTgiKQ0KICAgICAgIChzaG91bGQgKHN0 cmluZz0gIiMgZW5jb2Rpbmc6IHV0Zi04XG5cbiIgKGJ1ZmZlci1zdHJpbmcp KSkpKSkNCiANCisoZXJ0LWRlZnRlc3QgcnVieS0tc2V0LWVuY29kaW5nLXdo ZW4tYXNjaWkgKCkNCisgIChydWJ5LXdpdGgtdGVtcC1maWxlICJhc2NpaSIN CisgICAgKGxldCAoKHJ1YnktZW5jb2RpbmctbWFnaWMtY29tbWVudC1zdHls ZSAncnVieSkNCisgICAgICAgICAgKHJ1YnktaW5zZXJ0LWVuY29kaW5nLW1h Z2ljLWNvbW1lbnQgdCkpDQorICAgICAgKHNldHEgc2F2ZS1idWZmZXItY29k aW5nLXN5c3RlbSAndXMtYXNjaWkpDQorICAgICAgKHJ1YnktbW9kZS1zZXQt ZW5jb2RpbmcpDQorICAgICAgKHNob3VsZCAoc3RyaW5nPSAiYXNjaWkiIChi dWZmZXItc3RyaW5nKSkpKSkpDQorDQorKGVydC1kZWZ0ZXN0IHJ1YnktLXNl dC1lbmNvZGluZy13aGVuLXV0ZjggKCkNCisgIChydWJ5LXdpdGgtdGVtcC1m aWxlICLwn5KOIg0KKyAgICAobGV0ICgocnVieS1lbmNvZGluZy1tYWdpYy1j b21tZW50LXN0eWxlICdydWJ5KQ0KKyAgICAgICAgICAocnVieS1pbnNlcnQt ZW5jb2RpbmctbWFnaWMtY29tbWVudCB0KSkNCisgICAgICAoc2V0cSBzYXZl LWJ1ZmZlci1jb2Rpbmctc3lzdGVtICd1dGYtOCkNCisgICAgICAocnVieS1t b2RlLXNldC1lbmNvZGluZykNCisgICAgICAoc2hvdWxkIChzdHJpbmc9ICLw n5KOIiAoYnVmZmVyLXN0cmluZykpKSkpKQ0KKw0KKyhlcnQtZGVmdGVzdCBy dWJ5LS1zZXQtZW5jb2Rpbmctd2hlbi1sYXRpbi0xNSAoKQ0KKyAgKHJ1Ynkt d2l0aC10ZW1wLWZpbGUgIuKThyINCisgICAgKGxldCAoKHJ1YnktZW5jb2Rp bmctbWFnaWMtY29tbWVudC1zdHlsZSAncnVieSkNCisgICAgICAgICAgKHJ1 YnktaW5zZXJ0LWVuY29kaW5nLW1hZ2ljLWNvbW1lbnQgdCkpDQorICAgICAg KHNldHEgc2F2ZS1idWZmZXItY29kaW5nLXN5c3RlbSAnaXNvLTg4NTktMTUp DQorICAgICAgKHJ1YnktbW9kZS1zZXQtZW5jb2RpbmcpDQorICAgICAgKHNo b3VsZCAoc3RyaW5nPSAiIyBjb2Rpbmc6IGlzby04ODU5LTE1XG7ik4ciIChi dWZmZXItc3RyaW5nKSkpKSkpDQorDQogKGVydC1kZWZ0ZXN0IHJ1YnktLWlu ZGVudC9jb252ZXJ0ZWQtZnJvbS1tYW51YWwtdGVzdCAoKQ0KICAgOnRhZ3Mg Jyg6ZXhwZW5zaXZlLXRlc3QpDQogICA7OyBDb252ZXJ0ZWQgZnJvbSBtYW51 YWwgdGVzdC4NCi0tIA0KMi4yNi4zDQoNCg== ---1463811583-1836946391-1619537357=:3611-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 27 22:24:08 2021 Received: (at 48043-done) by debbugs.gnu.org; 28 Apr 2021 02:24:08 +0000 Received: from localhost ([127.0.0.1]:51371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbZs0-0007DH-2f for submit@debbugs.gnu.org; Tue, 27 Apr 2021 22:24:08 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:56103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbZrw-0007Cg-7W for 48043-done@debbugs.gnu.org; Tue, 27 Apr 2021 22:24:06 -0400 Received: by mail-wm1-f43.google.com with SMTP id n127so20990583wmb.5 for <48043-done@debbugs.gnu.org>; Tue, 27 Apr 2021 19:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uFx05NxGoci0csCYLw/IvxOoIN6AmBWVgNMXQfYBnWY=; b=O5DdTiel6rVp+tqjCbaKRB3olGNIxFcmuJUHRfjyKJeYWu7A9Dr/reoy/5sr0kLd9J 2EvWinlWLMc3UpVAOoW7FAUwjHvni21eukLh9qG4vjQy7bgOeDfPId2ck5+csAGpWWuO AGmq8ddcVggFuhUHXWla9xzvf+etuSR5h+oNW0fWSdtiGL+VBgH2hwGN4umgWFod+zfL KKCQ/9DnuYB+E85WQrcUHzSnjIWjONTE2S2xIOOItfu+tpbZCqHLjs5P4kmiLD9cYqEA qK5f4UGXBhEdF9P6h4bD078zyoJuLy4kwiKKuuqW5YsDB9u0gyvojPxz9nBNfDjOnE0O QQFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uFx05NxGoci0csCYLw/IvxOoIN6AmBWVgNMXQfYBnWY=; b=PASdVKaX7ueZWVX5FjcSRauxeA6bEy/wWT8YcTRyqfQ5TeCqq7/lHf/4mMGUjB3CYZ tGl4FQPMg+M3PglpXlNUyeSrZaOuStjnJSIsezFZYFVlVTTse1faPwq73dPB91B6835C sjpTlw8rHPE5Obep4+s5yJFeDuwSGuRBGL9OkAwsNvxgznshlIVA8MeAHzAKhlQY07t1 xxzpym+8Tt+2lD7f9ZbZhMMgIAwCI46ck4a8JdEocRo2GNQKqK+ENtq4/u0Lp4efWba6 JXvo0H7MkBvczO00dX8RESozDTbFPhCQPVrcIdfp1uFghI5yJjN1YjYYoHLOwOvOScX6 29lw== X-Gm-Message-State: AOAM533zk9Py+SbjkVoT2pSiEq0rR8RX3efep82vKMjGdSegy8uSf9gf 5yWGNQaORTNX59ZEmJnp02R2WWi5Cbw= X-Google-Smtp-Source: ABdhPJxNuEVuIGrSNIKzVG08HmoPUjDOPka5J6Pbo1qusSoJNumyMvOg6kf5e7WdEgo5pSAhc3gggQ== X-Received: by 2002:a1c:b783:: with SMTP id h125mr1463103wmf.182.1619576638367; Tue, 27 Apr 2021 19:23:58 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id q20sm6286500wmq.2.2021.04.27.19.23.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Apr 2021 19:23:57 -0700 (PDT) Subject: Re: bug#48043: UTF-8 magic comment is unwelcome with recent Ruby versions To: Peter Oliver References: <5a8e33ff-2ca9-7125-2fac-1874a9f69900@yandex.ru> From: Dmitry Gutov Message-ID: Date: Wed, 28 Apr 2021 05:23:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 48043-done Cc: 48043-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Version: 28.1 On 27.04.2021 18:29, Peter Oliver wrote: > That works for me, and I think is more straightforward than my > approach.  Thanks. > > Attached is an additional patch which adapts the tests added in my patch > for your patch. Thanks! I've pushed the change and the tests to master. Please note that since (AFAICT) you don't have FSF copyright assignment on file this exhausts the allowed limit for code contributions to Emacs. Would you like us to send you the assignment form, so that the next patch could be accepted without reservation? From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 28 07:59:44 2021 Received: (at 48043-done) by debbugs.gnu.org; 28 Apr 2021 11:59:44 +0000 Received: from localhost ([127.0.0.1]:51928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbir2-0005ga-FT for submit@debbugs.gnu.org; Wed, 28 Apr 2021 07:59:44 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:34588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbiqy-0005gM-Ex for 48043-done@debbugs.gnu.org; Wed, 28 Apr 2021 07:59:42 -0400 Received: by mail-wm1-f51.google.com with SMTP id n3-20020a05600c4f83b02901425630b2c2so2452109wmq.1 for <48043-done@debbugs.gnu.org>; Wed, 28 Apr 2021 04:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mavit.org.uk; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=454VcyQgpXtoqxBBH/1NIJCXryFrtNkFOVaH2ZGQvxU=; b=Tyrw1cpDAB2mfnI9dlNPo/uyMOMBlhH9MjLKRJGyfsW6c+f235iWUWS9JAyo2qu6Dd SsiyUHAEz54Xj3EN7tGoy3VHFU8pkQVsDTmB90FF7KeUFO0RfZhSKPcWJmHQNv5Rnxdq tafAOnzAXDPRKULpHRecWhJ817fyu2tffgxJs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=454VcyQgpXtoqxBBH/1NIJCXryFrtNkFOVaH2ZGQvxU=; b=YkCLQZEk057x6jcweslCTq78Q9SfIe4NiFSnIBKhJJBTokxK0/w5fBawpthpeD05wr YZxy4iK8LOcY2e5jYiz+zi9ai+I9hBdFLooOCuuGTe44Sef2LZp8aJlJ25coKz36b9Pl bu5grkg8aCB3jrePI3v3EVlK1dxIARykUQ1r5zNsO9IQsIgYOE+9Pz3B+n+q9Ku8FrS/ 0X39FyCbq3XuGeEwyF5jU7fk/OuTnmg9u6bbrGYVK0Rpw/rdc3uMS2v1W30+lPtAPfDt YzGyW4hFhmUAkg8Z6qevYZopMBk+F0IrzNqNMSuDOAArzEy9SR5EoPzjLD1UpN95AZye ga6w== X-Gm-Message-State: AOAM533cvadIaZGlWXRfjs2z7hvArrK4hMd3GaCwNMOsATKQrxUi1FDe LICQQXGcDPfCKywikYl9EpVzJw== X-Google-Smtp-Source: ABdhPJyLQBV8oqVzV5IoRw7+izHp0I2CJEwfWcjqJSE7VgtZT/mi3swZ/UVw0qLGS9caJemyuvkrFg== X-Received: by 2002:a7b:cb4a:: with SMTP id v10mr30719860wmj.53.1619611174476; Wed, 28 Apr 2021 04:59:34 -0700 (PDT) Received: from froglet.home.mavit.org.uk (cpc118948-dudl14-2-0-cust32.16-1.cable.virginm.net. [82.37.201.33]) by smtp.gmail.com with ESMTPSA id q19sm6122066wmc.44.2021.04.28.04.59.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 04:59:33 -0700 (PDT) Received: from froglet.home.mavit.org.uk (localhost [127.0.0.1]) by froglet.home.mavit.org.uk (8.15.2/8.15.2) with ESMTPS id 13SBxWXI011126 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 28 Apr 2021 12:59:32 +0100 Received: from localhost (mavit@localhost) by froglet.home.mavit.org.uk (8.15.2/8.15.2/Submit) with ESMTP id 13SBxWOR011123; Wed, 28 Apr 2021 12:59:32 +0100 X-Authentication-Warning: froglet.home.mavit.org.uk: mavit owned process doing -bs Date: Wed, 28 Apr 2021 12:59:32 +0100 (BST) From: Peter Oliver To: Dmitry Gutov Subject: Re: bug#48043: UTF-8 magic comment is unwelcome with recent Ruby versions In-Reply-To: Message-ID: References: <5a8e33ff-2ca9-7125-2fac-1874a9f69900@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48043-done Cc: 48043-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 28 Apr 2021, Dmitry Gutov wrote: > Please note that since (AFAICT) you don't have FSF copyright assignment on > file this exhausts the allowed limit for code contributions to Emacs. > > Would you like us to send you the assignment form, so that the next patch > could be accepted without reservation? Yes please. -- Peter Oliver From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 28 08:29:18 2021 Received: (at 48043-done) by debbugs.gnu.org; 28 Apr 2021 12:29:18 +0000 Received: from localhost ([127.0.0.1]:51970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbjJe-0006P2-Em for submit@debbugs.gnu.org; Wed, 28 Apr 2021 08:29:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbjJd-0006Oq-MQ for 48043-done@debbugs.gnu.org; Wed, 28 Apr 2021 08:29:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42379) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbjJX-0005T8-8w; Wed, 28 Apr 2021 08:29:12 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3269 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lbjJV-0001yl-Oi; Wed, 28 Apr 2021 08:29:10 -0400 Date: Wed, 28 Apr 2021 15:28:57 +0300 Message-Id: <83zgxifv92.fsf@gnu.org> From: Eli Zaretskii To: Peter Oliver In-Reply-To: (message from Peter Oliver on Wed, 28 Apr 2021 12:59:32 +0100 (BST)) Subject: Re: bug#48043: UTF-8 magic comment is unwelcome with recent Ruby versions References: <5a8e33ff-2ca9-7125-2fac-1874a9f69900@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48043-done Cc: 48043-done@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 28 Apr 2021 12:59:32 +0100 (BST) > From: Peter Oliver > Cc: 48043-done@debbugs.gnu.org > > > Would you like us to send you the assignment form, so that the next patch > > could be accepted without reservation? > > Yes please. Thanks, form sent off-list. From unknown Thu Jun 19 14:05:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 27 May 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator