Subject: Re: bug#4804: 23.1; bookmark-bmenu-bookmark performances

From: Stefan Kangas <[email-masked]>
Date: Sun, 30 Jun 2019 03:09:45 +0200

tags 4804 fixed
close 4804 23.2
quit

Stefan Monnier <[email-masked]> writes:
>> 1) run a loop on all menu list to toggle filenames visibility.
>> 2) come back to the original place and get bookmark name with
>> buffer-substring
>> 3) run again a loop to toggle filenames visibility back.
>> That's very costly.
>
> Agreed, it's costly, brittle, and ugly.
>
> But your solution relies on a correspondance between
> bookmark-latest-sorted-alist and the buffer's content, even though this
> correspondance is nowhere enforced (i.e. future changes to the code are
> likely to break it, or manual buffer modifications could also break it).
>
> Much easier and more robust would be to put the relevant data directly
> in the buffer in the form of text-properties, so it can be extracted
> directly via get-text-property regardless of whether the filenames
> are hidden.
>
>
>         Stefan

This was subsequently implemented by Stefan Monnier:

fc9d6ad645ab0332811bcd7b79341f68ddd958e8
2009-11-21 06:43:45 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=fc9d6ad645ab0332811bcd7b79341f68ddd958e8

I'm therefore closing this bug report.

Thanks,
Stefan Kangas