Subject: Re: bug#48037: 28.0.50; add-change-log-entry does not detect name with digit

From: Lars Ingebrigtsen <[email-masked]>
Date: Tue, 27 Apr 2021 09:34:17 +0200

Michael Albinus <[email-masked]> writes:

>>>  (defcustom add-log-current-defun-header-regexp
>>> -  "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]"
>>> +  "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]+\\)[ \t]*[:=]"
>>>    "Heuristic regexp used by `add-log-current-defun' for unknown major modes.

[...]

> Yes. However, the existing regexp hits also entries like
>
> -:
>   stage: slow
>
> Looks also strange. So my proposal won't get worse. Remember,
> add-log-current-defun-header-regexp is just a heuristic.

Sure, but why not improve the regexp at the same time?  That is,
require at least one [:alpha:] for an identifier -- I think that's
pretty reasonable as heuristics go.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no