From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 26 11:49:44 2021 Received: (at submit) by debbugs.gnu.org; 26 Apr 2021 15:49:45 +0000 Received: from localhost ([127.0.0.1]:46832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb3UW-0006Ze-75 for submit@debbugs.gnu.org; Mon, 26 Apr 2021 11:49:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:41922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb3UR-0006ZU-85 for submit@debbugs.gnu.org; Mon, 26 Apr 2021 11:49:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lb3UQ-0001wJ-VU for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 11:49:38 -0400 Received: from mout.gmx.net ([212.227.15.18]:54291) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lb3UO-0007vk-30 for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 11:49:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619452169; bh=7n/sQgYhzNPJpGHS4kruAzS12N9VN+fZAXPIomMxr5U=; h=X-UI-Sender-Class:From:To:Subject:Date; b=DqxKuwG1ziOFF6tl/aXIzIztHdoFdLqUqsM4D4VjqcmxlwddQ8FGupjLk9hZwUo+Q cOebl/VHroUO1q620yHNptwRRfbmtvWZ8QvByYB47JCsZAV/f82DRrpvy6qZ8PsrGL We3pcEexVNffZ9UO45WfhIEg9ToxMxUjsQmiKZz8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.54.40]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N8ob6-1lUn1T0WhC-015tnw for ; Mon, 26 Apr 2021 17:49:29 +0200 From: Michael Albinus To: bug-gnu-emacs@gnu.org Subject: 28.0.50; add-change-log-entry does not detect name with digit Date: Mon, 26 Apr 2021 17:49:28 +0200 Message-ID: <87mttlkpvb.fsf@gmx.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:4KopxEU/bZxo+QusGGIGQbUdl8z367F3ev0EsMqSoOYGiChL6QY m13G3kMbA5t7j6JaTQ88HkUkaLKnSIe8ObxVKrXYNQB8QXP4yDb8OY5OKJ6bAUspkcMGM5l qxzgwwFyZW44pODPfBfP1nvoDGB/+HQdZu5vpevx1gR0QFhvrQgLozGtJ/q2rvloOpL8WhZ AjA3B6Vuhztwdg6prIl5Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:AQYzYyuI9g8=:aqvCNV83BBGCqBETmXZPYY /BoXuslxB6DGz9Gsc2Va95bnGpnjMK0uvKwt51XO3Wgi9ibQlUumwlqtBfw0kCnc6aoNbdbuV KaY21OeDxw9YyFt5v6R/Hj9Jtw/NU+grQWDblXg8Yj8F7ikMjNSpF+gH9O1PBKhZlwfXEJPOd IFKXlr7KAhNnl3454W/Vi/OYHrd/3Kx1fF5P7jhkGuE33xpUBXK1D9+AbrpdnImYMrYgKQwOZ Cf1BWVgBeNeVHBJKfNb+FxkbK1E3WHGin2NVT6Mgr6133wVMLh4u1ot1xgLbHNKmmqQtRQ9v0 bxWpkXaUnt2ef4xjiSMNCtZTgENsmO+WbYkjDHQ0coeK1Pm+c8HvSjAzcn9Du7F1z4jh0XeUw S5BswiB2HUJUkAUWiwLlJMlom639bO7tt9Opchicg1LycMoGHDN0VIROVhvXZHCpPdj/E9zx8 kmgw3fc2LQYUR5LKlrpnEBJBDyRCQRDVyMmi70JkvICrdWlLdxsCZKiO65JlyNEM/VUZuDRRa UHLo/vP4YAXPN+A0Ye3Tqrk4P8n6HBRwms4p45sfQy+b3gK4V6jsn7zoFHc8OiVTUynqj/1SO 0jsUPAHmd7KV3+ImbHcjSx9ASEy/LRBJ2PuFy/N3KV+wOxWqsWfLj2ONvJV9oIRuimf/mrPL2 l0OGFYXsP2F5mMkhWoTlKUx8vUXt+A2cSXoI3H7jgjdz3fqcdIZIHXzCcbKP/yfCTjZi/WuIp hjuCADRRWsLgDgirmPHNLZwoboTHmQOWUXoP1P1CCiPgTYn87HYXThQqxp/anbw+vDvqKCs5G jlbD/INDfDnctVvAoLSgT/sCwDtHRcAANRZKRCRsUHsRJMoJmQEiBQaCHZQOnzK/UVC7GXYlr s4saEzCCewwjBk00rYJ94z7TOkJuuRYFNe0pLoWisH42X9Y8CuVE0s4YXwuOjQedCRqyH9zup GWlgOAeL49js/qVl5Fy3wYWc+iYcEsF8ilj9l3OMgRaiszgHVkc0XiZlr6wGIS6owadWAyzJL LmW0jp1InFBrSbUpvEh2CgHz7wnJ1OxlOfxSNUq26OR6HFhzMLvFZedMffD0mjQuIjU4hKgbo iUuEFkjeMHmgpD53XEjMr7WtMhyspbnAD1jCXanuCJRudSZx3JXWmMBTNrB/X0eM9IY9wevN0 79lJL3KqVtzwNkQnsilB1cR4Oe7/6J1T8vM2I90/cT/m4IGW+xir/y0zRqvTd2qeIJrzb3rZu ihyfAJr/uWRgufYBy Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=212.227.15.18; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) In test/infra/gitlab-ci.yml, there are entries like =2D-8<---------------cut here---------------start------------->8--- build-native-bootstrap-speed2: stage: slow ... =2D-8<---------------cut here---------------end--------------->8--- If I change such an entry, and try to create a ChangeLog entry via 'C-x 4 a', this entry is not recognized due to the digit in its name. I propose the following patch, which improves this: =2D-8<---------------cut here---------------start------------->8--- diff --git a/lisp/vc/add-log.el b/lisp/vc/add-log.el index 6b38806651..d2d4e31d05 100644 =2D-- a/lisp/vc/add-log.el +++ b/lisp/vc/add-log.el @@ -1194,7 +1194,7 @@ change-log-fill-forward-paragraph (forward-paragraph n))) =0C (defcustom add-log-current-defun-header-regexp - "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:= =3D]" + "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]+\\)[ \t]*[:= =3D]" "Heuristic regexp used by `add-log-current-defun' for unknown major mod= es. The regexp's first submatch is placed in the ChangeLog entry, in parentheses." =2D-8<---------------cut here---------------end--------------->8--- Comments? Best regards, Michael. In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.26, = cairo version 1.16.0) of 2021-03-08 built on gandalf Repository revision: 11d3af3c7b9dc5a2910807d311168fb82d962d0d Repository branch: master Windowing system distributor 'Fedora Project', version 11.0.12010000 System Description: Fedora 33 (Workstation Edition) Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8 Major mode: YAML Minor modes in effect: async-bytecomp-package-mode: t global-git-commit-mode: t magit-auto-revert-mode: t auto-revert-mode: t display-time-mode: t shell-dirtrack-mode: t delete-selection-mode: t icomplete-mode: t show-paren-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t auto-fill-function: do-auto-fill transient-mark-mode: t Load-path shadows: ~/lisp/dbus hides /usr/local/share/emacs/28.0.50/lisp/net/dbus /home/albinus/src/tramp/lisp/tramp-sh hides /usr/local/share/emacs/28.0.50= /lisp/net/tramp-sh /home/albinus/src/tramp/lisp/tramp-fuse hides /usr/local/share/emacs/28.0.= 50/lisp/net/tramp-fuse /home/albinus/src/tramp/lisp/tramp-ftp hides /usr/local/share/emacs/28.0.5= 0/lisp/net/tramp-ftp /home/albinus/src/tramp/lisp/tramp hides /usr/local/share/emacs/28.0.50/li= sp/net/tramp /home/albinus/src/tramp/lisp/tramp-cache hides /usr/local/share/emacs/28.0= .50/lisp/net/tramp-cache /home/albinus/src/tramp/lisp/tramp-uu hides /usr/local/share/emacs/28.0.50= /lisp/net/tramp-uu /home/albinus/src/tramp/lisp/tramp-rclone hides /usr/local/share/emacs/28.= 0.50/lisp/net/tramp-rclone /home/albinus/src/tramp/lisp/tramp-integration hides /usr/local/share/emac= s/28.0.50/lisp/net/tramp-integration /home/albinus/src/tramp/lisp/tramp-archive hides /usr/local/share/emacs/28= .0.50/lisp/net/tramp-archive /home/albinus/src/tramp/lisp/tramp-adb hides /usr/local/share/emacs/28.0.5= 0/lisp/net/tramp-adb /home/albinus/src/tramp/lisp/tramp-cmds hides /usr/local/share/emacs/28.0.= 50/lisp/net/tramp-cmds /home/albinus/src/tramp/lisp/tramp-compat hides /usr/local/share/emacs/28.= 0.50/lisp/net/tramp-compat /home/albinus/src/tramp/lisp/tramp-sudoedit hides /usr/local/share/emacs/2= 8.0.50/lisp/net/tramp-sudoedit /home/albinus/src/tramp/lisp/tramp-gvfs hides /usr/local/share/emacs/28.0.= 50/lisp/net/tramp-gvfs /home/albinus/src/tramp/lisp/tramp-loaddefs hides /usr/local/share/emacs/2= 8.0.50/lisp/net/tramp-loaddefs /home/albinus/src/tramp/lisp/tramp-crypt hides /usr/local/share/emacs/28.0= .50/lisp/net/tramp-crypt /home/albinus/src/tramp/lisp/tramp-smb hides /usr/local/share/emacs/28.0.5= 0/lisp/net/tramp-smb /home/albinus/src/tramp/lisp/trampver hides /usr/local/share/emacs/28.0.50= /lisp/net/trampver /home/albinus/src/tramp/lisp/tramp-sshfs hides /usr/local/share/emacs/28.0= .50/lisp/net/tramp-sshfs Features: (emba glab ghub-graphql treepy gsexp ghub let-alist dockerfile-mode sh-script smie executable log-view yaml-mode ediff-ptch gnus-fun gnus-icalendar org-capture org-refile icalendar diary-lib diary-loaddefs shadow emacsbug tramp-theme em-dirs esh-var esh-mode esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util finder loadhist gdb-mi gud shortdoc ediff-vers rng-cmpct rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap sgml-mode nxml-util nxml-enc xmltok helm-for-files helm-comint helm-imenu semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet helm-bookmark helm-external helm-mode helm-elisp helm-files image-dired dired-x ffap helm-buffers helm-tags helm-locate helm-eval edebug helm-occur helm-grep helm-regexp helm-net helm-adaptive helm-info helm-utils helm-types helm-help helm async-bytecomp helm-global-bindings helm-easymenu helm-source helm-multi-match async helm-lib lsp-html lsp-icons lsp-completion lsp-mode lsp-protocol tree-widget spinner markdown-mode lv inline ht f s git-rebase magit-bookmark bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff git-commit log-edit pcvs-util magit-core magit-autorevert magit-margin magit-transient magit-process with-editor server magit-mode magit-git magit-section benchmark magit-utils which-func dash skeleton ibuf-macs find-dired grep ibuf-ext ibuffer ibuffer-loaddefs autorevert tar-mode arc-mode archive-mode autoload lisp-mnt cus-edit cus-start cus-load finder-inf transient vc-dir mailalias misearch multi-isearch shr-color color timezone help-fns radix-tree cl-print nndoc gnus-dup crm debbugs-gnu add-log debbugs soap-client rng-xsd rng-dt rng-util xsd-regexp mule-util tramp-cmds vc-mtn vc-src vc-sccs vc-svn vc-cvs vc-rcs eglot array filenotify jsonrpc ert pp ewoc debug backtrace xref flymake-proc flymake warnings compile pcase project imenu vc-hg vc-bzr cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs vc-git bug-reference ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util dired-aux time-stamp org-element avl-tree generator ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-search eieio-opt speedbar ezimage dframe ol-docview doc-view image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp org-table org-loaddefs find-func cal-menu calendar cal-loaddefs smerge-mode diff diff-mode easy-mmode flow-fill mm-archive eww xdg url-queue thingatpt mm-url url-http url-gw url-auth gnus-gravatar gravatar dns url-cache sort smiley gnus-cite mail-extr gnus-bcklg cl-extra help-mode gnus-async gnus-ml disp-table qp pop3 utf-7 nndraft nnmh nnml gnutls network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-cache gnus-sum shr kinsoku svg dom nnnil smtpmail sendmail gnus-demon nntp gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range message rmc puny rfc822 mml mml-sec epa derived epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums text-property-search mail-utils mm-util mail-prsvr wid-edit edmacro kmacro face-remap ob-shell ob ob-tangle ol org-src ob-ref ob-lob ob-table ob-exp ob-comint ob-core ob-eval org-keys org-compat advice org-macs vc vc-dispatcher cperl-mode rx time tramp-sh docker-tramp kubernetes-tramp tramp-cache lxc-tramp lxd-tramp tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell pcomplete comint ansi-color ring parse-time iso8601 time-date ls-lisp format-spec delsel ido jka-compr icomplete paren dired dired-loaddefs info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 3344516 732943) (symbols 48 68684 8) (strings 32 362188 107586) (string-bytes 1 33629375) (vectors 16 120564) (vector-slots 8 2219605 351489) (floats 8 706 4514) (intervals 56 961009 6868) (buffers 992 146)) From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 27 00:10:04 2021 Received: (at 48037) by debbugs.gnu.org; 27 Apr 2021 04:10:04 +0000 Received: from localhost ([127.0.0.1]:47697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbF2x-00046q-Rj for submit@debbugs.gnu.org; Tue, 27 Apr 2021 00:10:04 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbF2u-00046F-LL for 48037@debbugs.gnu.org; Tue, 27 Apr 2021 00:10:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EwGMp/ql6GX6hxCdPMSvLxHQt6FjjwCutbPLSiHVj1k=; b=hO+Cz8CoCKmCt/6kyxICdn6L3V MD2dGTUXRfAAzeMkzjog53ZX8QpD/yVKUDANEkORq6OhyCoDroymQMLLOaKALPPSSWCwtbODLmGvG J0voEPZXvB907G3MOChjVRd7JrQbklmkTChWpkJQtjpuOYhNsO7PE7MnaE0JJ4IRzYiQ=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbF2l-0007f9-2S; Tue, 27 Apr 2021 06:09:54 +0200 From: Lars Ingebrigtsen To: Michael Albinus Subject: Re: bug#48037: 28.0.50; add-change-log-entry does not detect name with digit References: <87mttlkpvb.fsf@gmx.de> X-Now-Playing: Jerry Harrison's _The Red And The Black_: "Worlds In Collision" Date: Tue, 27 Apr 2021 06:09:50 +0200 In-Reply-To: <87mttlkpvb.fsf@gmx.de> (Michael Albinus's message of "Mon, 26 Apr 2021 17:49:28 +0200") Message-ID: <87k0oo1i7l.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: > (defcustom add-log-current-defun-header-regexp > - "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]" > + "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]+\\)[ \t]*[ [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48037 Cc: 48037@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: > (defcustom add-log-current-defun-header-regexp > - "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]" > + "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]+\\)[ \t]*[:=]" > "Heuristic regexp used by `add-log-current-defun' for unknown major modes. This would also catch stuff like 2: stage: slow which looks like a false positive? So I think there should be some alpha in there. Probably. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 27 03:30:30 2021 Received: (at 48037) by debbugs.gnu.org; 27 Apr 2021 07:30:30 +0000 Received: from localhost ([127.0.0.1]:47933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbIAw-0002yn-3Y for submit@debbugs.gnu.org; Tue, 27 Apr 2021 03:30:30 -0400 Received: from mout.gmx.net ([212.227.17.20]:48825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbIAt-0002yW-6I for 48037@debbugs.gnu.org; Tue, 27 Apr 2021 03:30:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619508621; bh=kxGIBoQQOlsMuRMSo9KYC80EbEbNEJO7Cbq3mIYptIw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=i8TgGiEp6atPhK6e6SFrsgye9UtgIMepMxCKiknWVJxTntSUbjHp9Ur4dheVjVGsv oVe5UmTSw9HMfzTEj2lsIEqeDGxjmwk29GVtyh+HA6ep4QD7+IlIObNIuj7h7GHOZk IhphjLzvI1k+2RPosQrSVANpK6WudV3DOa20d79g= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.54.40]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mt79F-1lLXVN3Ci9-00tTW7; Tue, 27 Apr 2021 09:30:20 +0200 From: Michael Albinus To: Lars Ingebrigtsen Subject: Re: bug#48037: 28.0.50; add-change-log-entry does not detect name with digit References: <87mttlkpvb.fsf@gmx.de> <87k0oo1i7l.fsf@gnus.org> Date: Tue, 27 Apr 2021 09:30:19 +0200 In-Reply-To: <87k0oo1i7l.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 27 Apr 2021 06:09:50 +0200") Message-ID: <874kfskwvo.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:PY7a5QLF7WGnZCt+jYCmzCdn1RJcR3lKXW9f3t38BLYOxmcIbDt Pc+bRdxxpDjCdmU86Db2fc/xYJEWSKLDizNdNLJiPxMvKlofo03P4gD9/yybA8gdzv27tb+ hVSSSbKB3NsS/cTVY1YC0MFRGHUzTEFAGhnlvHPvGIRmNj61+B7+JW995t7T4O8UyDcUC5A GCmavStrXftL7HMB47xkA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:0esXg7+yWjE=:XNKXAl6q4s+dp8kR9Or3Jr qE1taqzpZH6H0VfiHbfQKMBTQTzpYz74W0+yixKje/TFvaAUcCI6afUDuML+UzAbPGesQTH11 Ae5rebUdd0HAhWOzMYQJs57lr+JuILrJ13jsGXDPXnnz8KLF29CpFqd9L2KOETmIRoIbqfbv2 +LLSFdA5iVI6W2MKaUZmtgK1xw770G1u9s65Tl1P4km5OJWYWHoKhNy/yIuuGs1G0TVjxd8as 2XAdRsMrMOmBRlhj2UNoCzYH4XHLDmcLDde/zoPnEMOI6hQq1BdG/4LEJIudA8+P4zhmQ/yWg 4VOCkKIhsb/7qjynNq/Tdy0x6RuxybkFkMZ6xd+rqYAi3VQlNv9+6sgW4i005IStNnV4RUGDm RGwTtmAKKtLjVqQa0We8e+2ReJKTjiB9HhNPznl2xOkwKcMSnIGAfg+CH+R03HvsxNlRuJyK2 SQuj8PQdUasLGcXYyvdgj+0iBEO0tHijyjdA/PfeyXE0sr31CCe9UGrmAfHZ2BgDUAJwkEzA5 1oi829YGnBYaMMzqiavlkTCNF3xUGk8/7tisB5KPX1mjNgOyYJruKV8OXSla/7MDgzdnCCO1S P2SbfZAU5lVQXMtmNSln2NKOyllzww1XBMP1O+pxEja9We6RhWM2ZZ3Sp6hbs+9czERSfRGJ7 TYU3IP2Ds40d8BOo6vydimi9YK1fOuEiyZbTPHtW00+81Cd10tWgb3BfJ8xtQnlHbiBnzqRLu Tz0Tki63PIF/ic4Z7l9LiPF0iPkxiC+HarQNncI/zIwSsAeYm6qP+wLshunDm23ZstMDv2TKw n495cuBSkatg4aBXMffX6aXJGWG/gA5fsNagnyluOxVHB+NVUZBWJ8t2qh45MJ3aZcblBS+g0 mU71M6NPRcuiOCQS9I33864Ch5slSXA4cpqAKIGjXrY5YPnZ6UG1Tu8x6MYVYxWbD06er3y6x tbkhvxVcbJ5XBLGt2IB3x26T/r0H/+K1sXwqYdoJaLvPNJKrjn/WscjNf1MCIxNLuM3Bh6IlP UTFINQopoVbmH29XcC8/DuLSUyMbRKHscace63C3Aqt8O9AD8CT04EOLDutjWTnXc/gc1GbY8 K50bEQmKpk1cCjUEwqikrFZp8hRk0W9QzbyR8IVuWix1fVLRuY0TCpLA8xaKJQByyT2qiioFB 9bKVYuhzpZpalBdpY8CyBizrdzbvBWi0nDTqb4qRTO9DUUZMywyWqGOt/HUBeiwlrgpiivzG9 JLcqN27dJxpVU2V8r X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48037 Cc: 48037@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: Hi Lars, >> (defcustom add-log-current-defun-header-regexp >> - "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]" >> + "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]+\\)[ \t]*[:=]" >> "Heuristic regexp used by `add-log-current-defun' for unknown major modes. > > This would also catch stuff like > > 2: > stage: slow > > which looks like a false positive? So I think there should be some > alpha in there. Probably. Yes. However, the existing regexp hits also entries like -: stage: slow Looks also strange. So my proposal won't get worse. Remember, add-log-current-defun-header-regexp is just a heuristic. Alternatively, I could just give gitlab-ci.yml a file-local value for this variable, and let the lions sleep :-) Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 27 03:34:30 2021 Received: (at 48037) by debbugs.gnu.org; 27 Apr 2021 07:34:30 +0000 Received: from localhost ([127.0.0.1]:47956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbIEo-00036l-I5 for submit@debbugs.gnu.org; Tue, 27 Apr 2021 03:34:30 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbIEm-00036V-MY for 48037@debbugs.gnu.org; Tue, 27 Apr 2021 03:34:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YTVRYvVJOm1F742OUHDmVw2T6Nz8tqBowmCrxWhs8AE=; b=a/EtapUc7hJvEMaDSfYPQBagvX Uktqy41A8kC1p4+VxoIEF5fs/6I6GTkh0KPHAQO1BHjiSxQWtb/O2PhgwE2Kl52pLJQheznMuuCnm 77OeWT47N/CL1xm9e6msWaZT/ORNV5cSKD9V/2ITbfsE5PT9ZxMVwjMIFFXCR7qKZmeM=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbIEc-0001Li-Gj; Tue, 27 Apr 2021 09:34:22 +0200 From: Lars Ingebrigtsen To: Michael Albinus Subject: Re: bug#48037: 28.0.50; add-change-log-entry does not detect name with digit References: <87mttlkpvb.fsf@gmx.de> <87k0oo1i7l.fsf@gnus.org> <874kfskwvo.fsf@gmx.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXb1tmhbGwxKSz/ //+NCYosAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UEGwcgB/Zq8UsAAAGOSURBVCjPZZHBattAEIZH wg40Jxm0psk5l/ophKlyyGnX7BjHpwakIO1TiEJCjmtRQ/DJAclI85SdWSeQpnsQfJrZ+ef/F66+ p61+Qo2YAdSVav0TmgBjsbjl3xrXDPYGrhgMlg3An2rRC7gTwz9nYkEnKo30jAE3qtRYmAcZgHZ6 r9GYBzzDVq9z0wnkdrb2qJabUNlEeLQ4288ZymKKBVrzmDPwVJUYs8pN9kWUIEngbTSRZRhBoW7H HTrerRZ4bv23VfNeubjz87iROwoBnJ8vpZIpzCLy65PYttwG9Eb0ydwEg2gKOsMPeaeTxnmlztBD s/UyEzJw1EV3O6UkN674Ge1CovizNJktz1mjLfqmgigA2JKODjPM/zM3/PBwcWpRdqOhPsI1tSTm 3OCOUDMcgrm6g8O4InkS0q6K6DUOFmi4fuFPTH2Axxqoi0MbTJIU2DhKopgqmwBE76KObgDivT7D IBD2HFm0+wDauN8CVmwvXqvLDpJ4L6+w7X65DtSyl7ZDx4FMzZJ42l//CJuoI21Q4QAAACV0RVh0 ZGF0ZTpjcmVhdGUAMjAyMS0wNC0yN1QwNzozMjowNyswMDowMP7a6YgAAAAldEVYdGRhdGU6bW9k aWZ5ADIwMjEtMDQtMjdUMDc6MzI6MDcrMDA6MDCPh1E0AAAAAElFTkSuQmCC X-Now-Playing: Liquid Liquid's _Successive Reflexes_: "Groupmegroup (Live)" Date: Tue, 27 Apr 2021 09:34:17 +0200 In-Reply-To: <874kfskwvo.fsf@gmx.de> (Michael Albinus's message of "Tue, 27 Apr 2021 09:30:19 +0200") Message-ID: <874kfs18qu.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: >>> (defcustom add-log-current-defun-header-regexp >>> - "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]" >>> + "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]+\\)[ [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48037 Cc: 48037@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: >>> (defcustom add-log-current-defun-header-regexp >>> - "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]" >>> + "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]+\\)[ \t]*[:=]" >>> "Heuristic regexp used by `add-log-current-defun' for unknown major modes. [...] > Yes. However, the existing regexp hits also entries like > > -: > stage: slow > > Looks also strange. So my proposal won't get worse. Remember, > add-log-current-defun-header-regexp is just a heuristic. Sure, but why not improve the regexp at the same time? That is, require at least one [:alpha:] for an identifier -- I think that's pretty reasonable as heuristics go. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 27 03:55:12 2021 Received: (at 48037) by debbugs.gnu.org; 27 Apr 2021 07:55:12 +0000 Received: from localhost ([127.0.0.1]:47986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbIYq-0005ns-2C for submit@debbugs.gnu.org; Tue, 27 Apr 2021 03:55:12 -0400 Received: from mout.gmx.net ([212.227.17.20]:60593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbIYo-0005nK-Ij for 48037@debbugs.gnu.org; Tue, 27 Apr 2021 03:55:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619510104; bh=FQovYtWP9HhmCOLwx3PM2v4BcxNkhpYjlr3xyocoSRw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=I4ARueHt0taKlsZB3OlhZqmoNMPHNtL2TxpcHKMB1g1G7z1WXsA7zH/HxC5NIrdar ZM7AH/bi+TWzSkUN14j7Qh9HhWlxkZKMDk/7acNrDyE5MNPHktMPHEa1semAGx+hUJ aBbNPFrtlDfmhd+LGXTAjNlUOnUBGFjg7g4kzaSU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.54.40]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MCKBm-1lja260hMY-009Rhg; Tue, 27 Apr 2021 09:55:04 +0200 From: Michael Albinus To: Lars Ingebrigtsen Subject: Re: bug#48037: 28.0.50; add-change-log-entry does not detect name with digit References: <87mttlkpvb.fsf@gmx.de> <87k0oo1i7l.fsf@gnus.org> <874kfskwvo.fsf@gmx.de> <874kfs18qu.fsf@gnus.org> Date: Tue, 27 Apr 2021 09:55:03 +0200 In-Reply-To: <874kfs18qu.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 27 Apr 2021 09:34:17 +0200") Message-ID: <87zgxkjh60.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:R+KON83SodhRpUvyu1dYgKngG0yqOZzwtYa6wknnBEloQ42gLN6 9XlKzTpgiwugnXPisQMr7xjQ2aARppC/kNFoToKOg4oi2kDZJUjZonH8qYfXNFefnCjIsJM pxpMmakRO8MQ9r2I1iFAZGk+n0C442JTAy4+utJYQuQAEx7if++ZlwWLBJwdsV+Etk77A5I ECm5SonV3rFncMaQSCXDQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ParNzR0Tc/c=:2ou0NnZDLerwq4M15Mb/t5 kiSjDZV/2YP+hrcYHr12KBuXNgb7dmvUPJ1cC7gmljy4n/HvMl4Mx8Ei+rowbWT112qVw03jL gCCh9RRmAjfGd93hnvIr55WStiQP254/k0YTpmNkQQ/tz0odM9q59wkQudq/HuN7gZYna6Yn0 dEZ6eWqTyulv0kIW4cHLwtfHgQ6jxaI4zbNEhNQ+fKYOhY/y8/2IjhCicy+QkIZk75VXYjN6V vfjPdqxx+d9L1U8SFw+6+QejquGv1aqP0tWMLkr/Ai4VuEPaddZlATV/WMU2BCMQviYHfIHNr aVpPGkz6dhXw+EHmmFgeupaC7rSy7TP8gGZM84mUBAMNKrxUNVv8n0NOqX49NGTpKnc9dwMpH nkAXCGKs+43FSagEOVbcv+FocKpe6TQLNTYOakrF/MAxKBiEXeio9WFS+BJkd6MZTICAwjTB8 HMBjrcMDq/h+9o9uyKEjsps8eEVskffZGav657CIfPaYo3StnlrzUzuONdJbkSJVyAfivgcms DlIhSLljrEIcio4legVkMCOGEJ127X44SARK5KfRhPsb2ejhNb4b9YR/S1kTztV/5njThHAJQ Q0/YFySCqGL2SP0Nw5lTs/ogkfacJW75LBmYEF4ASA5U5JEfLxwnn1POFMnSBY2DhuoO11K78 oZJhYI7yO9oQLgPF/xu4jg0+9FaOihdOzWNWESe/qhltHae/41JU74Ej1XJmenEETKvE7wrYM a3dn4VmuOk/AdNqq5RAPHPo1U8681Iuyklg0NwZ/5K8ebvnFOHzrav8lQCElfWT91QQHvyHJV Fp4KybWo/J8/uFcrxcYz4B2EW8J/fjW+aWqqWooAOV9mwu2ZM9MvuRIzH86XM5wmmUpTnTRb6 LMaH5790J1zcwV9pjWGL2PVj+QgXQTLXAPej+mXFpalntrs9jFeOk1oULyHHsxbxOEwWwjTIw NkHXx1xhKRhyTn3VHFyhl1h3XYSZIGyVPONQLxbll7utd6zwOulpLaJoGG3soD5f7W00Ct1hj benVY3HHhviQFNUyhteKl3uXO5XRYmu2XBXIt+BL8oOJKPvDv7ylc5Ds0D17VcWHmJ+7oTpY7 A264s97aPbfi+M/+9QjbTvXQ9Ox8GHJGbQRlhPU1x3UhmHRVLkROLyk63A+vb5kmcY6RjXF5V 9KL0pVb6l0LULk3hbriMz3UDkevH7DrAKAFxacpNakkFKBJwQFgJsBYY+3zWMxx0q3nNUp5IP NCVucecUUch0reoOJ X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48037 Cc: 48037@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: Hi Lars, > >>>> (defcustom add-log-current-defun-header-regexp >>>> - "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]" >>>> + "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]+\\)[ \t]*[:=]" >>>> "Heuristic regexp used by `add-log-current-defun' for unknown major modes. > > [...] > >> Yes. However, the existing regexp hits also entries like >> >> -: >> stage: slow >> >> Looks also strange. So my proposal won't get worse. Remember, >> add-log-current-defun-header-regexp is just a heuristic. > > Sure, but why not improve the regexp at the same time? That is, > require at least one [:alpha:] for an identifier -- I think that's > pretty reasonable as heuristics go. Wouldn't this be too complex for a simple heuristic? Something like "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]*[[:alpha:]][-_[:alnum:]]*\\)[ \t]*[:=]" Note, that this regexp still doesn't fit all entries in gitlab-ci.yml, for example entries with a dot, like '.job-template:'. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 27 06:31:38 2021 Received: (at 48037-done) by debbugs.gnu.org; 27 Apr 2021 10:31:39 +0000 Received: from localhost ([127.0.0.1]:48133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbL0E-0005oH-OB for submit@debbugs.gnu.org; Tue, 27 Apr 2021 06:31:38 -0400 Received: from mout.gmx.net ([212.227.15.15]:33171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbL0C-0005o3-EL for 48037-done@debbugs.gnu.org; Tue, 27 Apr 2021 06:31:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619519490; bh=dBDXNRK+rCIHbU2iu4blVjtxkQNN4O+6fHKbarHPM9E=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=YJrRrg7AQ6t06G2jzeCcJTHHWYjoAQyChKcoG0PbDcW8BawSOsDtQvu3nv5TE33/8 EreTupOr/fcuDiRpEW18HOtnjVikej2pvOfFJHVdCWpsiUjAHbojSaUnkNOa9QHvKV RiOoFG12QEAtg/pZGislHmKQwadn36HLB0jvUd24= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.54.40]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MlNtP-1lBadr0GYn-00llEy; Tue, 27 Apr 2021 12:31:30 +0200 From: Michael Albinus To: Lars Ingebrigtsen Subject: Re: bug#48037: 28.0.50; add-change-log-entry does not detect name with digit References: <87mttlkpvb.fsf@gmx.de> <87k0oo1i7l.fsf@gnus.org> <874kfskwvo.fsf@gmx.de> <874kfs18qu.fsf@gnus.org> <87zgxkjh60.fsf@gmx.de> Date: Tue, 27 Apr 2021 12:31:28 +0200 In-Reply-To: <87zgxkjh60.fsf@gmx.de> (Michael Albinus's message of "Tue, 27 Apr 2021 09:55:03 +0200") Message-ID: <87v988j9xb.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:PWnYHejxUjZDlcZPl8SM8iye0AldUAUJeKNulDTQ6H0aR5Cdf9z YRupwdmk1PwF05Rfs2ABJNZD1WkPCqbtHe8muwa/hPzRbOcb+iJ0tAs3gxk7RP/VSeYnGUS Ox7nzrICaCI5Df8+q/RMjDJ+dy8f5louLU/Ir8c0v5uuYQl4VhgsBDRJ6myEJvxa0gZ0diJ e5QP9rpvmNawHx87+awlQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:uXjLL7828tE=:yGYKd0wnc9qWRDdlkYrrY5 VuHxvm9DXJm809zP1S9HH2Jbf+0u+qKN3swGAhsF17R9+a4bOAU8rOZzfTq/T2ffmc40ieRWw GpV1V/uugQYI15cwegtqjBebcHVDo475mMz8XDB9BtBJFM0pMG3+Fp1iFE8CblcuiFoyRissb dTfTd1rH4bjJf44Lps/LWMhHbnvVgWx2gsl7/69C1H7KLx0vO5o10+QwgW3JwNEI+61xxJBiQ V2U0bfVMURy8oDKig9EgDuZrV2RLPA/WpsAmNonQWE1E43HunYFDRKuOiIZ1NXsXTror68viF ZHsemGxTqrUnwpsN73NYACxhPP2st3zAsuek8dc04b91bRF3sp1oYm85SXKh9fSMoqsLKFPR3 xdH+sp6/rNkviQkSxhivw8DR/YHmPb73aff6QG+aYSWTpyDppzdCg5ItjHJNHatfzUUANNc1P //ufNtCtDeT/wdCmAgSsg/lhaV5waUJ2LcOiN7vnhkSwAyhYGxp7cSqd3zJcuJSaqOuDwwJ4Q FYy0eUI0YMpGhxWueucXzup7uvie51tOMQ9QElbCoNHQI7S9CwZwdW2V1fB1cyjld65EWmP+J jSpMwZYmRdB8khuUTDaJwXMKwMdtumxIn378HtmOMyElHj02EpIBnb+7X/MH/4TzFWvi75R// TV0mhkiZn+JMmEabxMrLIhqliANDskx8IpEFtp5p4pyz7xZ6b/eEUzL70z1eTg51BeJBrgX6M SjYeSxIvrbiwp0bsImEjqy+fJDsQt83nWHBeja53WoSfFkq4prFkm5Yo8duAmkhy5BC/j9C9Y i9UeUAW/uq9kZb3neQVpe2Zr03Ks7+VIBxgMx75CT55drm9pnUxDUASjPcTQEtkGDJqY3usTm cgc95in3hpIiX0KWvRRCjsGqn6pOMI8+bgcd9EvVOv8T/BRVj3KvblfEut6I/sVbQgr1McVJg QhbK62M3fCstoCddugrPnP2JPWvn0tQgdGoaqn3WlarcOASzusJ/D+CtlMWfcxFIJnRM6679c 2cDYhJ64MojYszCc7dQcS/Jcy78BeN8tW7q+bMGxqjMRedrZrCf+HczEETUFBZbIkOA9cLBID eRSlwgjOzEaXmtSX6dGFaoQ7GJQMB09mHIrv0hxMXTfiQAB4HzfcpnWoPBiIGNx97H55Um4iE dX5nOtDHsz+GA/jykyINf2S76n+Q/+4QQkG+2D0i7+ptfDJL8h7uSkW3nN1RXsnaBOqaulHNB /z+ZnolA3XfTVyta8 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48037-done Cc: 48037-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Note, that this regexp still doesn't fit all entries in gitlab-ci.yml, > for example entries with a dot, like '.job-template:'. I've added add-log-current-defun-header-regexp as file-local variable to gitlab-ci.yml. Closing the bug. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 27 19:18:07 2021 Received: (at 48037) by debbugs.gnu.org; 27 Apr 2021 23:18:07 +0000 Received: from localhost ([127.0.0.1]:51257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbWxz-0002kv-5k for submit@debbugs.gnu.org; Tue, 27 Apr 2021 19:18:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbWxv-0002kP-Vf for 48037@debbugs.gnu.org; Tue, 27 Apr 2021 19:18:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3ZjkwBoAwbblEzaqblf4InYUTHXYGz4tuxZ9zy1A04o=; b=cIbn6v3oL2nfIxw1rnB0sQilZN ne72EBLR8up26/dh1R4zyn7Gith7xG3kmyKzEQYyqeGiqoFt6I+CKWbwXHnKZxbcYqotsfXr8SF0O uqfediwO0VYHCp67T1gXjbpRVtxW+9o1zbNWi6y/1ZzwkJeXMYpfbtGVw+F6EALie0jE=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbWxm-0004Zf-41; Wed, 28 Apr 2021 01:17:57 +0200 From: Lars Ingebrigtsen To: Michael Albinus Subject: Re: bug#48037: 28.0.50; add-change-log-entry does not detect name with digit References: <87mttlkpvb.fsf@gmx.de> <87k0oo1i7l.fsf@gnus.org> <874kfskwvo.fsf@gmx.de> <874kfs18qu.fsf@gnus.org> <87zgxkjh60.fsf@gmx.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUNDA0fHx0vLy5L S0ohIB5AQD9APz3///9zk+3GAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UEGxcRGk8XOVAAAADMSURB VDjLzdJRDoMgDAbgVs2eaXYBKR5AqQdQzA6w+19mqJlOCw9LzLI/MZh+UhAFuDQmXqjLtuwlABet 3C1P9Q5u8hF82UnZ86PdAbdW690/pbIZcDIk6yhSJ6EQeeagT8LN87y6PhLkpajBBBzAoAZwhEAJ QAkGiDQEz4Az0LmTt2lgbxbAM4RlIQ3IzRgHmu0IDddJgOVrxNfQ/x1BJuYwfGTMwVpJneIK25z3 Luj8+L69ASpIQq77LyMizkmngZmDOPt9x+sST+oF+ewRqQv+VL8AAAAldEVYdGRhdGU6Y3JlYXRl ADIwMjEtMDQtMjdUMjM6MTc6MjYrMDA6MDCFGjn/AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTA0 LTI3VDIzOjE3OjI2KzAwOjAw9EeBQwAAAABJRU5ErkJggg== X-Now-Playing: Lori Carson's _Where It Goes_: "Down Here" Date: Wed, 28 Apr 2021 01:17:53 +0200 In-Reply-To: <87zgxkjh60.fsf@gmx.de> (Michael Albinus's message of "Tue, 27 Apr 2021 09:55:03 +0200") Message-ID: <87zgxjz59a.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: > Wouldn't this be too complex for a simple heuristic? Something like > > "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]*[[:alpha:]][-_[:alnum:]]*\\)[ \t]*[:=]" Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48037 Cc: 48037@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: > Wouldn't this be too complex for a simple heuristic? Something like > > "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]*[[:alpha:]][-_[:alnum:]]*\\)[ \t]*[:=]" If I'm reading that right, it looks like an improvement to the heuristics to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 28 04:07:59 2021 Received: (at 48037) by debbugs.gnu.org; 28 Apr 2021 08:08:00 +0000 Received: from localhost ([127.0.0.1]:51631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbfEi-0001gJ-58 for submit@debbugs.gnu.org; Wed, 28 Apr 2021 04:07:59 -0400 Received: from mout.gmx.net ([212.227.15.15]:39949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbfEb-0001fz-OZ for 48037@debbugs.gnu.org; Wed, 28 Apr 2021 04:07:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619597263; bh=QwLTGHUy7RgSBqBF7E4X2tJVs3isGCoxtBSvh2nNI18=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Bb2ARq8h0K9w9VJtBW2v2oXuLKnFOK+0s9Fit2e7011P4xiY1VGiTem72CYO/snOQ SJ2+9EQ8CJVcryCmdNbTkh2QCEQ6vf6ROs5jBFdOAfoJSHq+ES/grUiXfTYzbJ3VNS LnRbDEuYZMak6g78guaHRFb6kqNvcwTjkWxRxjC4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.147.93]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MJmKh-1lqrdG1S3d-00K9yt; Wed, 28 Apr 2021 10:07:43 +0200 From: Michael Albinus To: Lars Ingebrigtsen Subject: Re: bug#48037: 28.0.50; add-change-log-entry does not detect name with digit References: <87mttlkpvb.fsf@gmx.de> <87k0oo1i7l.fsf@gnus.org> <874kfskwvo.fsf@gmx.de> <874kfs18qu.fsf@gnus.org> <87zgxkjh60.fsf@gmx.de> <87zgxjz59a.fsf@gnus.org> Date: Wed, 28 Apr 2021 10:07:42 +0200 In-Reply-To: <87zgxjz59a.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 28 Apr 2021 01:17:53 +0200") Message-ID: <877dkmde7l.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Fr4tqjBkQPaBVDEeaScbq+7A0OJZjckDDkd6KQesGnGh0inHWyT EdRdxu8Gfx208VUmUYFtn1sBw9nRCb53C9POonvA6ytk1Zzf7bSjBuRdSsC5P5HE+gqyvTH plTSFqstA4hWi0Hs8kbZ5f0ReL6W8W5NZV/HQM8CW0o7mvDlBuDLtQrGG2tAcK0ItPoU9hf Xldfvali1cMS1zarc/SoQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:JOb4zE5hT24=:58MYDBfAyVpLeWDGdq8kyK nFK4QfvYyD4it5603UYb9u9eTmBsvGIg+aYGHWp6CrDYX7QSbpzgNHqDA7TUb+KXTIuajvzon qP9lQu/5M3EOlEYLjNrPsigk+vRpdJZpDOSgHXCYqFgn4AAxZMvyKAeN14akelNwByZbXvw4a di7LnBJjdRjw5OkPY8G27gRCc5ELxFUVlJxwwsgPP/W6Ynw6RA+/YDaucIewfPZ6I9S50k4Z8 VP2ewztMv1NdkiEIzD+ACrzwV/7b4GMtEOnwQuOmLwpx8k0Bbh79e6gGWVk3uw42QsVQbB9vQ k2e69nVZ1R+3bgX1sGk1yCrEzIkKc9DI4eSCR6RMfDKNbp+5QvHhIXNP1wNG4XfpvMGdQ1aje maTgUlTED3MGIrNBYWshLycEwAt01I36RyS3UAH6P3A9RggbQnpd3rn/RNlaEgaM3U8hQyOXd RdCycTtvtsKMjE1SKsImhl9wBgn+e5yNk9M8CtemXx4+tTLulbpg+8LcjWDZ7e5qjosMKYBut PUQReVZCa+jxkReJ78I9G1taLbaYrejMFwp+JstzacppaHmd7jECTghxGYrgF2qrD5/9t8lmh VUhqR3mErqmd7wYcSdcXyCrwGoa+rvRlN+rZkCtUVJ8/P+Jpum5RUBogwiU/W7pR2IezEd42K Ms1xj9I+kxaV4GAcFtKrQvD6ClUhXcGWhL/ycDVoIV5DeIQ+Uq7tzyhnGArjkXXx/3zyvdhd4 Gt/w6qHMuGV14C4TAG0ZHqNxgu44ZW4Gn/z+vUctYl5UbELla6TkE1OJVfz5wbFKmgetPbiaf H1C3bO/tyQk5KHbAnoH8oAdNtYMceFCsPxl0APVv8066dTHRqpnrVCKAVe/dakwmrdhEhb/Ko R7zgwjrfrwH12Fi2MS3aYfBqRfUFYLUwdykDpZiEAsz4itkSGTurtGDoHO3VnQpjo1YMu0SfF HlSyxHl2mCZgLvfPFAfvNrR5ZBIlJc5Hz15aN5CodBDxMO0DGMOl3yUb2UAxyE9KD9tiVaErS 3PpPYkk6MzxXwW58SppcDfzSBF5CpQ6VKYSimCab1mbf74wQaviA926dbb605MxVE9tWYMrFX lHNbvff2wepOV0yTbrdA3y0JqppSgRyCWiyZBRCgRU9kSom0oc5Kj/FDqYOleYgs7I2VPt79R IeCreH7pSxT78gu8qlL519WoeSk03OgsgMQATgovLBixF3DIoE8DqKMYLdjbB4xiQwni3vKRB bqgZDkpMrpsqAlm6y X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48037 Cc: 48037@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: >> Wouldn't this be too complex for a simple heuristic? Something like >> >> "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]*[[:alpha:]][-_[:alnum:]]*\\)[ \t]*[:=]" > > If I'm reading that right, it looks like an improvement to the > heuristics to me. OK, so I've pushed this to master. Best regards, Michael. From unknown Tue Jun 17 20:39:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 26 May 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator