From unknown Sun Aug 10 16:51:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#48026 <48026@debbugs.gnu.org> To: bug#48026 <48026@debbugs.gnu.org> Subject: Status: [PATCH] Possible typo in tramp-get-remote-gid Reply-To: bug#48026 <48026@debbugs.gnu.org> Date: Sun, 10 Aug 2025 23:51:22 +0000 retitle 48026 [PATCH] Possible typo in tramp-get-remote-gid reassign 48026 emacs submitter 48026 Dario Gjorgjevski severity 48026 normal tag 48026 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 26 03:10:37 2021 Received: (at submit) by debbugs.gnu.org; 26 Apr 2021 07:10:37 +0000 Received: from localhost ([127.0.0.1]:44316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lavO8-0007Vl-VG for submit@debbugs.gnu.org; Mon, 26 Apr 2021 03:10:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:41124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lavO7-0007Vd-Gl for submit@debbugs.gnu.org; Mon, 26 Apr 2021 03:10:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lavO7-0001jq-C7 for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 03:10:35 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:33433) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lavO3-0007Wm-3j for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 03:10:35 -0400 Received: by mail-wr1-x430.google.com with SMTP id n2so1428821wrm.0 for ; Mon, 26 Apr 2021 00:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=5lW95ZJNrSEvmj0DChs6Eh19IinGRCpgKXdC8Yy4ieY=; b=LE/pww+v5idBJzsDowP+UWUdYk1fe9h37pBBqMGhEWYvtHZJ745DCit7fzOOq5RZFT JunaIOxJEuXj6fzUrASRpXvktFb11FmBIy1BOV6pds+rpc9OHAlid6q4WnLT0XKf8QGU dUPJMSTB45XeMlNsM2XBRZXqWTTlPTyXfs3AGqXAjsC/pPF63jstPKH4tfE2KnFVgn/n RSPUFiohWgjh15mLNVzUnPYNncKPUxnDGMVemQwavfZJFmnPwWEejWnHi0Ai+roy8mfe b2tkwGo5uXwN7EVFW4fM8e03fod3b1oy0UXT/pKf1fNE5IyURhCUrNQ6pjwgb3HpPw/D wcZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=5lW95ZJNrSEvmj0DChs6Eh19IinGRCpgKXdC8Yy4ieY=; b=cHyqP4tEzNa5XPonw1F+C1GciHpFK0TOOeqpaMqRNDLUs/7BswBrPrMRv6RWQ7r1Ek Dw7yH9S8EVb/TfUHiSgJy04k6/3vVfJRC8HhLHmbBha+K3kcpxACQQt0FlHF5Bi3vZDM EA02Vzn3ez2+sKMrMTbWQBoGzdv4FAWAq4N1AXwzocKJaK9aRw/JYgY7H2lsa6kq8DCO RqDksztlNdFr1gbNcgcoBfLvklkn4Ww0/mwEQb2O5OxKirijTk11fbKL6B61hg3IUGOW JHoMaDovXTJWBYY/dVCTTNNjaNaAWPRVi/Gi292IzQyD+SMO4WGpzYfqa1I67zNrhClp 123Q== X-Gm-Message-State: AOAM531ITexW2a8lNyXMrPfatThTIwWzZih1ANFlghlP4hY8d2KXg4XJ 1Ws971TS2fZ9Bl0v8k7jn6Xh0RGQHAjiPA== X-Google-Smtp-Source: ABdhPJzAQ4i2/qc9cvMpEwt+532DY+D7N8+ptmcV/lqASb3BZepNhHfxXhLWWNPcxmXIzFBakO/F9A== X-Received: by 2002:adf:f7d2:: with SMTP id a18mr2521285wrq.198.1619421028626; Mon, 26 Apr 2021 00:10:28 -0700 (PDT) Received: from ZALANDO-31298 (p200300e97702ce0f30e8472eb4351e58.dip0.t-ipconnect.de. [2003:e9:7702:ce0f:30e8:472e:b435:1e58]) by smtp.gmail.com with ESMTPSA id 61sm21226118wrm.52.2021.04.26.00.10.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Apr 2021 00:10:27 -0700 (PDT) From: Dario Gjorgjevski To: bug-gnu-emacs@gnu.org Subject: [PATCH] Possible typo in tramp-get-remote-gid Date: Mon, 26 Apr 2021 09:10:27 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=dario.gjorgjevski@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Hi, I was browsing through TRAMP's source code and noticed a possible typo in tramp-get-remote-gid. Please note that I have almost no familiarity with the code, so it may well not even be a typo. Here is what I am talking about: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-typo-in-tramp-get-remote-gid.patch Content-Description: Fix typo in tramp-get-remote-gid >From 87ed8e1e19fd4ddb0922d907a45569c61598369d Mon Sep 17 00:00:00 2001 From: Dario Gjorgjevski Date: Mon, 26 Apr 2021 09:01:51 +0200 Subject: [PATCH] Fix typo in tramp-get-remote-gid * lisp/net/tramp.el (tramp-get-remote-gid): Pass the correct operation to find-file-name-handler. --- lisp/net/tramp.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el index a411aaf..dc34b8f 100644 --- a/lisp/net/tramp.el +++ b/lisp/net/tramp.el @@ -5080,7 +5080,7 @@ ID-FORMAT valid values are `string' and `integer'." (or (when-let ((handler (find-file-name-handler - (tramp-make-tramp-file-name vec) 'tramp-get-remote-uid))) + (tramp-make-tramp-file-name vec) 'tramp-get-remote-gid))) (funcall handler #'tramp-get-remote-gid vec id-format)) ;; Ensure there is a valid result. (and (equal id-format 'integer) tramp-unknown-id-integer) -- 2.31.GIT --=-=-= Content-Type: text/plain Best regards, Dario -- $ keyserver=hkps://hkps.pool.sks-keyservers.net $ keyid=744A4F0B4F1C9371 $ gpg --keyserver $keyserver --search-keys $keyid --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 26 04:01:01 2021 Received: (at 48026-done) by debbugs.gnu.org; 26 Apr 2021 08:01:01 +0000 Received: from localhost ([127.0.0.1]:44356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lawAv-0000Nk-4h for submit@debbugs.gnu.org; Mon, 26 Apr 2021 04:01:01 -0400 Received: from mout.gmx.net ([212.227.15.15]:36061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lawAt-0000NV-Nd for 48026-done@debbugs.gnu.org; Mon, 26 Apr 2021 04:01:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619424053; bh=iCOtB3hhZ8AJU3RFO09wxH48avS1945VmueJ+VhUWZI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=KIznC4kGRzsTX27WJwKWj2rMcbNWI8xM43auXbGtYlGyxnY/s3/wz7GJ3DhJGi4n4 ms4HS+KK3i1foTClKKGimYY+3iI44a2xWk9UqeuKoN1AtG3aT0vSbrjZy7dJ59htp2 EhMziQW3veE6VdfypXmjCWuyTy9lBo2PDNI8Msf4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.54.40]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MyKDe-1lOu403uKy-00yhrL; Mon, 26 Apr 2021 10:00:53 +0200 From: Michael Albinus To: Dario Gjorgjevski Subject: Re: bug#48026: [PATCH] Possible typo in tramp-get-remote-gid References: Date: Mon, 26 Apr 2021 10:00:50 +0200 In-Reply-To: (Dario Gjorgjevski's message of "Mon, 26 Apr 2021 09:10:27 +0200") Message-ID: <87pmyhlbkd.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:SKJwwbs+s+nyzUCyleSrN5mXCvxoKhc4DJKcU2r1heV4YSwmwfO cTBgDvGjlaimBmUpVQdbKgc3pxSb5jCRtQnxACwAktViK94MEf6Lk4A8veVAZucbPOnyuso U36slwEPfY4oBpfLHacJho/NypJ6hW6fYfL9JOz1okG68vJD/CxOPei8ma63Dbie9k9JBeo vy7SBJPQDas8iVKecy2dQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:7Oit5G2kv/c=:uUsqGmBFvZkJboLmxM34j6 qxH8yrJNQXVG+InSfkql4EwmASqCz4DwmbtOu7cBND1qzlXO43xnP7fRihzCdEiX51VpON0sz jMO6VC+GaGyIgr2ZzccF9fEOIVn+IALEe352pk7s+wVYWkfpTuCTzp0AbubjXMyBQB+7U0syy hNZrc91ZK6vbHj5qBTbA/KCb0gwQjlIWMntW1N6xA5j3FK1qBZgysG9o55U/QcF1DVuvaegHM vH8Qz/oPOd3uj4dTsPE6hckM3dJyatiFp69oAydguDby+0gLWwmxeQZ9wYNImcJqII86AQ5pF zldqtdyMLP4Ew6YwcnwMVvl4xo+IP+lpakCP/D2jWjtHlrro0tdQh+dXiPFl3pDw6a0hyLs4g dGPb4ZKWm8sk4tNdXjDCWZMDs+N2pUdpm559wMtggpQp8wbBGLDPvBJyEh38H7GuJMlqabIZ+ rQB1VfTw90OBtPHoqHRxYI0PHZI6XyPeh0odvyvhspvGHmTeVeFN4ly/FrT+IgYnf60JmaGCB d+NhNaUdDQPsQNzPrWlT74cZewm3PUO7Hm6HOL8FkpJx7Wri7NE2CfnW4tAUku2RR5c5J5HnJ Qr98pusVWxVpEn505XsFqOxUrbMx8OXOBxjFTdzz1IvBssGxKTv87/bsyGkLHAhyQf+j8ZgDV njPlJC9nl79L0aLRoVDOfBPYIR/7MHTF4okTXIto0oo+DJx+V9q6bxzO+z06pYh0bMLuzvhWZ KQWUkFzDtgWBfyZYoEyUUW8cYsbAtEHol/E5YqJLIW1ZYxQ2q9wNzE47rZ+tq5pgGm93SbUcH /AQDPtisimpmby674GB70EMDmEXHwO6Mn+yrAyxhoV6fvTRkiUZ574WmpkQxrN/4FQn9GFaFD p+8Gue7ovZ327XbtpQVOqaN8hT5yDpOLSgCKaI5Koppt8fwi4KDvgfjV5hbyiragamUo62Io6 a7cAAhhb7pQyk74JxXv5hzD+zB7vV+SmmT8d80zS2cX1x5BLCX1Pa9zDGtieaT/vnoTn1r3GS 0aq3UhCLU28GU99Epm00RsVy/JxXnQ50vyUia3qKazxdLCuv1UTQlutInOwrdy/kZ5K16lyVP nk+PdHWkmCOWR6T+g/HKJvVwViD3G01RIaZM8nzp7ErN9rjrlFtSja2YE5U6M4saS6+RzQvjQ FpiB9cx23u22tBg8zmmTRP7IY/ZJZue2iEhJGlD2V9m5uiRA4J3Duhyv3x6TKaDmq9y7oBkL9 S9jxgi79CvGbyqn0a X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48026-done Cc: 48026-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 28.1 Dario Gjorgjevski writes: > Hi, Hi Dario, > I was browsing through TRAMP's source code and noticed a possible typo > in tramp-get-remote-gid. Please note that I have almost no familiarity > with the code, so it may well not even be a typo. It is a typo, indeed. Thanks for reporting! I've pushed your patch to master, closing the bug. > Best regards, > Dario Best regards, Michael. From unknown Sun Aug 10 16:51:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 24 May 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator