GNU bug report logs - #48016
[PATCH] gnu: direnv: Install manpages

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Famulari <leo <at> famulari.name>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#48016: closed ([PATCH] gnu: direnv: Install manpages)
Date: Sun, 25 Apr 2021 17:45:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 25 Apr 2021 13:44:06 -0400
with message-id <YIWqZnDtEq/R/hBO <at> jasmine.lan>
and subject line Re: [bug#48016] [PATCH] gnu: direnv: Install manpages
has caused the debbugs.gnu.org bug report #48016,
regarding [PATCH] gnu: direnv: Install manpages
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
48016: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48016
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dion Mendel <guix <at> dm9.info>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: direnv: Install manpages
Date: Sun, 25 Apr 2021 19:43:08 +0800

[Message part 3 (text/plain, inline)]

Hi guix,

The direnv package has manpages in the source repository, yet none are 
currently installed.  This patch installs the manpages.

The patch was tested by installing and running direnv locally and 
viewing the manpages with man-db.

[0001-gnu-direnv-Install-manpages.patch (text/x-diff, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: Dion Mendel <guix <at> dm9.info>
Cc: 48016-done <at> debbugs.gnu.org
Subject: Re: [bug#48016] [PATCH] gnu: direnv: Install manpages
Date: Sun, 25 Apr 2021 13:44:06 -0400

On Sun, Apr 25, 2021 at 07:43:08PM +0800, Dion Mendel wrote:
> The direnv package has manpages in the source repository, yet none are
> currently installed.  This patch installs the manpages.
> 
> The patch was tested by installing and running direnv locally and viewing
> the manpages with man-db.

Good catch and thanks for the patch!

> From 87fbd9f5d183b1912db186e7c5879566267655b8 Mon Sep 17 00:00:00 2001
> From: Dion Mendel <guix <at> dm9.info>
> Date: Sun, 25 Apr 2021 18:57:21 +0800
> Subject: [PATCH] gnu: direnv: Install manpages
> 
> * gnu/packages/shellutils.scm (direnv): Install manpages.

I tweaked the commit message and added you to the list authors of
'gnu/packages/shellutils.scm' ...

> +         (add-after 'install 'install-manpages
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (man (string-append out "/share/man/man1")))
> +               (mkdir-p man)
> +               (with-directory-excursion "src/github.com/direnv/direnv"
> +                 (install-file "man/direnv.1" man)
> +                 (install-file "man/direnv-stdlib.1" man)
> +                 (install-file "man/direnv.toml.1" man)
> +               )
> +               #t)))

... and I also removed this #t because it will not be necessary soon
enough. I know that you were probably warned to include it, so I'm sorry
about the contradictory advice.

Pushed as 862a88612f903ffe5cca1213ba40010876d19c62

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.