GNU bug report logs - #47992
27; 28; Phase out use of `equal` in `add-hook`, `remove-hook`

Previous Next

Full log

View this message in rfc822 format

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Drew Adams <drew.adams <at> oracle.com>, "47992 <at> debbugs.gnu.org" <47992 <at> debbugs.gnu.org>
Cc: "monnier <at> iro.umontreal.ca" <monnier <at> iro.umontreal.ca>, "jakanakaevangeli <at> chiru.no" <jakanakaevangeli <at> chiru.no>
Subject: bug#47992: [External] : bug#47992: 27; 28; Phase out use of `equal` in `add-hook`, `remove-hook`
Date: Sat, 24 Apr 2021 23:34:52 +0200

On 4/24/21 11:20 PM, Drew Adams wrote:
> Shouldn't your argument be that closure equality should
> _always_ be tested (testable) using just `eq'?  Is this
> really about `add|remove-hook'?  Why would they be
> special in this regard?

This could be discussed. But a change in equality would be much more 
impactful.

There are reasons why one would want to allow structural equality 
testing for closures. I don't see a problem with it if I opt-in 
explicitly by using `equal`. It is still the wrong equality for 
`add/remove-hook` which should be robust. And currently it is not.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.